fix(shorebird_cli): only show current adb logs in shorebird preview (#1480)

This commit is contained in:
Bryan Oltman
2023-11-10 17:22:34 -05:00
committed by GitHub
parent 254941b5d9
commit 43907bbb2d
2 changed files with 7 additions and 4 deletions
@@ -67,6 +67,8 @@ class Adb {
final args = [
if (deviceId != null) ...['-s', deviceId],
'logcat',
// This arg prevents old logs from being displayed.
...['-T', '1'],
if (filter != null) ...['-s', filter],
];
return _stream(args.join(' '));
@@ -202,7 +202,7 @@ void main() {
});
final result = await runWithOverrides(() => adb.logcat());
expect(result, equals(logcatProcess));
verify(() => process.start(adbPath, ['logcat'])).called(1);
verify(() => process.start(adbPath, ['logcat', '-T', '1'])).called(1);
});
test('returns correct process (filtered)', () async {
@@ -221,7 +221,7 @@ void main() {
final result = await runWithOverrides(() => adb.logcat(filter: filter));
expect(result, equals(logcatProcess));
verify(
() => process.start(adbPath, ['logcat', '-s', filter]),
() => process.start(adbPath, ['logcat', '-T', '1', '-s', filter]),
).called(1);
});
@@ -234,8 +234,9 @@ void main() {
fail('Unexpected executable: $executable');
});
await runWithOverrides(() => adb.logcat(deviceId: deviceId));
verify(() => process.start(adbPath, ['-s', deviceId, 'logcat']))
.called(1);
verify(
() => process.start(adbPath, ['-s', deviceId, 'logcat', '-T', '1']),
).called(1);
});
});
});