fix: include plist path in failure message (#1488)

This commit is contained in:
Eric Seidel
2023-11-13 08:34:09 -08:00
committed by GitHub
parent 5e0b941f53
commit 35b6b6f435
4 changed files with 13 additions and 7 deletions
@@ -145,7 +145,9 @@ If this option is not provided, the version number will be determined from the p
try {
releaseVersion = plist.versionNumber;
} catch (error) {
logger.err('Failed to determine release version: $error');
logger.err(
'Failed to determine release version from ${plistFile.path}: $error',
);
return ExitCode.software.code;
}
@@ -198,7 +198,9 @@ make smaller updates to your app.
try {
releaseVersion = plist.versionNumber;
} catch (error) {
logger.err('Failed to determine release version: $error');
logger.err(
'Failed to determine release version from ${plistFile.path}: $error',
);
return ExitCode.software.code;
}
@@ -720,7 +720,7 @@ Please re-run the release command for this version or create a new release.'''),
() async {
final tempDir = setUpTempDir();
setUpTempArtifacts(tempDir);
File(
final file = File(
p.join(
tempDir.path,
'build',
@@ -741,7 +741,8 @@ Please re-run the release command for this version or create a new release.'''),
expect(exitCode, equals(ExitCode.software.code));
verify(
() => logger.err(
any(that: contains('Failed to determine release version')),
'Failed to determine release version from ${file.path}: '
'Exception: Could not determine release version',
),
).called(1);
});
@@ -716,10 +716,10 @@ error: exportArchive: No signing certificate "iOS Distribution" found
).called(1);
});
test('exits with code 70 when release version cannot be determiend',
test('exits with code 70 when release version cannot be determined',
() async {
final tempDir = setUpTempDir();
File(
final file = File(
p.join(
tempDir.path,
'build',
@@ -739,7 +739,8 @@ error: exportArchive: No signing certificate "iOS Distribution" found
expect(exitCode, equals(ExitCode.software.code));
verify(
() => logger.err(
any(that: contains('Failed to determine release version')),
'Failed to determine release version from ${file.path}: '
'Exception: Could not determine release version',
),
).called(1);
});