flutter/shorebird
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(shorebird_cli): flutter config parsing logic (#2961)

Browse Source
This commit is contained in:
Felix Angelov
2025-03-12 16:59:57 -05:00
committed by GitHub
parent 60dfb6e143
commit 32c400d6e9
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/shorebird_cli/lib/src/shorebird_flutter.dart
+5 -6
View File
@@ -137,12 +137,11 @@ class ShorebirdFlutter {
final config = <String, dynamic>{};
final lines = LineSplitter.split(output).toList();
for (final line in lines.skip(1)) {
final parts = line.split(':');
if (parts.length == 2) {
final key = parts[0].trim();
final value = parts[1].trim();
config[key] = value;
}
final index = line.indexOf(':');
if (index == -1) continue;
final key = line.substring(0, index).trim();
final value = line.substring(index + 1).trim();
config[key] = value;
}
return config;
}
packages/shorebird_cli/test/src/shorebird_flutter_test.dart
+3 -3
View File
@@ -168,7 +168,7 @@ void main() {
group('when process completes successfully', () {
setUp(() {
when(() => configProcessResult.stdout).thenReturn('''
when(() => configProcessResult.stdout).thenReturn(r'''
All Settings:
enable-web: (Not set)
enable-linux-desktop: (Not set)
@@ -183,7 +183,7 @@ All Settings:
enable-flutter-preview: (Not set) (Unavailable)
enable-swift-package-manager: (Not set)
explicit-package-dependencies: (Not set)
jdk-dir: ./jdk/dir/override
jdk-dir: C:\Program Files\Android\Android Studio\jdk
''');
when(
() => configProcessResult.exitCode,
@@ -207,7 +207,7 @@ All Settings:
'enable-flutter-preview': '(Not set) (Unavailable)',
'enable-swift-package-manager': '(Not set)',
'explicit-package-dependencies': '(Not set)',
'jdk-dir': './jdk/dir/override',
'jdk-dir': r'C:\Program Files\Android\Android Studio\jdk',
}),
);
});