Jens Johansen
8521d4f5d9
[CFE] Fix coverage destroyed by (wrong) offsets on extension method tearoffs
...
Say you have a class method like this:
```
class Bar {
/*offset a*/ void /*offset b*/ qux() {
/*offset c*/ print("hello");
}
}
```
Lets also say that this method is run.
This will mark offset a and offset c as hits.
Offset b does not exist in coverage terms.
Now say you have an extension mehod like this:
```
extension Foo on Bar {
/*offset a*/ void /*offset b*/ baz() {
/*offset c*/ print("hello");
}
}
```
Lets also say that this method is also executed.
This will mark offset a and offset c as hits.
Offset b does not exist in coverage terms for this method.
Because extension methods are special though we create a special tearoff for
it. Lets say we didn't execute that one.
The tearoff method - before this CL - had offset b on positions that caused
the position to exist in coverage terms, and as the method wasn't executed
this would make it a miss.
This CL fixes the issue by setting the offsets on the tearoff that before
introduced offset b to offset a instead.
Change-Id: I3a5339135f3d76327624b35f04cc14afccaf487a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404563
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Slava Egorov <vegorov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2025-01-27 01:27:50 -08:00
..
2025-01-23 23:25:22 -08:00
2023-11-14 21:26:31 +00:00
2024-06-03 21:23:38 +00:00
2023-11-06 17:23:04 +00:00
2024-06-03 21:23:38 +00:00
2023-11-09 18:51:16 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-08-24 15:44:49 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2024-06-24 22:00:28 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2024-06-24 22:00:28 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-08 14:51:12 -08:00
2025-01-08 14:51:12 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2024-06-03 21:23:38 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2024-06-10 13:02:28 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-27 01:27:50 -08:00
2024-06-17 10:47:58 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2024-06-17 10:47:58 +00:00
2023-11-14 21:26:31 +00:00
2024-02-05 22:17:27 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2024-08-20 20:38:19 +00:00
2024-01-10 12:06:57 +00:00
2024-12-12 23:08:49 -08:00
2023-11-14 21:26:31 +00:00
2023-12-07 20:31:11 +00:00
2024-01-10 12:06:57 +00:00
2024-12-12 23:08:49 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2024-12-20 09:00:17 -08:00
2024-12-20 09:00:17 -08:00
2024-12-20 09:00:17 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2024-12-20 09:00:17 -08:00
2024-12-20 09:00:17 -08:00
2024-12-20 09:00:17 -08:00
2025-01-23 06:31:51 -08:00
2024-12-20 09:00:17 -08:00
2024-12-20 09:00:17 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2024-10-09 11:01:57 +00:00
2024-10-09 11:01:57 +00:00
2024-12-20 09:00:17 -08:00
2024-12-20 09:00:17 -08:00
2024-12-20 09:00:17 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2023-12-15 17:08:56 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2023-11-14 21:26:31 +00:00
2024-11-27 17:31:07 +00:00
2024-11-27 17:31:07 +00:00
2024-11-27 17:31:07 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2023-11-14 21:26:31 +00:00
2023-12-12 17:11:27 +00:00
2023-12-08 15:58:52 +00:00
2023-11-14 21:26:31 +00:00
2024-02-15 18:56:08 +00:00
2023-10-31 19:49:42 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2024-12-12 23:08:49 -08:00
2023-11-14 21:26:31 +00:00
2024-01-18 20:10:40 +00:00
2024-01-18 18:39:42 +00:00
2024-08-28 16:41:50 +00:00
2024-02-12 20:17:00 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2023-10-31 19:49:42 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-10-31 19:49:42 +00:00
2023-10-31 19:49:42 +00:00
2023-10-31 19:49:42 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2024-09-26 15:29:05 +00:00
2024-09-26 15:29:05 +00:00
2024-02-05 22:17:27 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2024-02-05 22:17:27 +00:00
2024-02-15 22:52:41 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2024-10-02 15:46:31 +00:00
2024-10-02 15:46:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 23:25:22 -08:00
2025-01-23 23:25:22 -08:00
2025-01-23 23:26:39 -08:00
2025-01-23 23:25:22 -08:00
2025-01-23 06:31:51 -08:00
2024-11-18 20:45:45 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2024-01-10 12:06:57 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2024-02-05 22:17:27 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2024-02-16 12:55:22 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2024-12-18 11:39:40 -08:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2024-03-20 20:08:13 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-08 16:42:44 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2024-05-02 16:01:49 +00:00
2024-09-26 15:29:05 +00:00
2025-01-23 06:31:51 -08:00
2024-10-22 17:02:02 +00:00
2024-02-15 23:00:44 +00:00
2025-01-23 06:31:51 -08:00
2025-01-08 14:51:12 -08:00
2025-01-08 14:51:12 -08:00
2023-11-08 16:42:44 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-13 19:54:40 +00:00
2023-11-16 16:24:11 +00:00
2023-11-09 18:51:16 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2024-06-03 21:23:38 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2024-02-23 00:29:58 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2024-04-17 19:47:29 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2023-11-13 19:54:40 +00:00
2024-01-10 12:06:57 +00:00
2023-11-14 21:26:31 +00:00
2023-11-14 21:26:31 +00:00
2023-11-08 23:19:18 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 18:11:59 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2023-11-13 19:54:40 +00:00
2025-01-23 06:31:51 -08:00
2023-11-14 21:26:31 +00:00
2024-10-08 15:42:21 +00:00
2023-11-14 21:26:31 +00:00
2025-01-23 06:31:51 -08:00