dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[ package:vm_service ] Add logging to get_allocation_traces_test

Browse Source 
Will hopefully give more information as to why this test is flakily
failing on some configurations.

Change-Id: Ib72eca7fbcb5337bce19d28755d6dba701ae668a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341360
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
This commit is contained in:
Ben Konyi
2023-12-12 17:11:27 +00:00
committed by Commit Queue
parent bdefe5fa7e
commit f095557189
1 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/vm_service/test/get_allocation_traces_test.dart
+21 -3
View File
@@ -53,6 +53,9 @@ Future<Class?> getClassFromRootLib(
return null;
}
late Class fooClass;
late Class barClass;
final tests = <IsolateTest>[
hasStoppedAtBreakpoint,
stoppedAtLine(27),
@@ -60,7 +63,7 @@ final tests = <IsolateTest>[
// Initial.
(VmService service, IsolateRef isolate) async {
// Verify initial state of 'Foo'.
Class fooClass = (await getClassFromRootLib(service, isolate, 'Foo'))!;
fooClass = (await getClassFromRootLib(service, isolate, 'Foo'))!;
expect(fooClass.name, equals('Foo'));
expect(fooClass.traceAllocations, false);
await service.setTraceClassAllocation(isolate.id!, fooClass.id!, true);
@@ -75,7 +78,7 @@ final tests = <IsolateTest>[
// Allocation profile.
(VmService service, IsolateRef isolate) async {
Class fooClass = (await getClassFromRootLib(service, isolate, 'Foo'))!;
fooClass = (await getClassFromRootLib(service, isolate, 'Foo'))!;
expect(fooClass.traceAllocations, true);
final profileResponse = await service.getAllocationTraces(isolate.id!);
@@ -103,11 +106,12 @@ final tests = <IsolateTest>[
expect(fooClass.traceAllocations, false);
// Trace Bar.
Class barClass = (await getClassFromRootLib(service, isolate, 'Bar'))!;
barClass = (await getClassFromRootLib(service, isolate, 'Bar'))!;
expect(barClass.traceAllocations, false);
await service.setTraceClassAllocation(isolate.id!, barClass.id!, true);
barClass = (await getClassFromRootLib(service, isolate, 'Bar'))!;
expect(barClass.traceAllocations, true);
print('Allocation tracing enabled for Bar');
},
resumeIsolate,
@@ -117,6 +121,20 @@ final tests = <IsolateTest>[
(VmService service, IsolateRef isolate) async {
// Ensure the allocation of `Bar()` was recorded.
final profileResponse = await service.getAllocationTraces(isolate.id!);
final samples = profileResponse.samples!;
if (samples.length != 2) {
print('Foo ID: ${fooClass.id}');
print('Bar ID: ${barClass.id}');
final functions = profileResponse.functions!;
for (final sample in samples) {
print('Sample for CID: ${sample.classId}');
for (int i = 0; i < sample.stack!.length; ++i) {
final frame = sample.stack![i];
final location = (functions[frame].function as FuncRef).location!;
print('$i: ${location.script!.uri}:${location.line}');
}
}
}
expect(profileResponse.samples!.length, 2);
},
];