Alexander Markov
d77fff7307
[vm/nnbd] Add separate Snapshot::Kind for core snapshots
...
Core snapshots should be agnostic to the sound null safety mode
(so they can be used both in weak and strong modes), and snapshot
writer verifies that.
Snapshot::kFull was previously used both for core snapshots and
app snapshots on ia32. However, app snapshots are not guaranteed to
be agnostic, which appeared as failures on a few test on ia32.
Also, VM should be able to detect null safety mode from app snapshots,
even if they do not contain code, but null safety mode was not
written into features string of kFull snapshots.
In order to disambiguate core snapshots, a new Snapshot::Kind is
added. Snapshot::kFullCore works exactly as Snapshot::kFull, except
for verification of agnostic null safety and snapshot features string
omitting null safety mode. All snapshots except kFullCore now have
null safety mode included into their features string.
Fixes https://github.com/dart-lang/sdk/issues/43626
Issue https://github.com/dart-lang/sdk/issues/43613
Change-Id: I8cd3b049ef4e428dd5e1ce666d4c7aa3b596d70c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166308
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-10-08 19:59:15 +00:00
..
2020-10-07 22:34:24 +00:00
2020-10-05 17:56:12 +00:00
2020-10-01 19:18:30 +00:00
2020-02-27 17:50:43 +00:00
2020-10-08 19:59:15 +00:00
2020-03-11 13:05:59 +00:00
2020-03-11 13:05:59 +00:00
2020-02-14 17:57:47 +00:00
2020-04-25 05:21:27 +00:00
2020-05-07 16:16:08 +00:00
2020-08-21 19:32:40 +00:00
2020-07-09 00:15:07 +00:00
2020-04-25 05:21:27 +00:00
2020-10-06 17:10:05 +00:00
2020-05-26 08:47:30 +00:00
2020-08-21 18:23:00 +00:00
2020-09-23 19:13:29 +00:00
2020-04-25 05:21:27 +00:00
2020-09-30 22:29:05 +00:00
2020-07-13 17:42:09 +00:00
2020-10-06 17:10:05 +00:00
2020-07-09 18:33:32 +00:00
2020-07-09 18:33:32 +00:00
2020-10-08 19:59:15 +00:00
2020-10-05 21:28:52 +00:00
2020-04-16 22:59:03 +00:00
2020-04-16 22:59:03 +00:00
2020-08-26 18:03:05 +00:00
2020-09-23 21:05:59 +00:00
2020-09-23 21:05:59 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-05-07 19:40:18 +00:00
2020-04-25 05:21:27 +00:00
2020-08-12 17:23:14 +00:00
2020-04-25 05:21:27 +00:00
2020-09-23 21:05:59 +00:00
2020-09-23 21:05:59 +00:00
2020-08-21 02:57:07 +00:00
2020-02-05 16:36:09 +00:00
2020-09-17 21:08:13 +00:00
2020-02-05 16:36:09 +00:00
2020-09-17 21:08:13 +00:00
2020-02-18 08:43:16 +00:00
2020-02-05 16:36:09 +00:00
2020-09-17 21:08:13 +00:00
2020-06-01 23:21:38 +00:00
2020-09-17 21:08:13 +00:00
2020-06-11 12:29:19 +00:00
2020-02-18 08:43:16 +00:00
2020-06-26 09:39:15 +00:00
2020-06-26 09:39:15 +00:00
2020-04-16 22:59:03 +00:00
2020-06-25 03:36:41 +00:00
2020-06-25 03:36:41 +00:00
2020-06-25 03:36:41 +00:00
2020-09-21 22:02:32 +00:00
2020-10-08 19:59:15 +00:00
2020-04-25 05:21:27 +00:00
2020-09-23 21:05:59 +00:00
2020-05-07 19:40:18 +00:00
2020-07-23 11:30:39 +00:00
2020-09-30 22:29:05 +00:00
2020-08-11 10:04:19 +00:00
2020-10-08 19:59:15 +00:00
2020-09-17 06:07:50 +00:00
2020-10-06 07:59:33 +00:00
2020-10-06 17:10:05 +00:00
2020-07-09 14:55:11 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-09-28 08:18:07 +00:00
2020-08-14 12:45:37 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-09-23 21:05:59 +00:00
2020-04-25 05:21:27 +00:00
2020-03-13 17:19:52 +00:00
2020-03-13 17:19:52 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-10-06 17:10:05 +00:00
2020-10-06 17:10:05 +00:00
2020-10-06 17:10:05 +00:00
2020-10-06 17:10:05 +00:00
2020-06-02 21:29:03 +00:00
2020-10-02 15:59:18 +00:00
2020-09-23 21:05:59 +00:00
2020-04-16 22:59:03 +00:00
2020-04-16 22:59:03 +00:00
2020-05-04 21:15:27 +00:00
2020-04-25 05:21:27 +00:00
2020-02-14 17:50:42 +00:00
2020-01-29 11:46:50 +00:00
2020-08-21 21:44:50 +00:00
2020-10-07 15:23:25 +00:00
2020-04-25 05:21:27 +00:00
2020-05-20 14:05:40 +00:00
2020-09-18 09:35:22 +00:00
2020-05-26 22:40:52 +00:00
2020-04-25 05:21:27 +00:00
2020-03-04 18:56:16 +00:00
2020-04-17 03:02:27 +00:00
2020-07-30 15:57:33 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-07-17 19:29:47 +00:00
2020-10-06 17:10:05 +00:00
2020-10-06 17:10:05 +00:00
2020-08-12 17:23:14 +00:00
2020-04-25 05:21:27 +00:00
2020-08-12 17:23:14 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-05-07 19:40:18 +00:00
2020-05-07 19:40:18 +00:00
2020-09-16 03:16:42 +00:00
2020-04-25 05:21:27 +00:00
2020-05-02 17:22:05 +00:00
2020-05-02 17:22:05 +00:00
2020-08-14 20:11:19 +00:00
2020-08-21 21:44:50 +00:00
2020-07-09 18:33:32 +00:00
2020-05-26 22:40:52 +00:00
2020-10-05 20:42:02 +00:00
2020-10-05 20:42:02 +00:00
2020-06-11 22:43:39 +00:00
2020-06-11 22:43:39 +00:00
2020-08-07 18:09:35 +00:00
2020-08-07 18:09:35 +00:00
2020-08-07 18:09:35 +00:00
2020-07-07 06:08:20 +00:00
2020-10-03 19:15:41 +00:00
2020-09-21 22:02:32 +00:00
2020-07-09 14:55:11 +00:00
2020-09-08 13:16:24 +00:00
2020-07-09 00:15:07 +00:00
2020-07-16 20:26:04 +00:00
2020-06-19 13:50:03 +00:00
2020-02-20 21:08:35 +00:00
2020-09-08 16:26:43 +00:00
2020-08-21 21:44:50 +00:00
2020-05-30 01:06:44 +00:00
2020-08-26 21:32:36 +00:00
2020-06-02 13:25:01 +00:00
2020-08-26 21:32:36 +00:00
2020-08-26 21:32:36 +00:00
2020-05-15 20:28:21 +00:00
2020-05-15 20:28:21 +00:00
2020-05-07 19:40:18 +00:00
2020-05-28 17:25:58 +00:00
2020-05-05 12:08:43 +00:00
2020-04-21 14:05:53 +00:00
2020-06-25 03:36:41 +00:00
2020-04-25 05:21:27 +00:00
2020-05-08 18:28:06 +00:00
2020-08-31 12:14:38 +00:00
2020-05-09 08:27:48 +00:00
2020-05-09 08:27:48 +00:00
2020-06-25 03:36:41 +00:00
2020-04-25 05:21:27 +00:00
2020-05-07 16:16:08 +00:00
2020-04-25 05:21:27 +00:00
2020-06-25 03:36:41 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-06-25 03:36:41 +00:00
2020-05-26 08:47:30 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-09-15 18:32:31 +00:00
2020-05-19 17:37:10 +00:00
2020-05-06 19:19:52 +00:00
2020-05-06 19:19:52 +00:00
2020-05-06 19:19:52 +00:00
2020-09-30 22:29:05 +00:00
2020-10-06 17:10:05 +00:00
2020-04-25 05:21:27 +00:00
2020-10-05 20:42:02 +00:00
2020-10-08 19:59:15 +00:00
2020-09-30 22:29:05 +00:00
2020-04-25 05:21:27 +00:00
2020-10-07 17:09:37 +00:00
2020-10-07 17:09:37 +00:00
2020-06-03 17:27:41 +00:00
2020-09-02 18:36:02 +00:00
2020-06-03 17:27:41 +00:00
2020-06-03 17:27:41 +00:00
2020-05-04 21:15:27 +00:00
2020-06-10 19:57:02 +00:00
2020-06-10 19:57:02 +00:00
2020-06-10 19:57:02 +00:00
2020-06-10 19:57:02 +00:00
2020-09-21 19:42:42 +00:00
2020-06-25 03:36:41 +00:00
2020-06-03 17:27:41 +00:00
2020-06-03 17:27:41 +00:00
2020-10-02 16:17:58 +00:00
2020-09-10 07:12:14 +00:00
2020-04-25 05:21:27 +00:00
2020-04-21 14:05:53 +00:00
2020-06-25 03:36:41 +00:00
2020-04-25 05:21:27 +00:00
2020-04-22 17:34:09 +00:00
2020-05-04 21:15:27 +00:00
2020-04-25 05:21:27 +00:00
2020-09-16 03:16:42 +00:00
2020-06-26 09:39:15 +00:00
2020-06-25 22:21:22 +00:00
2020-09-08 12:11:34 +00:00
2020-07-17 19:29:47 +00:00
2020-07-09 00:15:07 +00:00
2020-10-06 17:10:05 +00:00
2020-10-06 17:10:05 +00:00
2020-10-08 19:59:15 +00:00
2020-10-07 22:34:24 +00:00
2020-04-25 05:21:27 +00:00
2020-06-26 09:39:15 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-06-18 11:14:13 +00:00
2020-06-17 14:01:54 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-09-08 13:16:24 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-08-11 23:02:09 +00:00
2020-08-05 04:48:20 +00:00
2020-08-12 17:23:14 +00:00
2020-08-12 17:23:14 +00:00
2020-09-11 07:37:51 +00:00
2020-04-17 13:11:08 +00:00
2020-09-16 03:16:42 +00:00
2020-04-16 22:59:03 +00:00
2020-09-16 03:16:42 +00:00
2020-08-05 02:01:36 +00:00
2020-07-28 05:41:01 +00:00
2020-10-02 16:17:58 +00:00
2020-09-03 21:40:35 +00:00
2020-05-12 19:22:41 +00:00
2020-08-21 21:44:50 +00:00
2020-08-21 21:44:50 +00:00
2020-06-25 03:36:41 +00:00
2020-10-05 15:11:33 +00:00
2020-10-01 19:18:30 +00:00
2020-03-23 21:49:37 +00:00
2020-05-29 21:54:04 +00:00
2020-05-27 17:04:30 +00:00
2020-06-26 09:39:15 +00:00
2020-05-07 16:16:08 +00:00
2020-02-11 23:37:05 +00:00
2020-10-08 19:59:15 +00:00
2020-10-08 19:59:15 +00:00
2020-10-08 19:59:15 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-06-12 11:14:22 +00:00
2020-06-12 11:14:22 +00:00
2020-06-12 11:14:22 +00:00
2020-06-02 20:40:03 +00:00
2020-06-12 11:14:22 +00:00
2020-08-12 17:23:14 +00:00
2020-08-12 17:23:14 +00:00
2020-08-14 12:45:37 +00:00
2020-03-30 18:33:48 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-09-16 03:16:42 +00:00
2020-04-25 05:21:27 +00:00
2020-09-16 03:16:42 +00:00
2020-09-16 03:16:42 +00:00
2020-09-23 19:13:29 +00:00
2020-09-23 19:13:29 +00:00
2020-10-06 17:10:05 +00:00
2020-06-11 01:22:35 +00:00
2020-03-11 22:03:50 +00:00
2020-03-11 22:03:50 +00:00
2020-03-11 22:03:50 +00:00
2020-06-12 03:29:17 +00:00
2020-03-28 00:41:51 +00:00
2020-06-02 13:25:01 +00:00
2020-05-15 10:57:09 +00:00
2020-05-15 10:57:09 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-09-18 21:32:56 +00:00
2020-06-12 11:14:22 +00:00
2020-07-01 20:52:34 +00:00
2020-08-04 17:19:19 +00:00
2020-03-10 23:29:18 +00:00
2020-08-04 17:19:19 +00:00
2020-07-02 12:01:49 +00:00
2020-06-25 03:36:41 +00:00
2020-07-02 12:01:49 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-09-30 22:29:05 +00:00
2020-03-17 14:11:02 +00:00
2020-09-30 22:29:05 +00:00
2020-09-18 12:01:11 +00:00
2020-06-29 16:10:13 +00:00
2020-07-15 00:55:03 +00:00
2020-06-02 20:40:03 +00:00
2020-05-04 21:15:27 +00:00
2020-05-26 10:46:05 +00:00
2020-05-26 10:46:05 +00:00
2020-08-06 19:55:12 +00:00
2020-08-06 19:55:12 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-05-08 18:28:06 +00:00
2020-02-20 21:08:35 +00:00
2020-04-17 03:02:27 +00:00
2020-09-15 18:32:31 +00:00
2020-09-23 19:13:29 +00:00
2020-08-07 21:40:45 +00:00
2020-08-07 21:40:45 +00:00
2020-06-25 19:51:12 +00:00
2020-06-25 19:51:12 +00:00