Jens Johansen
40777c001a
Currently, if a not-enabled-by-default experimental flag is on we allow formatting to fail. This means that when the flag is flipped there's a risk of failures as formatter crashes are now not allowed anymore. The failures for flipping the extension types / inline-class feature has caused crashes and was fixed before (twice!) in https://dart-review.googlesource.com/c/sdk/+/336001 https://dart-review.googlesource.com/c/sdk/+/335448 But naturally a new test was added after (https://dart-review.googlesource.com/c/sdk/+/336022) and we had a new failure on the flag-flip CL. This CL instead pretends like the inline-class flag is already flipped, in that the formatter is not allowed to crash because of it. That should make any new tests added before the flag is flipped that would otherwise cause a failure upon flag flip, fail, forcing the update of the status file. The status file is furtermore updated. Change-Id: Ifbc3d271a614e5dd747b35b252034087ad155a92 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337321 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency