[CFE] Textual outline suite pretends the inline_class flag was flipped

Currently, if a not-enabled-by-default experimental flag is on we allow
formatting to fail.
This means that when the flag is flipped there's a risk of failures as
formatter crashes are now not allowed anymore.

The failures for flipping the extension types / inline-class feature
has caused crashes and was fixed before (twice!) in
https://dart-review.googlesource.com/c/sdk/+/336001
https://dart-review.googlesource.com/c/sdk/+/335448

But naturally a new test was added after
(https://dart-review.googlesource.com/c/sdk/+/336022) and we had a new
failure on the flag-flip CL.

This CL instead pretends like the inline-class flag is already flipped,
in that the formatter is not allowed to crash because of it.
That should make any new tests added before the flag is flipped that
would otherwise cause a failure upon flag flip, fail, forcing the
update of the status file.

The status file is furtermore updated.

Change-Id: Ifbc3d271a614e5dd747b35b252034087ad155a92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337321
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
This commit is contained in:
Jens Johansen
2023-11-21 10:23:48 +00:00
committed by Commit Queue
parent 6b0ce926d1
commit 40777c001a
3 changed files with 9 additions and 9 deletions
@@ -183,6 +183,9 @@ class TextualOutline extends Step<TestDescription, TestDescription, Context> {
for (MapEntry<ExperimentalFlag, bool> entry
in experimentalFlagsExplicit.entries) {
if (entry.value) {
// Don't treat "inline-class" as disabled by default as it's about
// to have the flag flipped.
if (entry.key.name == "inline-class") continue;
if (!entry.key.isEnabledByDefault) {
hasUnreleasedExperiment = true;
break;
@@ -317,6 +317,7 @@ fisk
five
fl
flame
flipped
floor
fluctuate
foo'bar'baz
@@ -9,15 +9,11 @@ super_parameters/issue47741: FormatterCrash # https://github.com/dart-lang/dart_
# These tests have errors in them which isn't reported by the parser but the
# formatter still sees as syntax errors and thus won't format.
# Before the extension_types flag is flipped they are allowed to crash though,
# so for now they're marked as both crashing and passing.
extension_types/field_access: FormatterCrash, Pass
extension_types/issue52119: FormatterCrash, Pass
extension_types/issue53212: FormatterCrash, Pass
extension_types/representation: FormatterCrash, Pass
# These tests have errors in them which isn't reported by the parser but the
# formatter still sees as syntax errors and thus won't format.
extension_types/const_constructor_body: FormatterCrash
extension_types/field_access: FormatterCrash
extension_types/issue52119: FormatterCrash
extension_types/issue53212: FormatterCrash
extension_types/representation: FormatterCrash
general/base_class_declaration: FormatterCrash
general/constants/non_const_constructor: FormatterCrash
general/constants/various: FormatterCrash