Ryan Macnak
6851c0eca3
Fix visiting roots to wait for visiting new-space pages to finish, not merely start. Change-Id: I0c6688701f4563bf5c3b8ae02f215e709d5cac6f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148230 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
88 lines
2.8 KiB
C++
88 lines
2.8 KiB
C++
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_VM_HEAP_MARKER_H_
|
|
#define RUNTIME_VM_HEAP_MARKER_H_
|
|
|
|
#include "vm/allocation.h"
|
|
#include "vm/heap/pointer_block.h"
|
|
#include "vm/os_thread.h" // Mutex.
|
|
|
|
namespace dart {
|
|
|
|
// Forward declarations.
|
|
class HandleVisitor;
|
|
class Heap;
|
|
class IsolateGroup;
|
|
class ObjectPointerVisitor;
|
|
class PageSpace;
|
|
template <bool sync>
|
|
class MarkingVisitorBase;
|
|
class NewPage;
|
|
class Thread;
|
|
|
|
// The class GCMarker is used to mark reachable old generation objects as part
|
|
// of the mark-sweep collection. The marking bit used is defined in RawObject.
|
|
// Instances have a lifetime that spans from the beginining of concurrent
|
|
// marking (or stop-the-world marking) until marking is complete. In particular,
|
|
// an instance may be created and destroyed on different threads if the isolate
|
|
// is exited during concurrent marking.
|
|
class GCMarker {
|
|
public:
|
|
GCMarker(IsolateGroup* isolate_group, Heap* heap);
|
|
~GCMarker();
|
|
|
|
// Mark roots synchronously, then spawn tasks to concurrently drain the
|
|
// marking queue. Only called when no marking or sweeping is in progress.
|
|
// Marking must later be finalized by calling MarkObjects.
|
|
void StartConcurrentMark(PageSpace* page_space);
|
|
|
|
// (Re)mark roots, drain the marking queue and finalize weak references.
|
|
// Does not required StartConcurrentMark to have been previously called.
|
|
void MarkObjects(PageSpace* page_space);
|
|
|
|
intptr_t marked_words() const { return marked_bytes_ >> kWordSizeLog2; }
|
|
intptr_t MarkedWordsPerMicro() const;
|
|
|
|
private:
|
|
void Prologue();
|
|
void Epilogue();
|
|
void ResetSlices();
|
|
void IterateRoots(ObjectPointerVisitor* visitor);
|
|
void IterateWeakRoots(Thread* thread);
|
|
void ProcessWeakHandles(Thread* thread);
|
|
void ProcessWeakTables(Thread* thread);
|
|
void ProcessRememberedSet(Thread* thread);
|
|
void ProcessObjectIdTable(Thread* thread);
|
|
|
|
// Called by anyone: finalize and accumulate stats from 'visitor'.
|
|
template <class MarkingVisitorType>
|
|
void FinalizeResultsFrom(MarkingVisitorType* visitor);
|
|
|
|
IsolateGroup* const isolate_group_;
|
|
Heap* const heap_;
|
|
MarkingStack marking_stack_;
|
|
MarkingStack deferred_marking_stack_;
|
|
MarkingVisitorBase<true>** visitors_;
|
|
|
|
NewPage* new_page_;
|
|
Monitor root_slices_monitor_;
|
|
RelaxedAtomic<intptr_t> root_slices_started_;
|
|
intptr_t root_slices_finished_;
|
|
intptr_t root_slices_count_;
|
|
RelaxedAtomic<intptr_t> weak_slices_started_;
|
|
|
|
Mutex stats_mutex_;
|
|
uintptr_t marked_bytes_;
|
|
int64_t marked_micros_;
|
|
|
|
friend class ConcurrentMarkTask;
|
|
friend class ParallelMarkTask;
|
|
DISALLOW_IMPLICIT_CONSTRUCTORS(GCMarker);
|
|
};
|
|
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_VM_HEAP_MARKER_H_
|