Brian Wilkerson
4d93f4d586
The purpose of this lint is to help automate testing of the primary constructors feature. It is unlikely to be shipped in its current form. The goal is to flag all cases where a secondary constructor could be converted to a primary constructor. This includes classes with a default constructor. There is an assist that should convert most of these cases, but it has not yet been enhanced to work as a fix. That will be done in a future CL. I want to implement the lint first so that I know all of the conditions that the fix needs to handle. The most important part of this review is to ensure that the tests are reasonably complete. If there are any missing cases where the lint should flag a constructor for conversion, or any missing cases where a conversion should not be requested, please let me know. Change-Id: Ib8256677a0659479ab341974b87bd03c953ff644 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/500583 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Linter for Dart
The Dart Linter package defines lint rules that identify and report on "lints" found in Dart code. Linting is performed by the Dart
analysis server and the dart analyze command in the Dart command-line tool.
Installing
The linter is bundled with the Dart SDK; if you have an updated Dart SDK already, you're done!
Usage
The linter gives you feedback to help you catch potential errors and keep your code in line with the published
Dart Style Guide. Enforceable lint rules (or "lints") are cataloged here and can be configured via an
analysis options file. The linter is run from within the dart analyze command-line tool shipped with the
Dart SDK. Assuming you have lints configured in an analysis_options.yaml file at the root of your project with these contents:
linter:
rules:
- annotate_overrides
- hash_and_equals
- prefer_is_not_empty
you could lint your package like this:
$ dart analyze .
and see any violations of the annotate_overrides, hash_and_equals, and prefer_is_not_empty rules in the console.
To help you choose the rules you want to enable for your package, we have provided a complete list of rules
with lints recommended by the Dart team collected in package:lints. Lints recommended for Flutter apps, packages,
and plugins are documented in package:flutter_lints.
If a specific lint warning should be ignored, it can be flagged with a comment. For example,
// ignore: camel_case_types
class whyOhWhy { }
tells the Dart analyzer to ignore this instance of the camel_case_types warning.
End-of-line comments are supported as well. The following communicates the same thing:
class whyOhWhy { // ignore: camel_case_types
To ignore a rule for an entire file, use the ignore_for_file comment flag. For example,
// ignore_for_file: camel_case_types
...
class whyOhWhy { }
tells the Dart analyzer to ignore all occurrences of the camel_case_types warning in this file.
As lints are treated the same as errors and warnings by the analyzer, their severity can similarly be configured in an options file. For example, an analysis options file that specifies
linter:
rules:
- camel_case_types
analyzer:
errors:
camel_case_types: error
tells the analyzer to treat camel_case_types lints as errors. For more on configuring analysis see the analysis option file docs.
Contributing
Feedback is greatly appreciated and contributions are welcome! Please read the contribution guidelines; mechanics of writing lints are covered here.
Features and bugs
Please file feature requests and bugs in the issue tracker.