Brian Wilkerson
4d93f4d586
The purpose of this lint is to help automate testing of the primary constructors feature. It is unlikely to be shipped in its current form. The goal is to flag all cases where a secondary constructor could be converted to a primary constructor. This includes classes with a default constructor. There is an assist that should convert most of these cases, but it has not yet been enhanced to work as a fix. That will be done in a future CL. I want to implement the lint first so that I know all of the conditions that the fix needs to handle. The most important part of this review is to ensure that the tests are reasonably complete. If there are any missing cases where the lint should flag a constructor for conversion, or any missing cases where a conversion should not be requested, please let me know. Change-Id: Ib8256677a0659479ab341974b87bd03c953ff644 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/500583 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.