Lasse R.H. Nielsen a1783a9c34
String.fromCharCodes allows start and end after end of iterable....
The current `String.fromCharCodes` behavior, throwing if `start`
or `end` is larger than the length of the `charCodes` iterable,
is inconsistent with the argument being an `Iterable<int>`,
which the user is not expected to know the length of.
Most other operations that accepts or produces an `Iterable` and
restricts it to a range, will allow the range to exceed the length
of the iterable, acting like `.take(end).skip(start)`, just without
needing to create wrappers that hide the original value.
(`List.setRange` is another exception, and should probably be fixed
by allowing the range to be partially filled, since it's too hard
to change it to require a `List` argument.)
Fixes #50253 , #53937
Tested: Added to `corelib/string_fromcharcodes_test.dart`
Bug: https://dartbug.com/53937 , https://dartbug.com/50253 , https://dartbug.com/23282
Change-Id: Ie19c5fa8e715ea1c58c9c77c247f2a563654c1aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333921
Commit-Queue: Lasse Nielsen <lrn@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Ömer Ağacan <omersa@google.com >
2023-11-17 13:34:22 +00:00
2023-04-26 19:46:06 +00:00
2022-09-07 14:49:17 +00:00
2021-06-24 03:29:38 +00:00
2020-04-16 09:20:21 +00:00
2023-08-11 20:59:30 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2022-10-10 21:04:18 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2023-09-11 21:05:38 +00:00
2022-11-04 16:10:39 +00:00
2023-03-09 15:14:32 +00:00
2023-03-09 15:14:32 +00:00
2020-07-27 16:44:15 +00:00
2020-04-30 02:33:53 +00:00
2020-04-30 02:33:53 +00:00
2020-04-30 02:33:53 +00:00
2020-04-30 02:33:53 +00:00
2020-04-30 02:33:53 +00:00
2020-05-01 17:02:23 +00:00
2020-05-01 17:02:23 +00:00
2022-12-19 12:56:47 +00:00
2023-10-31 22:52:40 +00:00
2023-04-20 19:19:01 +00:00
2020-03-11 23:31:06 +00:00
2023-05-26 20:05:08 +00:00
2022-02-22 10:47:41 +00:00
2020-03-24 17:34:25 +00:00
2022-10-20 10:50:25 +00:00
2023-11-10 02:00:18 +00:00
2020-09-26 01:11:54 +00:00
2023-03-31 20:52:31 +00:00
2022-12-08 23:29:14 +00:00
2023-02-08 17:45:40 +00:00
2023-02-08 17:45:40 +00:00
2023-03-30 14:02:38 +00:00
2020-07-21 10:00:41 +00:00
2020-05-05 09:57:23 +00:00
2022-12-19 12:56:47 +00:00
2020-05-05 09:57:23 +00:00
2021-11-10 21:36:13 +00:00
2022-11-08 19:02:35 +00:00
2021-04-14 12:07:18 +00:00
2020-03-17 13:43:17 +00:00
2020-03-27 19:02:52 +00:00
2020-04-07 20:09:26 +00:00
2023-08-11 20:59:30 +00:00
2020-03-17 13:43:17 +00:00
2023-01-25 14:08:27 +00:00
2023-11-13 20:13:04 +00:00
2022-12-12 09:54:54 +00:00
2022-12-12 09:54:54 +00:00
2020-04-06 19:17:54 +00:00
2022-05-24 13:54:23 +00:00
2023-04-04 23:05:54 +00:00
2020-04-06 19:17:54 +00:00
2020-03-24 17:34:25 +00:00
2020-04-06 19:17:54 +00:00
2020-04-01 00:03:46 +00:00
2020-04-01 00:03:46 +00:00
2020-04-01 00:03:46 +00:00
2020-02-03 19:06:17 +00:00
2020-02-03 19:06:17 +00:00
2021-01-28 17:19:35 +00:00
2020-02-03 19:06:17 +00:00
2022-09-07 14:49:17 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2020-11-05 19:46:35 +00:00
2020-11-05 19:46:35 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2020-03-31 18:14:45 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2020-05-04 08:14:43 +00:00
2020-07-09 01:37:23 +00:00
2020-03-31 18:14:45 +00:00
2020-05-04 08:14:43 +00:00
2020-03-30 19:58:08 +00:00
2020-07-15 00:45:43 +00:00
2020-03-30 19:58:08 +00:00
2022-12-19 12:56:47 +00:00
2020-03-20 17:58:22 +00:00
2020-03-11 23:31:06 +00:00
2020-03-24 08:21:36 +00:00
2023-07-04 11:00:50 +00:00
2022-09-07 14:49:17 +00:00
2023-03-17 16:17:50 +00:00
2023-08-28 20:16:57 +00:00
2022-02-16 01:32:14 +00:00
2020-07-21 10:00:41 +00:00
2023-02-08 17:45:40 +00:00
2023-02-08 17:45:40 +00:00
2022-12-19 12:56:47 +00:00
2022-11-08 19:02:35 +00:00
2020-11-05 14:26:53 +00:00
2021-06-09 02:50:50 +00:00
2020-11-25 12:01:44 +00:00
2020-06-30 17:14:14 +00:00
2021-05-10 14:15:07 +00:00
2020-03-24 08:21:36 +00:00
2020-12-10 11:00:27 +00:00
2020-12-10 11:00:27 +00:00
2022-07-25 12:21:59 +00:00
2020-04-06 19:17:54 +00:00
2021-03-22 13:20:13 +00:00
2022-12-14 13:41:46 +00:00
2020-03-27 15:59:27 +00:00
2023-04-20 19:19:01 +00:00
2020-03-30 19:58:08 +00:00
2022-12-19 12:56:47 +00:00
2021-02-05 23:53:28 +00:00
2020-03-30 19:58:08 +00:00
2023-11-17 13:34:22 +00:00
2020-03-25 17:32:02 +00:00
2022-06-19 17:02:41 +00:00
2022-05-24 09:10:51 +00:00
2022-01-13 20:52:33 +00:00
2022-01-13 20:52:33 +00:00
2023-04-20 19:19:01 +00:00
2022-05-24 09:10:51 +00:00
2023-11-03 17:28:08 +00:00
2023-04-20 19:19:01 +00:00
2022-05-24 09:10:51 +00:00
2021-10-01 00:56:14 +00:00
2020-04-16 09:20:21 +00:00
2021-07-01 18:43:14 +00:00
2021-06-01 15:55:03 +00:00
2021-06-01 15:55:03 +00:00
2021-07-01 18:43:14 +00:00
2021-04-16 07:33:57 +00:00
2022-12-19 12:56:47 +00:00
2022-02-08 21:38:57 +00:00
2022-09-07 14:49:17 +00:00
2022-06-03 18:07:27 +00:00
2022-07-25 12:21:59 +00:00
2023-01-19 16:24:29 +00:00
2021-06-03 22:47:56 +00:00
Lasse R.H. Nielsen
a1783a9c34