Paul Berry
2b06ac466d
- Variable types are no longer specified in the call to the `Var` constructor; they are now specified in the call to `declare`. This paves the way for supporting variable pattern syntax, in which a single variable might appear in multiple variable patterns, and have its type specified in each pattern. The properties `isFinal` and `isLate` are also moved to `declare` for consistency. - Variables with inferred types are now specified by simply not including a type in `declare`; it's no longer necessary to specify `isImplicitlyTyped: true`. - `declare` now supports an `expectInferredType` argument to allow the inferred type of an implicitly typed variable to be tested. - The tests now check that variables are assigned a type before flow analysis requests it; previously this was not tested, and the flow analysis tests sometimes did things in the wrong order. (The analyzer and CFE have always done this in the proper order though). - The tests now support some of the crazy types that arise during type parameter promotion, e.g. they can now distinguish `(T&int)?` from `T&(int?)`. - Flow analysis tests now properly replicate the analyzer and CFE behaviors for converting the static type of an initializer expression to the corresponding inferred variable type: (a) `Null` is converted to `dynamic`, and (b) type parameter promotions are dropped. Note that this last behavior (dropping type parameter promotions) has a lot of subtleties, and I'm not convinced the CFE and analyzer do it soundly in all cases (I've already found one such soundness bug: https://github.com/dart-lang/sdk/issues/49691). In a later CL, I plan to add a more thorough set of language tests to verify that we don't have other lurking soundness issues. Change-Id: I6f2cd20db1f07b34e0ad4e7002351c8de846b125 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255600 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency