[pkg] use package:lints when analying pkg/

Change-Id: Ib25573375ea1f54e07846af6fcd9cd74a8fefb7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250784
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>

pkg/async_helper/analysis_options.yaml

@@ -0,0 +1 @@
+include: package:lints/core.yaml

pkg/async_helper/lib/async_minitest.dart

@@ -286,6 +286,7 @@ abstract class _Matcher {
   void call(dynamic o);
 }
 
+// ignore: camel_case_types
 class isInstanceOf<T> implements _Matcher {
   void call(dynamic o) {
     Expect.type<T>(o);

pkg/async_helper/pubspec.yaml

@@ -14,3 +14,7 @@ environment:
 # Use 'any' constraints here; we get our versions from the DEPS file.
 dependencies:
   expect: any
+
+# Use 'any' constraints here; we get our versions from the DEPS file.
+dev_dependencies:
+  lints: any

pkg/dart_internal/analysis_options.yaml

@@ -1,3 +1,5 @@
+include: package:lints/recommended.yaml
+
 analyzer:
   errors:
     import_internal_library: ignore

pkg/dart_internal/pubspec.yaml

@@ -10,3 +10,7 @@ environment:
   # Restrict the upper bound so that we can remove support for this in a later
   # version of the SDK without it being a breaking change.
   sdk: ">=2.12.0 <2.19.0"
+
+# Use 'any' constraints here; we get our versions from the DEPS file.
+dev_dependencies:
+  lints: any

pkg/dds_service_extensions/analysis_options.yaml

@@ -1,30 +1 @@
-# This file configures the static analysis results for your project (errors,
-# warnings, and lints).
-#
-# This enables the 'recommended' set of lints from `package:lints`.
-# This set helps identify many issues that may lead to problems when running
-# or consuming Dart code, and enforces writing Dart using a single, idiomatic
-# style and format.
-#
-# If you want a smaller set of lints you can change this to specify
-# 'package:lints/core.yaml'. These are just the most critical lints
-# (the recommended set includes the core lints).
-# The core lints are also what is used by pub.dev for scoring packages.
-
 include: package:lints/recommended.yaml
-
-# Uncomment the following section to specify additional rules.
-
-# linter:
-#   rules:
-#     - camel_case_types
-
-# analyzer:
-#   exclude:
-#     - path/to/excluded/files/**
-
-# For more information about the core and recommended set of lints, see
-# https://dart.dev/go/core-lints
-
-# For additional information about configuring this file, see
-# https://dart.dev/guides/language/analysis-options

pkg/telemetry/analysis_options.yaml

@@ -3,6 +3,7 @@ include: package:lints/recommended.yaml
 analyzer:
   language:
     strict-casts: true
+
 linter:
   rules:
     - unawaited_futures

pkg/test_runner/analysis_options.yaml

@@ -1,83 +1,27 @@
+include: package:lints/core.yaml
+
 analyzer:
   language:
     strict-casts: true
+
 linter:
   rules:
-    # TODO: Enable these once the existing violations have been fixed.
-#    - annotate_overrides
-#    - non_constant_identifier_names
-#    - only_throw_errors
-#    - prefer_interpolation_to_compose_strings
-#    - prefer_single_quotes
-    - avoid_bool_literals_in_conditional_expressions
-    - avoid_empty_else
-    - avoid_function_literals_in_foreach_calls
-    - avoid_init_to_null
-    - avoid_null_checks_in_equality_operators
-    - avoid_relative_lib_imports
-    - avoid_renaming_method_parameters
-    - avoid_return_types_on_setters
-    - avoid_returning_null
-    - avoid_returning_null_for_void
-    - avoid_shadowing_type_parameters
-    - avoid_single_cascade_in_expression_statements
-    - avoid_types_as_parameter_names
-    - avoid_unused_constructor_parameters
-    - await_only_futures
-    - camel_case_types
-    - cancel_subscriptions
-    - comment_references
-    - constant_identifier_names
-    - control_flow_in_finally
-    - curly_braces_in_flow_control_structures
-    - directives_ordering
-    - empty_catches
-    - empty_constructor_bodies
-    - empty_statements
-    - file_names
-    - hash_and_equals
-    - implementation_imports
-    - invariant_booleans
-    - iterable_contains_unrelated_type
-    - library_names
-    - library_prefixes
-    - list_remove_unrelated_type
-    - no_duplicate_case_values
-    - null_closures
-    - omit_local_variable_types
-    - overridden_fields
-    - package_api_docs
-    - package_names
-    - package_prefixed_library_names
-    - prefer_adjacent_string_concatenation
-    - prefer_collection_literals
-    - prefer_conditional_assignment
-    - prefer_const_constructors
-    - prefer_contains
-    - prefer_equal_for_default_values
-    - prefer_final_fields
-    - prefer_generic_function_type_aliases
-    - prefer_initializing_formals
-    - prefer_is_empty
-    - prefer_is_not_empty
-    - prefer_null_aware_operators
-    - prefer_typing_uninitialized_variables
-    - recursive_getters
-    - slash_for_doc_comments
-    - throw_in_finally
-    - type_init_formals
-    - unnecessary_brace_in_string_interps
-    - unnecessary_const
-    - unnecessary_getters_setters
-    - unnecessary_lambdas
-    - unnecessary_new
-    - unnecessary_null_aware_assignments
-    - unnecessary_null_in_if_null_operators
-    - unnecessary_parenthesis
-    - unnecessary_statements
-    - unnecessary_this
-    - unnecessary_overrides
-    - unrelated_type_equality_checks
-    - use_rethrow_when_possible
-    - valid_regexps
-    - void_checks
+    avoid_bool_literals_in_conditional_expressions: true
+    avoid_returning_null: true
+    avoid_unused_constructor_parameters: true
+    cancel_subscriptions: true
+    comment_references: true
+    directives_ordering: true
+    invariant_booleans: true
+    omit_local_variable_types: true
+    package_api_docs: true
+    prefer_const_constructors: true
+    throw_in_finally: true
+    unnecessary_lambdas: true
+    unnecessary_parenthesis: true
+    unnecessary_statements: true
+
+    # Disabled due to existing violations.
+    non_constant_identifier_names: false
+    only_throw_errors: false
+    prefer_single_quotes: false

pkg/test_runner/pubspec.yaml

@@ -26,3 +26,4 @@ dev_dependencies:
   analyzer: any
   expect: any
   glob: any
+  lints: any