Paul Berry
277cee68a4
Converts the code that reports diagnostic codes `bodyMightCompleteNormally` and `bodyMightCompleteNormallyNullable` to use the literate diagnostic reporting API. This was not a straightforward conversion because the code for reporting these diagnostics (`ResolverVisitor.checkForBodyMayCompleteNormally`) made use of the `DiagnosticReporter.atConstructorDeclaration` method, which doesn't have a direct analogue in the literate diagnostic API. The equivalent formulation in the literate diagnostic API is to call `ConstructorDeclarationExtension.errorRange` to compute the offset and length for the constructor name, and then pass the result to `LocatableDiagnostic.at`. Note that the previous version of `ResolverVisitor.checkForBodyMayCompleteNormally` used an `if`/`else` chain to handle three possible types for `errorNode`: `ConstructorDeclaration`, `Token`, or `BlockFunctionBody`. But the call sites might pass in any sort of `FunctionBody`. So it appeared that the diagnostic would be accidentally dropped in the case where `errorNode` was some other type of `FunctionBody`. However, it turns out that there was a tricky reason why the diagnostic was never accidentally dropped: the call site that passes in a `FunctionBody` also passes the same `FunctionBody` for the `body` parameter, and `ResolverVisitor.checkForBodyMayCompleteNormally` only checks for `bodyMightCompleteNormally...` errors if `body` is of type `BlockFunctionBody`. In the new code, a `switch` expression is used to compute the range over which the diagnostic should be reported, so it is manifestly clear that the diagnostic is never accidentally dropped. Change-Id: I6a6a69647a8fd1928d935ec8b5cb0c733ad2412f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467540 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Dart
An approachable, portable, and productive language for high-quality apps on any platform
Dart is:
-
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
-
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
-
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
-
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
-
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
License & patents
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Using Dart
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
Building Dart
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
Contributing to Dart
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Roadmap
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.