Ryan Macnak
d36adbacaf
The former contents of the VM isolate are now included into each isolate group. This makes each isolate group's heap independent, and in particular allows each heap to be allocated to a separate pointer cage (not done in this CL). The duplicated stubs that allowed PC relative calls are removed, since the originals can now be the target of PC relative calls. The bootstrapping needing to load an AppJIT or AppAOT snapshot is reduced to allocating the oddballs. The code is entirely dropped in the AOT runtime, but the JIT runtime still has it to allow for flags to affect the compilation of the stub code. Further refactoring might be able to remove this for the JIT runtime too, with only gen_snapshot knowing how to bootstrap. Class serialization no longer distinguishes predefined classes. The page containing null is marked as never-evacuate. null, false and true must not move because the compiler relies on their low bits having certain patterns for some optimizations. (Previously, the entire VM isolate heap never moved.) Compaction is disabled for IA32. Due to register pressure, some stub calls must not use a scratch register and embed the address of Code. The page containing the call-through-safepoint stub is frozen when running with --write-protect-code and the stub is created at runtime (instead of loaded from an AppJIT or AppAOT snapshot). This stub must remain executable even during a safepoint, as a foreign call might during return during a safepoint and only block after the stub directs it to the runtime. The snapshot symbols are renamed to kDartSnapshotData and kDartSnapshotText. There is no need to distinguish the VM isolate's snapshot, and snaphots are per isolate group not per isolate. Aliases with the old names are added to ease migration. Some global flags that were automatically set based on the VM isolate's snapshot are now isolate group flags and automatically set by the isolate group's snapshot. TEST=ci Change-Id: Iee82016057d609112e9b021d178fc3d4d18b5044 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/500621 Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Tess Strickland <sstrickl@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
109 lines
3.7 KiB
C++
109 lines
3.7 KiB
C++
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/reverse_pc_lookup_cache.h"
|
|
|
|
#include "vm/isolate.h"
|
|
#include "vm/object.h"
|
|
#include "vm/object_store.h"
|
|
#include "vm/stub_code.h"
|
|
|
|
namespace dart {
|
|
|
|
CodePtr ReversePc::FindCodeInGroup(IsolateGroup* group,
|
|
uword pc,
|
|
bool is_return_address) {
|
|
#if defined(DART_PRECOMPILED_RUNTIME)
|
|
// This can run in the middle of GC and must not allocate handles.
|
|
NoSafepointScope no_safepoint;
|
|
|
|
if (is_return_address) {
|
|
pc--;
|
|
}
|
|
|
|
// This expected number of tables is low (one per loading unit), so we go
|
|
// through them linearly. If this changes, would could sort the table list
|
|
// during deserialization and binary search for the table.
|
|
GrowableObjectArrayPtr tables = group->object_store()->instructions_tables();
|
|
intptr_t tables_length = Smi::Value(tables->untag()->length());
|
|
for (intptr_t i = 0; i < tables_length; i++) {
|
|
InstructionsTablePtr table = static_cast<InstructionsTablePtr>(
|
|
tables->untag()->data()->untag()->element(i));
|
|
CodePtr code = InstructionsTable::FindCode(table, pc);
|
|
if (code != Code::null()) {
|
|
return code;
|
|
}
|
|
}
|
|
#endif // defined(DART_PRECOMPILED_RUNTIME)
|
|
return Code::null();
|
|
}
|
|
|
|
const UntaggedCompressedStackMaps::Payload* ReversePc::FindStackMapInGroup(
|
|
IsolateGroup* group,
|
|
uword pc,
|
|
bool is_return_address,
|
|
uword* code_start,
|
|
const UntaggedCompressedStackMaps::Payload** global_table) {
|
|
#if defined(DART_PRECOMPILED_RUNTIME)
|
|
// This can run in the middle of GC and must not allocate handles.
|
|
NoSafepointScope no_safepoint;
|
|
|
|
if (is_return_address) {
|
|
pc--;
|
|
}
|
|
|
|
// This expected number of tables is low (one per loading unit), so we go
|
|
// through them linearly. If this changes, would could sort the table list
|
|
// during deserialization and binary search for the table.
|
|
GrowableObjectArrayPtr tables = group->object_store()->instructions_tables();
|
|
intptr_t tables_length = Smi::Value(tables->untag()->length());
|
|
for (intptr_t i = 0; i < tables_length; i++) {
|
|
InstructionsTablePtr table = static_cast<InstructionsTablePtr>(
|
|
tables->untag()->data()->untag()->element(i));
|
|
auto map = InstructionsTable::FindStackMap(table, pc, code_start);
|
|
if (map != nullptr) {
|
|
// Take global table from the first table.
|
|
table = static_cast<InstructionsTablePtr>(
|
|
tables->untag()->data()->untag()->element(0));
|
|
*global_table = InstructionsTable::GetCanonicalStackMap(table);
|
|
return map;
|
|
}
|
|
}
|
|
#endif // defined(DART_PRECOMPILED_RUNTIME)
|
|
|
|
*code_start = 0;
|
|
return nullptr;
|
|
}
|
|
|
|
const UntaggedCompressedStackMaps::Payload* ReversePc::FindStackMap(
|
|
IsolateGroup* group,
|
|
uword pc,
|
|
bool is_return_address,
|
|
uword* code_start,
|
|
const UntaggedCompressedStackMaps::Payload** global_table) {
|
|
ASSERT(FLAG_precompiled_mode);
|
|
NoSafepointScope no_safepoint;
|
|
return FindStackMapInGroup(group, pc, is_return_address, code_start,
|
|
global_table);
|
|
}
|
|
|
|
CodePtr ReversePc::FindCode(IsolateGroup* group,
|
|
uword pc,
|
|
bool is_return_address) {
|
|
ASSERT(FLAG_precompiled_mode);
|
|
NoSafepointScope no_safepoint;
|
|
return FindCodeInGroup(group, pc, is_return_address);
|
|
}
|
|
|
|
CodePtr ReversePc::Lookup(IsolateGroup* group,
|
|
uword pc,
|
|
bool is_return_address) {
|
|
ASSERT(FLAG_precompiled_mode);
|
|
NoSafepointScope no_safepoint;
|
|
|
|
return FindCode(group, pc, is_return_address);
|
|
}
|
|
|
|
} // namespace dart
|