a677c369d9
Although the data races on patchable object pool entries are benign, without proper release-acquire ordering there is no happens-before relationship between store and load and there is a data race as defined by the C++ standard (and detected by TSAN), which is an undefined behavior. It seems like additional memory_order_acquire loads only happen in runtime entries when we need to patch calls, which is rather infrequent. Unless additional barriers measurably affect performance, we should prefer to avoid UB. TEST=ci Fixes https://github.com/dart-lang/sdk/issues/62236 Change-Id: I3a4d8c3dca7ce1ee1a75efd1ea8ba4e9c06c9dd6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/476500 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
182 lines
6.5 KiB
C++
182 lines
6.5 KiB
C++
// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
|
|
#if defined(TARGET_ARCH_ARM64)
|
|
|
|
#include "vm/code_patcher.h"
|
|
#include "vm/cpu.h"
|
|
#include "vm/instructions.h"
|
|
#include "vm/object.h"
|
|
|
|
namespace dart {
|
|
|
|
class PoolPointerCall : public ValueObject {
|
|
public:
|
|
PoolPointerCall(uword pc, const Code& code)
|
|
: end_(pc), object_pool_(ObjectPool::Handle(code.GetObjectPool())) {
|
|
// Last instruction: blr lr.
|
|
ASSERT(*(reinterpret_cast<uint32_t*>(end_) - 1) == 0xd63f03c0);
|
|
InstructionPattern::DecodeLoadWordFromPool(end_ - 2 * Instr::kInstrSize,
|
|
®_, &index_);
|
|
}
|
|
|
|
intptr_t pp_index() const { return index_; }
|
|
|
|
CodePtr Target() const {
|
|
return static_cast<CodePtr>(
|
|
object_pool_.ObjectAt<std::memory_order_acquire>(pp_index()));
|
|
}
|
|
|
|
void SetTarget(const Code& target) const {
|
|
object_pool_.SetObjectAt<std::memory_order_release>(pp_index(), target);
|
|
// No need to flush the instruction cache, since the code is not modified.
|
|
}
|
|
|
|
private:
|
|
static constexpr int kCallPatternSize = 3 * Instr::kInstrSize;
|
|
uword end_;
|
|
const ObjectPool& object_pool_;
|
|
Register reg_;
|
|
intptr_t index_;
|
|
DISALLOW_IMPLICIT_CONSTRUCTORS(PoolPointerCall);
|
|
};
|
|
|
|
CodePtr CodePatcher::GetStaticCallTargetAt(uword return_address,
|
|
const Code& code) {
|
|
ASSERT(code.ContainsInstructionAt(return_address));
|
|
PoolPointerCall call(return_address, code);
|
|
return call.Target();
|
|
}
|
|
|
|
void CodePatcher::PatchStaticCallAt(uword return_address,
|
|
const Code& code,
|
|
const Code& new_target) {
|
|
PatchPoolPointerCallAt(return_address, code, new_target);
|
|
}
|
|
|
|
void CodePatcher::PatchPoolPointerCallAt(uword return_address,
|
|
const Code& code,
|
|
const Code& new_target) {
|
|
ASSERT(code.ContainsInstructionAt(return_address));
|
|
PoolPointerCall call(return_address, code);
|
|
call.SetTarget(new_target);
|
|
}
|
|
|
|
CodePtr CodePatcher::GetInstanceCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
Object* data) {
|
|
ASSERT(caller_code.ContainsInstructionAt(return_address));
|
|
ICCallPattern call(return_address, caller_code);
|
|
if (data != nullptr) {
|
|
*data = call.Data();
|
|
}
|
|
return call.TargetCode();
|
|
}
|
|
|
|
void CodePatcher::PatchInstanceCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
const Object& data,
|
|
const Code& target) {
|
|
auto thread = Thread::Current();
|
|
thread->isolate_group()->RunWithStoppedMutators([&]() {
|
|
PatchInstanceCallAtWithMutatorsStopped(thread, return_address, caller_code,
|
|
data, target);
|
|
});
|
|
}
|
|
|
|
void CodePatcher::PatchInstanceCallAtWithMutatorsStopped(
|
|
Thread* thread,
|
|
uword return_address,
|
|
const Code& caller_code,
|
|
const Object& data,
|
|
const Code& target) {
|
|
ASSERT(caller_code.ContainsInstructionAt(return_address));
|
|
ICCallPattern call(return_address, caller_code);
|
|
call.SetData(data);
|
|
call.SetTargetCode(target);
|
|
}
|
|
|
|
FunctionPtr CodePatcher::GetUnoptimizedStaticCallAt(uword return_address,
|
|
const Code& code,
|
|
ICData* ic_data_result) {
|
|
ASSERT(code.ContainsInstructionAt(return_address));
|
|
ICCallPattern static_call(return_address, code);
|
|
ICData& ic_data = ICData::Handle();
|
|
ic_data ^= static_call.Data();
|
|
if (ic_data_result != nullptr) {
|
|
*ic_data_result = ic_data.ptr();
|
|
}
|
|
return ic_data.GetTargetAt(0);
|
|
}
|
|
|
|
void CodePatcher::PatchSwitchableCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
const Object& data,
|
|
const Code& target) {
|
|
// We lock to block other writers but don't start a safepoint to block readers
|
|
// (i.e., Dart execution).
|
|
// First update target to a stub that does not read 'data' so that concurrent
|
|
// Dart execution cannot observe the new stub with the old data or the old
|
|
// stub with the new data.
|
|
SafepointMutexLocker ml(IsolateGroup::Current()->type_feedback_mutex());
|
|
if (FLAG_precompiled_mode) {
|
|
BareSwitchableCallPattern call(return_address);
|
|
call.SetTargetRelease(StubCode::SwitchableCallMiss());
|
|
call.SetDataRelease(data);
|
|
call.SetTargetRelease(target);
|
|
} else {
|
|
SwitchableCallPattern call(return_address, caller_code);
|
|
call.SetTargetRelease(StubCode::SwitchableCallMiss());
|
|
call.SetDataRelease(data);
|
|
call.SetTargetRelease(target);
|
|
}
|
|
}
|
|
|
|
uword CodePatcher::GetSwitchableCallTargetEntryAt(uword return_address,
|
|
const Code& caller_code) {
|
|
if (FLAG_precompiled_mode) {
|
|
BareSwitchableCallPattern call(return_address);
|
|
return call.target_entry();
|
|
} else {
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
|
|
ObjectPtr CodePatcher::GetSwitchableCallDataAt(uword return_address,
|
|
const Code& caller_code) {
|
|
if (FLAG_precompiled_mode) {
|
|
BareSwitchableCallPattern call(return_address);
|
|
return call.data();
|
|
} else {
|
|
SwitchableCallPattern call(return_address, caller_code);
|
|
return call.data();
|
|
}
|
|
}
|
|
|
|
void CodePatcher::PatchNativeCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
NativeFunction target,
|
|
const Code& trampoline) {
|
|
Thread::Current()->isolate_group()->RunWithStoppedMutators([&]() {
|
|
ASSERT(caller_code.ContainsInstructionAt(return_address));
|
|
NativeCallPattern call(return_address, caller_code);
|
|
call.set_target(trampoline);
|
|
call.set_native_function(target);
|
|
});
|
|
}
|
|
|
|
CodePtr CodePatcher::GetNativeCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
NativeFunction* target) {
|
|
ASSERT(caller_code.ContainsInstructionAt(return_address));
|
|
NativeCallPattern call(return_address, caller_code);
|
|
*target = call.native_function();
|
|
return call.target();
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined TARGET_ARCH_ARM64
|