Commit Graph

37355 Commits

Author SHA1 Message Date
Florian Schneider f6c19ee595 VM: Improve single-target polymorphic calls.
Use the existing class-id check for dense ranges in more places.
Previously we would fall back to megamorphic lookup with >4 cids,
even though we can check cid ranges up to word-size efficiently.

Next step is to generalize the dense class id checks to multiple
word-sizes.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/1847293002 .
2016-04-01 09:59:27 -07:00
Jacob Richman 618f46da9c Roll webkit to version that elmininates snapshot generation from the vm for JS interop now that the VM allows allows patching of classes after finalization.
BUG=

Review URL: https://codereview.chromium.org/1848443006 .
2016-04-01 09:54:45 -07:00
Konstantin Shcheglov b8fc38e8a8 Issue 26167. Test for indexing a unit which is not attached to a library.
We had the corresponding check wider than tests.
So, the problem in the issue does not happen now.
But it's still good to have a test.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26167

Review URL: https://codereview.chromium.org/1854683003 .
2016-04-01 09:47:08 -07:00
Paul Berry 5268afc378 Add more type inference uses cases to AST-based summaries.
With this CL, we support type inference of fields and property
accessors (when generics are not involved) based on inheritance.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1853433006 .
2016-04-01 09:44:02 -07:00
Brian Wilkerson 6dae827b70 More strong mode fixes for analyzer
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1842363004 .
2016-04-01 09:35:22 -07:00
Konstantin Shcheglov 8dcba124cf Increment version before publishing a new version of analyzer.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1847853005 .
2016-04-01 09:08:03 -07:00
Paul Berry a829226945 Add support for method parameter type inference to AST summaries.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1849843003 .
2016-04-01 08:59:00 -07:00
Regis Crelier 786623ee61 Removing unnecessary entry according to https://github.com/dart-lang/sdk/issues/26157
R=iposva@google.com

Review URL: https://codereview.chromium.org/1848933003 .
2016-04-01 08:20:50 -07:00
Zachary Anderson 9c9b5e2f2f Update changelog for SecurityContext.alpnSupported
fixes #26157

R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1850913002 .
2016-04-01 07:49:09 -07:00
John McCutchan b1eb8859a5 Add call tree filter to Observatory CPU profile tree
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1846713003 .
2016-04-01 06:41:09 -07:00
Johnni Winther 46beb25f43 Add *IndexSetIfNull methods to SemanticSendVisitor.
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1842033004 .
2016-04-01 09:46:42 +02:00
Siva Annamalai 4b38c3dfc2 - Fix the hash code for raw objects that are added into the object pool
index table
- Do not try to figure out if the passed in handle is a temporary scoped
  handle, instead have all the callers create a ZoneHandle

Compilation of the ESS initialization code in GreenTea reduces from 2.56secs to .497 secs

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1846063002 .
2016-03-31 21:41:16 -07:00
Siva Annamalai 78a6b46155 Provide ability to patch external functions in a class that has already been finalized. The following restrictions are in place:
- No new fields or patching of existing fields can be done
 - Only external methods that have not already executed (i.e code for it has been   generated) can be patched

This change enables patching of JS Interop methods into a class and provides close to 5 sec drop in start up times for Green Tea app.

R=hausner@google.com, regis@google.com

Review URL: https://codereview.chromium.org/1850653003 .
2016-03-31 20:06:44 -07:00
Kevin Moore 8613e9c6d0 Document addition of dartdevc in CHANGELOG
R=vsm@google.com

Review URL: https://codereview.chromium.org/1845963004 .
2016-03-31 16:55:51 -07:00
Zach Anderson b0475caa7f Allows adding trusted certs on iOS.
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org/1845273004 .
2016-03-31 15:51:14 -07:00
Paul Berry 2706796239 Begin implementing type inference for AST summaries.
As much as possible, we re-use the logic of InstanceMemberInferrer.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1845403003 .
2016-03-31 15:12:51 -07:00
Srdjan Mitrovic c86ad33bca Fix product run
BUG=

Review URL: https://codereview.chromium.org/1850693004 .
2016-03-31 13:50:11 -07:00
Konstantin Shcheglov fd4e357413 Issue 26147. Don't attempt to set the type of the parameter for setters without parameters.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26147

Review URL: https://codereview.chromium.org/1850623005 .
2016-03-31 13:46:41 -07:00
Brian Wilkerson cbcb689184 Fix the way generated code is made strong mode clean
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1849973002 .
2016-03-31 13:43:07 -07:00
Konstantin Shcheglov 054be34e6c Issue 26148. Don't use a current token if it does not match - create a new synthetic.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26148

Review URL: https://codereview.chromium.org/1851623002 .
2016-03-31 13:40:17 -07:00
Srdjan Mitrovic f9150317fb Fix product build
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1850873002 .
2016-03-31 13:33:14 -07:00
Brian Wilkerson e531f01e73 Fix more strong mode errors in analyzer
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1847633002 .
2016-03-31 13:30:04 -07:00
Brian Wilkerson ca100e0be2 Merge pull request #26153 from pylaligand/lints
Added option to dartanalyzer to treat lints as errors.
2016-03-31 13:28:20 -07:00
Zach Anderson 08450dc432 Begin work on ios secure sockets
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org/1839123003 .
2016-03-31 12:55:31 -07:00
Konstantin Shcheglov 498c77ef51 Issue dartdoc#1124. Get used elements from directive comments.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/dartdoc/issues/1124

Review URL: https://codereview.chromium.org/1850813002 .
2016-03-31 12:42:51 -07:00
Srdjan Mitrovic f8f120bb17 Fix disassembly with background compilation: parsing can report 'errors' in background compilation
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1843253003 .
2016-03-31 12:17:51 -07:00
P.Y. Laligand f2a8ee1ebc Added option to dartanalyzer to treat lints as errors.
Fixes #25977
2016-03-31 11:24:51 -07:00
John McCutchan 29225365fd Automatically fetch timeline when timeline page is loaded
R=asiva@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/1847043003 .
2016-03-31 11:03:14 -07:00
Brian Wilkerson 301a6a4725 Fix generated server code to be strong mode compliant
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1852473002 .
2016-03-31 10:44:42 -07:00
Konstantin Shcheglov 05df65f7db Issue 26146. Get next token after '{' or '}' while skipping interpolations.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26146

Review URL: https://codereview.chromium.org/1847093002 .
2016-03-31 10:40:43 -07:00
Srdjan Mitrovic 8e03dddabf Fix crash by disabling problematic functionalitie (VerifyPointers)
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1848843002 .
2016-03-31 10:35:52 -07:00
Konstantin Shcheglov 559bc17535 Rework computing simple strings difference.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26140

Review URL: https://codereview.chromium.org/1849843002 .
2016-03-31 10:18:06 -07:00
Ryan Macnak 7007644ba4 Include snapshot size in the events for reading the isolate snapshots.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1844423003 .
2016-03-31 10:17:50 -07:00
John McCutchan bb70592aa0 Update trace-viewer to a154c2f5e4ee5e7bafa82340a69b3cd32047de8c
BUG=

Review URL: https://codereview.chromium.org/1834223010 .
2016-03-31 10:07:53 -07:00
Ryan Macnak 1c107c4fbd vm-service: Include bytecode with _RegExp objects.
BUG=http://dartbug.com/26042
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1822933002 .
2016-03-31 10:05:18 -07:00
Alan Knight 0f5c249f22 Fix webgl methods, properly this time
BUG=

Review URL: https://codereview.chromium.org/1846803002 .
2016-03-31 09:45:32 -07:00
Dan Rubel 3b18b656c3 tests to assert completion suggestion replacementLength includes entire URI
https://github.com/dart-lang/sdk/issues/26083

R=jwren@google.com

Review URL: https://codereview.chromium.org/1843513003 .
2016-03-31 12:38:38 -04:00
John McCutchan ad0878d1a8 Remove redundant timeline API
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1848683002 .
2016-03-31 09:13:54 -07:00
Jacob Richman 3cb280c5e1 Fast path Location.hash as some apps call it 10000+ times a frame.
BUG=

Review URL: https://codereview.chromium.org/1847543003 .
2016-03-31 09:04:10 -07:00
Brian Wilkerson 0d743fbacf Start making server strong mode clean
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1842063003 .
2016-03-31 08:27:05 -07:00
Johnni Winther 27b2c36ec1 Serialize ResolutionImpact instead of WorldImpact.
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1839243003 .
2016-03-31 09:55:03 +02:00
Florian Schneider c53ec0971b Add diagnostic printing to standalone/precompilation_test.
This should help diagnose which step causes the flaky timeout
failures on the buildbot.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1844233002 .
2016-03-30 17:38:35 -07:00
Konstantin Shcheglov 582c038940 Fix for sorting directives with documentation comments.
Stop trying to keep non-documentation directive comments after sorting.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1843763002 .
2016-03-30 17:21:30 -07:00
John McCutchan a72409a0d4 Refactor call tree search to support both Code and Function trees
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1837373002 .
2016-03-30 17:13:48 -07:00
John McCutchan d8df41c483 Add support for async, metadata, and counter timeline events to be reported by the embedder
Fixes #26142

R=chinmaygarde@google.com

Review URL: https://codereview.chromium.org/1849643002 .
2016-03-30 16:45:46 -07:00
Florian Schneider dd72d74964 Fix --trace-isolates VM crash.
Thread::Current() is NULL when shutting down, causing a seg fault when
executing thread()->sticky_error().

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1818883003 .
2016-03-30 16:35:10 -07:00
Florian Schneider 2783afd607 VM: Fix receiver type propagation in presence of try-catch.
With catch blocks appearing as additional function entry blocks,
there can be phis for the receiver (parameter 0).

This CL fixes the problem that the receiver type information
was lost in the presence of try-catch.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/1841073003 .
2016-03-30 15:55:11 -07:00
Srdjan Mitrovic a7a7a5be55 Fix CompilerStats aggregation: do not aggregate if there is no mutator thread (isolate shutting down).
Disable background compilation in Profiler_StringInterpolation.

BUG=

Review URL: https://codereview.chromium.org/1847683002 .
2016-03-30 14:24:08 -07:00
Srdjan Mitrovic 1a9fc8b2fa Move CompilerStats from isolate to thread. Aggregate stats.
The mutator thread holds the aggregate values, the background compiler adds its value to it.

BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org/1841213003 .
2016-03-30 13:38:32 -07:00
Ryan Macnak ba608694b7 Ensure deoptimizing frames have a valid pc marker before deferred materialization.
BUG=http://dartbug.com/26131
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1847623002 .
2016-03-30 13:11:14 -07:00