It looks like some of the tests in this block were already migrated,
but I re-migrated them and made a few tweaks that I think make them
better 2.0 tests.
Change-Id: I6d9058a53408f046d7db34f2244eeeb2c5eda625
Reviewed-on: https://dart-review.googlesource.com/13620
Reviewed-by: Ben Konyi <bkonyi@google.com>
Successfully migrated 11 tests. Need manual work on 5 tests:
- language_2/sync_generator1_test.dart:
(TODO) Merge from language/sync_generator1_test.dart into this file.
- language_2/syncstar_less_than_test.dart:
(TODO) Merge from language/syncstar_less_than_test.dart into this file.
- language_2/syncstar_yield_test.dart:
(TODO) Merge from language/syncstar_yield_test.dart into this file.
- language_2/syncstar_yieldstar_test.dart:
(TODO) Merge from language/syncstar_yieldstar_test.dart into this file.
- language_2/syntax_test.dart:
(TODO) Merge from language/syntax_test.dart into this file.
Bug:
Change-Id: I894d881a9c1182e6f2c9d190128cc3d0a53faa7f
Reviewed-on: https://dart-review.googlesource.com/12385
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Successfully migrated 7 tests. Need manual work on 6 tests:
- language_2/try_catch_test.dart:
(TODO) Merge from language/try_catch_test.dart into this file.
- language_2/type_argument_in_super_type_test.dart:
(TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
- language_2/type_check_const_function_typedef2_test.dart:
(TODO) Fix code that mentions "checked" mode.
- language_2/type_checks_in_factory_method_test.dart:
(TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
- language_2/type_conversion_ssa_test.dart:
(TODO) Fix code that mentions "checked" mode.
- language_2/type_error_test.dart:
(TODO) Merge from language/type_error_test.dart into this file.
(TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
Bug:
Change-Id: I43901890540efcf55da13d013571ce91979cbb64
Reviewed-on: https://dart-review.googlesource.com/11142
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
1. We no longer remove type parameters on functions.
2. We no longer remove type arguments at call sites.
3. We allow non-captured function type parameters to be used outside closures.
Bug:
Change-Id: I116ec54c90b04be90e1157042c22797e57a7c51c
Reviewed-on: https://dart-review.googlesource.com/9342
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
In kernel the loop level wasn't set correctly for for loops, resulting
in the loop variable not always being fresh.
Examples:
```
// Capture the loop variable, ensure we capture the right value.
for (int i = 0; i < 10; i++) { if (i == 7) f = () => "i = $i"; }
print(f());
// There is only one instance of k. The captured variable continues to change.
int k;
for (k = 0; k < 10; k++) { if (k == 7) f = () => "k = $k"; }
print(f());
```
resulted in
i = 10
k = 10
(i.e. it's wrong)
whereas
```
// Capture the loop variable, ensure we capture the right value.
for (int i = 0; i < 10; i++) { if (i == 7) { f = () => "i = $i"; } }
print(f());
{
// There is only one instance of k. The captured variable continues to change.
int k;
for (k = 0; k < 10; k++) { if (k == 7) { f = () => "k = $k"; } }
print(f());
}
```
resultet in
i = 7
k = 10
(i.e. it's correct).
Now both examples produce the correct result.
Change-Id: I1fb4c888c6a0eaa690f62226e093508992b33ed4
Reviewed-on: https://dart-review.googlesource.com/9961
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Previously we got the length of the class' type_parameters().
Now instead we use the class' NumTypeArguments().
Bug:
Change-Id: I3807443765e4926efc17eba54d3bf4f50e8e30c6
Reviewed-on: https://dart-review.googlesource.com/9482
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
- New handleRecoverImport event
for clauses in import directive that are out of order
- New error codes for
Duplicate prefix
Prefix after combinator
Change-Id: I0fea7ad4b4014a0b8578d3982e0515fe85044854
Reviewed-on: https://dart-review.googlesource.com/7980
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Passing the type argument vector <int> in the 'none' configuration is not
correct, but this is not what this test is supposed to check.
Change-Id: I2afd2987e572a6b4340a7d70ee92878abc67055e
Reviewed-on: https://dart-review.googlesource.com/8729
Reviewed-by: Ben Konyi <bkonyi@google.com>
Did not migrate null_bottom / null_is_bottom type tests. Modified
null_test to not run some mirrors related checks on platforms that don't
support mirrors.
Bug:
Change-Id: I7fce784f537cc298e2945a32073700083d9275f8
Reviewed-on: https://dart-review.googlesource.com/7848
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Ben Konyi