dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
51,027 Commits 2 Branches 0 Tags
eead460367914052d1121a8490fc013e2c91c333
Commit Graph

51027 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ben Konyi eead460367 Fixing build failure on DDC-windows. 
Bug:
Change-Id: I137f4075f83864edffd8187add21a1c93b49b83a
Reviewed-on: https://dart-review.googlesource.com/13935
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-14 00:14:44 +00:00
Emily Fortuna 9ab66f726f Fix up language2 status changes as result of https://dart-review.googlesource.com/c/sdk/+/13620 
Bug:
Change-Id: I576d403b76192252e15e8e235fcc613a5e2a178d
Reviewed-on: https://dart-review.googlesource.com/13933
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-14 00:14:11 +00:00
Ben Konyi 73e13aefe6 Migrated block 145 to Dart 2.0. 
Various changes made for strong mode.

Bug:
Change-Id: I7d57cba0ec0420b68f7c1cf3d31fb4c8577e9898
Reviewed-on: https://dart-review.googlesource.com/13201
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-10-13 23:52:14 +00:00
Bob Nystrom 51fdf52c8a Fix analyzer status on the 1.0 language tests. 
Change-Id: Ib15263153f5ded4fc2dcb7ca02c666213ab53a80
Reviewed-on: https://dart-review.googlesource.com/13932
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-13 23:39:57 +00:00
Terry Lucas 087ea1eb28 Updated test with the correct status. 
TBR=rnystrom@google.com

Change-Id: Iccb72b8d38b2d4bf2834efc3d0d0db2cdbd5c19c
Reviewed-on: https://dart-review.googlesource.com/13931
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 23:23:44 +00:00
Brian Wilkerson b7623c1e73 Add another test to help keep analyzer in sync with Fasta 
Change-Id: Ib6c7fdd713fc40948005910607664520cbcbc88f
Reviewed-on: https://dart-review.googlesource.com/13940
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-13 23:06:16 +00:00
Bob Nystrom e2cc730067 Migrate blocks 51 and 52. 
It looks like some of the tests in this block were already migrated,
but I re-migrated them and made a few tweaks that I think make them
better 2.0 tests.

Change-Id: I6d9058a53408f046d7db34f2244eeeb2c5eda625
Reviewed-on: https://dart-review.googlesource.com/13620
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-13 22:46:23 +00:00
Terry Lucas 0ef4de3f0c Updated jsshell tests failures. 
TBR=rnystrom@google.com

Change-Id: I01215d93895d75481063a90e5101d06c470c30d1
Reviewed-on: https://dart-review.googlesource.com/13930
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 22:44:17 +00:00
Stephen Adams b80c0a1dde fix archaic syntax in dart2js_native test 
TBR=efortuna@google.com

Bug:
Change-Id: I394985d25513fa213f7ba9270c92b4d357bff91c
Reviewed-on: https://dart-review.googlesource.com/13923
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2017-10-13 22:40:34 +00:00
Terry Lucas 461d5338ce Update status file for jsshell failure. 
TBR=rnystrom@google.com

Change-Id: Ia852ca2c2b998ca4edc44da00b59bf670dea2330
Reviewed-on: https://dart-review.googlesource.com/13928
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 22:20:32 +00:00
Harry Terkelsen cbfb3b642d Treat async-for-in statements as if they are wrapped in a try-finally 
Change-Id: Ide40e69f93db199e2b452a4ee5acbbabe331bcbf
Reviewed-on: https://dart-review.googlesource.com/13921
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-10-13 22:19:46 +00:00
Terry Lucas f92a9787ba Fixes a couple of analyzer non-strong failures and vm-app failures. 
TBR=asiva@google.com,rnystrom@google.com

Change-Id: I118929724d8a2306db92535992f560d1f1927d12
Reviewed-on: https://dart-review.googlesource.com/13927
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 22:17:16 +00:00
Terry Lucas 7eb00ea45d Migrated Block 146 to Dart 2.0 
R=bkonyi@google.com

Change-Id: If6c7c2ebd8a4e3a3b724ada3967fc5836123732d
Reviewed-on: https://dart-review.googlesource.com/13621
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-13 21:27:17 +00:00
Bob Nystrom f7c70a4bd2 Bring back import_combinators_negative_test. 
I turned it into a normal positive multitest to better capture where the
error is.

Change-Id: I69a1ddbf38b594d6b8270e28f32e018878eee755
Reviewed-on: https://dart-review.googlesource.com/13922
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2017-10-13 21:21:55 +00:00
Ben Konyi df85386946 Publishing Dart Language Newsletter for 2017/10/13. 
Bug:
Change-Id: Iedd649c2b38b0b7044c631d970336d1cd764ac82
Reviewed-on: https://dart-review.googlesource.com/13924
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-13 21:17:07 +00:00
Jennifer Messerly 697e531c17 fix IdentityMap setter concurrent modification detection 
Change-Id: Ib999210cf5709a4cef6a14a8d7fafe7b516f09c9
Reviewed-on: https://dart-review.googlesource.com/13641
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-10-13 20:57:24 +00:00
Konstantin Shcheglov 6b5ba5351b Implement combining outlines for top-level declarations. 
R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com

Bug:
Change-Id: Id849e68d3026457bdddb98604b92c7424961bbd9
Reviewed-on: https://dart-review.googlesource.com/11649
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2017-10-13 20:32:24 +00:00
Paul Berry 27f5e7f9ee Remove ClassHierarchy.forEachCrossOverridePair. 
This method is no longer needed, since the front end iterates through
members directly to find cross overrides.

Change-Id: Ibc5180962a097c4d6194dbf4cbd1a0dea15050c2
Reviewed-on: https://dart-review.googlesource.com/13582
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-10-13 20:28:55 +00:00
Paul Berry 1dfdbae429 Test that generic covariance annotations are correct when based on inferred types. 
Change-Id: I5d621aa47d088266efd86ee67c96111633b112ac
Reviewed-on: https://dart-review.googlesource.com/13625
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-10-13 19:46:37 +00:00
Konstantin Shcheglov df459aa19d Malbounded types should have all 'dynamic' type arguments. 
See "19.8 Parameterized Types" in the specification.

"In short, any arity mismatch results in all type arguments being dropped, and
replaced with the correct number of type arguments, all set to dynamic. Of course,
a static warning will be issued."

R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/31062
Change-Id: Ia04b6c4da538582736617931eb7b7c20dc0a4259
Reviewed-on: https://dart-review.googlesource.com/13340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-10-13 18:44:34 +00:00
Brian Wilkerson 75908a5315 Fix recovery inside expressions 
Change-Id: I20bc1c87c258cb99032e0d8099e88f56779fc509
Reviewed-on: https://dart-review.googlesource.com/13880
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-13 18:06:05 +00:00
Brian Wilkerson 940b9e5fdf Connect a Fasta error to an Analyzer error 
Change-Id: I9b47e6712b65c2e97693bfef4c022109431660f1
Reviewed-on: https://dart-review.googlesource.com/13860
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-13 18:05:44 +00:00
Brian Wilkerson 64eee95cb0 Minor clean-up of asserts and comments 
Change-Id: Ib28a6ba789bfdf65f740863c28ca050512433736
Reviewed-on: https://dart-review.googlesource.com/13820
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-10-13 17:55:58 +00:00
Alexander Markov dd2d586a30 [Test status] exclude html/* tests from dartkp configuration 
Change-Id: I3684b3fc87f91465076c6ca70804a47c6053d9a6
Reviewed-on: https://dart-review.googlesource.com/13840
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-10-13 17:53:23 +00:00
Konstantin Shcheglov 49503ac2cc Start using Kernel metadata support in KernelDriver and Analyzer. 
Use it to implement documentation comments for typedef(s).

R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug:
Change-Id: I6f67f1c0e6b6f383a96e6bf6eee17f4786bc5f99
Reviewed-on: https://dart-review.googlesource.com/12700
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-10-13 17:47:53 +00:00
pq 10bc3abaa4 Migrate test block 155 to Dart 2.0. 
Bug:
Change-Id: Ic0f21c64f43f4e1b914ae4b2ceb576f2a5f6b92a
Reviewed-on: https://dart-review.googlesource.com/13100
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-13 17:11:42 +00:00
Brian Wilkerson 2aa005b11b Improved handling of semicolons 
Change-Id: I85c42387bad18149bd2fb7718f6d40b82a95562f
Reviewed-on: https://dart-review.googlesource.com/13626
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-10-13 16:16:43 +00:00
William Hesse 1d0edd70e3 Debian package building should show all output to stdout 
Bug: https://github.com/dart-lang/sdk/issues/31055
Change-Id: I464af3f09df73b19b1fc7cdfd1df133f649c7fe8
R=eernst@google.com,ahe@google.com
Reviewed-on: https://dart-review.googlesource.com/13760
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-10-13 14:18:33 +00:00
Morten Krogh-Jespersen 16fd76c481 Allow logging of all types of failures. 
Bug:
Change-Id: I9f37f77815eda65085fa3b303d8197d480db8d66
Reviewed-on: https://dart-review.googlesource.com/13740
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-10-13 13:06:47 +00:00
Karl Klose b34a107371 Add WATCHLISTS entry for pkg/kernel 
R=dmitryas@google.com

Change-Id: Iafa7071a74ed40aae48887c460b5b5efcf1c8c5d
Reviewed-on: https://dart-review.googlesource.com/13721
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2017-10-13 11:15:13 +00:00
Erik Ernst 338b070178 Added informal specification of instantiate to bound. 
Change-Id: Ie4b05f16006743207be76e26195ff345bf2efc6b
Reviewed-on: https://dart-review.googlesource.com/5765
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2017-10-13 10:03:43 +00:00
William Hesse d162f26e77 Update dart2js-with-kernel status on a migrated language_2 test 
TBR=terry@google.com

Bug:
Change-Id: I4082b429a84aefae61a151fee821de24fc77d6a7
Reviewed-on: https://dart-review.googlesource.com/13720
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-13 08:53:09 +00:00
Johnni Winther f80860ddbd Track exposure of this in inferrer 
Change-Id: I07d899ed59fd28ffe258c518743c66aa20fa0540
Reviewed-on: https://dart-review.googlesource.com/13480
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-10-13 07:50:35 +00:00
Terry Lucas fb8099fc42 Fix precompiler tests 
TBR=bkonyi@google.com

Change-Id: I167c8894886b495e1e239c0ff7072dbf2f601622
Reviewed-on: https://dart-review.googlesource.com/13685
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 05:41:22 +00:00
Terry Lucas 07920cb852 Updated for strong mode tests only. 
TBR=bkonyi@google.com

Change-Id: Ica922201af78bff8897ffd5659d352fe11a6b746
Reviewed-on: https://dart-review.googlesource.com/13684
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 05:30:30 +00:00
Terry Lucas d64f62df27 Fixed status for analyzer w/o strong mode. 
TBR=bkonyi@google.com

Change-Id: Id966134cd589f0eeffe5781b2e5ec886ac41fe03
Reviewed-on: https://dart-review.googlesource.com/13683
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 04:55:03 +00:00
Terry Lucas aa768ee6bc Fixed status file for arm64 
TBR=bkonyi@google.com

Change-Id: Ibc4f8faa1d30c0c5d9a2d78d7cc5c25badbf7003
Reviewed-on: https://dart-review.googlesource.com/13682
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 04:31:45 +00:00
Terry Lucas dfa7916418 Migrated block 148 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I2f455fd681b66c43cbcd873f3d3d278a5ff5c843
Reviewed-on: https://dart-review.googlesource.com/12762
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 04:27:03 +00:00
Dan Rubel f985f42db5 update status file 
Change-Id: Ie3219ac0e13b1b94982fcf0e13f629ded11041fa
Reviewed-on: https://dart-review.googlesource.com/13700
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-10-13 03:12:19 +00:00
Terry Lucas 0975c0f948 Updated status files 
TBR=bkonyi@google.com

Change-Id: I00fe74bda01e6d8478251767053e4ba945527c49
Reviewed-on: https://dart-review.googlesource.com/13680
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 01:04:28 +00:00
Terry Lucas 9cf013a802 Revert "Revert "Migrated Block 150 to Dart 2.0"" 
This reverts commit a80fecfa20.

TBR=alanknight@google.com

Change-Id: I448a808c0dcf67209c2981732f8829723b959c52
Reviewed-on: https://dart-review.googlesource.com/13663
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-13 00:06:32 +00:00
Terry Lucas 9432ab4e62 Update status file for bot failures. 
TBR=bkonyi@google.com

Change-Id: I90addb38cb265a6b2de6423c29c8957e86182f2d
Reviewed-on: https://dart-review.googlesource.com/13661
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-12 23:57:54 +00:00
Alan Knight a80fecfa20 Revert "Migrated Block 150 to Dart 2.0" 
This reverts commit 7601cb257e.

Bug:
Change-Id: I5b7c8c18917bdb4a4fc6b4147b487c3044b89bc8
Reviewed-on: https://dart-review.googlesource.com/13660
Reviewed-by: Alan Knight <alanknight@google.com>
Commit-Queue: Alan Knight <alanknight@google.com>
 2017-10-12 23:52:26 +00:00
danrubel 1582021556 Allow built-in keywords as top level function identifiers 
Change-Id: I4287e8279d2ebe6f4460ce48409b7bd9ead16b96
Reviewed-on: https://dart-review.googlesource.com/13627
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-12 23:48:05 +00:00
P.Y. Laligand ab352af7f7 Teach the SDK patch tool to look for Flutter in a new location. 
The Flutter engine will soon be mapped to //third_party/flutter in Fuchsia.

Change-Id: I280e2ffcfc3de2a5c7ffb96159d7d37341a974a3
Bug:
Reviewed-on: https://dart-review.googlesource.com/13601
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2017-10-12 22:41:05 +00:00
Terry Lucas 7601cb257e Migrated Block 150 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic68c28221f67b3c8ca86b7ac37a3dd15ebe98d80
Reviewed-on: https://dart-review.googlesource.com/12621
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-12 22:14:15 +00:00
Jaime Wren 09c44617e6 Migrate Dart 2.0 test block 133 
Change-Id: I58172fdfe7daf5910d11ce90491b5aefa137accd
Reviewed-on: https://dart-review.googlesource.com/13623
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-10-12 21:22:41 +00:00
Brian Wilkerson a22c8dc958 Recover when enum constants have metadata 
Change-Id: I1432c3b2d4ce63c5520087c79dd33e48c57cee5b
Reviewed-on: https://dart-review.googlesource.com/13102
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-12 20:50:31 +00:00
danrubel bde7c0c1ce cleanup top level out-of-order tests 
Change-Id: I473ed461ec754b172866462326e9eaae65ad9aff
Reviewed-on: https://dart-review.googlesource.com/13602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-12 20:04:27 +00:00
Régis Crelier ae94cbf3d6 Revert "[kernel] Support generic closures in VM's kernel frontend." 
This reverts commit a273ff8314.

Revert "[kernel] Support generic function types in the VM's kernel frontend."

This reverts commit 2cac57da09.

Revert "[kernel] Completely remove type erasure."

This reverts commit 3ffacb3814.

Change-Id: I8fdd40a6a8f34911028353f48249fdd4bf7dba76
Reviewed-on: https://dart-review.googlesource.com/13622
Reviewed-by: Alan Knight <alanknight@google.com>
Commit-Queue: Alan Knight <alanknight@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2017-10-12 20:01:11 +00:00