Commit Graph

16074 Commits

Author SHA1 Message Date
Ben Konyi eead460367 Fixing build failure on DDC-windows.
Bug:
Change-Id: I137f4075f83864edffd8187add21a1c93b49b83a
Reviewed-on: https://dart-review.googlesource.com/13935
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-14 00:14:44 +00:00
Emily Fortuna 9ab66f726f Fix up language2 status changes as result of https://dart-review.googlesource.com/c/sdk/+/13620
Bug:
Change-Id: I576d403b76192252e15e8e235fcc613a5e2a178d
Reviewed-on: https://dart-review.googlesource.com/13933
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-14 00:14:11 +00:00
Ben Konyi 73e13aefe6 Migrated block 145 to Dart 2.0.
Various changes made for strong mode.

Bug:
Change-Id: I7d57cba0ec0420b68f7c1cf3d31fb4c8577e9898
Reviewed-on: https://dart-review.googlesource.com/13201
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
2017-10-13 23:52:14 +00:00
Bob Nystrom 51fdf52c8a Fix analyzer status on the 1.0 language tests.
Change-Id: Ib15263153f5ded4fc2dcb7ca02c666213ab53a80
Reviewed-on: https://dart-review.googlesource.com/13932
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-13 23:39:57 +00:00
Terry Lucas 087ea1eb28 Updated test with the correct status.
TBR=rnystrom@google.com

Change-Id: Iccb72b8d38b2d4bf2834efc3d0d0db2cdbd5c19c
Reviewed-on: https://dart-review.googlesource.com/13931
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 23:23:44 +00:00
Bob Nystrom e2cc730067 Migrate blocks 51 and 52.
It looks like some of the tests in this block were already migrated,
but I re-migrated them and made a few tweaks that I think make them
better 2.0 tests.

Change-Id: I6d9058a53408f046d7db34f2244eeeb2c5eda625
Reviewed-on: https://dart-review.googlesource.com/13620
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-13 22:46:23 +00:00
Terry Lucas 0ef4de3f0c Updated jsshell tests failures.
TBR=rnystrom@google.com

Change-Id: I01215d93895d75481063a90e5101d06c470c30d1
Reviewed-on: https://dart-review.googlesource.com/13930
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 22:44:17 +00:00
Stephen Adams b80c0a1dde fix archaic syntax in dart2js_native test
TBR=efortuna@google.com

Bug:
Change-Id: I394985d25513fa213f7ba9270c92b4d357bff91c
Reviewed-on: https://dart-review.googlesource.com/13923
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2017-10-13 22:40:34 +00:00
Terry Lucas 461d5338ce Update status file for jsshell failure.
TBR=rnystrom@google.com

Change-Id: Ia852ca2c2b998ca4edc44da00b59bf670dea2330
Reviewed-on: https://dart-review.googlesource.com/13928
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 22:20:32 +00:00
Harry Terkelsen cbfb3b642d Treat async-for-in statements as if they are wrapped in a try-finally
Change-Id: Ide40e69f93db199e2b452a4ee5acbbabe331bcbf
Reviewed-on: https://dart-review.googlesource.com/13921
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
2017-10-13 22:19:46 +00:00
Terry Lucas f92a9787ba Fixes a couple of analyzer non-strong failures and vm-app failures.
TBR=asiva@google.com,rnystrom@google.com

Change-Id: I118929724d8a2306db92535992f560d1f1927d12
Reviewed-on: https://dart-review.googlesource.com/13927
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 22:17:16 +00:00
Terry Lucas 7eb00ea45d Migrated Block 146 to Dart 2.0
R=bkonyi@google.com

Change-Id: If6c7c2ebd8a4e3a3b724ada3967fc5836123732d
Reviewed-on: https://dart-review.googlesource.com/13621
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-13 21:27:17 +00:00
Bob Nystrom f7c70a4bd2 Bring back import_combinators_negative_test.
I turned it into a normal positive multitest to better capture where the
error is.

Change-Id: I69a1ddbf38b594d6b8270e28f32e018878eee755
Reviewed-on: https://dart-review.googlesource.com/13922
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2017-10-13 21:21:55 +00:00
Konstantin Shcheglov df459aa19d Malbounded types should have all 'dynamic' type arguments.
See "19.8 Parameterized Types" in the specification.

"In short, any arity mismatch results in all type arguments being dropped, and
replaced with the correct number of type arguments, all set to dynamic. Of course,
a static warning will be issued."

R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/31062
Change-Id: Ia04b6c4da538582736617931eb7b7c20dc0a4259
Reviewed-on: https://dart-review.googlesource.com/13340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2017-10-13 18:44:34 +00:00
Alexander Markov dd2d586a30 [Test status] exclude html/* tests from dartkp configuration
Change-Id: I3684b3fc87f91465076c6ca70804a47c6053d9a6
Reviewed-on: https://dart-review.googlesource.com/13840
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2017-10-13 17:53:23 +00:00
pq 10bc3abaa4 Migrate test block 155 to Dart 2.0.
Bug:
Change-Id: Ic0f21c64f43f4e1b914ae4b2ceb576f2a5f6b92a
Reviewed-on: https://dart-review.googlesource.com/13100
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-13 17:11:42 +00:00
William Hesse d162f26e77 Update dart2js-with-kernel status on a migrated language_2 test
TBR=terry@google.com

Bug:
Change-Id: I4082b429a84aefae61a151fee821de24fc77d6a7
Reviewed-on: https://dart-review.googlesource.com/13720
Reviewed-by: William Hesse <whesse@google.com>
2017-10-13 08:53:09 +00:00
Johnni Winther f80860ddbd Track exposure of this in inferrer
Change-Id: I07d899ed59fd28ffe258c518743c66aa20fa0540
Reviewed-on: https://dart-review.googlesource.com/13480
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-10-13 07:50:35 +00:00
Terry Lucas fb8099fc42 Fix precompiler tests
TBR=bkonyi@google.com

Change-Id: I167c8894886b495e1e239c0ff7072dbf2f601622
Reviewed-on: https://dart-review.googlesource.com/13685
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 05:41:22 +00:00
Terry Lucas 07920cb852 Updated for strong mode tests only.
TBR=bkonyi@google.com

Change-Id: Ica922201af78bff8897ffd5659d352fe11a6b746
Reviewed-on: https://dart-review.googlesource.com/13684
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 05:30:30 +00:00
Terry Lucas d64f62df27 Fixed status for analyzer w/o strong mode.
TBR=bkonyi@google.com

Change-Id: Id966134cd589f0eeffe5781b2e5ec886ac41fe03
Reviewed-on: https://dart-review.googlesource.com/13683
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 04:55:03 +00:00
Terry Lucas aa768ee6bc Fixed status file for arm64
TBR=bkonyi@google.com

Change-Id: Ibc4f8faa1d30c0c5d9a2d78d7cc5c25badbf7003
Reviewed-on: https://dart-review.googlesource.com/13682
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 04:31:45 +00:00
Terry Lucas dfa7916418 Migrated block 148 to Dart 2.0
R=bkonyi@google.com

Change-Id: I2f455fd681b66c43cbcd873f3d3d278a5ff5c843
Reviewed-on: https://dart-review.googlesource.com/12762
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 04:27:03 +00:00
Dan Rubel f985f42db5 update status file
Change-Id: Ie3219ac0e13b1b94982fcf0e13f629ded11041fa
Reviewed-on: https://dart-review.googlesource.com/13700
Reviewed-by: Dan Rubel <danrubel@google.com>
2017-10-13 03:12:19 +00:00
Terry Lucas 0975c0f948 Updated status files
TBR=bkonyi@google.com

Change-Id: I00fe74bda01e6d8478251767053e4ba945527c49
Reviewed-on: https://dart-review.googlesource.com/13680
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 01:04:28 +00:00
Terry Lucas 9cf013a802 Revert "Revert "Migrated Block 150 to Dart 2.0""
This reverts commit a80fecfa20.

TBR=alanknight@google.com

Change-Id: I448a808c0dcf67209c2981732f8829723b959c52
Reviewed-on: https://dart-review.googlesource.com/13663
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-13 00:06:32 +00:00
Terry Lucas 9432ab4e62 Update status file for bot failures.
TBR=bkonyi@google.com

Change-Id: I90addb38cb265a6b2de6423c29c8957e86182f2d
Reviewed-on: https://dart-review.googlesource.com/13661
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-12 23:57:54 +00:00
Alan Knight a80fecfa20 Revert "Migrated Block 150 to Dart 2.0"
This reverts commit 7601cb257e.

Bug:
Change-Id: I5b7c8c18917bdb4a4fc6b4147b487c3044b89bc8
Reviewed-on: https://dart-review.googlesource.com/13660
Reviewed-by: Alan Knight <alanknight@google.com>
Commit-Queue: Alan Knight <alanknight@google.com>
2017-10-12 23:52:26 +00:00
danrubel 1582021556 Allow built-in keywords as top level function identifiers
Change-Id: I4287e8279d2ebe6f4460ce48409b7bd9ead16b96
Reviewed-on: https://dart-review.googlesource.com/13627
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-10-12 23:48:05 +00:00
Terry Lucas 7601cb257e Migrated Block 150 to Dart 2.0
R=bkonyi@google.com

Change-Id: Ic68c28221f67b3c8ca86b7ac37a3dd15ebe98d80
Reviewed-on: https://dart-review.googlesource.com/12621
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-12 22:14:15 +00:00
Jaime Wren 09c44617e6 Migrate Dart 2.0 test block 133
Change-Id: I58172fdfe7daf5910d11ce90491b5aefa137accd
Reviewed-on: https://dart-review.googlesource.com/13623
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
2017-10-12 21:22:41 +00:00
Régis Crelier ae94cbf3d6 Revert "[kernel] Support generic closures in VM's kernel frontend."
This reverts commit a273ff8314.

Revert "[kernel] Support generic function types in the VM's kernel frontend."

This reverts commit 2cac57da09.

Revert "[kernel] Completely remove type erasure."

This reverts commit 3ffacb3814.

Change-Id: I8fdd40a6a8f34911028353f48249fdd4bf7dba76
Reviewed-on: https://dart-review.googlesource.com/13622
Reviewed-by: Alan Knight <alanknight@google.com>
Commit-Queue: Alan Knight <alanknight@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2017-10-12 20:01:11 +00:00
Jaime Wren 3e13e9783d Migrate Dart 2.0 test block 128
Change-Id: I3621006cbd2db4075f1ea55f5e34ecee688a2e18
Reviewed-on: https://dart-review.googlesource.com/13380
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-12 17:35:02 +00:00
Samir Jindel 2cac57da09 [kernel] Support generic function types in the VM's kernel frontend.
Bug:
Change-Id: I3554562b409b35478437601f34e6263615409b38
Reviewed-on: https://dart-review.googlesource.com/12292
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2017-10-12 14:45:21 +00:00
Dmitry Stefantsov 7fa0a6bb69 Mark test standalone_2/io/web_socket_test as flaky
The status of the test was lost for some configurations during the test
migration.

Change-Id: I3cdcefe640614c44fd52a1bae0a55f0026b2d50d
Reviewed-on: https://dart-review.googlesource.com/13541
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-12 13:44:59 +00:00
William Hesse 5e3f12f110 Update status for two migrated tests.
This updates the status for language_2/super_getter_setter_test
and language_2/super_call4_test

Bug:
Change-Id: I0d6aa27003a6f4cb67f6be593e4036dec820d837
Reviewed-on: https://dart-review.googlesource.com/13540
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-12 12:23:51 +00:00
William Hesse 6d1e43630f Update status for migrated tests
Bug:
Change-Id: I2ba85715f5fa375b12009df7e0094c4032f29071
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/13500
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-12 11:22:13 +00:00
Erik Ernst 63de49ccde test.py will now run the spec parser.
This CL modifies tools/test.py such that it can run the spec parser
(after doing `make parser` in tools/spec_parser, and assuming that the
ANTLR 3 library is available at /usr/share/java/antlr3-runtime.jar)
with a command line like

  `tools/test.py -c spec_parser -r none language/callable_test`

It also changes status files to have a name which follows the expected
patterns (e.g., `language/language_spec_parser.status`). Finally, it
adds/changes many entries in status files, such that parsing of the
directories `language` and `language_2` run successfully.

Change-Id: I82a22e32ac4fecd23ac0d4434bcac08f75dd8ffe
Reviewed-on: https://dart-review.googlesource.com/12680
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-12 09:22:28 +00:00
Johnni Winther 99af2fef35 Handle initializers in inferrer.
Change-Id: I0f21682448da8e427a73b849c8e6c8cc523c8201
Reviewed-on: https://dart-review.googlesource.com/12940
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-10-12 08:08:03 +00:00
Johnni Winther 0daecdf552 Skip captured variables in refinement.
Change-Id: Iad54833db0dbdc683790fccec3dca4f5cf435657
Reviewed-on: https://dart-review.googlesource.com/12442
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-10-12 07:59:13 +00:00
Stephen Adams e9317a3417 dedup language_2_dart2js.status
Moved symbol_literal_test/none out of the [ $compiler == dart2js ] section.

TBR=sigmund@google.com

Bug:
Change-Id: I5cfc0c92ded3a0f5a1f5c14d1af121b85301d9eb
Reviewed-on: https://dart-review.googlesource.com/13443
Reviewed-by: Stephen Adams <sra@google.com>
2017-10-12 04:28:04 +00:00
Stephen Adams f9c2fe5e7b update dart2js kernel status for language
TBR=sigmund@google.com
Bug:
Change-Id: I987bff27908e8dd23ebfed0bb40ca513e7ddbf43
Reviewed-on: https://dart-review.googlesource.com/13420
Reviewed-by: Stephen Adams <sra@google.com>
2017-10-12 03:28:21 +00:00
Stephen Adams d6232aab51 update dart2js kernel language_2 status
TBR=sigmund@google.com
Bug:
Change-Id: I22fa0f6994777f442ed8bf8280066079676bbd48
Reviewed-on: https://dart-review.googlesource.com/13402
Reviewed-by: Stephen Adams <sra@google.com>
2017-10-12 01:06:37 +00:00
Stephen Adams 7e45238571 Update dart2js kernel status langauge_2
TBR=sigmund@google.com
Bug:
Change-Id: I9ee76cbe845cfa8ef149a8ae4987fb7a7de53f80
Reviewed-on: https://dart-review.googlesource.com/13401
Reviewed-by: Stephen Adams <sra@google.com>
2017-10-12 00:29:54 +00:00
William Hesse 28414ddf2d Update status for two language_2 tests on dart2js fast-startup
Bug:
Change-Id: I59cb5b7dcc3ad1c54ecc0bd3fd855864159b0465
TBR=pquitslund@google.com
Reviewed-on: https://dart-review.googlesource.com/13321
Reviewed-by: William Hesse <whesse@google.com>
2017-10-11 22:12:37 +00:00
Harry Terkelsen d62eb05435 Search for members in superclasses when searching for a class member
This changes 'hasConcreteMatch' to search the superclass chain in the
kernel implementation. This matches what the Element model does.

Change-Id: I6a0ab69bc7e6fe705139d6fa69fffc2346582702
Reviewed-on: https://dart-review.googlesource.com/12843
Commit-Queue: Harry Terkelsen <het@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-11 22:07:11 +00:00
Bob Nystrom 3ee3cf7dda Fix status of language/assertion_test in dart2js.
Change-Id: Ic50d183e4b038b6a3bf96cc1000ca83ff7b052c9
Reviewed-on: https://dart-review.googlesource.com/13302
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-11 21:08:19 +00:00
Bob Nystrom 502b450e08 Update the status of resurrected test that is crashing dart2js.
Change-Id: I30bb15c3e1e21df7173cf0d8481db011db41fc6a
Reviewed-on: https://dart-review.googlesource.com/13301
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-11 21:00:36 +00:00
Jennifer Messerly 8c36b4685f fix #31049, fix #31050, avoid name collision for static members
Change-Id: I5a14315b99ace15aa6ac0c67f753bc3e1f39b3a9
Reviewed-on: https://dart-review.googlesource.com/12481
Commit-Queue: Jennifer Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2017-10-11 21:00:02 +00:00
Zachary Anderson 346e1edf7e [dart:io] Rename IoOverrides -> IOOverrides
fixes #31063

Change-Id: Ib49ae77903805a5c027ab870898954bb43901fda
Reviewed-on: https://dart-review.googlesource.com/13120
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2017-10-11 20:31:00 +00:00