Commit Graph

1361 Commits

Author SHA1 Message Date
nweiz@google.com c8de060c54 Revert "Revert "Use native async/await support in pub.""
The VM now fully supports all the weird async stuff pub is doing, and all the
tests pass with native async/await!

Previous CLs were r43484 and r43483.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//937243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43897 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:28:54 +00:00
rmacnak@google.com 3858e8fc50 Classify mirror tests skipped on the VM.
R=kevmoo@google.com

Review URL: https://codereview.chromium.org//938603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43862 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 01:14:19 +00:00
rmacnak@google.com 4abf50c04d Add LibraryDependencyMirror.isDeferred.
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//921163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43829 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 23:49:40 +00:00
kevmoo@google.com 4cc4e28411 status files: trying out new SkipSlow flag
and selectively used SkipByDesign in more places

R=whesse@google.com

Review URL: https://codereview.chromium.org//928523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43815 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:21:39 +00:00
rmacnak@google.com 511c997316 Implement DeclarationMirror.location for all but ParameterMirrors.
- Mark NativeFieldWrapper classes as synthetic.
- Mark ClassID fields as synthetic.

BUG=http://dartbug.com/22378
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//922023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43784 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 23:32:20 +00:00
paulberry@google.com 4a5680aec8 Visit async and core library dependencies when computing library cycles.
Previously, we would create the Library objects for the core and async
libraries before calling _computeLibraryDependencies().  As a result,
_computeLibraryDependencies() would skip those libraries when
computing dependencies.  Normally this was not a problem, because the
dependencies surrounding the core and async libraries are so richly
intertwined that all of the necessary files got included in the cycle
anyhow.  However if the starting point of analysis was the
"dart:async" library, some files would be missed entirely, leading to
bogus warnings.

The solution is to let _computeLibraryDependencies() create all the
Library objects, even for the core and async libraries; this way it
won't skip any dependencies.

BUG=dartbug.com/22415
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//921213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43772 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 18:52:39 +00:00
karlklose@google.com 308b2c4a68 Mark test as failing.
R=sigurdm@google.com
BUG= http://dartbug.com/22415

Review URL: https://codereview.chromium.org//924783004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43761 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 14:58:09 +00:00
lrn@google.com 34cc8411a3 Fix behavior when listening multiple times to a broadcast take/skip stream.
Turns out the existing behavior was badly broken.
A broadcastStream.take(10) would only produce ten events total, no matter how
many listeners were attached, beacuse the counter was on the stream, not the
subscription.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//920373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43755 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 13:59:41 +00:00
koda@google.com 8c24d57e15 Update test status for slow ASAN bot.
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//916473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43664 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:58:35 +00:00
kustermann@google.com a9962948d6 Mark async/timer_isActive_test as flaky on dartium
R=ricow@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//898183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43648 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 14:36:05 +00:00
rmacnak@google.com 63bba8d603 Blacklist Process.killPid in invocation_fuzzer_test.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//884133005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43491 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 23:50:58 +00:00
nweiz@google.com bbe0d9325c Revert "Use native async/await support in pub."
This caused SDK compilation issues that may have obscured pub test failures as
well.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//887223007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43484 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:15:44 +00:00
nweiz@google.com 1835c63d0a Use native async/await support in pub.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//896623005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43483 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 20:45:49 +00:00
sigurdm@google.com a636a3c5a2 Change timer delay to 0 to make jsshell happy.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//903433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43464 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 12:11:40 +00:00
sigurdm@google.com 0187b8144a Avoid crashing when a closed StreamIterator is cancelled
BUG=
R=floitsch@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//896793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43460 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 11:23:27 +00:00
sra@google.com 452d90acdd Mark mirrors/mirrors_reader_test as Crash on jsshell
Dies on the bots with 10GB heap

TBR=ricow@google.com

Review URL: https://codereview.chromium.org//866253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43089 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 23:27:09 +00:00
nweiz@google.com b8d1c3a8b7 Regenerate pub's sources and remove workarounds for fixed issues.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//868463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43057 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 01:07:38 +00:00
rmacnak@google.com 2fb0bb020b Reapply "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list."
Broken assumption in Dartium fixed in blink r188698.

R=hausner@google.com

Review URL: https://codereview.chromium.org//862093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43053 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 20:44:04 +00:00
rmacnak@google.com ed88ac7f0c Revert "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list."
Broke Dartium.

TBR=hausner@google.com

Review URL: https://codereview.chromium.org//863773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43026 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 20:56:59 +00:00
rmacnak@google.com 045bd762d7 Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list.
An invisible function is hidden from stack traces, will not be enumerated
by mirrors, and cannot be directly invoked by mirrors. Note that private
classes remain accessible.

Fix a few internal dart:io functions that should be private.

Fix bug where mirrors would enumerate top-level invisible functions.

Mark observatory test that was using such private functions through
mirrors as failing.

BUG=http://dartbug.com/15274
R=hausner@google.com

Review URL: https://codereview.chromium.org//816353012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43019 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 18:32:19 +00:00
sigurdm@google.com b9c1798175 Improve mirror_in_static_init_test
Make it a multitest.
Fix a syntax error.
Also move it to lib/mirrors/ - it will then automatically be skipped by
dart2dart.

BUG=dartbug.com/22071
R=floitsch@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//813503005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42992 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-19 14:52:25 +00:00
whesse@google.com 247ff772d6 Update status files, replace "dartbug.com" with "Issue ".
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//845793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42900 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 10:27:11 +00:00
nweiz@google.com c951660859 Don't analyze pub's command_runner library.
This works around https://github.com/dart-lang/async_await/issues/77.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//849053008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42893 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 01:28:02 +00:00
whesse@google.com a0c609991c Update co19 status.
BUG=

Review URL: https://codereview.chromium.org//840073003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42811 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 15:35:06 +00:00
whesse@google.com ca69477f4e Update co19 status and timing-out tests.
BUG=dartbug.com/22050
R=ricow@google.com

Review URL: https://codereview.chromium.org//851683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42803 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 12:24:30 +00:00
asiva@google.com ca1c3241c4 Fix for issue 21398.
Accept only 'literal-like' objects when sending messages to isolates
spawned using spawnURI. Allow all objects for isolates spawned using
spawnFunction.

R=iposva@google.com

Review URL: https://codereview.chromium.org//834233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42793 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 23:14:30 +00:00
whesse@google.com 1a92824c85 Update co19 status on firefox and chrome.
Update status for two timing out tests, and co19 on Android.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//825353007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42782 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 17:51:08 +00:00
regis@google.com 03fa3d1ff4 Mark mutator methods of canonical constants as invisible to reflective access.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//810593008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42747 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 18:03:31 +00:00
lrn@google.com 3a66c29a6d Add cleanUp function to Future.wait.
The cleanUp function is called on the values of successful futures,
so it can release any resources that were successfully allocated.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//815773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42730 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 10:52:15 +00:00
iposva@google.com 2104fd6165 Fix http://dartbug.com/21834
- Ensure that microtasks fire after every timer event, instead
  of being bunched together once all pending timers fired.
- Do not wait for timer message to be delivered. Trigger timers
  as soon as they are ready from within the message handling
  loop.
- Notify timers in the order of wakeup time regardless of
  specified timeout value. (AKA Do not allow Timer.run to
  overtake new Timer() scheduled operations.)

R=zra@google.com

Review URL: https://codereview.chromium.org//825403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42673 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 22:21:59 +00:00
regis@google.com cc843c2189 Process two 32-bit digits as one 64-bit digit in all bigint intrinsics on x64.
R=zra@google.com

Review URL: https://codereview.chromium.org//786933009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42607 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 19:44:02 +00:00
koda@google.com 56defa8060 Write-barrier verification on ARM.
Add and use methods on Assembler for writing and verifying object fields.
Enable tests in verified_mem mode for simarm.
Also generalize and use InitializeFieldsNoBarrierUnrolled in one more place.

R=iposva@google.com

Review URL: https://codereview.chromium.org//730343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42208 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 16:15:33 +00:00
regis@google.com e20569cf8b Reenable a few previously slow tests on MIPS.
R=zra@google.com

Review URL: https://codereview.chromium.org//781123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42141 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 19:32:39 +00:00
rmacnak@google.com 9bdff93aa9 Re-blacklist SystemEncoding: still failing on Windows.
BUG=http://dartbug.com/15274
TBR=regis@google.com

Review URL: https://codereview.chromium.org//775993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42095 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 00:09:42 +00:00
rmacnak@google.com dd3c1fa32e Remove several entries from invocation fuzzer blacklist.
Add event loop, isolate startup, and symbol helper functions to the invisible list.

Include doubles as a target.

BUG=http://dartbug.com/15274
BUG=http://dartbug.com/20583
BUG=http://dartbug.com/21707
R=regis@google.com

Review URL: https://codereview.chromium.org//775223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42092 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 22:08:32 +00:00
fschneider@google.com a49870e721 VM: Remove use of IterableMixinWorkaround from _List, _ImmutableList and _GrowableList.
_List, _ImmutableList and _GrowableList now extend ListBase which uses ListMixin.

Note that typed data lists are still using IterableMixinWorkaround for now.
They will be changed in a separate CL since it involves a few more changes
to the VM.

BUG=dartbug.com/13647
R=lrn@google.com

Review URL: https://codereview.chromium.org//730543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42061 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-02 10:38:51 +00:00
rmacnak@google.com 5aff08b9ef Skip more of event loop dispatch in invocation fuzzer to avoid triggering runtime errors we cannot catch.
BUG=http://dartbug.com/21473
R=regis@google.com

Review URL: https://codereview.chromium.org//753323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42054 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:56:31 +00:00
whesse@google.com 0cda682b96 Update status for html and lib tests.
BUG=dartbug.com/21710
R=ricow@google.com

Review URL: https://codereview.chromium.org//754403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41954 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 14:41:42 +00:00
ricow@google.com 9fe428f545 Fix suppression reorg from revision 41945.
I did not take the multitest selector into account

Review URL: https://codereview.chromium.org//756923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41947 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 08:46:11 +00:00
ricow@google.com 1c6f7eeeca Supress flaky test, lib/mirrors/invocation_fuzz_test/string, on mac debug
Additionally, simplify existing supression on javascript command line engines.

Filed issue 21707 to track the flaky test

Review URL: https://codereview.chromium.org//747363004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41945 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 07:59:06 +00:00
whesse@google.com 12845acbf3 Revert "Add android device id to test output in test scripts."
This reverts r41933

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//758563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41934 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 17:53:30 +00:00
whesse@google.com d91010512a Add android device id to test output in test scripts.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//752173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41933 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 17:40:13 +00:00
lrn@google.com ad532b79e0 Make Utf8Decoder and Utf8Encoder's convert methods take start and end too.
BUG= http://dartbug.com/21652
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//736583008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41844 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 11:23:51 +00:00
koda@google.com 7001650c96 Test status: verification tests on ia32, x64 only.
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//720323007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41810 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 18:59:58 +00:00
koda@google.com fde4d2882c Add missing verified write on x64; extend test coverage
On x64, StoreInstanceField and StoreIndexed sometimes used Assembler::StoreObject to store constants directly into heap objects. This method is unaware of the write barrier. Fix this by adding a write-barrier-aware method, like we already have on ia32.

Generally, we should consider distinguishing more clearly between stack stores and heap stores, for instance by adding HeapAddress/StackAddress types.

R=iposva@google.com

Review URL: https://codereview.chromium.org//738453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41808 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 16:35:59 +00:00
whesse@google.com c61eb1fdb9 Update test status for analyzer error in DOM bindings code.
BUG=dartbug.com/21647
R=ricow@google.com

Review URL: https://codereview.chromium.org//733373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41799 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 12:52:30 +00:00
rmacnak@google.com 77adbe5bca Remove/skip invalid mirror tests.
-class of 1 is not required to declare int as an interface
-owner of members of mixin applications is the mixin
-MirrorsUsed does not have a semantics

R=gbracha@google.com

Review URL: https://codereview.chromium.org//706793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41540 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 01:10:33 +00:00
johnniwinther@google.com 09fbe78e71 Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
BUG=

Review URL: https://codereview.chromium.org//694353007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41514 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:51:01 +00:00
johnniwinther@google.com 8637cfd322 Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler"
This reverts commit r41512.

BUG=

Review URL: https://codereview.chromium.org//693183006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41513 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 08:15:26 +00:00
johnniwinther@google.com 2b336e17f0 Move dart2js from sdk/lib/_internal/compiler to pkg/compiler
BUG=

Review URL: https://codereview.chromium.org//690103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41512 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 07:09:04 +00:00