ec00a4ace6
Make test compatible with dart2js integer semantics.
...
R=vegorov@google.com
Review URL: https://codereview.chromium.org//946203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43941 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-22 05:57:35 +00:00
574028165f
Ensure hash pattern is non-zero. Re-enable compact hash map/set.
...
BUG=dart:22520
TBR=vegorov@google.com
Review URL: https://codereview.chromium.org//946893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43940 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-22 03:04:35 +00:00
be05129a8c
Mark async_rethrow_test as failing on Dartium as well.
...
TBR=hausner@google.com
Review URL: https://codereview.chromium.org//943093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43939 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-21 01:00:30 +00:00
2a74e16a4f
Update status for no longer crashing test.
...
This issue is made obsolete by r43927.
(Still, I'd still like to figure out why our assumption about the stack was violated.)
TBR=johnmccutchan@google.com
BUG=dart:22488
Review URL: https://codereview.chromium.org//948593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43938 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-21 00:37:05 +00:00
56867c3af2
Rationalize service method handler names
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//945163003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43937 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-21 00:33:48 +00:00
acec842aee
Add 'Convert Method to Getter' proposal only if it is an available refactoring.
...
So, that we don't show it for method with parameter or returning null.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//945113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 23:18:21 +00:00
093da297dc
Added a test for issue 22523.
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//950463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43935 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:55:23 +00:00
f2ccdbd73d
Minor changes in analyzer to make it easier to extend
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//924943010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43934 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:23:27 +00:00
4da5931086
Fix for filtering unknown options.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//944073003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43933 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:12:03 +00:00
946d56198e
Fix for searching constructor references.
...
Currently we record constructor declarations and SearchEngine returns them as "references".
But it is not quite a reference, and it is used only as a way to get name range.
With this change to ConstructorElement we don't need to have these artificial references.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//946023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43932 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:10:30 +00:00
0348d0decd
Issue 22288. Rename named parameters in hierarchy.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22288
Review URL: https://codereview.chromium.org//945693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43931 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:08:18 +00:00
ddb56280a2
Added a test for issue 12474.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//943503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43929 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 21:09:43 +00:00
c1008f15c0
Save top StackResource in entry frame.
...
This avoids relying on stack address order, which enables us to benefit from AddressSanitizer's detect_stack_use_after_return feature.
R=iposva@google.com
Review URL: https://codereview.chromium.org//944783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43927 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 20:46:31 +00:00
25f3f6733d
Remove heap settings from pub scripts for SDK too.
...
r43821 only does it for the scripts used to run pub from within the source repo.
Also add support to the Windows shell script for passing VM flags to pub similar to
what dart2js and the bash pub scripts allow.
BUG=https://code.google.com/p/dart/issues/detail?id=22461
R=ahe@google.com , nweiz@google.com
Review URL: https://codereview.chromium.org//943993005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43925 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 20:15:25 +00:00
01126e0213
Issue 22492. Increase number of event pumping cycles.
...
I'm not sure if it is going to fix the problem.
I cannot reproduce it with x86 release build on Win7.
But that's the best guess I have.
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22492
Review URL: https://codereview.chromium.org//944013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43922 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 18:35:06 +00:00
018ec1cb83
Temporarily disable compact hash map/set to see whether it fixes Dart2JS flaky faliures.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//942003004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43921 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 17:27:06 +00:00
bbc11c6640
Add ignore-unrecognized-flags as an option to the command line options of analysis server
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//940093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43920 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 17:19:53 +00:00
cef3704d8e
dart2js: don't emit big integers as integer, but instead use their exponential representation.
...
BUG= http://dartbug.com/16600
R=herhut@google.com
Review URL: https://codereview.chromium.org//944863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43913 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 14:29:46 +00:00
44bcb14217
Small fixes in preparation for SemanticVisitor.
...
BUG=http://dartbug.com/20377
R=karlklose@google.com
Review URL: https://codereview.chromium.org//938173004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43912 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 14:25:12 +00:00
429e0f049a
dart2js: add function type to the model.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//940053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43911 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 14:03:46 +00:00
cbde4578af
Fix Function.apply for static functions in new emitter.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//932523004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43910 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 12:47:06 +00:00
917f9cb813
Handle super calls to fields or getters that look like method calls.
...
These are of form:
class A {
get foo => {..}
}
class B extends A {
m() {
super.foo(1, 2, 3);
}
}
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//913213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43909 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 12:01:58 +00:00
be3c508ffd
Fix type propagation for and operator.
...
BUG= http://dartbug.com/22427
R=floitsch@google.com
Review URL: https://codereview.chromium.org//941293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43908 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 11:49:10 +00:00
78e30804e8
Make enum a keyword in dart2js.
...
BUG=http://dartbug.com/22478
R=floitsch@google.com
Review URL: https://codereview.chromium.org//944813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43906 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 10:54:48 +00:00
27a30ee1de
dart2js: Support isDeferred on DependencyMirrors.
...
BUG= http://dartbug.com/22475
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//924393003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43905 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 10:37:44 +00:00
87fd45d46e
Add explicit return value.
...
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//942773003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43904 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 10:27:43 +00:00
f1941c15ca
dart2js: Remove unused function.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//933043008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43902 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 09:16:36 +00:00
5230b1a673
dart2js: only allocate one closure in 'setupClass' of the new emitter.
...
R=zarah@google.com
Review URL: https://codereview.chromium.org//939753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43901 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 09:10:14 +00:00
0deab36c67
dart2js: Don't show "--enable-concrete-type-inference" in help.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//940713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43900 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 09:07:32 +00:00
10d92dd4ab
Fix an analysis error in pub.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//942693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43899 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 00:42:40 +00:00
9dff378e6c
Work around race condition in MakeArray for ASSERTs and document assumptions.
...
BUG=dart:22501
Review URL: https://codereview.chromium.org//936393003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43898 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:55:50 +00:00
c8de060c54
Revert "Revert "Use native async/await support in pub.""
...
The VM now fully supports all the weird async stuff pub is doing, and all the
tests pass with native async/await!
Previous CLs were r43484 and r43483.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//937243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43897 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:28:54 +00:00
45acfc4524
fix code completion invocation on getter
...
BUG=dartbug.com/22376
R=scheglov@google.com
Review URL: https://codereview.chromium.org//929323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:14:52 +00:00
f062e0894f
Mitigate windows crash & failure by disabling merging of sin & cos.
...
Review URL: https://codereview.chromium.org//937193005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43895 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 21:58:23 +00:00
c6e3dd73c2
Default to compact Map/Set implementation.
...
Also adjust unit tests accoringly to maintain coverage, and remove some redundant ones.
R=iposva@google.com
Review URL: https://codereview.chromium.org//936613007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43894 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 21:28:56 +00:00
3750ba067f
Return version with connected notification
...
R=jwren@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//943723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:45:01 +00:00
b67d23747f
- Fix sin-cos merge, add a flag to turn it on/off. Using fsincos is much slower than calling out to runtime.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//939113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43891 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:19:16 +00:00
c845e7cd9a
Change equality comparison for FileBasedSource to use URI.
...
Previously, we considered two FileBasedSources to be equal if they
referred to the same file. As a result, if a given file was
accessible via multiple URI's, only one cache entry would be created
for the file and we would only resolve it once; the elements created
by resolution would be nondeterministic, they would refer to the file
via whatever source happened to be used to analyze it first. Worse
yet, incremental analysis might cause some of the elements in the file
to later be replaced by elements that would refer to the file via a
different source, resulting in confusing errors.
BUG=dartbug.com/22030
R=scheglov@google.com
Review URL: https://codereview.chromium.org//944493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43888 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 19:15:50 +00:00
2602413b00
Fix for dart2js codegen issue 22487
...
R=herhut@google.com
Review URL: https://codereview.chromium.org//932363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43887 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 19:04:41 +00:00
3caf1669dc
Fix indentation of parser trace (several threads may compile at once).
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//944463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43885 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 18:54:24 +00:00
a5ad3de7b0
- Mark failing dart2js test.
...
Review URL: https://codereview.chromium.org//939183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43883 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 17:13:52 +00:00
2442d5e047
VM: Fix a bug with local variable values when breaking at a variable declaration.
...
This fixes the case When breaking at a declaration 'var a;'
BUG=dartbug.com/22353
R=hausner@google.com
Review URL: https://codereview.chromium.org//936283005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43882 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 17:11:07 +00:00
6bb78fd867
- Mark flaky test.
...
Review URL: https://codereview.chromium.org//937113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43881 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 16:55:54 +00:00
7d1785e760
- Allow any implementation of StackTrace to participate in async/
...
await exception handling.
R=hausner@google.com
Review URL: https://codereview.chromium.org//940863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43880 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 16:17:19 +00:00
4e7ecb1103
Issue 22409. Restore recognizing string concatenation in const expressions.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22409
https://code.google.com/p/dart/issues/detail?id=21000
Review URL: https://codereview.chromium.org//940853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43879 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 15:35:54 +00:00
84ef02af67
Revert "Remove implicit dependencies."
...
This reverts r43874.
Revert "Register literals through backend."
This reverts r43876.
FAILED: dart2js-d8-checked release_ia32 utils/source_mirrors_test
out/ReleaseIA32/dart-sdk/lib/_internal/compiler/js_lib/preambles/d8.js:263: Uncaught Error: Invalid argument(s): "_Proxy" is a private identifier
Stack Trace:
Error
at dart.wrapException (/mnt/data/b/build/slave/dart2js-linux-release-checked-1-5-be/build/dart/out/ReleaseIA32/generated_compilations/dart2js-checked-sdk/tests_utils_source_mirrors_test/out.js:2990:15)
at dart.Symbol0.static.Symbol_validatePublicSymbol (/mnt/data/b/build/slave/dart2js-linux-release-checked-1-5-be/build/dart/out/ReleaseIA32/generated_compilations/dart2js-checked-sdk/tests_utils_source_mirrors_test/out.js:11047:19)
That is, attempting to create a symbol for _Proxy, which is something I did change.
Also, many dart2dart fails with errors like this:
Internal Error: Function signature has not been computed for function(Symbol#).
const factory Symbol(String name) = internal.Symbol;
^^^^^^
Also something that I changed.
Review URL: https://codereview.chromium.org//918893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43878 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 15:31:39 +00:00
d9f2ea18a9
Register literals through backend.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//935033005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43876 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:54:25 +00:00
e8b7f9cb06
Don't constant fold operation if result is incompatible with it.
...
For example we can't replace BinarySmiOp with Mint constant because we might have removed the checks based on the assumption that BinarySmiOp always returns a Smi.
BUG=http://dartbug.com/22480
R=fschneider@google.com
Review URL: https://codereview.chromium.org//938783003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43875 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:48:48 +00:00
b3f2d3be1f
Remove implicit dependencies.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//930143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43874 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:31:37 +00:00
fdfb53269d
Fix darttags' usage of source file provider.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//924393005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43873 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:26:02 +00:00
koda@google.com