dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
29,799 Commits 2 Branches 0 Tags
ec00a4ace68a58caf78b2e6c3b9e11693cfd7e68
Commit Graph

25 Commits

Author SHA1 Message Date
turnidge@google.com e65e6fab9d Begin migrating the vm service from a rest-style interface to a json-rpc style interface. 
BUG=

Review URL: https://codereview.chromium.org//823403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43370 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-02 23:15:40 +00:00
srdjan@google.com 154eb30f58 ONe more iteration of PcDesacriptor iterator imporvement: do not copy record but access individual values when needed. 
R=hausner@google.com

Review URL: https://codereview.chromium.org//403643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38408 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-18 20:11:29 +00:00
srdjan@google.com 1259bda234 Fix PcDescriptor iterator to never return a pointer to a memory location since the PcDescriptor can move with the GC. 
R=hausner@google.com

Review URL: https://codereview.chromium.org//396213005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38338 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-17 18:30:38 +00:00
mlippautz@google.com a97bafab93 vm/observatory: Clean up script access 
Addresses issues from https://codereview.chromium.org/346003003/

BUG=
R=hausner@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//392933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38264 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-15 22:55:19 +00:00
srdjan@google.com 9c8a395f6f More PcDescriptor cleanups, compress recors if no try index is needed (frequent). 
R=asiva@google.com

Review URL: https://codereview.chromium.org//382993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38242 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-15 17:07:03 +00:00
mlippautz@google.com e0d40e8d3b BUG= 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//376333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38165 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-11 18:39:09 +00:00
srdjan@google.com 4c69c06f27 Specify descriptor kind to iterate on. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//383523005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38128 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-10 19:44:49 +00:00
srdjan@google.com 2bb77cd8d5 Iterate over PcDescriptors only via iterators, not via an index. (preparation for more compression of PcDescriptors). 
R=asiva@google.com

Review URL: https://codereview.chromium.org//356923006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38032 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-07 18:25:45 +00:00
mlippautz@google.com f2db35a741 Coverage API supports proper filtering 
(Partly) addressing concerns of https://codereview.chromium.org/346003003/

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//351373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37793 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-27 17:51:52 +00:00
mlippautz@google.com 85ce6bffb9 Coverage data for single entities can be obtained by querying: 
* script: isolate/id/script/name/coverage
 * class: isolate/id/class/id/coverage
 * library: isolate/id/library/id/coverage

Some numbers (curl on vm service):
 * old base line (full coverage of dart:core + script computing faculty): ~1.2s
 * generation for just the script file: ~12ms
 * generation of dart:core (after executing fac script): ~150ms
 * generation of dart:core-patch/array.dart: ~12ms

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//346003003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37676 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-25 00:06:53 +00:00
mlippautz@google.com bcd02501f8 coverage: Improve generation, see below. 
* Ignore non-valid PC descriptors, i.e., descriptors where tokens are not
   within range of the actual function.
 * Merge line data where it would be consecutively emitted.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//356433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37662 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-24 16:41:36 +00:00
srdjan@google.com 58fd318f4c Cleanup: use a ZoneGrowableArray instead of Array for ICData map. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//333403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37400 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-17 15:52:05 +00:00
srdjan@google.com e3a00fa4e5 Add SetLength to GrowableArray and use it in code coverage. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//324203003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37215 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-10 23:43:54 +00:00
srdjan@google.com 112ab3aef2 Significantly improve performance of code coverage tool by precomputing a map token_pos->line number. 
R=asiva@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//324843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37203 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-10 21:37:52 +00:00
iposva@google.com b4b4889406 - Refined https://codereview.chromium.org/293963008/ 
Make compilation VM more fine grained

- Use the isolate where appropriate.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//294943008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36451 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-21 21:04:03 +00:00
turnidge@google.com 9243ffc4ff Always use the same json for null in the vm service. 
PrintToJSONStream -> PrintJSON.

ALSO:

Fix <em> tags in the Observatory.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//257053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35532 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-29 18:10:02 +00:00
johnmccutchan@google.com 6edd276df8 Switch Observatory to use only ServiceObject instances. 
All fetched objects are upgraded to a ServiceObject.
ServiceObjectCache.
Uniform updating / refreshing.
Fix UTF8 string escaping in TextBuffer (should fix invalid character bug https://code.google.com/p/dart/issues/detail?id=16590)

R=turnidge@google.com

Review URL: https://codereview.chromium.org//192443004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33541 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-11 17:48:09 +00:00
johnmccutchan@google.com a6399981e6 Code coverage in Observatory 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//143973005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31970 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-22 00:46:30 +00:00
iposva@google.com 3423572926 - Harden coverage generation, by not attempting to compile 
un-compilable functions.
- Only register closure functions in the class when they
  have been properly setup.
- Make sure to compile closure functions when calling CompileAll.

R=hausner@google.com

Review URL: https://codereview.chromium.org//25954003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28282 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-04 20:50:16 +00:00
iposva@google.com fbec69dca1 - Fix typos and add comments. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org//25790004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28180 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-02 20:52:15 +00:00
mlippautz@google.com 1941e151ea Improve code coverage generation. 
- Remove function name from output.
- Remove column from output (side effect: We can use fast version of
  GetTokenLocation())
- Insert HANDLESCOPES
- Fold source file entries where easily possible, i.e., fold consecutive entries
  created by functions in the same source file.
- Change format to

  [{
     "source": "...",
     "hits": [<line>,<hitcount>, ...]
   }, ... ]

BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//24654003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28030 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-27 23:22:49 +00:00
iposva@google.com 9b8358c505 - Fix C++11 string literal requirements. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//23464105

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27727 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-20 23:12:47 +00:00
iposva@google.com d0b681f354 - Write the coverage data to a file instead of printing to stdout. 
- Explicitly include lines with zero hits.

R=asiva@google.com, mlippautz@google.com

Review URL: https://codereview.chromium.org//24255013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27726 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-20 21:37:48 +00:00
iposva@google.com 52a736ee38 - Disallow copy constructors. 
Review URL: https://codereview.chromium.org//23903034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27346 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-10 17:47:55 +00:00
iposva@google.com 74b2a34d5b - Base JSON stream printing on stack objects. 
- Simplify creation of a JSONStream.

- Add experimental coverage output to the VM.

R=asiva@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//23875015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27344 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-10 17:21:59 +00:00