dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
29,799 Commits 2 Branches 0 Tags
ec00a4ace68a58caf78b2e6c3b9e11693cfd7e68
Commit Graph

1776 Commits

Author SHA1 Message Date
sgjesse@google.com 0518874077 Add error handling when initializing the file system watcher 
R=kustermann@google.com, wibling@google.com
BUG=

Review URL: https://codereview.chromium.org//939643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43838 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-18 13:20:15 +00:00
johnmccutchan@google.com 65bab52df5 Fix HTTP support in vm-service 
- Add back Message.fromUri constructor.
- Fix 'root' isolateId alias.
- FATAL on missing source files when starting up the service isolate.

Review URL: https://codereview.chromium.org//922163005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43814 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-17 16:36:36 +00:00
zra@google.com b1c08457f6 Allows gen_snapshot to be built with asan in the Mojo tree. 
R=koda@google.com

Review URL: https://codereview.chromium.org//922863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43764 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-13 15:37:03 +00:00
johnmccutchan@google.com 9b1f39bf58 Initialize standalone embedder debugger before calling Dart_Initialize 
BUG=dartbug.com/22394
R=hausner@google.com

Review URL: https://codereview.chromium.org//914253006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43741 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 21:22:34 +00:00
sgjesse@google.com b40b0690c6 Fix Android build 
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//922693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43728 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 15:13:35 +00:00
kustermann@google.com e06874c751 Fix potential use-after-free bug in windows eventhandler 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//925443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43725 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 13:47:45 +00:00
sgjesse@google.com 3fe2af43d1 Reafctor to use 'const RawAddr&' or 'RawAddr*' in the eventhandler code 
Also pass the port as part of RawAddr instead of in a separate argument
when both addr and port are passed.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//910183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43722 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 11:39:20 +00:00
kustermann@google.com be70a52106 Reorder includes and remove platform/globals include 
TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org//915083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43693 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-11 17:24:37 +00:00
kustermann@google.com dbd56a9b5c Add unittest for CircularLinkedList + bugfix 
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//914203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43691 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-11 16:20:18 +00:00
kustermann@google.com 70ca358a33 Send destroy events for each closed listening socket instead of waiting for all listening sockets to be done 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//914103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43680 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-11 11:34:47 +00:00
kustermann@google.com 615d1a01ac Reland "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..." 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//913753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43678 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-11 10:01:20 +00:00
kustermann@google.com 700bea9f78 Parenthesize expression using bit-wise and on windows 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//895533006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43640 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 12:17:54 +00:00
sgjesse@google.com 7b7ac3620a Add support to specify the source address for socket connect 
BUG=http://dartbug.com/22253
R=kustermann@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//908873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43638 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 11:56:51 +00:00
kustermann@google.com f0e8ff5381 Fix mac build: Add new disable_tokens=false value to super constructor call 
Review URL: https://codereview.chromium.org//899593004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43634 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 10:34:35 +00:00
kustermann@google.com 1c7ef3c4f2 Implement mac support for having multiple Dart_Port's registered on one OS socket 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//908183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43632 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 10:15:33 +00:00
kustermann@google.com 74c0f65c89 Implement windows support for having multiple Dart_Port's registered on one OS socket 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//910863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43631 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 10:08:49 +00:00
sgjesse@google.com 91e7a32eb5 Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec 
The methods SetNonBlocking/SetBlocking on Sockets where not implemented on Linux
and not used on Windwsm. Removed and call directly to FDUtils when needed.

In Socket::Accept setting close on exec was missing on OS X and Android.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//907883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43627 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 07:29:36 +00:00
kustermann@google.com ebde0dbaeb Extract common Mask/Dart_Port settings of linux event handler implementation to eventhandler.h 
R=sgjesse@google.com, wibling@google.com

Review URL: https://codereview.chromium.org//905733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43585 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 08:50:32 +00:00
johnmccutchan@google.com 7cfc0d2e78 Fix checked mode failure in _asyncLoadError 
Fixes dartbug.com/22295

Review URL: https://codereview.chromium.org//877763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43554 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 14:39:08 +00:00
kustermann@google.com 3ea331e741 Introduce a kSetEventMaskCommand, some cleanups in windows eventhandler 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//900363004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43547 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 09:36:57 +00:00
kustermann@google.com a7f50cd5d2 Move CircularLinkedList to eventhandler.h 
Move constants and InterruptMessage to eventhandler.h

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43524 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 21:45:47 +00:00
turnidge@google.com d554f4fbfe Finish moving service protocol to json rpc. 
Service

- Remove support for old-style service requests.

- Drop 'arguments' from JsonStream and ServiceRequestHandler.

- Json-rpc inspired renaming: command->method, options->params all over.

- Implement getFlagList, setFlag, getObjectByAddress.

- Add helpers PrintMissingParamError and PrintInvalidParamError
  to make our error messages more regular.

- Update tests.

- Service_SetSource removed for now.  John will resurrect.

Observatory

- Drop all Deprecated 'get' functions.  We now use json rpc for everything.

- Drop 'link' and 'relativeLink' from ServiceObject -- they were
  ui-specific and they are no longer meaningful anyways.  Use 'id' instead.

- New pages: VMPage, FlagsPage, InspectPage, ErrorPage.  All urls
  used by Observatory are now 'new school' and have a proper
  prefix.  ErrorPage is the new catch-all.

- Pages now use a Uri instead of a url String.  This lets them
  grab query parameters more easily.

- SimplePage replaces IsolateSuffixPage.

- We now use gotoLink() or makeLink() to make our navigation
  links.  gotoLink gets some optional parameters to make it
  easier to construct links to ServiceObjects.

- Rework mouse clicks on the heap map to use getObjectByAddress.

- Remove the breakpoint_list.  It wasn't working.  I'll add it back later.

- Silence logging of getIsolateMetric/getVMMetric.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//897193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43514 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 17:45:52 +00:00
iposva@google.com c859d25679 - Return exit code 253 in case of API errors during loading. This 
will trigger for example when loading outdated snapshots.

R=ricow@google.com

Review URL: https://codereview.chromium.org//899523005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43505 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 14:30:24 +00:00
kustermann@google.com cae03aaf1a Wait for eventhandler to shut down before exiting 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//875403006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43504 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 13:16:07 +00:00
johnmccutchan@google.com 9c89a1bdc8 Synchronize gen_snapshot sources in bin/BUILD.gn with bin.gypi 
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org//901053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43490 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 22:33:12 +00:00
rmacnak@google.com cc2e1e4bd1 Make _FileSystemWatcher.watch private. 
It doesn't verify the path is a string before running native code, so when invoked via mirrors it will hit an uncatchable API error instead of a Dart exception.

R=asiva@google.com

Review URL: https://codereview.chromium.org//897703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43487 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 21:39:38 +00:00
kustermann@google.com 1d6231bacd Revert "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..." 
Review URL: https://codereview.chromium.org//896213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43476 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 16:00:21 +00:00
kustermann@google.com 3c6c29fee9 Introduce optional 'bool shared' parameter to ServerSocket.bind() ... 
R=sgjesse@google.com, wibling@google.com

Review URL: https://codereview.chromium.org//879353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43467 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 13:41:41 +00:00
sgjesse@google.com 6ba8c7bd7f Fix another type bug in r43455 
TBR=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//899823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43459 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 10:13:11 +00:00
sgjesse@google.com a99617c254 Fix type bug in r43455 
TBR=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//901523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43456 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 08:45:23 +00:00
sgjesse@google.com 833e5d9aee Add support for killing a process with a given PID to dart:io 
R=lrn@google.com, kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//895623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43455 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 08:20:33 +00:00
johnmccutchan@google.com 9d1bb3aa6b Port type arguments to new RPC protocol 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//887413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43428 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-03 21:26:19 +00:00
sgjesse@google.com 9aa4805e21 Add an option for starting a detached process with stdio connected 
R=lrn@google.com, kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//890633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43393 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-03 13:38:38 +00:00
turnidge@google.com e65e6fab9d Begin migrating the vm service from a rest-style interface to a json-rpc style interface. 
BUG=

Review URL: https://codereview.chromium.org//823403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43370 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-02 23:15:40 +00:00
johnmccutchan@google.com 409a4527b3 Set LibraryTagHandler before attempting to load builtin libraries 
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//891533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43317 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 22:09:55 +00:00
johnmccutchan@google.com 19719a1442 Add missing library dependencies for Windows 
As seen here:
http://build.chromium.org/p/client.dart/builders/dartium-win-full-be/builds/2781/steps/compile/logs/stdio

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//890743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43313 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 20:54:04 +00:00
johnmccutchan@google.com 13f05cdb87 Fix build breaking typo on MacOS 
BUG=

Review URL: https://codereview.chromium.org//884463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43308 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 18:39:36 +00:00
johnmccutchan@google.com 172baa03ff Service isolate rework take 2 
Review URL: https://codereview.chromium.org//889443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43306 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 18:31:27 +00:00
sgjesse@google.com 042462d69b Refactor the process creation code on POSIX platforms 
This moved the process creation code to a class, and splits the
single function used before into several methods operation on instance
variables.

The refactor revealed at least one leaked file descriptor.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//884143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43280 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 13:06:40 +00:00
sgjesse@google.com f1b1e4a8db Aling process implementation and fix bugs 
Aling the code for dart:io process as much as possible between Linux,
Mac OS and Android prior to refactiring the code.

On Mac OS file descriptors where not closed corrently. On Linux EINTR
was not expected for all calls.

R=kustermann@google.com, kunstemann@google.com
BUG=

Review URL: https://codereview.chromium.org//882093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43274 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 11:54:54 +00:00
iposva@google.com ad008bf8ba - Move timer implementation closer to the rest of message handling. 
R=zra@google.com

Review URL: https://codereview.chromium.org//878323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43225 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 00:39:35 +00:00
johnmccutchan@google.com db271b0477 Revert r43217, r43215, r43208, r43207, and r43202. 
Reverting because of some isolate spawn issues (on Windows, and pub bots).

Review URL: https://codereview.chromium.org//867113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43219 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 22:56:18 +00:00
johnmccutchan@google.com 2e17119ebe Don't include platform_sources in libvmservice_io 
Fixes link error on Dartium Android:

/b/build/slave/dartium-android-release-be/build/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.8/../../../../arm-linux-androideabi/bin/ld.gold: error: obj/dart/runtime/libdart_vm.a(obj/dart/runtime/platform/libdart_vm.assert.o): multiple definition of 'dart::DynamicAssertionHelper::Fail(char const*, ...)'
/b/build/slave/dartium-android-release-be/build/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.8/../../../../arm-linux-androideabi/bin/ld.gold: obj/dart/runtime/libvmservice_io.a(obj/dart/runtime/platform/libvmservice_io.assert.o): previous definition here

Review URL: https://codereview.chromium.org//879083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43217 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 22:31:20 +00:00
johnmccutchan@google.com dde8645f9d Use MacOS helper to get address of environ variable 
BUG=

Review URL: https://codereview.chromium.org//866043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43215 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 22:18:47 +00:00
johnmccutchan@google.com 900e4e5bd0 Fix ARM cross compile 
BUG=

Review URL: https://codereview.chromium.org//883893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43208 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 21:27:02 +00:00
johnmccutchan@google.com 6909a377ef Fix Windows build 
BUG=

Review URL: https://codereview.chromium.org//885433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43207 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 21:08:51 +00:00
johnmccutchan@google.com 66aa470fc6 * Create vm-service isolate at Dart_Initialize time. 
* Remove Service create callback.
* Simplify creation of service isolate.
* Creation is done on thread pool.
* Use vm-service isolate for loading in standalone embedder.
* Remove import of dart:io from builtin library.

performance changes:

no service isolate:

$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:27 | 100% | +12363 | -    0]

$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:27 | 100% | +12363 | -    0]

always start service isolate (as a thread pool task):

$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:45 | 100% | +12363 | -    0]

$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:44 | 100% | +12363 | -    0]

service does I/O (calls to Dart_LoadScript block until service is running):

$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:55 | 100% | +12363 | -    0]

$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:55 | 100% | +12363 | -    0]

R=asiva@google.com

Review URL: https://codereview.chromium.org//584023004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43202 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 19:45:48 +00:00
sgjesse@google.com 417ee299b3 Port the support for starting a detached process to Android. 
This is the Android part of r43070.

TBR=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//864293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43072 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-22 13:16:07 +00:00
sgjesse@google.com f6a10fbdf1 Add support for starting a detached process 
BUG=http://dartbug.com/20970
R=kustermann@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//798743004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43070 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-22 11:49:39 +00:00
ricow@google.com 5160c6564b Fix mac build, missing ; 
TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org//870523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43069 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-22 11:33:47 +00:00