dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
29,799 Commits 2 Branches 0 Tags
ec00a4ace68a58caf78b2e6c3b9e11693cfd7e68
Commit Graph

240 Commits

Author SHA1 Message Date
scheglov@google.com acec842aee Add 'Convert Method to Getter' proposal only if it is an available refactoring. 
So, that we don't show it for method with parameter or returning null.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//945113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 23:18:21 +00:00
scheglov@google.com 946d56198e Fix for searching constructor references. 
Currently we record constructor declarations and SearchEngine returns them as "references".
But it is not quite a reference, and it is used only as a way to get name range.

With this change to ConstructorElement we don't need to have these artificial references.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//946023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43932 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 22:10:30 +00:00
scheglov@google.com 0348d0decd Issue 22288. Rename named parameters in hierarchy. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22288

Review URL: https://codereview.chromium.org//945693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43931 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 22:08:18 +00:00
danrubel@google.com 45acfc4524 fix code completion invocation on getter 
BUG=dartbug.com/22376
R=scheglov@google.com

Review URL: https://codereview.chromium.org//929323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-19 22:14:52 +00:00
scheglov@google.com 1e120443b5 Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body. 
R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21879

Review URL: https://codereview.chromium.org//935123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43857 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-18 23:17:10 +00:00
scheglov@google.com 55a3255070 Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests. 
Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//923103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43819 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-17 20:01:45 +00:00
danrubel@google.com a56ac2f521 update code completion suggestion relevance based on common usage 
BUG=
R=lukechurch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//925723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43792 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-15 21:17:48 +00:00
scheglov@google.com ef1e368409 Improve code generation for 'bottom' and 'dynamic' arguments. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//924783005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43780 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-13 21:02:34 +00:00
scheglov@google.com 0b922f3d22 Quick Fix for an undefined class in is/as expressions. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//913923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43675 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-11 01:31:53 +00:00
paulberry@google.com acaed71dba Clean up analyzer and analysis server hints. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43667 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 20:40:26 +00:00
scheglov@google.com ff4e2bfce1 Issue 22188. Verify that none or all execution flows return. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188

Review URL: https://codereview.chromium.org//871013012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43663 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 19:14:01 +00:00
scheglov@google.com 07d2c82919 Issue 22316. Don't propose to create invalid local variable. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22316

Review URL: https://codereview.chromium.org//895773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43600 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 16:45:43 +00:00
danrubel@google.com 5194a2b1b4 filter static methods when showing instance completions 
BUG=dartbug.com/22171
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43580 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-07 00:56:15 +00:00
scheglov@google.com 8cee600323 Don't propose fixes to update SDK sources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//902273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43574 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:21:48 +00:00
scheglov@google.com 8d35890475 Convert refactoring tests to use 'await'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43573 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:13:37 +00:00
scheglov@google.com 2593c00b36 Quick Fix for adding 'async' to fix invalid 'await'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//894373005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43571 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 21:10:11 +00:00
danrubel@google.com f43912dfce fix code completion in string literals 
BUG=dartbug.com/22297
R=scheglov@google.com

Review URL: https://codereview.chromium.org//907453005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43567 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 20:07:29 +00:00
scheglov@google.com bd8778a87b Quick Assist to add explicit types to formal parameters. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43566 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 20:03:39 +00:00
danrubel@google.com 20b64a97a4 fix completion in for statement 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//862803008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43541 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:58:11 +00:00
danrubel@google.com 84350e186c fix named param default value code completion 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//897483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43540 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:50:57 +00:00
danrubel@google.com dc95fd3689 use propogated type for completions 
BUG=dartbug.com/21457
R=scheglov@google.com

Review URL: https://codereview.chromium.org//902983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43539 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:43:15 +00:00
danrubel@google.com fa0dc53f6f fix code completion in conditional expressions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//904653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43538 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:33:07 +00:00
scheglov@google.com 81ebd5fd77 Fix for extracting local variable in if-else-if statements. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//879463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43528 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 22:36:56 +00:00
danrubel@google.com e5a34c3c12 fix completions in indexed expression 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//902913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43523 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 21:42:43 +00:00
danrubel@google.com 2425d0c57c const rename and cleanup 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//904603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43520 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 19:50:42 +00:00
danrubel@google.com 8233434126 move relevance computation from client to server 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//901253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43519 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 19:36:19 +00:00
danrubel@google.com dbd0fa9d68 fix exception and improve keyword completion 
BUG=dartbug.com/22231
R=scheglov@google.com

Review URL: https://codereview.chromium.org//897833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43466 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 13:18:42 +00:00
danrubel@google.com ef89b4c21a tests for earlier CL 
BUG=dartbug.com/21768
R=paulberry@google.com

Review URL: https://codereview.chromium.org//882273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43295 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 16:50:24 +00:00
brianwilkerson@google.com cb6c16922f Fix for issue 22052 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//881403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 16:01:58 +00:00
danrubel@google.com 4229cb1c6f use CompletionTarget for replacement offset/length 
add code completion replacementLength and replacementOffset assertions

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//886463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43255 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 20:11:10 +00:00
scheglov@google.com 36ce6423a6 Fix for two semantic highlighting problems. 
1. We need to dispose the existing semantic highlighting manager before setting a new input.
   So, we would not apply old highlighting to the new file.

2. We need to clear "input" fields to correctly determine full file path.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//882203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43254 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 19:55:25 +00:00
scheglov@google.com c5af5132fc Issue 22191. Grab the document lock before positionsLock to prevent deadlock. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22191

Review URL: https://codereview.chromium.org//885653005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43251 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 18:33:16 +00:00
paulberry@google.com ea333d8459 Fix mixin resolution order when multiple mixins present. 
BUG=dartbug.com/22069
R=scheglov@google.com

Review URL: https://codereview.chromium.org//879093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43224 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 23:41:21 +00:00
scheglov@google.com a016a7b56e Fix for 'Convert Method to Getter' when multiple files are changed. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//881943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43221 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 23:12:23 +00:00
pquitslund@google.com b9f355d2a4 Library dependencies server API updates (to pass package maps). 
R=brianwilkerson@google.com, jwren@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//874373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 17:23:09 +00:00
scheglov@google.com a9bc5e512d Issue 22150. Quick fix to add a getter, in addition to create a field. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22150

Review URL: https://codereview.chromium.org//875193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43155 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-26 22:29:37 +00:00
scheglov@google.com 2b8c66ea79 Rename ChangeNotice resolved Dart/Html unit fields. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//881463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-26 19:58:19 +00:00
scheglov@google.com f32f6699bf Fix for file:// package: references to the same element. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//877693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43143 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-26 19:30:45 +00:00
pquitslund@google.com 26d43c80fc Library dependency service tests. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//868873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43142 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-26 18:28:12 +00:00
paulberry@google.com 30f1b97888 Handle generic parameters correctly in invocation completions. 
When doing invocation completions, we need to walk the interface
types, not the classes, because the interface types record the actual
types of the generic parameters.  This required some rework because
the old technique used an element visitor, and interface types can't
be visited using an element visitor.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//829173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43040 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-21 15:16:50 +00:00
danrubel@google.com cbd16a7336 add local parameter info to completion suggestions 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//850003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42894 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 02:26:45 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 17:11:24 +00:00
danrubel@google.com 0974f8b1ea insert parameters when completing imported functions and inherited methods 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//811933007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42808 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 14:10:47 +00:00
paulberry@google.com cebcc398f6 Add support for completion of case labels. 
This change addresses completions like the following:

  switch (...) {
    foo: case 1:
      ...
    bar: case 2:
      continue ^;
    baz: case 3:
      ...
  }

Completion at the point marked "^" will show "foo", "bar", and "baz"
as possible completions.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//806473007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42799 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 03:11:46 +00:00
danrubel@google.com 14a97cafed suggest fields rather than synthetic getters 
and return dynamic returnType rather than null

BUG=dartbug.com/21679
R=paulberry@google.com

Review URL: https://codereview.chromium.org//791553007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42786 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 19:02:47 +00:00
paulberry@google.com 531c591460 Completion support for loop labels. 
Break and continue statements inside loops now have their targets
properly completed.  Continue statements inside switch statements will
be addressed in a future CL.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//812593008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42781 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 17:37:46 +00:00
scheglov@google.com 214a2380ca Fix for NPE in the index store. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//823223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42777 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 16:38:52 +00:00
danrubel@google.com 2005b07aea Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int 
This allows the sever to return a more graduated relevance
and facilitates moving client side prioritization over to the server.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//845553005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42735 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 15:30:59 +00:00
scheglov@google.com 05ac43c3ea Issue 22027. When parameters has function type alias type, use its name. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22027

Review URL: https://codereview.chromium.org//836413006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42720 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 22:10:36 +00:00
danrubel@google.com 46df250c5a suggest fields rather than synthetic getters 
BUG=dartbug.com/21679
R=paulberry@google.com

Review URL: https://codereview.chromium.org//838053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42712 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 19:35:52 +00:00