dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
29,799 Commits 2 Branches 0 Tags
ec00a4ace68a58caf78b2e6c3b9e11693cfd7e68
Commit Graph

701 Commits

Author SHA1 Message Date
scheglov@google.com acec842aee Add 'Convert Method to Getter' proposal only if it is an available refactoring. 
So, that we don't show it for method with parameter or returning null.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//945113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 23:18:21 +00:00
scheglov@google.com 946d56198e Fix for searching constructor references. 
Currently we record constructor declarations and SearchEngine returns them as "references".
But it is not quite a reference, and it is used only as a way to get name range.

With this change to ConstructorElement we don't need to have these artificial references.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//946023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43932 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 22:10:30 +00:00
scheglov@google.com 0348d0decd Issue 22288. Rename named parameters in hierarchy. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22288

Review URL: https://codereview.chromium.org//945693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43931 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 22:08:18 +00:00
scheglov@google.com 01126e0213 Issue 22492. Increase number of event pumping cycles. 
I'm not sure if it is going to fix the problem.
I cannot reproduce it with x86 release build on Win7.
But that's the best guess I have.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22492

Review URL: https://codereview.chromium.org//944013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43922 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 18:35:06 +00:00
danrubel@google.com 45acfc4524 fix code completion invocation on getter 
BUG=dartbug.com/22376
R=scheglov@google.com

Review URL: https://codereview.chromium.org//929323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-19 22:14:52 +00:00
brianwilkerson@google.com 3750ba067f Return version with connected notification 
R=jwren@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//943723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-19 20:45:01 +00:00
scheglov@google.com 7256562fcd Return RequestErrorCode.NO_INDEX_GENERATED if no index. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//939823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43866 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-19 05:07:06 +00:00
scheglov@google.com 1e120443b5 Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body. 
R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21879

Review URL: https://codereview.chromium.org//935123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43857 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-18 23:17:10 +00:00
scheglov@google.com 6a78250c64 Issue 22476. Outline for enums. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476

Review URL: https://codereview.chromium.org//934353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-18 21:37:27 +00:00
brianwilkerson@google.com 0e73ada9c2 Use package: URIs for files in lib 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//914373004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43827 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-17 22:47:34 +00:00
scheglov@google.com 55a3255070 Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests. 
Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//923103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43819 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-17 20:01:45 +00:00
jwren@google.com a46fc6016d Addition of the --no-index flag to the analysis server spec. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//932883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43816 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-17 17:55:00 +00:00
danrubel@google.com a56ac2f521 update code completion suggestion relevance based on common usage 
BUG=
R=lukechurch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//925723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43792 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-15 21:17:48 +00:00
scheglov@google.com ef1e368409 Improve code generation for 'bottom' and 'dynamic' arguments. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//924783005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43780 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-13 21:02:34 +00:00
scheglov@google.com 865b217511 Issue 22381. Fix for navigating to constructor from redirecting factory constructor. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22381

Review URL: https://codereview.chromium.org//921833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43731 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 17:58:29 +00:00
danrubel@google.com c762e94a1c check for null completion node 
BUG=dartbug.com/22371
R=scheglov@google.com

Review URL: https://codereview.chromium.org//915023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43690 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-11 15:44:21 +00:00
scheglov@google.com 0b922f3d22 Quick Fix for an undefined class in is/as expressions. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//913923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43675 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-11 01:31:53 +00:00
paulberry@google.com acaed71dba Clean up analyzer and analysis server hints. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43667 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 20:40:26 +00:00
scheglov@google.com ff4e2bfce1 Issue 22188. Verify that none or all execution flows return. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188

Review URL: https://codereview.chromium.org//871013012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43663 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 19:14:01 +00:00
brianwilkerson@google.com 92e3e1b94a Fix notifications for nested packages 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//907183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43620 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 22:57:44 +00:00
scheglov@google.com 07d2c82919 Issue 22316. Don't propose to create invalid local variable. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22316

Review URL: https://codereview.chromium.org//895773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43600 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 16:45:43 +00:00
danrubel@google.com 5194a2b1b4 filter static methods when showing instance completions 
BUG=dartbug.com/22171
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43580 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-07 00:56:15 +00:00
scheglov@google.com 8cee600323 Don't propose fixes to update SDK sources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//902273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43574 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:21:48 +00:00
scheglov@google.com 8d35890475 Convert refactoring tests to use 'await'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43573 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:13:37 +00:00
scheglov@google.com 2593c00b36 Quick Fix for adding 'async' to fix invalid 'await'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//894373005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43571 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 21:10:11 +00:00
danrubel@google.com f43912dfce fix code completion in string literals 
BUG=dartbug.com/22297
R=scheglov@google.com

Review URL: https://codereview.chromium.org//907453005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43567 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 20:07:29 +00:00
scheglov@google.com bd8778a87b Quick Assist to add explicit types to formal parameters. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43566 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 20:03:39 +00:00
brianwilkerson@google.com f473ae15a3 Spec changes for issue 22254 
Review URL: https://codereview.chromium.org//882643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43565 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 19:35:40 +00:00
scheglov@google.com eac4b2e0a3 Discard pending notifications on the same source change. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//904093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43564 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 19:31:13 +00:00
scheglov@google.com 172b8bee6e Fix for the server version test. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//891473006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43561 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 19:11:28 +00:00
brianwilkerson@google.com 4468038300 Rework requests in execution domain 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//904733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43556 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 15:49:44 +00:00
danrubel@google.com 20b64a97a4 fix completion in for statement 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//862803008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43541 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:58:11 +00:00
danrubel@google.com 84350e186c fix named param default value code completion 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//897483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43540 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:50:57 +00:00
danrubel@google.com dc95fd3689 use propogated type for completions 
BUG=dartbug.com/21457
R=scheglov@google.com

Review URL: https://codereview.chromium.org//902983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43539 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:43:15 +00:00
danrubel@google.com fa0dc53f6f fix code completion in conditional expressions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//904653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43538 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:33:07 +00:00
brianwilkerson@google.com 95a9962be0 Use MemoryResourceProvider in server and execution domain tests 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//896423004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43530 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 22:46:41 +00:00
scheglov@google.com 81ebd5fd77 Fix for extracting local variable in if-else-if statements. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//879463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43528 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 22:36:56 +00:00
danrubel@google.com e5a34c3c12 fix completions in indexed expression 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//902913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43523 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 21:42:43 +00:00
scheglov@google.com ae2e608ff9 Send notificatinos after no-op changes. 
This should solve the problem when client remove some part of the code,
so removes also error markers for it, and then quickly restores it,
so for the server it looks as an empty/no-op change. But information is
lost, and the server should resend it to the client.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//899753004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43521 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 20:42:17 +00:00
danrubel@google.com 2425d0c57c const rename and cleanup 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//904603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43520 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 19:50:42 +00:00
danrubel@google.com 8233434126 move relevance computation from client to server 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//901253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43519 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 19:36:19 +00:00
brianwilkerson@google.com fcd7fdb93a Fix ambiguous description 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//901063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43493 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 01:31:09 +00:00
brianwilkerson@google.com 6ddc37a5cc Disable analysis in hidden directories (fix for issue 22170) 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//880313006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43485 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 21:27:43 +00:00
danrubel@google.com dbd0fa9d68 fix exception and improve keyword completion 
BUG=dartbug.com/22231
R=scheglov@google.com

Review URL: https://codereview.chromium.org//897833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43466 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 13:18:42 +00:00
scheglov@google.com 51842b06f2 Fix type hierarchy when there is no element. 
This one was caught by an integration test.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//892913004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43445 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-03 23:01:51 +00:00
scheglov@google.com 1a94fa3a6a Wait for analysis in search domain. Rewrite with async/await. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//894323003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43435 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-03 21:59:31 +00:00
scheglov@google.com 658d3e949e Check PackageMapUriResolver constructor arguments. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//887943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43405 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-03 16:06:25 +00:00
pquitslund@google.com ba6742f9fe Formatter service API tweaks. 
Some way to indicate no selection is required in the case where there is none.  I opted for the -1 convention not becuase I particularly like it but because, well, it's convention! :)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//894863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43369 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-02 23:14:22 +00:00
brianwilkerson@google.com 81c90c6492 Specify mapUri for directories 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//896513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43364 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-02 22:45:50 +00:00
paulberry@google.com b40a5702b3 Fix async/await type checking in analyzer. 
This required making the "async" library into TypeProvider so that we
can create Future<...> types when doing resolution and error/hint
checking.

BUG=21888,22053,22091,22092,22160,22164
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//898513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43361 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-02 20:58:37 +00:00