acec842aee
Add 'Convert Method to Getter' proposal only if it is an available refactoring.
...
So, that we don't show it for method with parameter or returning null.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//945113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 23:18:21 +00:00
f2ccdbd73d
Minor changes in analyzer to make it easier to extend
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//924943010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43934 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:23:27 +00:00
4da5931086
Fix for filtering unknown options.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//944073003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43933 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:12:03 +00:00
946d56198e
Fix for searching constructor references.
...
Currently we record constructor declarations and SearchEngine returns them as "references".
But it is not quite a reference, and it is used only as a way to get name range.
With this change to ConstructorElement we don't need to have these artificial references.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//946023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43932 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:10:30 +00:00
0348d0decd
Issue 22288. Rename named parameters in hierarchy.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22288
Review URL: https://codereview.chromium.org//945693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43931 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:08:18 +00:00
01126e0213
Issue 22492. Increase number of event pumping cycles.
...
I'm not sure if it is going to fix the problem.
I cannot reproduce it with x86 release build on Win7.
But that's the best guess I have.
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22492
Review URL: https://codereview.chromium.org//944013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43922 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 18:35:06 +00:00
bbc11c6640
Add ignore-unrecognized-flags as an option to the command line options of analysis server
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//940093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43920 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 17:19:53 +00:00
cef3704d8e
dart2js: don't emit big integers as integer, but instead use their exponential representation.
...
BUG= http://dartbug.com/16600
R=herhut@google.com
Review URL: https://codereview.chromium.org//944863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43913 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 14:29:46 +00:00
44bcb14217
Small fixes in preparation for SemanticVisitor.
...
BUG=http://dartbug.com/20377
R=karlklose@google.com
Review URL: https://codereview.chromium.org//938173004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43912 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 14:25:12 +00:00
429e0f049a
dart2js: add function type to the model.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//940053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43911 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 14:03:46 +00:00
cbde4578af
Fix Function.apply for static functions in new emitter.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//932523004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43910 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 12:47:06 +00:00
917f9cb813
Handle super calls to fields or getters that look like method calls.
...
These are of form:
class A {
get foo => {..}
}
class B extends A {
m() {
super.foo(1, 2, 3);
}
}
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//913213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43909 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 12:01:58 +00:00
be3c508ffd
Fix type propagation for and operator.
...
BUG= http://dartbug.com/22427
R=floitsch@google.com
Review URL: https://codereview.chromium.org//941293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43908 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 11:49:10 +00:00
78e30804e8
Make enum a keyword in dart2js.
...
BUG=http://dartbug.com/22478
R=floitsch@google.com
Review URL: https://codereview.chromium.org//944813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43906 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 10:54:48 +00:00
27a30ee1de
dart2js: Support isDeferred on DependencyMirrors.
...
BUG= http://dartbug.com/22475
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//924393003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43905 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 10:37:44 +00:00
5230b1a673
dart2js: only allocate one closure in 'setupClass' of the new emitter.
...
R=zarah@google.com
Review URL: https://codereview.chromium.org//939753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43901 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 09:10:14 +00:00
0deab36c67
dart2js: Don't show "--enable-concrete-type-inference" in help.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//940713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43900 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 09:07:32 +00:00
45acfc4524
fix code completion invocation on getter
...
BUG=dartbug.com/22376
R=scheglov@google.com
Review URL: https://codereview.chromium.org//929323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:14:52 +00:00
3750ba067f
Return version with connected notification
...
R=jwren@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//943723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:45:01 +00:00
c845e7cd9a
Change equality comparison for FileBasedSource to use URI.
...
Previously, we considered two FileBasedSources to be equal if they
referred to the same file. As a result, if a given file was
accessible via multiple URI's, only one cache entry would be created
for the file and we would only resolve it once; the elements created
by resolution would be nondeterministic, they would refer to the file
via whatever source happened to be used to analyze it first. Worse
yet, incremental analysis might cause some of the elements in the file
to later be replaced by elements that would refer to the file via a
different source, resulting in confusing errors.
BUG=dartbug.com/22030
R=scheglov@google.com
Review URL: https://codereview.chromium.org//944493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43888 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 19:15:50 +00:00
2602413b00
Fix for dart2js codegen issue 22487
...
R=herhut@google.com
Review URL: https://codereview.chromium.org//932363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43887 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 19:04:41 +00:00
6bb78fd867
- Mark flaky test.
...
Review URL: https://codereview.chromium.org//937113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43881 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 16:55:54 +00:00
4e7ecb1103
Issue 22409. Restore recognizing string concatenation in const expressions.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22409
https://code.google.com/p/dart/issues/detail?id=21000
Review URL: https://codereview.chromium.org//940853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43879 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 15:35:54 +00:00
84ef02af67
Revert "Remove implicit dependencies."
...
This reverts r43874.
Revert "Register literals through backend."
This reverts r43876.
FAILED: dart2js-d8-checked release_ia32 utils/source_mirrors_test
out/ReleaseIA32/dart-sdk/lib/_internal/compiler/js_lib/preambles/d8.js:263: Uncaught Error: Invalid argument(s): "_Proxy" is a private identifier
Stack Trace:
Error
at dart.wrapException (/mnt/data/b/build/slave/dart2js-linux-release-checked-1-5-be/build/dart/out/ReleaseIA32/generated_compilations/dart2js-checked-sdk/tests_utils_source_mirrors_test/out.js:2990:15)
at dart.Symbol0.static.Symbol_validatePublicSymbol (/mnt/data/b/build/slave/dart2js-linux-release-checked-1-5-be/build/dart/out/ReleaseIA32/generated_compilations/dart2js-checked-sdk/tests_utils_source_mirrors_test/out.js:11047:19)
That is, attempting to create a symbol for _Proxy, which is something I did change.
Also, many dart2dart fails with errors like this:
Internal Error: Function signature has not been computed for function(Symbol#).
const factory Symbol(String name) = internal.Symbol;
^^^^^^
Also something that I changed.
Review URL: https://codereview.chromium.org//918893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43878 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 15:31:39 +00:00
d9f2ea18a9
Register literals through backend.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//935033005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43876 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:54:25 +00:00
b3f2d3be1f
Remove implicit dependencies.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//930143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43874 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:31:37 +00:00
fdfb53269d
Fix darttags' usage of source file provider.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//924393005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43873 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:26:02 +00:00
f4ffcd1c4b
Use an enum in embedded_names as input to JS_GET_NAME.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//929313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43869 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 10:28:23 +00:00
1227ed3eb9
Move the try-catch out of the async-function
...
V8 will not optimize bodies surrounded by try/catch. So it is moved to
js_helper.
To be applied on top of https://codereview.chromium.org/932053002/ .
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//926553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43868 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 09:21:11 +00:00
7256562fcd
Return RequestErrorCode.NO_INDEX_GENERATED if no index.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//939823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43866 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 05:07:06 +00:00
03b5b0c234
[ak] Handle mutually recursive re-exports in dartdocgen
...
BUG=
R=tjblasi@google.com
Review URL: https://codereview.chromium.org//929353004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43861 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 01:07:16 +00:00
1e120443b5
Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body.
...
R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21879
Review URL: https://codereview.chromium.org//935123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43857 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 23:17:10 +00:00
6a78250c64
Issue 22476. Outline for enums.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476
Review URL: https://codereview.chromium.org//934353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 21:37:27 +00:00
eb3c24c089
Mask ResolvableLibrary hashCode.
...
We create these objects often, so in theory we may overflowing the smi limit.
I wonder if extracting a mixin would be as effective and help to share code.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//936823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43852 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 19:43:36 +00:00
dffb8c8a68
Status updates for issue 22475.
...
TBR=rmacnak@google.com
Review URL: https://codereview.chromium.org//938593004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43843 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 15:18:39 +00:00
a468b5cd60
Add README file to the mime package
...
Also update CHANGELOG after last change.
R=kustermann@google.com , wibling@google.com
BUG=http://dartbug.com/22442
Review URL: https://codereview.chromium.org//936733004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43841 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 14:45:30 +00:00
6ff10c59a9
Support for interpolated declarations in the js parser.
...
Also use this support to avoid non-constant templates in async_rewrite.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//932053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43837 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 13:00:41 +00:00
38512aca1b
Make value range analysis tolerate erroneous length expressions.
...
BUG= http://dartbug.com/21166
R=floitsch@google.com
Review URL: https://codereview.chromium.org//936483004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43836 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 12:11:58 +00:00
f44c9f3b6c
Fix bug in subscription handling in mime package
...
The parser now parses each received chunk to the end no matter what the
paused state of the part stream is. This will add data to the part
stream controller before it is even listened on, but only the data already
received from the original input stream.
Not trying to stop the parsing on a received chunk when the part stream
is paused makes the code simpler to reason about.
The two added tests modes failed without this change. Either by hanging
or by hitting an exception trying to invoke the getter 'length' on null.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//934763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43835 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 07:27:48 +00:00
4e34c0d247
Generate artificial hashCode for often used classes.
...
By avoiding calling Object.hashCode we analyze about 1% faster.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//934113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43832 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 01:12:43 +00:00
0e73ada9c2
Use package: URIs for files in lib
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//914373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43827 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 22:47:34 +00:00
5090dd0228
In analyzer, track time spent computing library cycles.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//935673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43826 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 22:38:23 +00:00
89219a623f
Fix build, address comments from Brian in previous email.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//931833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43820 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 20:26:09 +00:00
55a3255070
Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests.
...
Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//923103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43819 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 20:01:45 +00:00
a46fc6016d
Addition of the --no-index flag to the analysis server spec.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//932883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43816 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:55:00 +00:00
4cc4e28411
status files: trying out new SkipSlow flag
...
and selectively used SkipByDesign in more places
R=whesse@google.com
Review URL: https://codereview.chromium.org//928523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43815 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:21:39 +00:00
3ae9ac92c5
Fix error handling in dart2js async-await
...
BUG= dartbug.com/22372
R=floitsch@google.com
Review URL: https://codereview.chromium.org//925973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43812 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 14:51:49 +00:00
da95947849
Make [EnumClassElement.enumValues] a [List].
...
BUG=
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//935613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43811 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 14:28:53 +00:00
f59c01304e
Implement Function.apply in the new emitter.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//928203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43807 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 11:47:49 +00:00
298747c23e
Add properties to the element tree
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//934603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43801 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-16 21:41:50 +00:00
scheglov@google.com