Commit Graph

1338 Commits

Author SHA1 Message Date
William Hesse 9b8f01f80e Add --packages flag to test.py, to specify a package spec file.
BUG=https://github.com/dart-lang/sdk/issues/27063

Review URL: https://codereview.chromium.org/2240193002 .
2016-08-12 15:44:09 +02:00
Aleksei Semenov c9081ea4df initial support for running tests against dart analyzer in strong mode (#27033) 2016-08-09 10:58:15 +02:00
Siva Annamalai 9eb719b105 Fix build break.
Review URL: https://codereview.chromium.org/2194413002 .
2016-08-01 15:03:55 -07:00
Siva Annamalai a794b54273 Increase test runtime timeout configuration for hot_reload tests in debug mode as we are about to add additional verification which involves iterating over the heap.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2197653005 .
2016-08-01 14:37:10 -07:00
John McCutchan 9c83d24622 Add --hot-reload-rollback test mode
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2200683002 .
2016-08-01 10:57:22 -07:00
Ryan Macnak 7fa49e9910 Resolve disagreement between build.py and test.py over which architectures are included in 'all'.
R=zra@google.com

Review URL: https://codereview.chromium.org/2162793004 .
2016-07-19 15:32:18 -07:00
John McCutchan ef71bc1834 Improve hot reload test mode
- [x] Start reloading even earlier.
- [x] Keep the value of FLAG_reload_every per-isolate (so spawned isolates reload eagerly too).
- [x] Adjust the reload every back off curve to be linear in the beginning.
- [x] Cap the reload every threshold at 1,000,000
- [x] Test status file updates.
- [x] Stop disabling the background compiler / OSR when running tests.
- [x] Skip multi tests with compilation errors when reloading.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2133823002 .
2016-07-11 12:29:13 -07:00
John McCutchan dc1b2bf580 Small tweaks to hot reload testing
- [x] Start reloading 5x sooner in test mode.
- [x] Skip mirrors tests for now.
- [x] Skip reloading tests that expect compile time errors.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2128923003 .
2016-07-08 06:51:21 -07:00
John McCutchan 621ce4e2fd Add --hot-reload-test-mode flag to embedder and wire it up to test.py
- [x] Add --hot-reload-test-mode to standalone embedder.
- [x] Have test.py pass `--hot-reload-test-mode` instead of specific flags.
- [x] Add --reload_every_back_off flag to control exponential backof off reloads.
- [x] Add --check_reloaded flag to ensure that an isolate has reloaded at least once before exiting.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2118923002 .
2016-07-01 14:26:25 -07:00
Ryan Macnak eb20b68e87 Add --hot-reload to the test harness.
./tools/build.py -mdebug,release runtime
./tools/test.py -mdebug,release --checked --hot-reload

BUG=http://dartbug.com/26809
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2114083002 .
2016-07-01 11:28:00 -07:00
William Hesse 3d9f53a4e6 Ensure short path names for generated tests on Windows, in test runner.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2104333002 .
2016-06-29 22:43:16 +02:00
Carlo Bernaschina 412c5f7bf5 Added observatory_ui tests to configuration
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2104213002 .
2016-06-29 08:39:44 -07:00
William Hesse f3c5ec9ff1 Suppress timeouts on Windows browser bots when dart2js hangs.
Also run dartfmt on test_runner.dart file.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2105783002 .
2016-06-28 17:23:02 +02:00
William Hesse 7e9a9804d9 Add suppression to test.dart for flaky content_shell crashes
BUG=https://github.com/dart-lang/sdk/issues/26739
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2081173002 .
2016-06-27 14:44:11 +02:00
William Hesse fb117bb484 Fix analyzer warnings for browser_controller.
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2069243002 .
2016-06-15 22:22:34 +02:00
William Hesse f76236db74 Revert "Revert "Make Safari tests more robust.""
This reverts commit b9cdd0e1b2.
This change should now work, because the buildbot recipes use the
renamed flag --reset-browser-configuration.

BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org/2070513002 .
2016-06-15 04:29:33 -07:00
Peter von der Ahé b9cdd0e1b2 Revert "Make Safari tests more robust."
This reverts commit 199806da03.

That commit failed because tools/bots/compiler.py is being ignored, and test.py is invoked based on recipes not included in this repository.

TBR

Review URL: https://codereview.chromium.org/2065053003 .
2016-06-15 10:39:36 +02:00
Peter von der Ahé 199806da03 Make Safari tests more robust.
R=whesse@google.com

Review URL: https://codereview.chromium.org/1871883002 .
2016-06-15 10:16:14 +02:00
Terry Lucas 6914b84a03 Fixed Linux bots to disable GPU otherwise process is terminated
R=whesse@google.com
TBR=alanknight@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2054153002 .
2016-06-13 06:34:04 -07:00
William Hesse 093672fe21 Queue standard test suites before co19
When running multiple test suites, queue the suites listed in
TEST_SUITE_DIRECTORIES before co19, vm tests, analyze_library, and
pkgbuild.

A re-upload of CL https://codereview.chromium.org/15565004/ from 2 years ago.

R=sgjesse@google.com
CC=kustermann@google.com

Review URL: https://codereview.chromium.org/2059153002 .
2016-06-13 13:37:34 +02:00
Zach Anderson 44796ed02d Move Windows build output from //build to //out
This is needed in order to begin migration to GN because
third-party dependencies and GN boilerplate expect GN
boilerplate to be in //build.

R=asiva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2027063003 .
2016-06-03 08:28:48 -07:00
Sigmund Cherem d1d46593d5 Make test.dart override only those dependencies declared in the pubspec.yaml
file (attempt #2).

Differences from before:
 - pull in transitive dependencies that were missing
 - pass on the package-root in standalone/io/test_runner_test

BUG= http://dartbug.com/26563
R=whesse@google.com

Review URL: https://codereview.chromium.org/2019163002 .
2016-05-31 15:48:54 -07:00
Sigmund Cherem dd7cfb2b62 Revert "Make test.dart override only those dependencies declared in the pubspec.yaml"
This reverts commit bcfdd3345b.

Broke standalone/io/test_runner_test, need to investigate.

BUG=

Review URL: https://codereview.chromium.org/2017093004 .
2016-05-27 17:39:17 -07:00
Sigmund Cherem bcfdd3345b Make test.dart override only those dependencies declared in the pubspec.yaml
file.

BUG= http://dartbug.com/26563
R=whesse@google.com

Review URL: https://codereview.chromium.org/2020843002 .
2016-05-27 17:19:47 -07:00
Ryan Macnak ef8baa8760 Add test harness option for app snapshots with unoptimized code.
./tools/test.py -m all -c dart2appjit -r dart_app --use-blobs

Rename 'dart_product' runtime to 'dart_app'.

Rename Dart_PrecompiledJITSnapshotBlob to Dart_CreateAppJITSnapshot and add documentation.

Remove out-of-date scripts in tools/precompilation.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1992703005 .
2016-05-26 10:37:47 -07:00
Florian Schneider 6c778cab08 Pass command line options of tests to precompiled runtime correctly.
This fixes the precompilation tests on Android that have command line
options specified in their test files.

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1988133003 .
2016-05-18 21:00:40 +02:00
Harry Terkelsen 1745ba77f5 fix all instances of "the the"
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1980573003 .
2016-05-13 12:38:25 -07:00
Florian Schneider 92a681266c Fix running precompiled tests on Android.
The command line options for running the snapshot were outdated.

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1963573002 .
2016-05-09 10:08:45 +02:00
Ryan Macnak 7546ef1709 Simplify command line options for creating snapshots.
Also makes codeless app snapshots work in debug and release modes.

dart --snapshot=file.snap [--snapshot-kind=script] script.dart
dart file.snap

dart_bootstrap --snapshot=dir --snapshot-kind=app-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-jit-after-run script.dart
dart --run-app-snapshot=dir script.dart

dart_bootstrap --snapshot=dir --snapshot-kind=app-aot script.dart
dart_precompiled_runtime --run-app-snapshot=dir script.dart

R=asiva@google.com

Review URL: https://codereview.chromium.org/1947783003 .
2016-05-06 12:40:04 -07:00
Ryan Macnak d7234da230 Include DBC in the "all" architecture.
R=zra@google.com

Review URL: https://codereview.chromium.org/1949423003 .
2016-05-05 15:19:58 -07:00
Florian Schneider b0f4ccabf4 Fix exit code handling for Android testing.
Shell returns 128+N when exiting because of signal.

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1950633003 .
2016-05-04 10:13:34 +02:00
Florian Schneider 174121435a Fix handling of negative exit codes in test.dart on Android.
BUG=dartbug.com/26375
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1940213003 .
2016-05-03 16:47:22 +02:00
Martin Kustermann abfea75f1e Add support for timeouts when using AdbPrecompilationCommand
R=whesse@google.com

Review URL: https://codereview.chromium.org/1940853002 .
2016-05-02 14:00:18 +02:00
Martin Kustermann 620b896e2f Initial support to test.dart for running precompiler tests on android devices
Steps to make this work:

a) Make sure you have an android sdk checkout:

  => See https://github.com/dart-lang/sdk/wiki/Building-Dart-SDK-for-Android

b) Building using android-toolchain crosscompiler:

  $ ./tools/build.py -mrelease -aarm --os=android dart_precompiled_runtime

  => Notice --os=android

c) Testing using attached android phones:

  $ export PATH=$PATH:$PWD/third_party/android_tools/sdk/platform-tools
  $ ./tools/test.py -mrelease -aarm --system=android -cprecompiler -rdart_precompiled --use-blobs

  => Notice --system=android

Failing tests on android can be marked in status files via:

[ $compiler == precompiler && $runtime == dart_precompiled && $system == android ]

R=whesse@google.com

Review URL: https://codereview.chromium.org/1922163002 .
2016-05-02 12:41:22 +02:00
William Hesse 7c9219a48e Revert "Delay Firefox browser startup in test scripts, to flatten load."
This reverts commit 40b69fd615.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1921553005 .
2016-04-26 21:29:45 +02:00
William Hesse 40b69fd615 Delay Firefox browser startup in test scripts, to flatten load.
BUG=https://github.com/dart-lang/sdk/issues/26060
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1882813002 .
2016-04-26 15:33:52 +02:00
Ryan Macnak f262fad639 Option to output precompiled instructions as a blob for use with mmap instead of assembly for use in a shared library.
BUG=http://dartbug.com/26199
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1915853004 .
2016-04-25 16:19:34 -07:00
Zachary Anderson 3d7202bad3 DBC: Adds simdbc64 target, adds arm64 arithmetic overflow logic
There were differences between linux gcc, android gcc,
MacOS clang, and 32 vs. 64-bit w.r.t the __builtin
functions for detecting arithmetic overflow. I couldn't get
them all working at the same time. Instead, I removed them,
and changed to always use the inline assembly. This works
in all the configurations above.

This change also adds a simdbc64 target for building simdbc
for 64-bit, and sets up the android targets. simdbc targets
arm, and simdbc64 targets arm64. You can build them with:

$ ./tools/build.py -m release -a simdbc{64} --os=android runtime

R=iposva@google.com

Review URL: https://codereview.chromium.org/1904153003 .
2016-04-25 12:48:34 -07:00
John McCutchan 14d8653ed8 Go back to using dart_bootstrap for precompilation bots
BUG=

Review URL: https://codereview.chromium.org/1913193002 .
2016-04-22 11:07:01 -07:00
John McCutchan 0cfd4f5cd5 GN Build fixes for Flutter + gen_snapshot fix
1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values: "release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument.

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler in gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of command line arguments the Flutter folks are using.

7. ASSERT that both DART_PRECOMPILED_RUNTIME and DART_PRECOMPILER are not set at the same time.

R=fschneider@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/1903583002 .
2016-04-22 07:00:03 -07:00
Florian Schneider e905d64058 VM: Remove redundant build target dart_product.
It has been replaced by out/Product<arch>/dart

Building and testing product mode works via the -mproduct flag
with build.py/test.py.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1902073003 .
2016-04-20 12:29:21 +02:00
Vyacheslav Egorov ee0f608ce4 Dart Byte Code interpreter.
This version is Clang/GCC only and does not support Windows because it uses computed goto's.

Only unoptimized mode is supported.

Architecture is described in constants_dbc.h and stack_frame_dbc.h.

R=fschneider@google.com, zra@google.com

Review URL: https://codereview.chromium.org/1858283002 .
2016-04-18 23:02:01 +02:00
William Hesse c0096e6f0c Print name of previous test when a browser test times out.
Remove timeout multiplier for dart2js browser tests.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1867283002 .
2016-04-13 12:35:27 +02:00
William Hesse 333959070b Remove timeout multiplier for dart2js browser tests.
This reverts part of
https://github.com/dart-lang/sdk/commit/82e62563924c0bfde5be8dccfddb186980de637f
Review is at
https://codereview.chromium.org/1865913002

BUG=https://github.com/dart-lang/sdk/issues/26060
R=ahe@google.com

Review URL: https://codereview.chromium.org/1874653002 .
2016-04-08 13:06:32 +02:00
William Hesse 82e6256392 Update status for html/JsArray test, increase dart2js timeout on browser bots.
BUG=https://github.com/dart-lang/sdk/issues/26060
BUG=https://github.com/dart-lang/sdk/issues/26197
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1865913002 .
2016-04-06 15:57:35 +02:00
William Hesse c63b10b611 Format the test scripts in /tools/testing/dart using dartfmt 1.16.0-dev.3.0.
R=ahe@google.com

Review URL: https://codereview.chromium.org/1859973002 .
2016-04-06 14:49:18 +02:00
William Hesse 7407ecded4 Start browsers sequentially in testing scripts, as needed.
BUG=https://github.com/dart-lang/sdk/issues/26060
R=ahe@google.com

Review URL: https://codereview.chromium.org/1859523002 .
2016-04-06 11:34:52 +02:00
Harry Terkelsen a9a0ce0c1c Stop retrying failing tests on Safari
BUG=https://github.com/dart-lang/sdk/issues/22519
R=ahe@google.com

Review URL: https://codereview.chromium.org/1844933002 .
2016-03-30 10:27:13 -07:00
Siva Annamalai 520ba45d16 Use the correct binary name for testing product mode.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1808853006 .
2016-03-18 13:59:34 -07:00
Terry Lucas 96d7fbaa1b Reverted experiment for ot test
R=whesse@google.com

Review URL: https://codereview.chromium.org/1806953002 .
2016-03-16 10:09:34 -07:00