dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
39,615 Commits 2 Branches 0 Tags
ea1b511e236fcedd4eaf214ecfcffa52eb1334bb
Commit Graph

39615 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Paul Berry ea1b511e23 Fix handling of sdk path when building SDK summaries. 
This was inadvertently broken by c41427383b.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2245073002 .
 2016-08-15 07:29:35 -07:00
Lasse R.H. Nielsen 04a470e636 Spec: Allow any expression in assert statements. 
Fixes issue #26866

BUG= http://dartbug.com/26866
R=eernst@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org/2143363002 .
 2016-08-15 11:57:51 +02:00
Carlo Bernaschina 1196cf5276 Fixed Observatory class-view crash 
TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2237383004 .
 2016-08-12 17:48:44 -07:00
Paul Berry 058dd73f1d Fix instantiateToBounds behavior in summary resynthesizer to match that of StrongTypeSystemImpl.instantiateToBounds. 
Note that StrongTypeSystemImpl.instantiateToBounds misbehaves if the
bound on one type parameter refers to a later type parameter.  I'm not
sure what the intended behavior is in this case, so I've filed
dartbug.com/27072.  Once that is fixed we can refine the behavior of
the summary resynthesizer further.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2244043002 .
 2016-08-12 17:29:21 -07:00
Sigmund Cherem 88383fb5e1 Fix batch test as well. 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2243073002 .
 2016-08-12 16:19:11 -07:00
Ryan Macnak 6b5f29fb70 Reload: Don't free the saved class table while another thread may be reading it. 
Fixes #27016.

R=asiva@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2240283002 .
 2016-08-12 16:12:25 -07:00
Siva Annamalai cb36467568 - Fix for issue 27054 (leak when removing element from _GrowableList) 
- _GrowableList.removeLast was not shrinking the backing array

BUG=27054
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2240313002 .
 2016-08-12 16:06:12 -07:00
Sigmund Cherem 8b594e0c26 Fix http test 
I refactored the code we used in the zero_termination_test to reuse it here,
also moved the test data to be in the same folder as the test.

BUG=

Review URL: https://codereview.chromium.org/2238073005 .
 2016-08-12 15:53:17 -07:00
Sigmund Cherem b23baf4d74 Making the bots greener: 
- fix file that refers to cps ir (breaks analyze_test_test)
 - add more shards to serialization tests to avoid so many timeouts.

Review URL: https://codereview.chromium.org/2241033002 .
 2016-08-12 15:52:34 -07:00
Ryan Macnak d98ddbfcca Fix unsimulated ARM/ARM64/MIPS builds. 
Review URL: https://codereview.chromium.org/2238363002 .
 2016-08-12 15:46:25 -07:00
Carlo Bernaschina 8860a60af4 Removing warnings from tests 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2243833003 .
 2016-08-12 15:08:55 -07:00
Konstantin Shcheglov 4cda900e9b Publish new analyzer version for new DartSdk.getLinkedBundle() method. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2242663003 .
 2016-08-12 15:03:41 -07:00
Sigmund Cherem a47c9167cd Delete CPS IR. 
We can always revert this CL if we want to bring it back later on.

R=sra@google.com

Review URL: https://codereview.chromium.org/2246623002 .
 2016-08-12 14:40:50 -07:00
Sigmund Cherem 02fa5aad8e Additional fixes to zero_termination_test 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2238353002 .
 2016-08-12 14:33:24 -07:00
John Messerly e36fa2b3be fix #26120, sideways casts no longer supported 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2231273002 .
 2016-08-12 14:32:36 -07:00
Konstantin Shcheglov ee3a93a0a8 Add a new Analysis Server flag '--enable-pub-summary-manager'. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2243003002 .
 2016-08-12 14:05:55 -07:00
Paul Berry 052a6c867d Fix summary handling of unresolved imports, exports, and parts. 
Previously this was working for a few use cases by dumb luck, but it
wasn't well tested and became broken by
b29c6bf330.  This CL fixes it for real
and adds tests to verify the fix.

Note that there is a change to how we represent an unresolved
import/export: instead of storing a URI_EXISTS modifier in the element
model, we simply mark the imported library element as synthetic.
(This library element existed anyway; we just weren't marking it as
synthetic).  This makes it easy to tie in with summaries, since it is
easy for the resynthesizer to detect that the library doesn't exist at
the time the library handle is resolved.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2235373003 .
 2016-08-12 13:59:51 -07:00
John McCutchan 3aba8355f3 Dump information when we hit a FATAL in become 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2240663004 .
 2016-08-12 13:48:21 -07:00
Carlo Bernaschina a58c34254d Compacting _GetRetainingPath result avoiding some internal structures. 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2231313002 .
 2016-08-12 13:42:04 -07:00
Konstantin Shcheglov c0631495ef Throw _LinkException when linking failed. 
We cannot actually continue linking with a missing dependency, we
have to terminate it and then mark the node as failed.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2243693004 .
 2016-08-12 13:25:48 -07:00
Ryan Macnak e09f2f940e Reload: Don't crash when a tearoff adds arguments and is called with too few. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2241603004 .
 2016-08-12 13:06:35 -07:00
Konstantin Shcheglov a3a031195a Add DartSdk.getLinkedBundle() and use it in PubSummaryManager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2242963002 .
 2016-08-12 12:11:03 -07:00
Ryan Macnak 7ff2dd4117 Optimize AOT's switchable calls for the monomorphic case. 
The call sequence is very similar to a classic IC call, except the guarded class and the target are loaded indirectly from the constant pool instead of as immediates. In the monomorphic case, we call directly to the expected target with a class check in the callee. In the unlinked, polymorphic and megamorphic cases, we call a stub; these case are now call-through instead of call-and-return.

Every code, except stubs involved in switchable calls, includes the class check sequence at the beginning. So we now distinguish between a checked and an unchecked entry point. Generated code except the switchable call continues to use the unchecked entry point.

PC offsets are calculated relative to the beginning of the instruction stream, rather than either entry point.

BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2226893002 .
 2016-08-12 11:18:35 -07:00
Konstantin Shcheglov 9f187f3df5 Normalize paths in PhysicalResourceProvider.getFile()/getFolder(). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2239303004 .
 2016-08-12 11:04:02 -07:00
Konstantin Shcheglov df4baa4332 Fix resolveRelativeUri() to handle correctly empty contained Uri(s). 
This was breaking linking with `package` Uri(s).
I also added a new test that exhibits this behaviour.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2242883003 .
 2016-08-12 10:59:33 -07:00
Sigmund Cherem 2c7f737353 Fix zero_termination tests in the bots. 
This test only fails in the bots because they don't build the SDK, they use a prebuilt SDK. The script called sdk/bin/dart2js which assumes you have a binary under out/ReleaseX64/dart.

R=sra@google.com

Review URL: https://codereview.chromium.org/2234343004 .
 2016-08-12 10:53:57 -07:00
Stephen Adams b5efb1c0c1 Don't use library tag for private name prefixes 
Use only the Uri.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2245533002 .
 2016-08-12 10:20:58 -07:00
Ryan Macnak 87360dc375 Revert asserting only 1 arg ICs are generated in precompilation. 
Review URL: https://codereview.chromium.org/2244743002 .
 2016-08-12 10:09:02 -07:00
Brian Wilkerson c41427383b Deprecate DirectoryBasedDartSdk and transition existing uses to the new API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2242853002 .
 2016-08-12 09:18:12 -07:00
William Hesse 9b8f01f80e Add --packages flag to test.py, to specify a package spec file. 
BUG=https://github.com/dart-lang/sdk/issues/27063

Review URL: https://codereview.chromium.org/2240193002 .
 2016-08-12 15:44:09 +02:00
Martin Kustermann 4a88439e34 Reduce generated ARM code size for ReturnInstr by one instruction 
Savings on flutter seem to be ~0.9%

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2238233002 .
 2016-08-12 12:58:39 +02:00
Stephen Adams b7aa65528c Rerun formatter 
TBR=het@google.com

Review URL: https://codereview.chromium.org/2239193002 .
 2016-08-11 19:05:59 -07:00
Ryan Macnak acf68a7126 Don't mark closurized natives as natives. 
We used to implement implicit closures by duplicating the body, but now they perform a call to the parent function.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2237113003 .
 2016-08-11 16:05:54 -07:00
Florian Schneider f26b130de9 VM: Fix math intrinsic code. 
The functions where we have intrinsics were always inlined, so the intrinsic
code was actually not used. Move these functions to the inline black list instead to
ensure the intrinsic code is used instead. Inlining these in the generic inliner would
 not help anyway since they are inlined as recognized methods by the optimizer.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2239903002 .
 2016-08-11 15:48:57 -07:00
Ryan Macnak 7244b5de0e Fail gracefully when attempting to evaluate against a VM internal class such a Field. 
We can't evaluate against these classes because they don't have Dart source, belong to a library, etc.

Fixes #27052.

R=cbernaschina@google.com

Review URL: https://codereview.chromium.org/2237953002 .
 2016-08-11 15:08:59 -07:00
Konstantin Shcheglov b290ea105f Use existing unlinked bundles even for packages outside of the pub cache. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2232403002 .
 2016-08-11 14:11:04 -07:00
Konstantin Shcheglov bcd9642d84 Link with exports dependencies. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2243463003 .
 2016-08-11 14:09:08 -07:00
Brian Wilkerson 110c0f7e0e Prototype for package-specific cache partitions 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2237893002 .
 2016-08-11 14:04:17 -07:00
Konstantin Shcheglov e1fd213d55 Link packages with an SDK extension. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2231413003 .
 2016-08-11 12:43:45 -07:00
Alexei Eleusis Diaz Vera c365f3023b fix typo (#27056) 2016-08-11 12:19:48 -07:00
Konstantin Shcheglov bd1c47146e Compute the linked bundle for the SDK extension. 
As Brian noticed, we have at most one extension, it would be waste to
implement general multi-extension linking. So, for now we have support
only for one.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2240593002 .
 2016-08-11 11:21:02 -07:00
Brian Wilkerson 261ef2bd1f Bump the version prior to publishing 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2235353002 .
 2016-08-11 11:17:36 -07:00
Ryan Macnak 0ad1b4e923 Guard against re-entrant requests for stack traces. 
R=zra@google.com

Review URL: https://codereview.chromium.org/2230713005 .
 2016-08-11 09:46:20 -07:00
Konstantin Shcheglov 18b6c12f61 Rewrite SdkExtUriResolver into reflective. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2243493002 .
 2016-08-11 09:28:59 -07:00
Konstantin Shcheglov 296d81f60a Issue 27053. Record errors in InferStaticVariableTypeTask and include them into unit errors. 
R=brianwilkerson@google.com, jmesserly@google.com
BUG=

Review URL: https://codereview.chromium.org/2239613002 .
 2016-08-11 09:10:31 -07:00
William Hesse 25bff74ab5 Dummy commit after restarting buildbot 
BUG=
TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org/2236903002 .
 2016-08-11 13:23:13 +02:00
Johnni Winther b6a6b19a1e Ensure correct current element for field initializers. 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2230853002 .
 2016-08-11 13:19:36 +02:00
John Messerly af13ca9e25 fix wrong order to isAssignableTo for override params 
Also renames the easy-to-miss overridden/overriding to the more clear base/derived, so these bugs will come up less often.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2236763002 .
 2016-08-10 17:50:33 -07:00
Stephen Adams b6f84a01d6 dart2js: Sort libraries by Uri only. 
Avoid using the 'library' tag.

Remove compareTo method from CompilationUnitElement and LibraryElement.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2221273002 .
 2016-08-10 17:09:27 -07:00
James Robinson cfdd6ee5cc [fuchsia] Update run_vm_tests_fuchsia for fuchsia launchpad API change 
R=zra@google.com

Review URL: https://codereview.chromium.org/2235033002 .
 2016-08-10 15:41:03 -07:00