Commit Graph

13386 Commits

Author SHA1 Message Date
Sigmund Cherem 88383fb5e1 Fix batch test as well.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2243073002 .
2016-08-12 16:19:11 -07:00
Sigmund Cherem 8b594e0c26 Fix http test
I refactored the code we used in the zero_termination_test to reuse it here,
also moved the test data to be in the same folder as the test.

BUG=

Review URL: https://codereview.chromium.org/2238073005 .
2016-08-12 15:53:17 -07:00
Sigmund Cherem b23baf4d74 Making the bots greener:
- fix file that refers to cps ir (breaks analyze_test_test)
 - add more shards to serialization tests to avoid so many timeouts.

Review URL: https://codereview.chromium.org/2241033002 .
2016-08-12 15:52:34 -07:00
Sigmund Cherem a47c9167cd Delete CPS IR.
We can always revert this CL if we want to bring it back later on.

R=sra@google.com

Review URL: https://codereview.chromium.org/2246623002 .
2016-08-12 14:40:50 -07:00
Sigmund Cherem 02fa5aad8e Additional fixes to zero_termination_test
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2238353002 .
2016-08-12 14:33:24 -07:00
Sigmund Cherem 2c7f737353 Fix zero_termination tests in the bots.
This test only fails in the bots because they don't build the SDK, they use a prebuilt SDK. The script called sdk/bin/dart2js which assumes you have a binary under out/ReleaseX64/dart.

R=sra@google.com

Review URL: https://codereview.chromium.org/2234343004 .
2016-08-12 10:53:57 -07:00
Johnni Winther b6a6b19a1e Ensure correct current element for field initializers.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2230853002 .
2016-08-11 13:19:36 +02:00
Johnni Winther 32bcf1e3b2 Fix string_interpolation tests.
BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org/2230823002 .
2016-08-10 11:39:25 +02:00
Johnni Winther 5af09978e7 Fix Resolution.getResolvedAst for serialization in production mode
- and split analysis_test into 4 subtests.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2220333007 .
2016-08-10 10:30:05 +02:00
Lasse R.H. Nielsen 3502fd5fd7 Revert "Reapply fast-URI patch."
Seems to trigger VM bug.

Review URL: https://codereview.chromium.org/2225243003 .
2016-08-09 12:51:58 +02:00
Lasse R.H. Nielsen 99e94db85b Reapply fast-URI patch.
R=whesse@google.com

Review URL: https://codereview.chromium.org/2220373002 .
2016-08-09 09:38:47 +02:00
Florian Loitsch 46a8579c1e Revert "Return futures on Stream.cancel when possible."
This reverts commit 1905ddafaa.

Review URL: https://codereview.chromium.org/2223133002 .
2016-08-08 19:31:04 +02:00
Sigmund Cherem 53d968bd02 delete send-info measurements. This experiment is not being maintained
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2214263002 .
2016-08-08 09:27:46 -07:00
Florian Loitsch 1905ddafaa Return futures on Stream.cancel when possible.
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/395e7aaa696126b82862a9f75e7ebf742c354b56

Review URL: https://codereview.chromium.org/2202533003 .

Reverted: https://github.com/dart-lang/sdk/commit/99e5328eaca7f98641a5c6e523e80b7297792817
2016-08-08 17:30:36 +02:00
Søren Gjesse f9404b969b Handle HTTP header parameters with empty values better
This handles the null issue reported.

Closes #26598

BUG= https://github.com/dart-lang/sdk/issues/26958
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2225003002 .
2016-08-08 16:35:15 +02:00
Johnni Winther e6241bc12d Include constants in deferred computation.
This ensures that in-code constants are included in the deferred computation.

Currently the set of live constants is not computed in itself, so the constants
used in the computation are not the same - and they are generally larger than needed.

R=het@google.com

Review URL: https://codereview.chromium.org/2194173002 .
2016-08-08 14:39:58 +02:00
Florian Loitsch 596723f0c3 Fix return type for JoinMulticast.
Fixes #27032.

BUG= http://dartbug.com/27032
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2220983002 .
2016-08-08 12:22:30 +02:00
Terry Lucas fa5741f325 Updated to reverted WebKit CL and updated status files to only skip the failing tests.
TBR=hausner@google.com

Review URL: https://codereview.chromium.org/2217343002 .
2016-08-05 13:17:00 -07:00
Florian Loitsch 99e5328eac Revert "Return futures on Stream.cancel when possible."
This reverts commit 395e7aaa69.

Review URL: https://codereview.chromium.org/2213193004 .
2016-08-05 14:32:14 +02:00
Florian Loitsch 395e7aaa69 Return futures on Stream.cancel when possible.
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2202533003 .
2016-08-05 13:58:45 +02:00
Regis Crelier c8910f9d38 Update new test to check asserts only if they are enabled and remove VM option.
It seems like asserts are not supported correctly in product mode.

Review URL: https://codereview.chromium.org/2215143002 .
2016-08-04 16:01:19 -07:00
Sigmund Cherem 0eee4027a6 Delete dart_backend from compiler.
R=sra@google.com

Review URL: https://codereview.chromium.org/2213673002 .
2016-08-04 15:57:04 -07:00
Regis Crelier fbbedf4f18 Introduce getter p on double in the VM to control fractional precision.
Add test.

R=asiva@google.com, fschneider@google.com

Review URL: https://codereview.chromium.org/2208473006 .
2016-08-04 15:18:00 -07:00
Matthias Hausner 6075a53547 Skip initializing_formal_* tests on Dartium
Apparently the VM does not get the --initializing-formal-access flag
set, which these tests need in order to pass.

TBR=terry

BUG=

Review URL: https://codereview.chromium.org/2219473002 .
2016-08-04 13:47:21 -07:00
Matthias Hausner 643fdb9dc8 Implement the language change that makes initializing formal parameters visible in the initializer list, but not in the constructor's body.
The feature is enabled with the flag --initializing-formal-access.

BUG=26655, 26656
R=regis@google.com

Review URL: https://codereview.chromium.org/2051213005 .
2016-08-04 11:24:25 -07:00
William Hesse cad5dd65cb Update status for Firefox 48
Also update status for Chrome on macOS.

BUG=https://github.com/dart-lang/sdk/issues/26789
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2215763002 .
2016-08-04 15:55:45 +02:00
Florian Loitsch ef4933df25 Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/34aed6a08b8547a985ac701cf3910a5f5450dd52

Reverted: https://github.com/dart-lang/sdk/commit/a1005bad7e249a5510b30683a5ca52b16baafbc4

Committed: https://github.com/dart-lang/sdk/commit/8c4954492f0593f41d270691bb82c26d8509c894

Reverted: https://github.com/dart-lang/sdk/commit/5ebcd3cda0f34be580be1a8ed816849a82691427

Committed: https://github.com/dart-lang/sdk/commit/eaeb260244d524b54d3ec842af2f8400cd543b12

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: https://github.com/dart-lang/sdk/commit/90a194be3c03c058c4e087e1bd11823817982393
2016-08-04 14:45:01 +02:00
Florian Loitsch 90a194be3c Enter a description of the change.
Merge branch 'master' into revert

Revert "Better error-message when bind fails."

This reverts commit eaeb260244.

Review URL: https://codereview.chromium.org/2213533002 .
2016-08-03 23:18:39 +02:00
Florian Loitsch eaeb260244 Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/34aed6a08b8547a985ac701cf3910a5f5450dd52

Reverted: https://github.com/dart-lang/sdk/commit/a1005bad7e249a5510b30683a5ca52b16baafbc4

Committed: https://github.com/dart-lang/sdk/commit/8c4954492f0593f41d270691bb82c26d8509c894

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: https://github.com/dart-lang/sdk/commit/5ebcd3cda0f34be580be1a8ed816849a82691427
2016-08-03 22:44:28 +02:00
Zachary Anderson 0e6f087942 Clear the error bit after reading the default trusted certs
fixes #26954

R=whesse@google.com

Review URL: https://codereview.chromium.org/2211453002 .
2016-08-03 12:24:35 -07:00
Ryan Macnak 5ebcd3cda0 Revert "Better error-message when bind fails."
This reverts commit 8c4954492f.

This change broke the Android build.

Review URL: https://codereview.chromium.org/2201183004 .
2016-08-03 09:54:57 -07:00
John McCutchan af46b9dc55 Fix typo in status file
BUG=

Review URL: https://codereview.chromium.org/2203163003 .
2016-08-03 08:34:11 -07:00
John McCutchan 6a23dda952 Mark double_pow_test as failing with a runtime error for reload
BUG=

Review URL: https://codereview.chromium.org/2209683003 .
2016-08-03 08:03:16 -07:00
Florian Loitsch 8c4954492f Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/34aed6a08b8547a985ac701cf3910a5f5450dd52

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: https://github.com/dart-lang/sdk/commit/a1005bad7e249a5510b30683a5ca52b16baafbc4
2016-08-03 16:27:48 +02:00
Florian Loitsch a1005bad7e Revert "Better error-message when bind fails."
This reverts commit 34aed6a08b.

Review URL: https://codereview.chromium.org/2210523002 .
2016-08-03 15:47:15 +02:00
Florian Loitsch 873c6e4688 Don't close stdio/stderr when shutting down.
Fixes #26872.

BUG= http://dartbug.com/26872
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2204953002 .
2016-08-03 15:30:30 +02:00
Florian Loitsch 34aed6a08b Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2205913003 .
2016-08-03 15:29:41 +02:00
John McCutchan 35146c688e Fix reload handling of unwind / stackoverflow errors
BUG=

Review URL: https://codereview.chromium.org/2201283002 .
2016-08-02 18:27:35 -07:00
John McCutchan b8500cdd2d More reload status and bug fixes
TBR=rmacnak

Review URL: https://codereview.chromium.org/2209513003 .
2016-08-02 17:26:13 -07:00
John McCutchan 268082769b Initial status file updates for $hot_reload_rollback
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2207653002 .
2016-08-02 11:03:44 -07:00
John McCutchan 8b3a8bbe0f Update status files now that tear off closure equality works across reloads
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2185133004 .
2016-07-28 12:42:12 -07:00
Regis Crelier 48060a653f Reverting bad fix of issue #26941.
Review URL: https://codereview.chromium.org/2179903009 .
2016-07-28 12:39:49 -07:00
William Hesse 118d55d79e Update status for html/js_util_test on IE.
This test was introduced in
https://codereview.chromium.org/2150313003

BUG=https://github.com/dart-lang/sdk/issues/26978
R=eernst@google.com

Review URL: https://codereview.chromium.org/2188663004 .
2016-07-28 15:30:48 +02:00
Regis Crelier 093bca5909 Temporarily skip test that became flaky after fixing #26941.
Review URL: https://codereview.chromium.org/2192723002 .
2016-07-27 22:38:42 -07:00
Regis Crelier f10ce1eb69 Skip new regression test crashing when precompiled.
Review URL: https://codereview.chromium.org/2186493005 .
2016-07-27 18:31:50 -07:00
Regis Crelier 11d340c51d Force local context allocation in finally clauses (fixes #26948).
Add regression test.

R=fschneider@google.com, hausner@google.com

Review URL: https://codereview.chromium.org/2188863002 .
2016-07-27 14:03:25 -07:00
Ryan Macnak 634a62c9df DBC: Add missing deopt info after stack overflow checks.
Fixes collecting a debugger stack trace at an interrupt.

Enable most vm-service tests.

R=zra@google.com

Review URL: https://codereview.chromium.org/2183993004 .
2016-07-27 12:25:54 -07:00
Stephen Adams 9d5fd9d5bd Avoid using call-through stub on calls to fields.
This usually removes the demand for the call-through stub and sometimes enables optimizations on the field load, e.g.:

    WhereIterator: {
      "^": "Iterator;_iterator,_f",
      moveNext$0: function() {
        for (var t1 = this._iterator; t1.moveNext$0();)
          if (this._f$1(t1.get$current()) === true)
            return true;
        return false;
      },
      _f$1: function(arg0) {
        return this._f.call$1(arg0);
      }
      ...
-->
    WhereIterator: {
      "^": "Iterator;_iterator,_f",
      moveNext$0: function() {
        var t1, t2;
        for (t1 = this._iterator, t2 = this._f; t1.moveNext$0();)
          if (t2.call$1(t1.get$current()) === true)
            return true;
        return false;
      },
      ...

BUG= https://github.com/dart-lang/sdk/issues/22197
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2180363002 .
2016-07-26 18:02:05 -07:00
Stephen Adams 94df5a0c24 dart2js: Avoid empty else clauses in generators.
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/a02c5798a4b9c682cfe5fddbf48f053c9c677b68

Review URL: https://codereview.chromium.org/1916863002 .

Reverted: https://github.com/dart-lang/sdk/commit/803826256d0be2c3560705c084d20ed78d1fca74
2016-07-26 09:58:34 -07:00
John McCutchan 50c141d298 Mark closure identity test as pass, fail for reload bots
BUG=

Review URL: https://codereview.chromium.org/2181233003 .
2016-07-26 06:38:06 -07:00