dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
39,615 Commits 2 Branches 0 Tags
ea1b511e236fcedd4eaf214ecfcffa52eb1334bb
Commit Graph

1427 Commits

Author SHA1 Message Date
Konstantin Shcheglov a3a031195a Add DartSdk.getLinkedBundle() and use it in PubSummaryManager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2242963002 .
 2016-08-12 12:11:03 -07:00
Brian Wilkerson c41427383b Deprecate DirectoryBasedDartSdk and transition existing uses to the new API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2242853002 .
 2016-08-12 09:18:12 -07:00
Konstantin Shcheglov 0522cad42a Convert to async/await parts that cause strong mode warnings. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2233633003 .
 2016-08-10 10:28:34 -07:00
Brian Wilkerson 38689cd848 Fix errors introduced by recent strong-mode changes 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2233913003 .
 2016-08-10 09:12:49 -07:00
Brian Wilkerson 5b26441dbf Convert server and cli and deprecate the old implementation 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2214613003 .
 2016-08-04 11:28:16 -07:00
Konstantin Shcheglov 30b2401907 Issue 25666. Add test for shadowing of a superclass member from other library. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25666

Review URL: https://codereview.chromium.org/2204263002 .
 2016-08-03 10:16:36 -07:00
Konstantin Shcheglov 0d84e5e586 New test for multiple imports with the same prefix name. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2200473002 .
 2016-07-29 16:04:38 -07:00
pq 722d4a13b0 Default trailing comma support to true (#26647). 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2185873002 .

See: https://github.com/dart-lang/sdk/issues/26647.
 2016-07-27 09:42:12 -07:00
Konstantin Shcheglov a3b1936567 Fix for SearchEngine.searchMemberDeclarations() - search exact names. 
R=pquitslund@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2183263002 .
 2016-07-26 14:47:32 -07:00
Konstantin Shcheglov dd18f93154 Issue 26926. Don't search hierarchy for static class members. 
R=pquitslund@google.com
BUG= https://github.com/dart-lang/sdk/issues/26926

Review URL: https://codereview.chromium.org/2176173004 .
 2016-07-25 11:36:52 -07:00
Devon Carew c52843e42d Validate the regex used in search.findTopLevelDeclarations. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2160723002 .
 2016-07-18 12:13:12 -07:00
Konstantin Shcheglov 55fcc03572 Use the new StaticWarningCode.UNDEFINED_IDENTIFIER_AWAIT error. 
...instead of StaticWarningCode.UNDEFINED_IDENTIFIER

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2162523003 .
 2016-07-18 10:48:55 -07:00
Konstantin Shcheglov 34ae48a6b0 Don't run Analysis Server performance tests in checked mode. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2153163002 .
 2016-07-15 09:05:09 -07:00
Brian Wilkerson 2b34885e4c Fix a small bug in the stress test 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2147223003 .
 2016-07-14 10:05:20 -07:00
Konstantin Shcheglov 7d9d451730 Don't insert additional ':' when changing a named argument name. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2136223004 .
 2016-07-12 17:25:55 -07:00
Konstantin Shcheglov 79f7150d97 Issue 26249. Quick Assist to convert final fields into getters. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249

Review URL: https://codereview.chromium.org/2140193003 .
 2016-07-12 14:15:44 -07:00
Konstantin Shcheglov f1fa32e356 Issue 26249. Quick Assist to convert getters into final fields. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249

Review URL: https://codereview.chromium.org/2144763002 .
 2016-07-12 13:31:53 -07:00
Konstantin Shcheglov 94a41e0d2e Fixes for context_manager_test on Windows. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2142143002 .
 2016-07-12 12:26:29 -07:00
Konstantin Shcheglov bf731dfcd5 Issue 26764. Insert required imports in the correct sorting order. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26764

Review URL: https://codereview.chromium.org/2143023002 .
 2016-07-12 11:17:02 -07:00
Konstantin Shcheglov ed887c09d1 Validate cache consistency asynchronously. Compute modification times of physical files in a separate isolate. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2132073003 .
 2016-07-08 15:01:05 -07:00
danrubel 37a6f62566 fix code completion when enableTrailingCommas is true 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2128693002 .
 2016-07-07 12:42:30 -04:00
Konstantin Shcheglov dc42500408 Issue 26821. Don't add 'void' return type for setters when lint 'avoid_return_types_on_setters' is enabled. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26821

Review URL: https://codereview.chromium.org/2123333002 .
 2016-07-06 13:00:38 -07:00
Brian Wilkerson f3dc748db5 Add two memory usage benchmarks 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2111743002 .
 2016-06-30 07:44:41 -07:00
Brian Wilkerson 9c5213a077 Generalize DartSdkManager to support embedder SDKs 
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2107793002 .
 2016-06-28 13:48:57 -07:00
Konstantin Shcheglov 2cdaa62c98 Make LIBRARY_CYCLE, LIBRARY_CYCLE_UNITS and LIBRARY_CYCLE_DEPENDENCIES for library source. 
It seems to me that it uses only LibrarySpecificUnit.library anyway.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2094133002 .
 2016-06-27 08:43:59 -07:00
pq 270695fc31 Adds PID to server.connected notification (#26744). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2088663004 .

Fixes: https://github.com/dart-lang/sdk/issues/26744.
 2016-06-21 16:00:27 -07:00
Jaime Wren b7aff9c72f Initial Bazel file resolver support. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2079873002 .
 2016-06-17 14:20:55 -07:00
Brian Wilkerson 5c97a88ddd Remove embedder locator from analysis context 
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2078993002 .
 2016-06-17 09:42:27 -07:00
Brian Wilkerson 2b522d50d0 Deprecate EmbedderUriResolver 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2076743002 .
 2016-06-17 07:44:02 -07:00
Jaime Wren 7f244c8d39 Deprecate FileUriResolver and RelativeFileUriResolver in source_io.dart, replace the usages with ResourceUriResolver(PhysicalResourceProvider.INSTANCE). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2060263006 .
 2016-06-16 11:14:03 -07:00
Brian Wilkerson 34a71429d9 Remove hook for setting a provider for an EmbedderUriResolver 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2075663002 .
 2016-06-16 10:28:40 -07:00
Florian Schneider 705e9e781d Fix more flakiness in pkg tests. 
I already fixed similar failures.

I recommend eliminating all uses of pumpEventQueue.

BUG=#26556
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2059503002 .
 2016-06-09 15:08:06 -07:00
Brian Wilkerson f183ec3a45 Fix equality between subclasses of Source 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2050083002 .
 2016-06-09 07:42:32 -07:00
danrubel 2d310f1e67 improve completions in closures and switch statements 
This addresses several situations where the parser interprets "as" as
part of an "as" expression, but the user is trying to enter the "async"
keyword or an identifier starting with "as".

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2034713004 .
 2016-06-06 08:09:44 -04:00
Konstantin Shcheglov a6b93661fd Fix two build failures - for typeProvider and findElement. 
TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2032893002 .
 2016-06-01 18:54:10 -07:00
Florian Schneider 2a6847de41 Make some pkg tests less timing-dependent. 
Testing should not depend on how long it takes to get a response from the
analysis server.

Depending on how long an analysis step takes, these tests will randomly fail
e.g. when run in -mdebug mode, or with other VM flags that change (i.e. slow-down)
timing (--trace-compiler, --optimization-counter-threshold=5"

There are probably more problematic places like this. I just fixed the ones that
I saw failing when running with --optimization-counter-threshold=5.

BUG=#26556
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2016993004 .
 2016-05-30 12:14:16 +02:00
pq fba5cbc425 Analyzer 0.27.4-alpha.9 (API fixes) (#26562). 
Restores `EmbedderUriResolver` API.

Addresses breakages in `dartdoc` and any other downstream dependencies.

See: https://github.com/dart-lang/sdk/issues/26562.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2021453003 .
 2016-05-29 06:57:42 -07:00
pq 53fe39137f Embedder support refactoring (phase 1). 
A bunch of changes to pave the way for emebdder SDK summary creation.

* Moves _embedder.yaml processing into the embedder SDK (out of the resolver).
* Changes EmbedderUriResolver to compose rather than extend a DartUriResolver.
* Fixes the wierd handling (dropping to add back) of `dart:` URIs.
* Fixes the incorrect overriding docs for `SDKLibraryImpl.shortName`.
* Updates embedder test to include a definition of `dart:core` in anticipation of adding some embedder SDK tests.

Some API work TODO in a follow-up CL (notably the way we check for the presence of embedders by querying the resolver is odd).

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2009303002 .
 2016-05-25 10:52:53 -07:00
Jaime Wren e3af3c8d76 Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the correct enum types in named arguments. 
BUG=https://github.com/dart-lang/sdk/issues/24759

Review URL: https://codereview.chromium.org/1989393002 .
 2016-05-18 12:08:17 -07:00
Konstantin Shcheglov 67a500e134 Issue 26460. Add Quick Fix for missing 'Function.call()' implementation. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26460

Review URL: https://codereview.chromium.org/1981353002 .
 2016-05-17 09:00:53 -07:00
Harry Terkelsen 1745ba77f5 fix all instances of "the the" 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1980573003 .
 2016-05-13 12:38:25 -07:00
Brian Wilkerson 44836f8538 Support the name analysis_options.yaml for analysis options files 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1975963002 .
 2016-05-13 07:33:06 -07:00
Konstantin Shcheglov 27650456d1 Improve completion after IfStatement. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1968883002 .
 2016-05-11 08:36:27 -07:00
Konstantin Shcheglov cd7b7fc018 More tweaks for 'for' completion. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1963323003 .
 2016-05-10 20:22:12 -07:00
Brian Wilkerson 3bf8b18680 More strong mode clean-up in server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1966453002 .
 2016-05-09 13:24:56 -07:00
Konstantin Shcheglov 522eaa9a80 Don't suggest types, getters, etc in 'for (Type ^)'. 
Variable names should be suggested there.

It does not work for the moment, I'll need to make changes into
VariableNameContributor. But NOT suggesting all the garbage - for me
thi is 90% of the full solution ;-)

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1960783002 .
 2016-05-09 12:30:15 -07:00
Konstantin Shcheglov cf71ab114b Suggest 'is' in 'if (x is^)'. 
So, we don't treat is as an expression start, and don't suggest
inappropriate 'while', 'await', etc or identifiers.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1958733002 .
 2016-05-06 14:36:43 -07:00
Konstantin Shcheglov 3775d92000 Suggest 'var' and 'final' in intializer of 'for'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1953893004 .
 2016-05-06 13:49:48 -07:00
Konstantin Shcheglov b73b82221e Fixes for completing 'for (var v in^)' and 'if (v is^)'. 
The 'if (v is)' will require more work - we somehow manage to suggest
'if', 'final', 'switch', 'while', but NOT 'is'. But at least identifiers
are now out.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1956813004 .
 2016-05-06 13:17:15 -07:00
Konstantin Shcheglov fef82ec1e8 Update mock SDK 'double'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1956443003 .
 2016-05-05 14:12:53 -07:00