1b9adcb502
[dds/dap] Normalise Windows drive letters to avoid missing breakpoints
...
See https://github.com/dart-lang/sdk/issues/32222 .
See https://github.com/Dart-Code/Dart-Code/issues/4149 .
Change-Id: I6f975734839ff7cad4d086d5363c0ab03390b966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258900
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-09-13 13:24:47 +00:00
70e8dc6ee4
[devtools] Ping browsers running DevTools before trying to reuse them
...
It's possible the browser has been closed but is in the SSE timeout period and therefore looks active. Ping it to see if it's actually responsive before deciding whether to reuse it or launch a new window.
Fixes https://github.com/Dart-Code/Dart-Code/issues/3966 .
Change-Id: I2fdcba036b8b63f7ab974e8fef5dd565c2917b64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257581
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-09-07 17:38:57 +00:00
94a64a01f6
[dds/dap] Handle duplicate breakpoints and failure to remove breakpoints
...
Fixes https://github.com/flutter/flutter/issues/111045 , along with another issue where multiple client breakpoints that map to the same VM breakpoint could cause an error during removal.
Change-Id: Ifb396b9cb9df4a0297a4b55b31494e229289191d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257962
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-09-07 13:50:27 +00:00
884cfae2c7
Make changes for internal debug
...
- Convert to google3:/// scheme and call `lookupPackageUris` for setting
breakpoints
- Return file:/// scheme URIs from DDS
Change-Id: If9a541be21f5830ec68dc39eb2f308f7ce90c5fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252782
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Helin Shiah <helinx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-07-28 18:30:10 +00:00
38dc6e7dc8
[dds] [dap] Ensure debug adapter shuts down on clean termination
...
Change-Id: I1baa77dd933a49c1df435ccc31eb6cf8995e3ff3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252660
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-07-25 19:18:49 +00:00
99f0fb5b70
Fix typos
...
Fixes #49364
TEST=ci
Change-Id: Ic643819c9cdd7b56690981b96b854b1e8d622fff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250160
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-07-12 19:35:22 +00:00
2a440e14f1
[dds] Include exception text in DAP StoppedEvent text field
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4039 .
Change-Id: Ibe362a3eaaea1ab9b6075501cb9a245d8daba737
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250745
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-07-07 13:15:01 +00:00
eb6aa221f0
[dds] [dap] Fix bug that tried to remove previously-removed breakpoints
...
Fixes https://github.com/flutter/flutter/issues/106369 .
Change-Id: I17fb46ad0ea0f30707ff6280f2e8269662e376f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249485
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-06-23 13:42:55 +00:00
51eed0cffd
[dds] Fix code generation for type references to simple types
...
Fixes https://github.com/dart-lang/sdk/issues/49268 .
Change-Id: Iaeda8271d8cb922511958a71cf1300ba64df16da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248605
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-06-17 18:26:09 +00:00
85700570f6
Fix typos
...
Fixes #49241
TEST=ci
Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-15 11:08:28 +00:00
ff08af36ce
[ package:dds ] Migrate devtools_observatory_connection_test to null safety
...
Fixes https://github.com/dart-lang/sdk/issues/49177
Change-Id: I7221386b64ade709114e793b2665beca0a4c8115
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247440
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2022-06-07 14:49:09 +00:00
d6665ae4cd
Reland "[ Service / DDS ] Add method that can return local paths"
...
This is a reland of commit a091ff7b27https://dart-review.googlesource.com/c/sdk/+/245040
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
> Commit-Queue: Ben Konyi <bkonyi@google.com >
Change-Id: I87433a410715393f853a6538dbfe67391e0c773b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246621
Commit-Queue: Helin Shiah <helinx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-06-01 21:22:34 +00:00
a8e6756c74
Revert "[ Service / DDS ] Add method that can return local paths"
...
This reverts commit a091ff7b27https://dart-review.googlesource.com/c/sdk/+/245040
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
> Commit-Queue: Ben Konyi <bkonyi@google.com >
TBR=bkonyi@google.com ,kenzieschmoll@google.com ,helinx@google.com
Change-Id: I59d7687ba722fb1f5c706196691fc8471fe862ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246057
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-05-26 18:46:39 +00:00
a091ff7b27
[ Service / DDS ] Add method that can return local paths
...
TEST=Check that a supplied URL conversion function is correctly applied when the `local` param is true.
Change-Id: Ibe80b6229c574c976379a519baca5d1904b684b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245040
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-05-26 17:45:39 +00:00
a6fcb56901
Fix typos
...
Fixes #49094
TEST=ci
Change-Id: I23cdcb5ad2fc83e5e91d80e34b66af186c0cb923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245820
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Slava Egorov <vegorov@google.com >
Reviewed-by: Slava Egorov <vegorov@google.com >
2022-05-24 09:10:51 +00:00
f6e025ed27
[dds] Unskip tests for checking devtools base href tags
...
Change-Id: Ic31344a65b04cb252aa661b2f9af411b5a148bd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243903
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-05-09 13:28:23 +00:00
5ee800b366
[dds] Fix potential test flake if test runs just happen to straddle midnight at exactly this time
...
Very unlikely, but happened in Flutter: https://github.com/flutter/flutter/issues/103215
Change-Id: Ic2acff02fcfe1f15b9ebbe371d6a9ec766ee9575
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243904
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-05-09 13:28:18 +00:00
5dafbb8889
[dds] Provide better error output for DAP protocol violations
...
See https://github.com/flutter/flutter/issues/99734 .
Change-Id: Idf23f745d0736db41a195fd5294b5f545c2a39a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240541
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-04-27 14:12:54 +00:00
db0d9b1852
[dds] Serve DevTools index page for extension-less requests to support UrlPathStrategy
...
Change-Id: I780e16b391dda6159c99b4844f6663dad02a98af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239082
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-04-25 14:12:13 +00:00
169365f953
Move pkg/dds to package:lints.
...
Change-Id: I614a826569fee248b72f973a863e758949c04932
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241146
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2022-04-14 22:44:33 +00:00
1771c55238
[ DDS ] Split DevTools server tests into smaller pieces
...
Should resolve timeout issues, particularly around server connection
tests
Change-Id: Ic06d1179b09a17497e38de9aa19549f66ff79d2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240180
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
2022-04-04 22:07:21 +00:00
d087f0334d
[ DDS ] Fix devtools_server tests on Windows
...
Fixes https://github.com/dart-lang/sdk/issues/48528
Change-Id: Iaa08d6ee409354eadc37d3beb98ea79b75575758
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239464
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-03-30 20:45:20 +00:00
8e90d6ac15
[dds] Fix deserialisation of env vars in DAP
...
Change-Id: Ia3da6d4abdfd41b4b4f6631fd82d8680ee1727b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239309
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-03-29 18:39:29 +00:00
0950d887be
[ package:dds ] Fix devtools_server_test flakiness
...
The test harness wasn't waiting on `CliAppFixture.onAppStarted` which
could cause an unhandled exception if the test cleanup started before
the target application finished initializing. This typically only
occurred while the test was running on a machine under load.
Fixes https://github.com/dart-lang/sdk/issues/48669
TEST=Locally while running under load (e.g., `stress -c 72`)
Change-Id: Ieb67e46f62c33101490899440574fb57fc0f8882
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238922
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-03-25 18:40:30 +00:00
b036052077
Reland "[ Service ] Update VM service message to not reference Observatory"
...
This reverts commit ee5837aa7ahttps://dart-review.googlesource.com/c/sdk/+/237741
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-03-17 23:15:57 +00:00
3f623c65b0
Split DevTools server tests up into two libraries
...
Change-Id: Ic394faee18547f3338fb36419defa45c6734d90c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236301
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-03-14 17:51:28 +00:00
167970dea7
Reland "Add DevTools Server test and test driver to DDS"
...
This reverts commit d0dff0e9ba02bff5bde2https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release/20638/overview )
>
> Original change's description:
> > Add DevTools Server test and test driver to DDS
> >
> > Bug: https://github.com/dart-lang/sdk/issues/48300
> > Change-Id: I3b72274d111489448a482d65eb7cc23a9f263edf
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233320
> > Reviewed-by: Ben Konyi <bkonyi@google.com >
> > Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
>
> TBR=bkonyi@google.com ,kenzieschmoll@google.com
>
> Change-Id: Iaca6b34a4e55ddd7b984b49821f3cc95337d696a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: https://github.com/dart-lang/sdk/issues/48300
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234114
> Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
> Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/dart-lang/sdk/issues/48300
Change-Id: I60ffd0e8a394353014408530d636c5918e517a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234861
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
2022-03-09 16:48:54 +00:00
ee5837aa7a
Revert "[ Service ] Update VM service message to not reference Observatory"
...
This reverts commit f9147d933ehttps://dart-review.googlesource.com/c/sdk/+/234325
Reviewed-by: Dan Field <dnfield@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2022-02-24 18:32:14 +00:00
d0dff0e9ba
Revert "Add DevTools Server test and test driver to DDS"
...
This reverts commit 02bff5bde2https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release/20638/overview )
Original change's description:
> Add DevTools Server test and test driver to DDS
>
> Bug: https://github.com/dart-lang/sdk/issues/48300
> Change-Id: I3b72274d111489448a482d65eb7cc23a9f263edf
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233320
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
TBR=bkonyi@google.com ,kenzieschmoll@google.com
Change-Id: Iaca6b34a4e55ddd7b984b49821f3cc95337d696a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/48300
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234114
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
2022-02-23 23:46:44 +00:00
02bff5bde2
Add DevTools Server test and test driver to DDS
...
Bug: https://github.com/dart-lang/sdk/issues/48300
Change-Id: I3b72274d111489448a482d65eb7cc23a9f263edf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233320
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
2022-02-23 21:09:04 +00:00
f9147d933e
[ Service ] Update VM service message to not reference Observatory
...
See https://github.com/dart-lang/sdk/issues/46756
TEST=Existing
Change-Id: Ib71bf00d667369d7438a4547ae444951ec0979df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233504
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-02-18 20:53:52 +00:00
ddadc8d7e4
[dds] Improve DAP test cleanup by retrying deletes where Windows may still have files locked
...
Fixes at least part of https://github.com/dart-lang/sdk/issues/48274 .
Change-Id: I3a31f8149d00729afe4d3c86ee38892ce90625c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231240
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-02-03 17:41:26 +00:00
0a5da6814d
[dds] Enable verbose output in DAP integration tests
...
See https://github.com/dart-lang/sdk/issues/48274 .
Change-Id: Ia2c0bed90e9f31b99a7074f397fc508abcf49071
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231301
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-02-02 17:54:10 +00:00
3b736b8460
[ package:dds ] Migrate package:devtools_server functionality under package:dds/devtools_server.dart
...
Will allow for us to remove dependencies on package:devtools_server in
various packages.
Change-Id: I055cc7bb05d5b4ce0071e3f88a71cb9596e76c74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228022
Reviewed-by: Kenzie (Schmoll) Davisson <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-01-18 22:42:05 +00:00
410a1fbec5
[dds] Attach file/line/col metadata to DAP OutputEvents for detected call stacks
...
Change-Id: Ia91f40aaf244d892d2ff5ffb0e4a1e47f8ad9068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228040
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-01-18 18:26:05 +00:00
05c1af4e42
[dds] Remove breakpoints/pause-on-exception and resume when detaching from an attached process via DAP
...
Change-Id: I650e98fb15278d3b9685cbd0430c683f91910f09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227300
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-01-11 17:57:54 +00:00
9f5ef6d5bc
[ DDS ] Move package:dds/vm_service_extensions.dart into package:dds_service_extensions
...
Reduces dependency complexity for tools which don't need the full
contents of package:dds
Change-Id: Ib9c5ce93eea72421f56114ab8a8efaa0dca6ae02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225240
Reviewed-by: Kenzie (Schmoll) Davisson <kenzieschmoll@google.com >
2022-01-10 21:11:33 +00:00
1096a554c6
[dds] Respond to launchRequest earlier, remove enableAsserts, fix test file name
...
Change-Id: I5182cb517476af05bfb9b0a9ca89c027cf9d1e04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224529
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-01-06 18:07:55 +00:00
0c071662a7
[ VM / Service ] Add support for streaming CPU samples with specific
...
user tags
TEST=cpu_sample_streaming_test.dart
Change-Id: Ia983217ae2a5da8c3252fafbed8197b4f4a20e2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224040
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-12-17 00:15:09 +00:00
ebe06b7ccd
[dds] Add support for additional VM args in DAP
...
Change-Id: Ib5c17e4f1881b3ca2c0fec72cc93178aaada3f60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221800
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-12-02 17:16:07 +00:00
167f83a46b
[dds] Add support for passing environment variables to DAP launches
...
Change-Id: Ie8f9e00d14cb04719b39238a669d86e9540d8189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221941
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-12-02 17:14:07 +00:00
66d2bbab07
[dds] Add a "customTool" option to DAP to allow overriding the dart tool
...
Change-Id: I5842b85d34af288ad48f4c019bd3cd5cef498487
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221625
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-12-01 17:27:16 +00:00
08db718290
[dds] Resolve dart: URIs to SDK file paths and back again in DAP
...
This fixes two issues:
1. When a user navigates into SDK sources using the analyzer (Go-to-Definition) and sets a breakpoint, we map it to a URI that the VM understands
2. When the VM breaks inside an SDK source, we map it back to a local file path (so that the user doesn't end up with two versions of the same file - one downloaded, and one the analyzer sent them to)
Change-Id: Ic1bdbed29196f98e612d81c383ad31ce241446b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221082
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-11-30 16:46:55 +00:00
46f9ae9568
[ VM / Service ] Stream light-weight version of CpuSamples for CPU
...
profiler events.
`Event.cpuSamples` is now a `CpuSamplesEvent` rather than a `CpuSamples`
object, where `CpuSamplesEvent` returns `(@Object|NativeFunction)[]` rather
than `(@Func|NativeFunction)[]`, resulting in a smaller JSON payload.
TEST=get_object_rpc_test.dart,get_cached_cpu_samples_test.dart
Change-Id: I1ad5e3df8840b8c41735d10c6c8669f6503e54a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219284
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2021-11-18 19:45:26 +00:00
51df1855ff
[dds] Add DAP support for 'hotReload' custom request that calls reloadSources
...
Change-Id: I413cd9ce8f72e97d14a3fb7762f98833a5991a1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219793
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-11-15 15:42:02 +00:00
8809779d80
[dds] Handle "Service Disappeared" errors from DDS/VM Service during shutdown
...
Change-Id: I1ddc59c56778461d5f42b210422eb24ba2f6da7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220005
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-11-11 18:03:41 +00:00
d041cf0478
Remove extra the, be and of
...
Fixes #https://github.com/dart-lang/sdk/issues/47504
TEST=No tests needed, only comments affected.
Change-Id: Ie096307b5ce314d328fea6780f396aaa226ad3b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216182
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
2021-10-20 09:29:01 +00:00
1bfa0bb8dd
[dds] Wrap DAP dart.log message in an object for future extensibility
...
Change-Id: Ifbff825751f7456645b28f23684447e1271e4ece
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216290
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-10-12 15:17:00 +00:00
df67dc892b
[dds] Add some basic test reporting for DAP test adapter
...
Change-Id: I39ca29ee5809fd0d6ef30ee163298f66749bed0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215080
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-10-01 16:31:34 +00:00
b8533e6b09
[ package:dds ] Fix issue where cancelling multiple streams with the same name would throw a StateError
...
Fixes https://github.com/flutter/devtools/issues/3302
TEST=test/regress_devtools_issue_3302_test.dart
Change-Id: Ica0665c8a48cdb881ecdf7e3985660513c4b98b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214662
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-09-27 16:35:53 +00:00
Danny Tuppeny