Commit Graph

106575 Commits

Author SHA1 Message Date
Mayank Patke de0845503b Reland "Point sdk/bin/dart to .../dart-sdk/bin/dart"
This is a reland of commit 0dd150bd27

Original change's description:
> Point sdk/bin/dart to .../dart-sdk/bin/dart
>
> Change-Id: I9ec75d2f4c8695448db922b57c2980715d6ef3f0
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417702
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Auto-Submit: Mayank Patke <fishythefish@google.com>

Change-Id: Ib29d6100d6f86aa5efcfe87d4cbc56796ee00667
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420360
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2025-04-03 15:25:20 -07:00
Mayank Patke 4d88caca09 Remove babel from third_party
Change-Id: I2b7aaff12477552ab9490deeeb31e2179897968b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420281
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2025-04-03 15:22:27 -07:00
Ömer Ağacan 26a065c60d [wasm_builder] Update names of instructions extern.internalize/externalize
These instructions were renamed to any.convert_extern and extern.convert_any in
Wasm GC spec commit:
https://github.com/WebAssembly/gc/commit/5bca3f7de6ad117a0d4349c138b5e32981c88d2f

Change-Id: Ie696541f75974c69828fb317754e3b613691eb4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420141
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
2025-04-03 14:24:31 -07:00
Mayank Patke 8cb4d3c981 [dart2js] Remove _CanonicalizedTypeMaskKey and use record
Since #60419 is fixed by https://github.com/dart-lang/sdk/issues/60419,
we should be able to use record keys again.

Change-Id: I1256d74e80e135b0ba2a38c64c42e0463964baaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419986
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2025-04-03 14:06:04 -07:00
Konstantin Shcheglov de3f423952 Elements. Return ExecutableElementImpl2 from ExecutableElement2OrMember.baseElement
Change-Id: I2878d65f04e5e1c6fe0e3f6691fedf4532e16d55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420260
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-03 13:58:30 -07:00
Konstantin Shcheglov 241ba78af4 Fine. Remove unused libraryUri / name.
I added them speculatively while working on initial version, and
did not actually use for anything.

Change-Id: Ib2bcb3ac5c16634392e956bd2dc6e99523f27479
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420163
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2025-04-03 13:58:00 -07:00
Brian Wilkerson 3cabc9a44f Minor cleanup in the message scheduler
Rename a couple of fields so that their purpose is more clear.

Enhance a few comments to record information I had to work to discover.

Change-Id: I9f9daa623ee4d2885d9831b59c40cccb7ab50ff7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420183
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2025-04-03 13:35:33 -07:00
Srujan Gaddam 9bc0d51467 [ddc] Compute js_util method regexes only once
sra@ noticed that we're recreating this RegExp every time
and we could just compute it once and store it in a static
field instead.

Change-Id: Iab2875d12295f0dc084aa1f0fb5e649b28c73c3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420165
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
2025-04-03 13:34:17 -07:00
Konstantin Shcheglov 65a5ed2c09 Fine. Use tokens and elements for constant expressions.
Extends `ManifestElement` to support not only top-level elements, but also members.

Change-Id: Ia714c4f23113883bac6d6b44ede3c1dfecbbb80d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419989
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-03 12:42:47 -07:00
Konstantin Shcheglov 8bfe452ffd Fine. Use shared ManifestItem.write()
Change-Id: Ic8a6ec5ca4d817655a5186286b64bebb949928f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420182
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-03 12:09:20 -07:00
Konstantin Shcheglov 051af8487d Fine. Rename of methods in LibraryManifestBuilder.
So,  that we better reflect what container, and what executable kind
we handle.

Change-Id: I69b0a5f1aef2bb408fea6abc75f42d305d7864aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420181
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2025-04-03 12:04:54 -07:00
Konstantin Shcheglov e5b8a944eb Fine. Support for isStatic in InstanceItemMemberItem.
Change-Id: I818a3f5aa27f6d447c6bc75092dd0996756cdd28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420162
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2025-04-03 12:01:17 -07:00
Paul Berry 08154451d5 [_fe_analyzer_shared] Use TypeAnalyzerOptions to configure flow analysis.
Previously, flow analysis was configured by passing a set of named
booleans to its constructor, each to enable or disable a separate
language feature.

This change merges the flow analysis configuration with the
`TypeAnalyzerOptions` class (which was already being used for
configuring the shared `TypeAnalyzer` class). This should make it
easier to add language features to the shared code base in the future,
since there will be one common place where all features will be
configured.

To avoid duplicating the logic that creates `TypeAnalyzerOptions`,
I've had to do a bit of minor surgery to the clients:

- In the test harness in `_fe_analyzer_shared`, there is a common
  method (`Harness.computeTypeAnalyzerOptions`) that constructs
  `TypeAnalyzerOptions` based on the harness configuration. It is
  called from a few different tests.

- In `pkg/analyzer`, there is a common method
  (`computeTypeAnalyzerOptions`) that constructs `TypeAnalyzerOptions`
  based on a `FeatureSet`. It is used by
  `LibraryAnalyzer.analyzeForCompletion`,
  `LibraryAnalyzer._resolveFile`, and the late variable
  `AstResolver._typeAnalyzerOptions`.

- In `pkg/front_end`, I've moved computation of `TypeAnalyzerOptions`
  from the `InferenceVisitorImpl` constructor to the
  `TypeInferrerImpl` constructor; the options are then passed to the
  `InferenceVisitorImpl` by `_createInferenceVisitor`.

I'm doing this work now as preparation for adding support for sound
flow analysis (https://github.com/dart-lang/sdk/issues/60438), so that
I can add the logic to enable it in a clean way.

Bug: https://github.com/dart-lang/sdk/issues/60438
Change-Id: Ib845194adb404b4c0a3feeff17a14ae641d515eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2025-04-03 11:56:51 -07:00
Devon Carew 437bf924a7 [deps] rev core, dartdoc, http, i18n, protobuf
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/a6e81e0..7a80178):
  7a80178c  2025-04-03  Moritz  Add `CODEOWNERS` file (dart-lang/core#877)

dartdoc (https://github.com/dart-lang/dartdoc/compare/cbc1885..62aefbb):
  62aefbb7  2025-04-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/dartdoc#4029)

http (https://github.com/dart-lang/http/compare/e988925..32d5ffc):
  32d5ffc  2025-04-02  Moritz  Merge pull request `#1745` from dart-lang/revTo3
  1cc17f8  2025-04-02  Moritz  Merge pull request `#1743` from ueman/readme-fix
  4afc7f4  2025-04-02  Moritz  Add changelog entry
  c18d55d  2025-04-02  Moritz  Fix CI
  0e094cc  2025-04-02  Moritz  Update to Dart `3.7.0`
  2132038  2025-03-31  Jonas Uekötter  Update README.md

i18n (https://github.com/dart-lang/i18n/compare/2701040..de19436):
  de19436  2025-04-02  Moritz  Add `CODEOWNERS` (dart-lang/i18n#961)

protobuf (https://github.com/dart-lang/protobuf/compare/cf4f3a8..1aaa332):
  1aaa332  2025-04-01  dependabot[bot]  Bump actions/cache from 4.2.2 to 4.2.3 (dart-lang/protobuf#972)

Change-Id: I183a6f902b8620e685f957f6a3d7d27e8bfcef4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420161
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2025-04-03 11:08:40 -07:00
Konstantin Shcheglov 708baa47b4 Fine. Make ManifestType generative constructors private, make encode() factory constructors.
Change-Id: Id8416b46c43c6d62fa7d5326c9ab017cfbc127b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420180
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-03 10:24:49 -07:00
Konstantin Shcheglov 713065de57 Fine. Rename InstanceItemMemberItem subclasses.
Previously InstanceMemberItem was confusing, because it could be read
as instance vs. static, when actually it is InstanceElementImpl member.

Change-Id: I0abf135638b18b205e6af1d243364ae9aca81239
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420160
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2025-04-03 10:24:13 -07:00
FMorschel cc4c1ac367 [DAS] Go to Super handles field declarations
Fixes: https://github.com/dart-lang/sdk/issues/60465
Change-Id: I8b9e0231d3e7f6e7d9b75fdcf6b16311d470a7fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420120
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
2025-04-03 09:46:58 -07:00
Konstantin Shcheglov b067916bd9 Elements. Fix for MultiplyDefinedElementImpl2.asElement
Bug: https://buganizer.corp.google.com/issues/408176818
Change-Id: Ib35ecf5c7d33a962d164a74b8c7292716e142130
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419927
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-03 09:43:09 -07:00
Chloe Stefantsova 001e0e6397 [model] Make null-guarded lowerings of cascades type safe
Change-Id: I035380abdb951a48110029ae93f965ad8bf83093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420100
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
2025-04-03 08:47:13 -07:00
Kevin Moore 94eb611a9a [io] Update doc comments for HttpClientCredentials
Test=docs only change

Change-Id: I51527c82f4ee3204897db64e5d24ee164212d553
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419987
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
2025-04-03 08:18:59 -07:00
Ivan Inozemtsev 2d80285a45 SDK Cache fixes for dartdev cross compilation
- Use `signed` stage only for executables (dartaotruntime is not signed)
- Ensure user-executable bit only for executables
- Fix Windows path issue (https://github.com/dart-lang/sdk/issues/60462)

Change-Id: I012c6df34174e292979610dabf1e9a5f486ef39e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420101
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
2025-04-03 06:50:10 -07:00
Johnni Winther dced5e0482 [cfe] Add LocalTypeParameterScope
This cleans up the LocalScope interface and the handling of named function expressions.

Change-Id: Id0432910a9e65d8ae966dfab67c66248639d241a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419842
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2025-04-03 03:43:30 -07:00
Kevin Moore bdf0f64b2f [io] http_impl cleanup
Turned _AuthenticationScheme into an enum
Made a few fields in _Credentials final

Test=no behavior change

Change-Id: I14f31182d3434aaf0d7292c932b8da278f13d57b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419926
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
2025-04-02 16:41:25 -07:00
Ryan Macnak 174acd490d [vm] Print some resource usage and limits when pthread_create fails.
TEST=ulimit
Bug: https://github.com/flutter/flutter/issues/164591
Change-Id: Ica782d6e9dbf8da3017f6cf65196564bbed40f2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419988
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2025-04-02 15:49:11 -07:00
Daco Harkes 4463abc509 [doc] Fix GSoC deadline typo
Change-Id: I5f90a943c5acdb4372cf2e53de3a572008ec5e8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419881
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
2025-04-02 15:42:16 -07:00
DEPS Autoroller 055ba0a9cb Roll Fuchsia SDK from 27.20250327.3.1 to 27.20250402.4.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: Ie10fa769354b3d4933040c6e37f4568ef7f0afe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420000
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2025-04-02 14:16:21 -07:00
DEPS Autoroller d8fcc3ac77 Roll BoringSSL from c86127e656ae to e68438b863af (1 revision)
https://boringssl.googlesource.com/boringssl.git/+log/c86127e656ae..e68438b863af

2025-04-02 davidben@google.com Fix comment on bn_div_rem_words and use MSVC instrinsic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: I1cf43ff686b9241ce154235a5eb597828d912d4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420040
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2025-04-02 14:11:30 -07:00
Konstantin Shcheglov e10122923e Fine. Include initializer of const top-level variable.
Change-Id: Ife91f61722f7b3d0279402868a820a54fc569cdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419985
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2025-04-02 14:08:18 -07:00
Konstantin Shcheglov 45a088f306 Fine. Include even private elements into manifests.
While only some elements can be referenced in constants
in valid code, still other elements might somehow affect public
elements. I think we will get more robust implementation, if we put all elements, including private into manifests. I don't want to guess: can this affect constants, or not?

The performance different is about 6% on computing library manifests on analyzer/ + analysis_server/ + linter/. And computing initial set of manifests itself is 5% of total work, so it is about 0.3% total slowdown.

Also adds static getters and methods to make it more representative.

Change-Id: I8994b8f84befbce695fd48fc657e4350109f6cfe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/418720
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2025-04-02 14:03:00 -07:00
Konstantin Shcheglov f7edb90991 Fine. Add ManifestNodeIntegerLiteral.
Also adds read/writeInt64() helpers.

No tests, because we don't have enough functionality, e.g. writing
constant variable initializers to test it with.

Change-Id: I677f988e8580cf6f290fd7c866ee8ef91821b110
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419925
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-02 13:38:58 -07:00
Alexander Aprelev e0dc78bbf6 [vm/oom] If unable to create OOM stack trace, report OOM without stack trace.
Fixes flaky out_of_memory tests failures.

BUG=https://github.com/dart-lang/sdk/issues/60453
TEST=ci

Change-Id: I5c9192c6cc25660e83f6c03d4293360c353b02d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419583
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2025-04-02 13:09:52 -07:00
Konstantin Shcheglov 5ee30689bf Fine. Assert LibraryManifest serialization, for all libraries.
Change-Id: Ic8ee0c30a5d701e321f70f044e1a09f21dcfcb5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419980
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2025-04-02 13:01:30 -07:00
Ryan Macnak 383cd496ce [vm] Use dlopen for loading AOT snapshots on Fuchsia.
This will play better with native tooling compared to Dart_LoadELF.

Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-arm64-try,vm-fuchsia-release-x64-try
Change-Id: If5265d079200d7be754b82a9775d977aa66c15f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419684
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zijie He <zijiehe@google.com>
2025-04-02 12:46:55 -07:00
Kallen Tu a94645962e [cfe] Dot shorthands: Constructor type parameters are inferred in the empty context.
Fixes https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Static-access-shorthand/type_inference_A07_t01.dart and https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Static-access-shorthand/type_inference_A07_t02.dart.

This CL changes the following behaviour according to the spec -- In case of a constructor invocation, the shorthand expression is inferred in the empty context.

Bug: https://github.com/dart-lang/sdk/issues/59758
Change-Id: Ia849888f1a810df7390a35e454a09f3fed458849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417960
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
2025-04-02 12:44:23 -07:00
Konstantin Shcheglov 474673fdc0 Fine. Rename ManifestNode subclasses.
Change-Id: I2baa6f448635a78bb36b121aba2b64f599e96ee1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420020
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-02 12:31:18 -07:00
Konstantin Shcheglov b0c6d970f0 Fine. Extract ManifestMetadata.
Change-Id: Ie51333b75a7ac67d1befa8906b133fcb3d9f37df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419984
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-02 12:26:29 -07:00
Konstantin Shcheglov 0fb8a42af9 Fine. Support for top-level setters.
Many existing manifest tests involving top level variables were changed to use `final` variables, so that the test expectations don't need to contain distracting references to top level setters.

Change-Id: I5a641c2d446f366435a127d66e951d78d784d0b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419983
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-02 12:17:39 -07:00
Konstantin Shcheglov b2d139ba7d Elements. Move elementModelDeprecationMsg to src/.
Change-Id: Ia71ffd60041890536e28635be981e4c9c7a249ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419981
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-02 12:16:51 -07:00
FMorschel 5d27e4f5bf [DAS] Fixes occurrences for extension and type parameters
Fixes: https://github.com/dart-lang/sdk/issues/60449
Change-Id: Ie862deea3d3d37890f1f610c7c83509fe82b2a40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419423
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
2025-04-02 11:28:40 -07:00
Ryan Macnak d4cb7a4f21 [vm] Fix COPY_FP_REGISTER for Windows x64, arm, arm64.
This should improve DumpStackTrace from assertion failures, though x64 still doesn't work for lack of frame pointers in the runtime code.

TEST=manually add assertion failure.
Change-Id: Ie632f79b21fd14a2ece3cde23736adc097938315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419800
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2025-04-02 11:20:48 -07:00
Stephen Adams c5adfd2d3e [dart2js] Trust refined types from Dart type promotion
Using the promoted type reduces the need for primitive receiver and argument checks, and can result in better code.

The promoted type is 'used' by inserting pinned HTypeKnown instructions at the use site. The pinning can constrain code motion. Better inference in the optimizer (https://github.com/dart-lang/sdk/commit/9505e957e1770cc4f15a70f6ab1fc9b1cc73723d) relaxes most of these constraints.




Change-Id: Ic9c0ebe7fd95b60382e2f66c49f69440b8b881d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419484
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2025-04-02 11:09:52 -07:00
DEPS Autoroller 4464f61e62 Roll BoringSSL from a9993612faac to c86127e656ae (1 revision)
https://boringssl.googlesource.com/boringssl.git/+log/a9993612faac..c86127e656ae

2025-04-01 victortan@google.com Change to use ALPS new codepoint as default

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-vm-gardener@grotations.appspotmail.com
Change-Id: I4323852d4198ead90594ce15a731facab5264de3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419462
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2025-04-02 10:29:08 -07:00
Konstantin Shcheglov 68b060e76b Fine. Verify write/read roundtrip for LibraryManifest.
Fixes for found bugs.

Change-Id: I873e43277b620afc3b712dcac1ace915991edf85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419685
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-04-02 09:37:28 -07:00
Kevin Moore dc7e9dac2e lib: drop unnecessary new and const
CoreLibraryReviewExempt: no API changes
TEST=no behavior changes
Change-Id: Ibef80bbfb000026042e562014b672258a5f1860d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419761
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2025-04-02 09:28:41 -07:00
Mehdi Hassan b18df098e7 docs(Dart-GSoC-2025-Project-Ideas): update GSoC 2025 application status
Closes https://github.com/dart-lang/sdk/pull/60460

GitOrigin-RevId: ae91b4b4af963f8c3a9c3fc067f0ab244766f4fa
Change-Id: I57fc88bc94ed3b3d3653137848e1aa6e5b6efb76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419921
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
2025-04-02 09:14:16 -07:00
Danny Tuppeny 5803acf31f [analysis_server] Update plugin tests to work through test runner
This removes a use of `Platform.script` so the tests work through the test runner. It also extracts some common code between this and the other integration tests to remove some duplication.

Change-Id: Ia9d441424789ea99decb071f7fdc6c71c8e54a72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419860
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2025-04-02 09:06:09 -07:00
DEPS Autoroller 853654d596 Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Fuchsia Test Scripts: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: I33a726f4bce351bd814de4af3158542b2fe2e6b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419447
Reviewed-by: Zijie He <zijiehe@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2025-04-02 08:39:31 -07:00
Alexander Markov af1be1fc13 [dynamic modules] Fix dynamic interface for dynamic_modules_suite/override_extra_params test
Fixes https://github.com/dart-lang/sdk/issues/60456

Change-Id: Id59dd0f82959ccefe35f6430b9d3548540d2824f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419900
Commit-Queue: Nate Biggs <natebiggs@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
2025-04-02 08:22:38 -07:00
Sam Rawlins 30a9f13794 DAS plugins: document assists
Change-Id: I2c50f36111cc319a85ad1a09369bcbdda14416d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2025-04-02 08:16:49 -07:00
Ivan Inozemtsev 9c88769967 Dartdev cross compilation support
- Add `target-arch` option to `dart compile exe|aot-snapshot`
- Add artifacts cache in `~/.dart`, and download gen_snapshot and
  dartaotruntime from cloud storage if necessary

I've manually built an aot snapshot and exe on macOS ARM64 for Linux
X64, copied them over to a linux machine, and made sure they work.

Change-Id: I74dd581ecb573ff4069a2fe19f9d04aaa352538e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417801
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2025-04-02 08:14:28 -07:00