b9116653bd
Modify dartanalyzer scripts to look more like dart2js scripts.
...
The dartanalyzer script (and its Windows companion, dartanalyzer.bat)
now support:
- Executing from snapshot if present, otherwise from source (needed
for buildbot tests).
- Passing in the appropriate package root when executind from source.
- Passing in VM tuning parameters to speed up analysis.
- Passing through extra DART_VM_OPTIONS to the VM.
Also, the old editor/tools/analyzer script has been removed and
the test infrastructure now uses sdk/bin/dartanalyzer, in the
same way that it works for dart2js.
R=ahe@google.com , johnniwinther@google.com , ricow@google.com
Review URL: https://codereview.chromium.org//628363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41150 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 14:21:37 +00:00
6650aeb3d6
Clean up test_runner Command subclass hash/equality.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//645533002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41037 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-10 12:05:52 +00:00
b21c902607
Add support in test scripts backend for simple HTML tests.
...
BUG=dartbug.com/20698
R=ricow@google.com
Review URL: https://codereview.chromium.org//632283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40956 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 15:29:39 +00:00
33e51a5295
Update co19 test suite to r786.
...
R=kustermann@google.com , ricow@google.com
Review URL: https://codereview.chromium.org//621753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40832 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-01 09:36:32 +00:00
7efd38d195
Start implementing checked mode compile time errors in analyzer.
...
This enables the Java-based command-line analyzer to accept the
"--enable_type_checks" flag so that it can be told whether to report
type checking errors during constant evaluation. Also it fixes the
tests language/compile_time_constant_checked2_test and
language/compile_time_constant_checked3_test in unchecked mode, by
causing CONST_FIELD_INITIALIZER_NOT_ASSIGNABLE to be escalated to an
error only in checked mode.
Note: in order to test this properly, I had to remove a hack from
test_runner.dart which caused it to effectively ignore the "checked
mode compile-time error" test annotation when testing analyzer. With
this hack removed, several new lines needed to be added to the .status
files.
BUG=dartbug.com/16391
R=jwren@google.com , kustermann@google.com
Review URL: https://codereview.chromium.org//610863004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40780 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-29 18:59:14 +00:00
94e1160661
Add PKGTestSuite that will be used for package waterfall testers.
...
This is based on the standard test suite but we specialcase html files.
There is another html file aproach currently being done by whesse@ that we may be able to utilize when it is done instead.
R=sigmund@google.com
Review URL: https://codereview.chromium.org//567803004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40255 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 17:16:35 +00:00
4acbe3d75a
Find pub status file in right directory.
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org//561893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40123 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 22:38:24 +00:00
13e1c5d54b
Allow trailing / in directory paths
...
I run into errors as soon as I use tab completion and include a trailing slash
in the suite_dir, this help a bit.
R=ricow@google.com
Review URL: https://codereview.chromium.org//560643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40093 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 15:37:49 +00:00
17c1642748
Store the async-await compiled pub code directly in the repo.
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org//557563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40041 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 16:55:16 +00:00
8bfaae17ea
Add package-root option to the testing scripts
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//552443003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39971 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 15:44:45 +00:00
f9b0a27ee9
test.dart: Serve the browser test driver page from the test file HTTP server.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//540933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39907 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 11:01:26 +00:00
46043093af
Move js library back into compiler directory.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//538513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39870 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 13:49:30 +00:00
94f0a3f3fd
Refactor testing http server in test.dart.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//539493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39867 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 12:58:19 +00:00
2ccac8093b
Add language tests for Issue 18628.
...
As suggested by @karlklose in https://codereview.chromium.org/513563002/
comments.
Improve testing documentation.
- add a README
- add a description by example of selectors to the "./tools/test.py -h"
output
- update/add source comments
I had a hard time figuring out how to add and run the tests, mostly
because I tried to call them "*_test_1.dart" and "*_test_2.dart", but
language test files must have names of the form "*_test.dart". So, I
added a README summarizing and referencing the relevant docs.
R=brianwilkerson@google.com , karlklose@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//521773003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39822 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 18:51:25 +00:00
3331fd5366
Put selector generation for the suite_dir runs in the same place as the other selector expansion
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//530363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39796 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 08:12:39 +00:00
8327e55137
Support passing in a test suite directory through a flag to the testing scripts
...
This will allow us to setup testing that mirrors what we currently have even with the packages moved to github.
R=whesse@google.com
Review URL: https://codereview.chromium.org//527053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39735 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 05:20:34 +00:00
7060865fa4
Pass --enable-async to the analyzer
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//517533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39662 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 16:45:02 +00:00
48065a1f91
Update test scripts to run under the Dart 1.6 vm.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//483353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39443 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-21 09:30:10 +00:00
8f54a8b5bd
Update CO19 test suite to r761
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//487603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39367 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-19 11:33:27 +00:00
1d73d2c30c
Test scripts: Detect and report error in accessing window.parent in browser_controller.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//472883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39249 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 15:31:33 +00:00
e89bd4ab1d
Try running ie10 in a new window instead of an iframe.
...
We are seeing issues where it seems that we are getting unittest-suite-success messages out of the blue and this may be related to:
https://code.google.com/p/dart/issues/detail?id=17825
This could be the old javascript still running in the iframe posting the event.
R=whesse@google.com
Review URL: https://codereview.chromium.org//477613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39245 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 12:36:54 +00:00
4431b50125
Browser testing: Run android content shell tests on hosts with multiple devices connected.
...
The adb_reverse_forwarder.py script in [dartium]/build/android/ needs the --all-devices option added. We will also try to upstream this flag to chromium.
This change makes the test host reinstall the ContentShell apk on the device each time the device is restarted due to timeout or periodic reset, which takes about 10 seconds, but this is simpler and more like the existing behavior with android chrome.
R=ricow@google.com
Review URL: https://codereview.chromium.org//467643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39142 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 14:40:26 +00:00
cbe97f9ea6
Don't use io prefix in test_suite.dart
...
Review URL: https://codereview.chromium.org//456373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39072 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 11:09:26 +00:00
e675541f42
Use rmdir to delete pkgbuild directories on windows
...
We are seeing issues with this all the time. I validated that this works on my windows box (and our current setup does not)
It sucks that we need to us runInShell, but rmdir is not part of the normal path (i.e., "where rmdir" says it can't find it, but e.g., "where xcopy" works fine)
Review URL: https://chromiumcodereview.appspot.com//462523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39071 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 10:41:25 +00:00
5886a0a997
Add the vmservice testing to the default test selector
...
Review URL: https://codereview.chromium.org//452833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39023 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 08:11:52 +00:00
d7c294b4e2
Remove observatory symlink from the repository - they have unforseen issues when copying around stuff for testing.
...
Long storry short: for testing the ability to do pub get and pub build we copy in the packages and test them if they have a pubspec yaml file.
If you copy a symlink, like the one added in r38788, without -L to cp you will just get the relative symlink copied in, which will, of course, not work.
I generally think it is a bad idea to add symlinks to the repo, we have had enough issues with the ones for packages/pub
Instead, to keep the testing, add the runtime/bin/vmservice to the location of where we look for packages
R=koda@google.com
Review URL: https://codereview.chromium.org//434883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38983 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 12:59:35 +00:00
75e14b393a
Test infrastructure: Avoid restarting browser app on Android twice simultaneously.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//442673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38898 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-05 14:01:23 +00:00
60a9ad6c0b
Reland r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime"
...
This was reverted in r38002, because it didn't seem needed. It now looks like it will make the builder more stable.
Original CL: https://codereview.chromium.org/363323002/
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//439713006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38866 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 16:25:47 +00:00
be4ebbe937
Add --dart2js-options flag to test command
...
Example:
tools/test.py ... --dart2js-options='--dump-info' ...
will run the dart2js compilation step with --dump-info
R=ricow@google.com
Review URL: https://codereview.chromium.org//435603005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38836 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-01 17:05:41 +00:00
769782b5d4
Fix CSP mode of the polymer compiler. Turns out that inline Javascript <script>
...
tags are also not allowed (unless you have unsafe-inline). This fixes our build
to extract code for those script tags as well.
R=blois@google.com
Review URL: https://codereview.chromium.org//424213004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38707 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 22:11:56 +00:00
c7d5711688
Build Tools Cleanup
...
Cleans up Python Code in Build Tools
TEST: build everything and run tests
BUG: https://code.google.com/p/dart/issues/detail?id=19592
R=ricow@google.com
Review URL: https://codereview.chromium.org//350483003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38573 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-25 11:47:59 +00:00
9f85c90367
Make ie11 use a fresh window again
...
Review URL: https://codereview.chromium.org//379923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38088 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 16:36:54 +00:00
53899b43a9
Add file-filter flag to polymer deploy
...
Use the filter to not copy in files from .svn directories when doing deploy
Please feel free to do this in another way and throw this away - I just want us to get moving on this.
Review URL: https://chromiumcodereview.appspot.com//372983006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38077 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 05:21:46 +00:00
33ed771f0a
Don't use new windows for ie11
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//377493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38023 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-07 11:10:35 +00:00
bb59b9fa85
Revert r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime. Update test status for ContentShellOnAndroid."
...
This reverts CL https://codereview.chromium.org/363323002/
We found that the flaky timeouts are real renderer crashes, and this change does not seem to help. We will instead report more data on the renderer crashes.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//373453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38002 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 09:19:08 +00:00
419bf8df29
Add periodic browser restart to ContentShellOnAndroid test runtime. Update test status for ContentShellOnAndroid.
...
BUG=dartbug.com/19127
R=kustermann@google.com
Review URL: https://codereview.chromium.org//363323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37983 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 12:59:59 +00:00
edcdb5e02d
Update co19 test suite to r737
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//330633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37305 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-13 08:15:06 +00:00
e3f564fb6c
Changes for running tests on arm64 hardware.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//311413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37046 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 18:43:55 +00:00
5e8288d086
Once again, seems that there are still tests failing with 59 chars. Seems that
...
is the longest we got in the bots thus far.
Review URL: https://codereview.chromium.org//300973004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36773 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 22:20:43 +00:00
37a3ab9189
Code review changes for r36718.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//303693006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36765 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 20:37:43 +00:00
702986dc4b
Fix again long paths in windows - seems that we had an off by one error in this
...
check.
Review URL: https://codereview.chromium.org//307693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36761 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 20:05:58 +00:00
b8e0779330
Patch long names in polymer/e2e_test/... (updates test_suite.dart)
...
R=jmesserly@google.com , ricow@google.com
Review URL: https://codereview.chromium.org//305633003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36755 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 18:14:18 +00:00
9c43b077fb
Don't run tests against pinned barback versions in third_party.
...
These packages are kept around to ensure that pub continues working
with historic barback versions, but pub's test suite handles loading
and testing against them manually. Other test suites (pkgbuild in
particular) can safely ignore them.
TBR
Review URL: https://codereview.chromium.org//306603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36718 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 23:05:18 +00:00
c5a9af1d62
Send data with 404 response
...
The primary reason is to work around http://dartbug.com/19024 , but this is not a hack or temporary code.
R=ricow@google.com
Review URL: https://codereview.chromium.org//301683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36675 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 13:30:49 +00:00
6da681a7f4
Add dart2js batch mode support
...
This removes an old map from runtimes to executables that is no longer needed and instead assumes a ProcessCommand that has an executable.
The added benefit of this is that it works with --use-sdk (and there are less code to maintain)
The flag to enable dart2js batch mode is temporary until we can switch the default.
When we can, this can go away and we can reuse the noBatch flag (which defaults to false)
R=whesse@google.com
Review URL: https://codereview.chromium.org//305453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36628 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-26 11:03:03 +00:00
6fc4ef13a6
Fix logical error in r36299
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//295603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36301 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 15:01:37 +00:00
dae3c92848
test.dart: Handle checkout paths containing spaces.
...
Change TestUtils to correctly convert from a URI to a file path, and
simplify the setting of the path to the Dart checkout.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//282173004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36299 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 14:30:26 +00:00
cad8fc591c
Add additional case where we use the use-dart2js-libraries flag in test.dart.
...
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org//283223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36224 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 15:27:19 +00:00
3a51e6bf88
Update test.dart to tell the analyzer to use the --use-dart2js-libraries flag when analyzing dart2js libs.
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//286883004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36189 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 20:34:43 +00:00
2146126308
Fix bug on arm64.
...
Also increases test timeout to match simarm and simmips.
R=regis@google.com
Review URL: https://codereview.chromium.org//283833005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36175 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 16:56:12 +00:00
paulberry@google.com