Commit Graph

27545 Commits

Author SHA1 Message Date
vegorov@google.com dde7963d36 Ignore redundant parallel moves when checking if a block is empty.
Single predecessor blocks containing nothing but redundant parallel moves can be compacted away.

R=zerny@google.com
BUG=http://dartbug.com/21302

Review URL: https://codereview.chromium.org//669613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41187 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 11:29:19 +00:00
johnniwinther@google.com bcf6565dfe Support if-statements in analyzer2dart.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//662363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41186 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 10:21:13 +00:00
floitsch@google.com 8d2bc28050 dart2js: Remove dead code.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//663813004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41185 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 07:29:22 +00:00
johnniwinther@google.com 40ccf5b5dd Cleanup constant building in IrBuilder.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//657373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41184 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 07:21:12 +00:00
danrubel@google.com 4f2faa385c fix failing test
BUG=

Review URL: https://codereview.chromium.org//669483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41183 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-18 16:48:28 +00:00
iposva@google.com 6266f1d4a0 - Do not attempt to set parameter types if they
were already finalized.

R=zra@google.com

Review URL: https://codereview.chromium.org//652743007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41182 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 21:50:28 +00:00
sigmund@google.com 7ca5a2ccef fix typo in error mesage polymer#42
R=jakemac@google.com

Review URL: https://codereview.chromium.org//664713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41181 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 20:38:54 +00:00
brianwilkerson@google.com acbf532add Disable tests to fix the build
Review URL: https://codereview.chromium.org//664773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41180 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 18:35:21 +00:00
danrubel@google.com 946d40e8ac improve element parameter string returned by local suggestion computer
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//664523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41178 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:37:37 +00:00
danrubel@google.com 8da06376d3 update keyword suggestion priorities
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//666473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41177 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:35:41 +00:00
danrubel@google.com efd813f9b3 update protocol server getter test
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//662013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41176 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:34:27 +00:00
danrubel@google.com 522e3433e4 remove duplicate packages in fuzz test
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//656533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41175 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:32:42 +00:00
iposva@google.com 39703863c4 - Add a separate step to finalize the VM isolate explicitly.
- Allocate the method extractor parameter types and names
  only once, namely in the VM isolate.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//664593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41173 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 17:02:19 +00:00
brianwilkerson@google.com 82c1b3550b Add (as yet unused) task
R=scheglov@google.com

Review URL: https://codereview.chromium.org//660203003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41172 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 16:57:33 +00:00
brianwilkerson@google.com 2fa3b2cab4 Add command-line options for instrumentation
R=paulberry@google.com

Review URL: https://codereview.chromium.org//664743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41171 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 16:47:11 +00:00
paulberry@google.com 271aee1d83 Handle non-factory redirects in constant evaluation.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//640813004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41169 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 15:54:44 +00:00
floitsch@google.com b856819070 Don't run through iterable twice.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//661953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41168 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 15:29:37 +00:00
johnniwinther@google.com 6e7481e4af Support binary expressions in analyzer2dart.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//661923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41167 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 12:28:53 +00:00
whesse@google.com 3430239194 Add additional check to vmservice/websocket_client test.
Fix type errors in update_homebrew script.

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//652833005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41166 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 12:11:27 +00:00
johnniwinther@google.com 621f291a27 Make cps_ir_builder_visitor a part.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//651163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41165 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 12:04:32 +00:00
johnniwinther@google.com 0496f8f2a1 Support dynamic get/invocation in analyzer2dart.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//662593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41164 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 11:55:07 +00:00
johnniwinther@google.com da0e6f745b Split IrBuilder and IrBuilderVisitor.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//661933002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41163 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 11:41:06 +00:00
floitsch@google.com 298425caf7 dart2js: Remove unused function in new emitter.
Review URL: https://codereview.chromium.org//635273003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41162 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 10:53:06 +00:00
floitsch@google.com 4c499dd2a3 dart2js: Add interceptors to new emitter.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//662663003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41161 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 09:29:56 +00:00
floitsch@google.com 86319da8fc dart2js: Add support for static fields to new emitter.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//661783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41160 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 09:26:13 +00:00
danrubel@google.com 582b276b6f filter invalid method invocation suggestions
and filter _ from local suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//651443006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41159 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 21:25:46 +00:00
brianwilkerson@google.com dd794e0d02 Minor cleanup
R=scheglov@google.com

Review URL: https://codereview.chromium.org//660053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41158 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 18:08:25 +00:00
srdjan@google.com 3dbcfcca7a Fix issue 21159: prevent endless inlining of field dispatchers.
Review URL: https://codereview.chromium.org//659793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41156 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 17:13:01 +00:00
srdjan@google.com 5b9f017992 Fix issue 20133: do not crash if debug port is illegal.
R=asiva@google.com

Review URL: https://codereview.chromium.org//657213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41155 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 17:08:22 +00:00
danrubel@google.com 8d47e699d9 filter void methods when suggesting expression
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//658053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41153 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 16:46:45 +00:00
floitsch@google.com 1bebfa6b58 It's not IE, but chrome that was slow.
Review URL: https://codereview.chromium.org//657393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41152 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 15:18:43 +00:00
brianwilkerson@google.com 77613046a5 Generalize source entry
R=scheglov@google.com

Review URL: https://codereview.chromium.org//661603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41151 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 15:12:45 +00:00
paulberry@google.com b9116653bd Modify dartanalyzer scripts to look more like dart2js scripts.
The dartanalyzer script (and its Windows companion, dartanalyzer.bat)
now support:

- Executing from snapshot if present, otherwise from source (needed
  for buildbot tests).
- Passing in the appropriate package root when executind from source.
- Passing in VM tuning parameters to speed up analysis.
- Passing through extra DART_VM_OPTIONS to the VM.

Also, the old editor/tools/analyzer script has been removed and
the test infrastructure now uses sdk/bin/dartanalyzer, in the
same way that it works for dart2js.

R=ahe@google.com, johnniwinther@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//628363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41150 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 14:21:37 +00:00
ricow@google.com 33c65f8fc6 Update bleeding edge VERSION file
Review URL: https://codereview.chromium.org//658143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41149 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 13:20:26 +00:00
floitsch@google.com a5bdd260ac Mark incremental compilation test as slow on IE.
Review URL: https://codereview.chromium.org//664513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41148 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 13:20:06 +00:00
floitsch@google.com 32ef6273ae Mark some analyzer/analysis_server tests as slow.
R=ricow@google.com

Review URL: https://codereview.chromium.org//656163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41147 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 13:16:09 +00:00
johnniwinther@google.com 8b1c404c16 Support local variables in analyzer2dart.
BUG=
R=floitsch@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//661593004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41146 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 13:09:05 +00:00
floitsch@google.com edbde2b1f4 dart2js: Emit constants in new emitter.
Currently the constants are still emitted eagerly, but it should be relatively straightforward to switch to a lazy emission.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//642813005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41144 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 13:00:07 +00:00
floitsch@google.com bc35aaabbe dart2js: Use computed classes/statics from code-emitter-task in new emitter.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//649873003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41143 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 12:07:56 +00:00
floitsch@google.com 728f4079e9 dart2js: restructure emitter.
Collect information before hand, and then emit output units in one go.
First emit the deferred units since we need their hashes in the main unit.

There is still code that collects the output-unit of the emitted element, even though we know that it should/must be in the current output-unit. That code can be cleaned up in a later CL. We should not need to look up the output unit for any element in the old-emitter anymore.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//656043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41142 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 11:53:51 +00:00
ahe@google.com 0251a5c202 Skip test that doesn't work in CSP mode.
R=ricow@google.com

Review URL: https://codereview.chromium.org//663453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41141 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 09:06:12 +00:00
ricow@google.com c416ea097d Mark the analyzer tests slow generally on dart2js
We are seeing these flake on several bots

Review URL: https://codereview.chromium.org//645063003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41140 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 06:31:54 +00:00
ricow@google.com 79fc884b86 Skip language/large_class_declaration_test in debug mode on the vm
This is flaky timing out on several platforms, and is consistentnly timing out on our win32 debug russian bot

Review URL: https://codereview.chromium.org//642813010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41139 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 05:56:15 +00:00
rmacnak@google.com f310862906 Revert "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises."
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//661603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41138 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 02:54:14 +00:00
danrubel@google.com 7c9dc9695b add imported inherited member suggestions
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//643153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41137 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 01:55:30 +00:00
rmacnak@google.com 5178314123 Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises.
R=vsm@google.com

Review URL: https://codereview.chromium.org//605853003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41136 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 01:17:45 +00:00
fschneider@google.com 04563b8bce Fix crash with --trace-deoptimization-verbose and tweak formatting.
Uninitialized instances (e.g. closures) can't be printed using ToCString.
Print just the class instead.

Print values/addresses consistently with our disassembly output (no leading zeros)
This makes searching in the trace output easier.

Limit printing source lines to max 80 chars. Otherwise the trace output for
minified Dart code gets unreadable.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//658773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41134 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-15 15:49:40 +00:00
fschneider@google.com 9087108b5f VM: Avoid repeated deoptimization on speculatively hoisted smi-checks.
This adds the same check as we already have for CheckClass for
CheckSmi and CheckEitherNonSmi instructions to avoid repeated
deoptimization after LICM.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//657613004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41133 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-15 15:46:49 +00:00
floitsch@google.com 2ce9c11016 dart2js: move reusable parts of interceptor emitter into a separate file.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//596313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41132 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-15 14:30:30 +00:00
ahe@google.com 673330403d Include class members in TAGS file.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//656043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41131 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-15 14:17:26 +00:00