dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
27,545 Commits 2 Branches 0 Tags
dde7963d36c81663e39f0df8ec5b3f8faec2d852
Commit Graph

1686 Commits

Author SHA1 Message Date
srdjan@google.com 5b9f017992 Fix issue 20133: do not crash if debug port is illegal. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//657213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41155 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-16 17:08:22 +00:00
ajohnsen@google.com 1e731cf3e5 Don't create unused OSError in Socket_Available. 
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//638303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41005 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-09 06:21:21 +00:00
turnidge@google.com f90e8ad15f Begin implementing a debugger page in Observatory. 
In progress.

For now we have a split view with the stack on top and
console/controls on the bottom.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//584293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40887 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-02 17:33:38 +00:00
asiva@google.com 2761153e08 Fix following compiler warnings: 
os_win.cc(266) : warning C4018: '>=' : signed/unsigned mismatch
stub_code_ia32.cc(89) : warning C4146: unary minus operator applied to unsigned type, result still unsigned
stub_code_ia32.cc(213) : warning C4146: unary minus operator applied to unsigned type, result still unsigned
stub_code_ia32.cc(317) : warning C4146: unary minus operator applied to unsigned type, result still unsigned
crypto_win.cc(5) : warning C4005: '_CRT_RAND_S' : macro redefinition
file_win.cc(512) : warning C4101: 'st' : unreferenced local variable

BUG=http://dartbug.com/21150
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//619723004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40826 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-30 23:29:26 +00:00
whesse@google.com 57ba535cf1 Update version of NSS in Dart to 3.16.7 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//612083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40802 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-30 09:15:32 +00:00
johnmccutchan@google.com 4b43b25d69 Fix handling of VM reconnect 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//608593005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40737 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-26 20:15:15 +00:00
iposva@google.com cc13627fc8 - Remove Isolate::CurrentAddress(). 
- Remove use of INFINITY and -INFINITY.

R=rmacnak@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//609593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40700 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-25 23:39:30 +00:00
sgjesse@google.com b90c405572 Remove the assumption that stat64 and lstat64 cannot return EINTR on Linux 
BUG=http://dartbug.com/21080
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//600273004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40671 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-25 07:06:06 +00:00
ajohnsen@google.com 0491f4e887 Per isolate package root. 
BUG=
R=iposva@google.com, ricow@google.com, sgjesse@google.com, turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40534

Review URL: https://codereview.chromium.org//545483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40581 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-23 05:46:14 +00:00
ajohnsen@google.com 38619425c2 Revert "Per isolate package root." 
Revert "Fix test in checked mode."

The Dartium branch is locked atm, making it impossible to land this and have green Dartium bots.

BUG=

Review URL: https://codereview.chromium.org//590123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40540 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 11:13:28 +00:00
ajohnsen@google.com a058d07806 Per isolate package root. 
BUG=
R=iposva@google.com, sgjesse@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//545483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40534 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 08:07:06 +00:00
whesse@google.com 0b9b34eb7f Update NSS to 3.16.4. Updated to Chromium's copy of NSS at revision 291806 
Includes a fix for an Android L issue.

R=ricow@google.com, sgjesse@google.com, zra@google.com

Review URL: https://codereview.chromium.org//574443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40430 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 10:40:40 +00:00
turnidge@google.com 16343fa13f Add tools/ddbg_service. 
This is the directory where we will work on a version of ddbg that
uses the vm service.

Not yet functional.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//575853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40334 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-16 18:16:28 +00:00
johnmccutchan@google.com a6c16efa38 Do not navigate to vm-connect page upon disconnect 
Also, prompt the user when they click a link when we hvae no connection

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//558703005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40262 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-15 18:19:48 +00:00
ajohnsen@google.com 9dd4df6f9a Fix datagram issue where available is not correctly updated upon receive. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//569173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40235 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-15 08:21:44 +00:00
rmacnak@google.com 128148aafc Preserve the contents of Dart strings with unmatched surrogate halfs by avoiding a UTF16 -> UTF8 -> UTF16 conversion. 
Clean up some confusion between code points and code units.

BUG=http://dartbug.com/20583
BUG=http://dartbug.com/20874
R=turnidge@google.com

Review URL: https://codereview.chromium.org//558853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40174 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-11 18:42:04 +00:00
rmacnak@google.com eff104a2e5 Give fields a model class in the service library. 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//561053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40166 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-11 17:32:55 +00:00
johnmccutchan@google.com 435c6ad7ac Reduce service isolate startup time from ~80ms to ~30ms 
- Get access to dart:io internal signal listening function using API instead of mirrors.

- Service isolate can start with service deactivated.
- Load Observatory front end resources only when service activated.
- Do not execute Dart Service code until service is activated.
- Register live isolates when service is activated.

- Startup refactored to allow for future use of script snapshots.

R=asiva@google.com

Review URL: https://codereview.chromium.org//533073005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40124 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-10 22:38:33 +00:00
johnmccutchan@google.com 22144dbed2 Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib 
Add generic 'Object' ref and view element. This will work for any ServiceObject with type == 'Object'.

Ref element uses the vmType as the link text if there is no name.
View element is mostly just <object-common> but that allows calculating retaining path, retained size, etc.

BUG=
R=rmacnak@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//560503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40119 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-10 21:20:59 +00:00
regis@google.com 0220e41d72 New bigint implementation in the vm. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org//509153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40061 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 21:47:44 +00:00
rmacnak@google.com 27b99b257c Don't double-escape strings in the VM Service, and don't use \u0000 to determine the string length. 
This makes characters above ASCII to display as themselves in Observatory, strings with \u0000 in the middle not to be truncated, and avoids a bug in the previous escaping where a non-ASCII character in the last position would have its escaped representation cut off.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//542363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40060 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 21:34:06 +00:00
rmacnak@google.com 26fcef52bf Fix UI for retained size of a class. 
(Was broken by r39758)

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//552903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40046 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 17:42:14 +00:00
turnidge@google.com 320c1bb74d Rework how types work in the VM Service. 
We now return a "type" property and an optional "_vmType" property for
each response.  We use this to "hide" vm implementation specifics in
the VM Service protocol.

For example, before we might have returned an integer reference with type
"@Smi".  Now it would have the type "@int" and the _vmType "@Smi".

This also allows us to hide funky vm internal types behind the generic
"Object" type.

Updated the protocol.md file somewhat to describe a notion of "private
properties".

Updated the Observatory and unit tests.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//547703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40044 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 17:25:52 +00:00
iposva@google.com adbe016fbc - Support loading from https. 
- Remove over-eager assertion.

R=asiva@google.com

Review URL: https://codereview.chromium.org//550003004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40005 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 00:10:06 +00:00
zra@google.com 0f6c47ab78 Delays creating a snapshot file until after the snapshot is created. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//499743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39998 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 20:52:25 +00:00
rmacnak@google.com 48d9189ab7 Add a manual test for inspecting types that have a special VM implementation. 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//545343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39982 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 17:38:35 +00:00
blois@google.com 2941737d68 Updating Android library dependencies 
We ran into some linker issues on gen_snapshot after upgrading to to Ubuntu 14.04 where it was unable to resolve pthread_condattr_setclock. I'm not sure if an additional dependency was added for this, or if the declaration moved.

The core issue though is that in cross-compilations, some of the necessary dependencies were being added as 'linux', but this is not the case when compiling for host when the target is Android. The gen_snapshot target was accounting for this by adding the dependencies for android itself, but instead it should be done at the targets.

The fix here is to move the dependencies from gen_snapshot and onto the targets as conditional OS=android, and to include the same set of libraries.

BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//504973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39972 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 15:59:30 +00:00
ajohnsen@google.com ebfff1fd60 Remove last _logResolution reference. 
Was missed due to merge.

BUG=

Review URL: https://codereview.chromium.org//540253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39899 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-05 06:32:49 +00:00
ajohnsen@google.com d6bbe5ad08 Don't do Uri->String->Uri when resolving package imports. 
This fixes an issue on windows where Uri.parse(Uri.toFilePath()) would produce escaped Windows paths.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//538373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39898 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-05 06:24:22 +00:00
ajohnsen@google.com 8674d45766 Remove debug logging from builtin. 
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//534273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39897 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-05 05:38:34 +00:00
ajohnsen@google.com ed3981ec78 Reduce the number of Uris parsed in builtin. 
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//543713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39896 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-05 05:33:17 +00:00
rmacnak@google.com 154c31169e Teach the Observatory about WeakProperties (ephemerons). 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//536273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39885 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 20:36:34 +00:00
rmacnak@google.com 22fed7f373 Teach the Observatory about MirrorReferences. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//542473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39883 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 19:55:15 +00:00
rmacnak@google.com 92b17f752b Address static warnings in the service library and tests. 
BUG=http://dartbug.com/20805
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//544753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39882 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 18:38:39 +00:00
turnidge@google.com d3173684dd Add --break-at-isolate-spawn to help with isolate debugging. 
This flags stops spawned isolates with a one-time breakpoint at their
entrypoints.

Fix a bug in Observatory which interfered with browsing a spawned
isolate.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//537673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39878 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 16:53:44 +00:00
floitsch@google.com 46043093af Move js library back into compiler directory. 
R=ricow@google.com

Review URL: https://codereview.chromium.org//538513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39870 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 13:49:30 +00:00
ajohnsen@google.com b01818d7be Don't use async loading in gen_snapshot. 
This fixes the dartium builds.

BUG=

Review URL: https://codereview.chromium.org//543623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39855 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 09:42:22 +00:00
ricow@google.com a1f884b9b7 Mark observatory tests as failing on the analyzer 
Filed issue 20805

Review URL: https://codereview.chromium.org//537853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39850 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 07:48:24 +00:00
ajohnsen@google.com e8946947aa Fix handling of Windows paths after cleanup. 
BUG=

Review URL: https://codereview.chromium.org//539863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39849 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 07:03:04 +00:00
ajohnsen@google.com ad4d4af975 Reuse HttpClient in the built-in resource loader. 
BUG=

Review URL: https://codereview.chromium.org//539473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39848 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 06:53:41 +00:00
ajohnsen@google.com 8c633a390e Cleanup resource loading of the VM. 
There is not only one path for loading resources, and it's async.

BUG=

Review URL: https://codereview.chromium.org//529203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39847 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 06:42:01 +00:00
rmacnak@google.com 117f18b8a4 Teach the Observatory about Contexts. Factor out object graph information from the instance view. 
Address various issues with mismatched tags and type errors.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//532063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39845 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-04 00:27:49 +00:00
zra@google.com ec1140b188 Adds support for building arm64 Android. 
R=regis@google.com

Review URL: https://codereview.chromium.org//539573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39844 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-03 23:31:51 +00:00
rmacnak@google.com 0f0b5d00e5 Reapply "Give instances their own model class; move DartErrors out of instance-ref into their own error-ref." 
Update inbound_references_test

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//524433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39758 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-02 17:47:14 +00:00
turnidge@google.com da871c0b45 Allow observatory to distinguish between user-level and vm-level types. 
Currently the 'type' property always encodes a vm-specific type.  In
the future 'type' will specify a user-level (Dart-ish) type and
'vmType' will (optionally) specify a vm-specific type if it is
different.  This will allow an application like a debugger (for
example) to ignore the specifics of the vm-internal Instance hierarchy
while still providing this information for applications like
Observatory, which want to know everything.

So, in this change, we prepare Observatory to receive both 'type' and
'vmType' properties.

Specifics:

- replace 'serviceType' on ServiceObject with 'type' and 'vmType'.
- replace uses of serviceType with type or vmType as appropriate.
- fix a couple of stray bugs I found ('user_name', etc.)

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//515303005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39705 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-29 17:17:43 +00:00
rmacnak@google.com 62a0ab203b Revert "Give instances their own model class; move DartErrors out of instance-ref into their own error-ref." 
Review URL: https://codereview.chromium.org//511413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39686 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-28 23:05:11 +00:00
rmacnak@google.com b418a04289 Give instances their own model class; move DartErrors out of instance-ref into their own error-ref. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//509563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39682 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-28 21:56:20 +00:00
johnmccutchan@google.com 40dd4b7607 Fix type in vm_metrics_test 
BUG=

Review URL: https://codereview.chromium.org//520443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39681 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-28 21:52:15 +00:00
johnmccutchan@google.com 47060ce13e Initial UI for Metrics in Observatory 
- s/href/_href to silence new polymer warnings.
- Add fixed pollers that metrics can be registered with.
- UI to control sample buffer size
- UI to control refresh rate
- UI to see registered counters

R=koda@google.com

Review URL: https://codereview.chromium.org//457803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39679 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-28 21:16:51 +00:00
turnidge@google.com 8a3c490f6b Add a new Sentinel type for sentinel responses. (They are not Null). 
Fix some stray problems.

Silence warnings about stray GC events.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//514833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39663 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-28 16:52:01 +00:00