da1a5b5bdf
Modify some documentation details
...
Closes https://github.com/dart-lang/sdk/pull/60287
GitOrigin-RevId: 284881fea53ecb86aeba413fe3e60089287ea311
Change-Id: Iaf695a524ec7bc7d604b7b176b77155a9707d662
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414481
Reviewed-by: Slava Egorov <vegorov@google.com >
Commit-Queue: Slava Egorov <vegorov@google.com >
2025-03-10 03:22:36 -07:00
078ddac8a7
Rename variable millisecondsPerExercise to microsecondsPerExercise
...
Closes https://github.com/dart-lang/sdk/pull/60286
GitOrigin-RevId: 051278201d6f0c7f362e618b51a4a493cec8929f
Change-Id: Icd98294879478b754809b45a938591e07d64543a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414480
Reviewed-by: Slava Egorov <vegorov@google.com >
Commit-Queue: Slava Egorov <vegorov@google.com >
2025-03-10 03:17:30 -07:00
4ab8296f73
[CFE] Remove no-NNBD compilation from expression suite
...
Now unsupported, and it made the weekly bot fail.
Change-Id: I7070d862eb79240d3afe19e5415db072d98362f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414501
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2025-03-10 03:01:40 -07:00
7d62bddb17
[_fe_analyzer_shared] Sort declarations in mini_ast.dart and shared_type.dart.
...
There is no functional change.
Change-Id: I1877d29efddd614688cd34506d5a496a472dea7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414260
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2025-03-10 01:54:00 -07:00
a408293b09
[cfe] Support patched methods through fragments
...
Change-Id: Ia1b6c9c7e3cc3b7b9bd0e9396e05bb45340ae8fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413782
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2025-03-10 01:40:10 -07:00
d469271ad9
[DAS] Make missing_required_argument fix work for multiple arguments
...
R=pquitslund@google.com
Fixes: https://github.com/dart-lang/sdk/issues/46915
Fixes: https://github.com/dart-lang/sdk/issues/38876
Change-Id: I966462c38bb45773072729a9495f53b448574208
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410740
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2025-03-09 20:52:30 -07:00
91a653b4e5
Revert "[sdk] Remove some redundant kernel-worker JIT snapshot generation code."
...
This reverts commit 0e556f6960https://dart-review.googlesource.com/c/sdk/+/412783
> Reviewed-by: Srujan Gaddam <srujzs@google.com >
> Commit-Queue: Siva Annamalai <asiva@google.com >
> Reviewed-by: Nicholas Shahan <nshahan@google.com >
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7dd273001bf9c016f014c111ba8fe9197c75e52e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414383
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Auto-Submit: Siva Annamalai <asiva@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2025-03-09 11:51:06 -07:00
283d3154a5
Elements. AugmentedExtensionTypeElement remove primaryConstructor, representation, typeErasure.
...
Change-Id: I01c654429367575cf40e1cc41165aa6f7652a8c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414201
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-03-07 22:43:57 -08:00
c5e400c882
[vm-service] - Fix location in which the vm-service server looks for the dds snapshot.
...
The location of the dds snapshot was changed when the g3 roll failed and at that time this code was not changed accordingly.
TEST=ci and manual testing
Change-Id: I92b43f68b082d7c2c7a7e56f53ccb987cbfb72e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414382
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2025-03-07 21:53:59 -08:00
3514767969
[sdk/lib] Fix typo in documentation.
...
Bug: 60253
Change-Id: I5d3968b5f7aa3a770ecaa693e938752ea86f9da2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414340
Reviewed-by: Brian Quinlan <bquinlan@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2025-03-07 21:53:30 -08:00
6322a400f1
[analyzer] Update messages and lint docs for downstream status
...
Change-Id: Ie4e057956dba0e568fa7fa6497ce42922207a382
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414440
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-03-07 17:37:20 -08:00
7b28c5a94f
[dart2wasm] Update serialization strategy for dynamic modules.
...
Introduces some more machinery to simplify the serialization pipeline. Now the logic to index kernel nodes is hidden away in the serializer. Now throughout the compiler if entities (i.e. classes, members and references) need to be serialized they can be passed to the serializer directly.
Also adds support for tracking brand type assignments from the main module to the dynamic module. This is necessary to decouple the execution order of both compilations which is a WIP.
Change-Id: I38dd0ed11811ea12a2230959588b261719976592
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412461
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Nate Biggs <natebiggs@google.com >
2025-03-07 16:45:35 -08:00
0e556f6960
[sdk] Remove some redundant kernel-worker JIT snapshot generation code.
...
Change-Id: Ic092633dd6f5eb0dcfdef70472221ddc7951bbbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412783
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2025-03-07 15:19:49 -08:00
03293b52f5
[dart2js/ddc] Cleanup sound flag from benchmark test
...
Updates test to match the updates to the actual invocations on golem:
https://chrome-internal-review.googlesource.com/c/golem/+/8082532
https://chrome-internal-review.googlesource.com/c/golem/+/8082531
Change-Id: I171560f42c70bf59568d6c96325899be2eceb754
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386082
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2025-03-07 15:10:02 -08:00
2d2475224a
[deps] rev dartdoc, ecosystem, i18n, protobuf, shelf, sync_http, test, tools, vector_math, web, webdriver
...
Revisions updated by `dart tools/rev_sdk_deps.dart`.
dartdoc (https://github.com/dart-lang/dartdoc/compare/34561d6..6c770bf ):
6c770bfb 2025-03-01 dependabot[bot] Bump the github-actions group with 5 updates (dart-lang/dartdoc#4011 )
06233c76 2025-02-26 Parker Lougheed Use nested scss in nav and footer styles (dart-lang/dartdoc#4006 )
4847677c 2025-02-26 Sam Rawlins Support the stats flag when documenting the testing package (dart-lang/dartdoc#4008 )
ecosystem (https://github.com/dart-lang/ecosystem/compare/06bbbff..a3cc42d ):
a3cc42d 2025-03-06 Devon Carew Update publish_internal.yaml (dart-lang/ecosystem#345 )
25f0fb2 2025-03-04 Devon Carew Update README.md (dart-lang/ecosystem#344 )
331d35d 2025-03-01 dependabot[bot] Bump the github-actions group with 5 updates (dart-lang/ecosystem#343 )
i18n (https://github.com/dart-lang/i18n/compare/06a664f..bdeec25 ):
bdeec25 2025-03-04 Moritz Publish `package:intl4x: 0.11.0` (dart-lang/i18n#953 )
d84a927 2025-03-04 Moritz Update publishing workflow
547ce9f 2025-03-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/i18n#952 )
c6b911b 2025-02-21 dependabot[bot] Bump the github-actions group across 1 directory with 4 updates (dart-lang/i18n#949 )
c3e9fe2 2025-02-21 Moritz Update to new native_assets (dart-lang/i18n#941 )
protobuf (https://github.com/dart-lang/protobuf/compare/610943a..7838e44 ):
7838e44 2025-03-07 Ömer Sinan Ağacan Prefix grpc method 'call' and 'request' arguments with '$' to avoid shadowing user methods with the same name (dart-lang/protobuf#964 )
125fe9c 2025-03-02 dependabot[bot] Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (dart-lang/protobuf#965 )
fb77c7c 2025-03-02 dependabot[bot] Bump actions/cache from 4.2.0 to 4.2.2 (dart-lang/protobuf#966 )
shelf (https://github.com/dart-lang/shelf/compare/b39e611..2af8529 ):
2af8529 2025-03-04 Devon Carew Update publish.yaml (dart-lang/shelf#473 )
f5ae797 2025-03-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/shelf#471 )
sync_http (https://github.com/dart-lang/sync_http/compare/47e6b26..dc54465 ):
dc54465 2025-03-02 dependabot[bot] Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (dart-lang/sync_http#54 )
test (https://github.com/dart-lang/test/compare/a833663..9e349d0 ):
9e349d0e 2025-03-06 Jonas Finnemann Jensen Suggest using `dart pub add dev:checks` (dart-lang/test#2467 )
e941dbac 2025-03-04 Devon Carew Update publish.yaml (dart-lang/test#2465 )
32bf9b73 2025-03-01 dependabot[bot] Bump the github-actions group with 5 updates (dart-lang/test#2462 )
tools (https://github.com/dart-lang/tools/compare/b51f39d..d67cd00 ):
d67cd002 2025-03-07 Parker Lougheed [pub_semver] Remove dependency on `package:meta` (dart-lang/tools#2021 )
04667d7e 2025-03-06 Parker Lougheed [pub_semver] Discourage modification of properties intended to be unmodifiable (dart-lang/tools#2020 )
b23129b9 2025-03-04 Devon Carew Update publish.yaml (dart-lang/tools#2025 )
9765c2aa 2025-02-25 Parker Lougheed [package_config] Implement relational operators for `LanguageVersion` (dart-lang/tools#2016 )
vector_math (https://github.com/google/vector_math.dart/compare/533c513..f08d7d2 ):
f08d7d2 2025-03-01 dependabot[bot] Bump dart-lang/setup-dart in the github-actions group (google/vector_math.dart#340 )
web (https://github.com/dart-lang/web/compare/c2d5f63..4854093 ):
4854093 2025-03-04 Srujan Gaddam Add pull request and id-token write permissions to publish.yaml (dart-lang/web#351 )
33ed133 2025-03-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/web#349 )
6031c1f 2025-02-26 Kevin Moore Delete all deprecated members (dart-lang/web#347 )
5a39fdc 2025-02-26 Kevin Moore Merge tag 'web-v1.1.1'
222164b 2025-02-26 Kevin Moore Deprecate a few more things before we launch v2 (dart-lang/web#348 )
b90b63d 2025-02-25 Kevin Moore Update APIs and docs (dart-lang/web#345 )
5caa92e 2025-02-25 Srujan Gaddam Add catch and finally to bannedNames (dart-lang/web#346 )
e2f9741 2025-02-25 Olzhas Suleimen Add variadic arguments (dart-lang/web#343 )
webdriver (https://github.com/google/webdriver.dart/compare/b4fd859..f52afbf ):
f52afbf 2025-03-06 Parker Lougheed Utilize switch expressions (google/webdriver.dart#327 )
ee311e0 2025-03-02 dependabot[bot] Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (google/webdriver.dart#328 )
b0cb6a9 2025-02-27 Kevin Moore Update to Dart/Flutter team lints and fix (google/webdriver.dart#322 )
d080ebf 2025-02-27 Kevin Moore Update a number of APIs to return Uint8List (google/webdriver.dart#323 )
0400c06 2025-02-27 Kevin Moore Re-enable Firefox on CI (google/webdriver.dart#324 )
38a6646 2025-02-24 Parker Lougheed Minor cleanup for new and future lints (google/webdriver.dart#321 )
Change-Id: Ied703b048f85dd78e30084ffa8bffcaab5bab67b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414301
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2025-03-07 14:26:44 -08:00
490b0f1a26
[DAS] Ambiguous Import fix - fix for static members
...
Fixes: https://github.com/dart-lang/sdk/issues/60276
Change-Id: I8f5cdda4b2e8acfd644c35b3fe54dfab67b8e081
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414360
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-03-07 14:04:04 -08:00
bc9def5da7
[analytics] track time in fix producer compute()s
...
Adds some insight into fix producer `compute` calls to the `GetFixes` diagnostics page.
See updated screenshot in https://github.com/dart-lang/sdk/issues/60258 .
Bug: https://github.com/dart-lang/sdk/issues/60258
Change-Id: I5d8c1911e86ef02b8d543fcda367b3e9aa6544f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2025-03-07 12:36:59 -08:00
90999994b4
Roll Fuchsia SDK from 27.20250304.5.1 to 27.20250305.4.1
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3p-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: Iba34293d77946cefca8b7b0e8d2fae5cbbb354ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413861
Commit-Queue: Brian Quinlan <bquinlan@google.com >
Reviewed-by: Brian Quinlan <bquinlan@google.com >
Reviewed-by: Zijie He <zijiehe@google.com >
2025-03-07 11:54:57 -08:00
671a5ebd85
[analyzer] Make two derived classes for FunctionElementImpl.
...
Derived class `LocalFunctionFragmentImpl` is used for local functions
and `TopLevelFunctionFragmentImpl` is used for top level
functions. Only `LocalFunctionFragmentImpl` implements
`LocalFunctionFragment` and only `TopLevelFunctionFragmentImpl`
implements `TopLevelFunctionFragment`. This ensures that clients
performing `is LocalFunctionFragment` and `is
TopLevelFunctionFragment` checks get the expected
behavior. (Previously, any instance of `FunctionElementImpl` would
satisfy *both* `is LocalFunctionFragment` and `is
TopLevelFunctionFragment` tests).
This made it possible for the types of getters defined in
`LocalFunctionFragmentImpl` and `TopLevelFunctionFragmentImpl` to be
more precise, which in turn allowed some casts to be removed from the
analyzer.
Change-Id: I5637366936683f43d0f0818d3d8a28191086dad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414162
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-03-07 10:54:32 -08:00
957c9a1247
Remove pkg/OWNERS.
...
The intention of this file was to allow any change to files in `pkg/`
to be approved by anyone in OWNERS_ECOSYSTEM, OWNERS_FOUNDATION, or
OWNERS_INFRA, but that if the package itself specifies other owners,
then those owners should be preferred when suggesting owners.
What was actually happening was that the `#{LAST_RESORT_SUGGESTION}`
annotation only has an effect on lines that name a specific user; it
is ignored on `file:` lines. (See docs at
https://gerrit.googlesource.com/plugins/code-owners/+/refs/heads/master/resources/Documentation/backend-find-owners.md#annotations ). So
people in OWNERS_ECOSYSTEM, OWNERS_FOUNDATION, and OWNERS_INFRA were
included in the suggested owners. Fortunately it was not too serious a
problem in practice, because the "find owners" backend seems to have
other heuristics that favor recent reviewers. But it still produced
surprising output when using Gerrit's "suggest all owners" checkbox.
I discussed this with athom@google.com , and we decided to just drop
the `pkg/OWNERS` file altogether.
There was one useful line in that file, assigning `pkg.status` to
OWNERS_ENG. That has been moved to the top level OWNERS file.
Change-Id: I8906ffcd18ffd35055f1401d40a3c3e7fc0eb3a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414183
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2025-03-07 10:42:29 -08:00
82c3d74505
[DAS] Renaming positional parameters to rename hierarchy equivalent
...
Fixes: https://github.com/dart-lang/sdk/issues/53187
Change-Id: Ie0aaea2e24667ad04a95ce6522fd687710501230
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-03-07 10:29:44 -08:00
611e264e0b
[cq] Clean up more uses of comment-based markers in tests
...
Change-Id: Ie069c39bc3a5e2c5132ee078af024730a10c9a6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-03-07 10:22:10 -08:00
2aa14dbe98
[cq] Convert some uses of a comment marker to use TestCode
...
There are a couple of other places where this older convention is still
being used, and I hope to clean them up as well.
Change-Id: I84d7e8d81778b6b7b69060df6eda5db2a6aaf256
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414161
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-03-07 10:15:59 -08:00
d5f82b7054
[dart2wasm] Add dynamic module tests to dart2wasm test builders.
...
3 failing tests have been approved.
Change-Id: Ia38cbce99e739f2ce67d0d60236b3006635837ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414163
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Nate Biggs <natebiggs@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2025-03-07 09:52:01 -08:00
a81828a66d
[tests] Fix and move erroneous constructor tearoff dot shorthands test.
...
Pretty sure this isn't valid code. Moving to an error test.
Bug: https://github.com/dart-lang/sdk/issues/59758
Change-Id: I58fc9cc00286bfae2b6093cfb5ac2c215baf344d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414187
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
2025-03-07 09:35:35 -08:00
2e238e92d9
[VM/Service] Fix profile_period_cli_option_test
...
I've seen up to 2500 samples get collected when running this test on
`vm-linux-debug-ia32` configs. 3000 is still significantly less than
5000, so this CL just changes the `lessThan(2000)` expectation to
`lessThan(3000)`.
Fixes: https://github.com/dart-lang/sdk/issues/60257
Change-Id: Iea88ec8dab6a3be9ca843bc445a8205730b8f2aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414280
Reviewed-by: Jessy Yameogo <yjessy@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2025-03-07 09:27:40 -08:00
83a16ea8a7
[DAS] Fixes renaming fields at constructor parameters
...
Fixes: https://github.com/dart-lang/sdk/issues/52305
Change-Id: I39a547c391ffd3538b3ccaafeab3af65bb4088b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413340
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2025-03-07 09:27:32 -08:00
49ad066aeb
Ignore TODOs in newly added analysis_server benchmark
...
Since the benchmark has its own `analysis_options.yaml` file, the
files inside it are analyzed with default analysis options, meaning
that `TODO` comments inside the benchmark are now showing up in the
IDE, which is distracting when making edits to the analysis server.
Change-Id: I42b02da06d6754a26157bcf0c07b8d5c4b2ac31d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414240
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-03-07 07:32:20 -08:00
fb137ff73e
[cfe] Patch declarations through fragments
...
Change-Id: I942f2b0b08e69012140d4671722411c86b073504
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413681
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2025-03-07 05:37:00 -08:00
1bbbf26434
[dart2js] Refactor FlatTypeMask cache.
...
As the powerset grows, the cache needs to be keyed on both the base and
the full flags. While we're at it, we ensure that all FlatTypeMask
allocations go via the cache.
Change-Id: Ifdd400bf4ea23a936c4d37be91a5d527102aa3b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413700
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2025-03-07 04:20:04 -08:00
d0e09ea091
[dart2js] Print powerset value in typemask toString methods.
...
We may find it useful later to add a more verbose stringification that
writes out the properties expressed by the powerset. For now, just
printing the int value is sufficient to debug e.g. test failures, and
it's relatively straightforward to manually convert an int to a set of
properties by looking at the definitions of the powerset domains.
Change-Id: I2397ffd83a6e86830f67c7f1ef811e33c0b7ff3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405567
Reviewed-by: Nate Biggs <natebiggs@google.com >
2025-03-07 04:20:04 -08:00
389ac928b9
[dart2js] Refactor typemasks to support additional powerset bits.
...
Change-Id: Ifffed9455272d6cedea55125e2af74b594fe310c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404381
Reviewed-by: Nate Biggs <natebiggs@google.com >
2025-03-07 04:20:04 -08:00
f00dbb5856
[dart2js] Reformat pkg/compiler.
...
Change-Id: I9e379d1f0673b589139a2389c6d3602c36995cd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413720
Reviewed-by: Nate Biggs <natebiggs@google.com >
2025-03-07 04:20:04 -08:00
0539814037
[co19] Roll co19 to c65089af3941dae18d513753960ee05181b4b35c
...
2025-03-06 sgrekhov22@gmail.com dart-lang/co19#3057 . Add reachability tests for operators. Part 3. (dart-lang/co19#3100 )
2025-03-06 sgrekhov22@gmail.com dart-lang/co19#3057 . Add reachability tests for operators. Part 2. (dart-lang/co19#3099 )
2025-03-06 sgrekhov22@gmail.com dart-lang/co19#3057 . Add reachability tests for operators. Part 1. (dart-lang/co19#3098 )
2025-03-05 sgrekhov22@gmail.com dart-lang/co19#3057 . Add reachability tests for operator + (dart-lang/co19#3097 )
2025-03-05 sgrekhov22@gmail.com dart-lang/co19#3057 . Add tests for cascade method invocation (dart-lang/co19#3095 )
2025-03-05 sgrekhov22@gmail.com Closes dart-lang/co19#3088 . Remove weak mode from LanguageFeatures/Patterns. (dart-lang/co19#3096 )
2025-03-05 sgrekhov22@gmail.com dart-lang/co19#3088 . Remove weak mode from LanguageFeatures/nnbd. Part 2. (dart-lang/co19#3094 )
2025-03-04 sgrekhov22@gmail.com dart-lang/co19#3057 . Add tests for method invocation (dart-lang/co19#3083 )
2025-03-04 sgrekhov22@gmail.com dart-lang/co19#3088 . Remove weak mode from LanguageFeatures/nnbd. Part 1. (dart-lang/co19#3092 )
2025-03-04 sgrekhov22@gmail.com dart-lang/co19#3088 . Remove weak mode from Language and LibTest (dart-lang/co19#3093 )
2025-03-03 sgrekhov22@gmail.com dart-lang/co19#3088 . Remove weak mode from TypeSystem/subtyping (dart-lang/co19#3091 )
2025-03-03 sgrekhov22@gmail.com dart-lang/co19#3088 . Remove weak mode from TypeSystem/type-normalization (dart-lang/co19#3089 )
2025-03-03 sgrekhov22@gmail.com dart-lang/co19#3088 . Remove weak mode from TypeSystem/flow-analysis (dart-lang/co19#3090 )
2025-03-03 sgrekhov22@gmail.com Fixes dart-lang/co19#3086 . Update context type for expected value (dart-lang/co19#3087 )
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ib3b8714c4d6ae5d73089b41374ed3ce16b6ddab0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414220
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2025-03-07 01:22:59 -08:00
a98011a5ef
[analyzer] Initial LSP server e2e benchmark
...
A benchmark that launches the dart analyzer server in language server
protocol mode and communicates with is as an IDE.
In this case the benchmark generates between 16 and 1024 copies of the
abstract scanner (to get a large amount of code) as well as imports and
exports all the files in cycles and/or chains; performs an edit,
requests completion and times initial startup (with no cache),
completion after change and when it's done analyzing after the change.
It does this in several modes than change the way the files are imported
and exported:
* ImportCycle where file1 imports file2 etc and the last file imports
file1. There are no exports.
* ImportChain where file1 imports file2 etc and the last file doesn't
import anything. There are no exports.
* ImportExportCycle where file1 imports and exports file2 etc and the
last file imports and exports file1.
* ImportExportChain where file1 imports and exports file2 etc and the
last file doesn't import or export anything.
* ImportCycleExportChain where file1 imports and exports file2 etc and
the last file imports file1 but doesn't export anything.
For ImportCycle, ImportChain and ImportExportChain things appear to
scale ~linear and - using AOT - have timeings in this ballpark (this is
specifically for ImportCycle):
+------+-----------+------------+------------+
| Size | Initial | Completion | Fully done |
+------+-----------+------------+------------+
| 16 | 0.46561 | 0.158765 | 0.40474 |
| 32 | 0.901167 | 0.268819 | 0.859874 |
| 64 | 1.657207 | 0.428747 | 1.488365 |
| 128 | 3.178606 | 0.843576 | 3.040237 |
| 256 | 6.015557 | 1.737661 | 6.010487 |
| 512 | 12.08567 | 2.979242 | 11.736878 |
| 1024 | 24.273368 | 6.101671 | 24.018495 |
+------+-----------+------------+------------+
For ImportExportCycle and ImportCycleExportChain it scales worse and
e.g. ImportExportCycle looks like this:
+------+-----------+------------+------------+
| Size | Initial | Completion | Fully done |
+------+-----------+------------+------------+
| 16 | 0.46673 | 0.169486 | 0.406448 |
| 32 | 0.875871 | 0.242876 | 0.85543 |
| 64 | 1.583077 | 0.465915 | 1.506953 |
| 128 | 3.198071 | 0.903894 | 3.09165 |
| 256 | 6.786677 | 2.149489 | 6.779569 |
| 512 | 17.346131 | 8.92149 | 17.971033 |
| 1024 | 63.358453 | 46.152089 | 65.401559 |
+------+-----------+------------+------------+
(In the tables 'Completion' is time until completion answers after a
top-level change and 'Fully done' is time until the analyzer stops
analyzing after a top-level change).
Change-Id: Id7214c0d6c14199f39c0c8a6a8b4941a0e575dc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2025-03-06 23:43:58 -08:00
219471cf2e
[dart2wasm] Only include deferred/dynamic loading code in mjs if needed
...
This removes 1.6 KB from the default mjs file in case neither deferred
loading nor dynamic loading is used.
=> Fixes size regression introduced by dynamic modules support ([0])
[0] https://dart-review.googlesource.com/c/sdk/+/397721
Change-Id: Id5bba9883117038b1fb4139b16f17a91478c7ded
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414000
Reviewed-by: Ömer Ağacan <omersa@google.com >
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2025-03-06 23:37:11 -08:00
49a93a0779
[analytics] show getFixes operation timings
...
Bug: https://github.com/dart-lang/sdk/issues/60258
Change-Id: Ie1f5006e32d3e0563e35d64354db4c5543758dc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414164
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-03-06 17:14:39 -08:00
b1849f5fcc
[dart2js] Delete regression test for unused dump-info mode
...
Change-Id: I491fd7c47f33ef900ab3189dee224291c7b2d73f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414165
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Nate Biggs <natebiggs@google.com >
2025-03-06 16:47:29 -08:00
79ab37f4cd
Elements. Remove constructors from AugmentedInterfaceElement.
...
Change-Id: If49bf51b36c0a638ed0b1052a5cc85edb0b7a1b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414181
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2025-03-06 16:39:37 -08:00
91de656811
[tests] Fix nullable test for dot shorthands.
...
Fixing a couple typos keeping this test from passing.
Bug: https://github.com/dart-lang/sdk/issues/59758
Change-Id: I5fd8345538ee4516db4565c910dcb75b93c4cda1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414185
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2025-03-06 16:18:32 -08:00
e03657855c
[dart2js] Remove old unused dart2js tools.
...
These files haven't been touched in years and, based on my queries, no one is using them.
Bug: https://github.com/dart-lang/sdk/issues/60263
Change-Id: Ie23597bfc9aa624ff63645660aded6c483cfbfc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414160
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Nate Biggs <natebiggs@google.com >
2025-03-06 14:46:16 -08:00
6a7fd7cedb
Elements. Remove from AugmentedInterfaceElement 'interfaces' and 'mixins'.
...
Change-Id: I95d4d11c0a5b0a5ccbfe7890f87cf3836a7a39f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-03-06 13:30:33 -08:00
e52b141660
[cfe] Fix bug with expression parsing with dot shorthands.
...
This CL is a bug fix where we weren't parsing the rest of the expression after the dot shorthand.
This caused errors in parsing dot shorthands expressions such as `.red..toString();` or `fn(.parse('true') || false)`.
Bug: https://github.com/dart-lang/sdk/issues/59758
Change-Id: I745f45e04af53eac0cfcebe7ab977b918da10fbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413920
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2025-03-06 13:17:32 -08:00
76be1bcded
[analytics] add getFixes timings to diagnostics/reports
...
See: https://github.com/dart-lang/sdk/issues/60258
Change-Id: I756cb04d3968ca02dbef332f45a6fbea5b1b8c3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414180
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-03-06 11:19:58 -08:00
5883289bb5
[cfe] Handle equality with dot shorthands.
...
This CL adds the ability to handle == with dot shorthands in regular equality expressions and then in relational patterns.
Bug: https://github.com/dart-lang/sdk/issues/59758
Change-Id: I958bbaf9e8a63ca576024ef2ee287779064e5967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413321
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2025-03-06 11:09:20 -08:00
b222933af6
[DAS] Adds remove const fix error to most common const errors
...
Following the work done at https://dart-review.googlesource.com/c/sdk/+/276941 . But trying to merge this time.
Fixes: https://github.com/dart-lang/sdk/issues/49818
Fixes: https://github.com/dart-lang/sdk/issues/53599
Change-Id: I7ed6890ec3d526b855dd71b45e0493cbaf419d6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410862
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-03-06 10:42:46 -08:00
50ff1c349c
[DAS] Fixes rename field add this to fix shadowing
...
R=srawlins@google.com
Fixes: https://github.com/dart-lang/sdk/issues/59954
Change-Id: I860e48989566a09ea09092ddd1771be61f89121b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413901
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
2025-03-06 10:15:43 -08:00
c066e292ab
[doc] add dart tui project proposal
...
Closes https://github.com/dart-lang/sdk/pull/60158
GitOrigin-RevId: 935304fa15805e15fca64a7e1eb9ee4d99295298
Change-Id: I1b529dd80363b3225dd7814fbb08ef7cb793057a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410440
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Jonas Jensen <jonasfj@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2025-03-06 09:57:12 -08:00
4bd9df1e2b
Elements. Remove support for augmentations and methods.
...
We don't support augmentations feature yet, and it turned out to be
complicated finishing migration while keeping the current implementation.
Change-Id: I035ecfa74cc107bd9d21a935f76d92987835f542
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413940
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-03-06 09:26:29 -08:00
3767d20e56
Bump language version for pkg/meta
...
Extracted from https://dart-review.googlesource.com/c/sdk/+/397164
Which migrates the sdk to resolve as a pub workspace
Pub workspaces requires a language version of 3.5.
Change-Id: If8e4f61fbf28c3fa9f22d2f2ed116fa179e30a22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412660
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2025-03-06 07:43:45 -08:00
Mo Luo