dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
72,374 Commits 2 Branches 0 Tags
cf3a0342102b8ec2094de629dfb891134df9de3c
Commit Graph

22 Commits

Author SHA1 Message Date
Konstantin Shcheglov 8990c063b7 Issue 41603. await voidExpression is an error. 
Bug: https://github.com/dart-lang/sdk/issues/41603
Change-Id: I6cbd8938c62e7f5f60e48e0ee65b80f4924a3a65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-24 03:42:52 +00:00
Konstantin Shcheglov 61c8ac8b46 Issue 40088. Promote to NonNull of the declared type on assignment. 
Bug: https://github.com/dart-lang/sdk/issues/40088
Change-Id: Icc2c720e24c2e6a85994497cd12bf34957d99d4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144040
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-21 03:01:54 +00:00
Srujan Gaddam 983f882180 [dart:html] Play videos in draw_image_video_element_test 
draw_image_video_element_test creates VideoElements, which the current
frame is taken from when drawing to a CanvasElement. The test was
waiting on the onCanPlay event of the VideoElement before drawing,
although this might mean the video won't actually start playing. This
fixes that issue by enabling autoplay and then awaiting the play Event.

Change-Id: I100a552a1eb8e88b6b368d88e499f62f2db8e831
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143621
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-16 00:23:23 +00:00
Srujan Gaddam 53296536de [dart:html] Add back lib/html/input_element_attributes_test 
Now that TextInputElement.value accepts a nullable value, this test
can be added back to test null behavior.

Change-Id: Ia17554314f25c5d09e113bb5c9c0a6b6f1cb1c03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143190
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-14 00:37:41 +00:00
Srujan Gaddam 09e47b6177 [dart:html] Copy test resources from lib_2 to lib 
Some none Dart files were not copied over in the migration. Tests
are refactored to use the lib version over lib_2.

Change-Id: I21053d81770c4f83b01f27af99cec11f08577c7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143330
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-13 23:56:08 +00:00
Srujan Gaddam 114752421d [dart:html] Remove multitest usage in some js tests 
Multitest usage that didn't involve separating out failures is
removed. Static errors are changed to static error tests.

Change-Id: I81d7409ead0005b9788ac80d229ac534279f1658
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142543
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-08 20:05:36 +00:00
Srujan Gaddam 8690bb5653 [dart:html] Change late finals to external getters 
Late final fields in the JS classes in js_typed_interop tests are
changed to external getters instead.

Change-Id: I5ed17e18b5fc59bd7267ac5f8ebda649c6fb21e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142722
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-07 18:44:06 +00:00
Srujan Gaddam 89e7cf3357 [dart:html] Fix named args in js_typed_interop tests 
Closes https://github.com/dart-lang/sdk/issues/41361

Several named args were non-nullable with no default value.
Fixes those instances and transforms some finals to late
initialization.

Change-Id: I2b223e6a8618ff3e98ced98a72f6bb87db1fe1c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142555
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-07 01:05:18 +00:00
Srujan Gaddam a925f4770f [dart:html] Remove 2.7 annotation from lib/html 
Strips out the temporary annotation so all the tests without
NNBD related changes can run in strong mode.

Change-Id: I88f18916f0c5a45a80eddb73941db19984f0bfcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140652
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-06 20:41:14 +00:00
Srujan Gaddam 4d4846c57a [dart:html] Migrate tests with only null asserts 
Remaining tests that don't belong to any particular test
suite, and only needed null asserts to be migrated.

Change-Id: I05141d60e7b50653aa9633e14e832e91d9116408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140651
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-06 20:41:14 +00:00
Srujan Gaddam 5b2482004b [dart:html] Migrate tests that need changes to NNBD 
Remaining tests that don't belong to any real test suite, but
need some changes beyond just null asserts to be migrated.

Change-Id: I91c0cb02eb72ada572a10c567b5d8bac596b16a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142445
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-06 20:41:14 +00:00
Srujan Gaddam 156e1c84c8 [dart:html] Migrate more js tests to NNBD 
Missed by the migration tool on the previous js CL.

Change-Id: I43eb70ed6ecde3b624a951d0e8dd24424935ccf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142444
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-06 20:41:14 +00:00
Srujan Gaddam d3c60e0342 [dart:html] Migrate html tests with dynamic list conversions 
Some tests where the list semantics aren't obvious in what we
want in the migration to NNBD.

Change-Id: I30b2d9cc5c0ea4ea360032b85ef5e48b8db27558
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142267
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-06 20:41:14 +00:00
Srujan Gaddam 16567ab59b [dart:html] Migrate htmlcollection_test to null-safe 
Change-Id: I68a7874cc0afda861cb002901f7db0b58ad4be38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142266
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-06 20:41:14 +00:00
Srujan Gaddam f144d5fdca [dart:html] Migrate css tests to NNBD 
Change-Id: Ia2c76116ad83abbea9721cf5dd812eeb7a47ad71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140650
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 17:43:57 +00:00
Srujan Gaddam 9b2d947786 [dart:html] Migrate indexeddb tests to NNBD 
Change-Id: I5fcd2d53435c70fc90b46c34ea5fbf5f17c450fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140649
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 17:43:57 +00:00
Srujan Gaddam 3438b33dce [dart:html] Migrate custom_element tests to NNBD 
Change-Id: I8554e2e41d56df403d73b34e38636e5108773195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140648
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 17:43:57 +00:00
Srujan Gaddam 364db086ef [dart:html] Migrate fileapi tests to NNBD 
Change-Id: I4c653fcac0f0a2c5ff7dc5b00f794fba4c3fc028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140647
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 17:43:57 +00:00
Srujan Gaddam 39509bae5f [dart:html] Migrate html js tests to NNBD 
Change-Id: I01cf3de95f4d7c67f97d440187a2d7254c7daecc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140646
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 17:43:57 +00:00
Srujan Gaddam 73b325c419 [dart:html] Migrate element tests to NNBD 
Change-Id: Ie7477c232f3f28c7fe597da7d5338ac27a2e33ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140201
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 17:43:57 +00:00
Srujan Gaddam dea080253a [dart:html] Migrate custom tests to NNBD 
DDC should skip some of these by default from the status file,
so these were tested using dart2js in strong mode.

Change-Id: I10a9096a9af7e394c416d26530ac42646991ddc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139964
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 17:43:57 +00:00
Srujan Gaddam 1d44ef07c1 [dart:html] Copy and rename lib_2/html to NNBD. 
Added annotations such that these tests won't fail when submitted.
Added copyright notices if there isn't a copyright notice.

Change-Id: I51ae347d44875cdfa1c6d0dad1bc41e00ea443bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139963
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-04-03 00:36:56 +00:00