cf3a034210
Implement promotion via initialization in flow analysis.
...
Change-Id: I10a5f6bfeb5a05dd144db5212c9f31796f5a2385
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145502
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-30 16:26:27 +00:00
a144fedbba
Migration: add support for --ignore-errors to new CLI
...
Change-Id: I467c3ecfc7e8a7f52a1ba2be887ac2a677d5545c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145543
Reviewed-by: Janice Collins <jcollins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-30 16:23:37 +00:00
136ad8353b
In migration CLI tests, verify that preview server only starts when expected
...
Change-Id: I81555fe4c520761ab14dc1535ad4a9918e226965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145540
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-30 16:23:37 +00:00
768fad820b
Extract EnclosingExecutableContext.
...
Change-Id: Ib4a8344db60c8c717dd6259ff550088d3b30d100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-30 16:18:22 +00:00
5ab3f3506f
migrator: quiver's checkNotNull implies non-null intent
...
Fixes https://github.com/dart-lang/sdk/issues/39315
Change-Id: I136975064c6aadf9b8548afe9b5928d4ee6775a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145569
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-30 16:15:32 +00:00
f4bdd68540
[dart2js] Fix small nnbd bug with code generation.
...
Change-Id: If82cb22b8dfed6bbae7ea531bc6ed0ff925a8579
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145563
Reviewed-by: Mayank Patke <fishythefish@google.com >
2020-04-30 15:09:09 +00:00
a9b81e18d9
[cfe] Handle dynamic return in async
...
Closes #41437
Change-Id: I493b516f0b72fc1da097b92bd75150aea8e60ba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145042
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-30 12:39:04 +00:00
c08bcbb25e
[CFE] Enable textual outline sorting in test suite
...
Change-Id: Iccf35b9cb3dce96487ca9ba688394e3b05be2e75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145401
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-04-30 08:25:17 +00:00
b1435ec38a
[CFE] Textual outline can sort data
...
Change-Id: Iac337903aace923f2cff8797840aa5cdbfded03f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145400
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-04-30 08:25:17 +00:00
f66e1ed7be
[CFE] Textual outline expect files
...
Change-Id: I5cc3339880d0a77fbbcbd9f8a22e1186e5e2a5df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145380
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-04-30 08:25:17 +00:00
e046afac1f
[cfe] Don't print nullability on Null in messages
...
Change-Id: I530d3eef1a0af73d68aaccf33095ab2dcaf4747c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145461
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-30 08:16:24 +00:00
afd43c4302
[VM] Mark all indirectly dependent code dirty on hot reload (2nd try)
...
The idea behind this is that the incremental compiler can now
(currently experimentally) recompile less if the outline didn't change.
This also mean that it can output less (e.g. only the changed library).
This change should make sure that the VM still invalidates everything
it needs to.
See also:
https://github.com/dart-lang/sdk/issues/34001
https://dart-review.googlesource.com/c/sdk/+/77722
This reverts commit 430506109dhttps://dart-review.googlesource.com/c/sdk/+/144824
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2020-04-30 07:52:24 +00:00
3a65f2ccd0
[release] Change version for 2.8 to 2.8.1
...
2.8 needs another cherry-pick but 2.8.0 has already been released on the
Flutter beta branch. To be on the safe side, bump the version to 2.8.1.
Change-Id: I977113b3272264e903b9150b5185c0eadb769057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145581
Reviewed-by: William Hesse <whesse@google.com >
2020-04-30 06:54:58 +00:00
9b9f89a64c
[co19] Skip not migrated to NNBD folders in a status file
...
Change-Id: Iaf54ad33ae79291caffda74843d46a238b6c2a17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144945
Reviewed-by: Sergey Grekhov <sgrekhov@unipro.ru >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Sergey Grekhov <sgrekhov@unipro.ru >
2020-04-30 05:29:14 +00:00
654b725ee4
[tests] Fix cast_test and migrate to nnbd.
...
Also splits up cast_test to test collections separately and
updates corelib_2 version with the same changes, including
fixes in relevant pending CL:
https://dart-review.googlesource.com/c/sdk/+/126320
Fixes #39517
Bug: http://dartbug.com/39517
Change-Id: I8df1fde1d48ed23561ce9d0d8b87d7fc2ba52eb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144469
Commit-Queue: Riley Porter <rileyporter@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-04-30 02:33:53 +00:00
ef1528aa78
[js_runtime] Never is a bottom in legacy mode
...
Opt-in code can have Never types even with legacy subtyping.
Bug: 41675
Change-Id: I6dbdc064dceeedf0774d10faaca336561b41b7d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145561
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2020-04-30 01:41:02 +00:00
94c81a137b
[dart2js] Remove redundant check for Object when printing bounds.
...
Change-Id: I7e8190ac9d0095cf1bb225f94184eceba00ba887
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145308
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2020-04-30 00:36:28 +00:00
cde8098c97
[nnbd_migration] Improve error message quality
...
Change-Id: I3da17864861dc58df7cde9d1c6b034715f1c88bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144684
Commit-Queue: Janice Collins <jcollins@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-30 00:25:48 +00:00
d2ae466056
[vm/aot] Update references from types to mixin applications after deduplication
...
CFE may use anonymous mixin application classes in types after
applying LUB (Least Upper Bound) algorithm in conditional expressions,
and then those types can spread via type inference.
After anonymous mixin application classes are deduplicated, all
references to removed mixin applications from types should be
updated to point to the remaining mixin application.
Fixes https://github.com/flutter/flutter/issues/55345
Change-Id: I7860b2868cb153d125fec363c1653b7aa16521e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145501
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-04-29 23:54:08 +00:00
4aec1e76e2
Record and report the completion suggestions that take the longest to compute in completion_metrics.dart.
...
Change-Id: I5a4043a9754439c38be6b86c094a895366c2afc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145562
Commit-Queue: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-29 22:38:58 +00:00
5506769402
Count variables checked with ArgumentError.checkNotNull as not null
...
Fixes https://github.com/dart-lang/sdk/issues/39644
Change-Id: I552e87e7c57dd2c5a012b76d9c73c24fefb19785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145025
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-04-29 22:35:18 +00:00
61755dea19
Migrator: Infer late for test variables
...
Fixes https://github.com/dart-lang/sdk/issues/38291
This change also involves moving the "package" where test sources are
written and analyzed; It used to be /home/test (or /project in some
places); and a pubspec.yaml was written (or a .packages file) which
specified the package's name was "test". However, this conflicts with
adding an entry for a mock copy of the actual _test_ package. A
.packages file cannot have two entries for a package named "test", so
the package where all test sources are written is changed to "tests"
(located at /home/tests).
Change-Id: I462b88a814931dc2d4f1e72d07e3daf64768a399
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144994
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-04-29 22:09:28 +00:00
62d5f57477
Migrate language_2/extension_methods to NNBD.
...
Change-Id: Ic4426baeb9d02624af5f60106473a1eeced15310
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142780
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-04-29 21:36:28 +00:00
3dc7664a8a
Additional tests in override_contributor_test.dart
...
Change-Id: I04311b5685bb853926ebef4c20aef5ac58b5881d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-29 20:54:04 +00:00
7deb5a3874
Fix documentation for EXPORT_LEGACY_SYMBOL.
...
With https://dart-review.googlesource.com/c/sdk/+/145220 specifying
the current language version using `// @dart=` does not opt-out from
experiments.
Change-Id: Ibee76c35af8e829bef7d14347fe155ba876c1033
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-29 20:36:39 +00:00
1784caa31d
Completion metrics bug fix, pass in DartdocDirectiveInfo() when creating a DartCompletionManager()
...
Change-Id: Ib9a1c15016d3ed2427510e58dd63458655a50b5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145504
Commit-Queue: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-29 20:05:44 +00:00
3388e5765b
Revert "[vm, gc] Address data race when recycling TLABs."
...
This reverts commit 8241779d833495158ec96e37605661https://dart-review.googlesource.com/c/sdk/+/145444
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-04-29 19:47:24 +00:00
70f8e1810c
[infra] Add linux-debug-canary configurations used by canary builder
...
With this change, each configuration is run on only one builder (per
branch). We need this to start processing and storing results by
configuration instead of by builder.
Change-Id: Ib11c1f3b459c2992440ce8a3540c455deb64b9f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144701
Reviewed-by: Jonas Termansen <sortie@google.com >
2020-04-29 19:45:18 +00:00
4d1ca6316f
Migration: fix mock SDK path for testing CLI on windows.
...
Bug: https://github.com/dart-lang/sdk/issues/41678
Change-Id: I191699a5b9f39445be1bccad5e1e44d6b568d486
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145441
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-29 19:11:54 +00:00
c6f94c3224
Migrtaion: add a hook to allow the preview server to be shut down in unit tests.
...
Without this, it's possible for a unit test failure to result in a
preview server remaining open, which can prevent test execution from
terminating.
Change-Id: I8a11056da5bea003dfa46e3871a241e8f5ce8cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145440
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-29 19:11:54 +00:00
fa6cc57a32
Reland "[vm] Make VM support .dart_tool/package_config.json"
...
This CL makes the VM add support for .dart_tool/package_config.json via
* the --packages=<file> command line parameter
* the `packageConfig: <file>` parameter to `Isolate.spawnUri`
It also allows now `package:*` uris being used in `Isolate.spawnUri`
The CL also removes the unused `packageRoot` parameter from the Dart to
C++ interface as well as in various places in C++.
The CL also aligns the implementations between sdk and sdk_nnbd more.
Issue https://github.com/dart-lang/sdk/issues/41649
Issue https://github.com/dart-lang/sdk/issues/41245
Issue https://github.com/dart-lang/sdk/issues/41246
Change-Id: I0a7aa3040332abafa19bf80bdbd8a8f8594cc6fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145462
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2020-04-29 19:05:26 +00:00
e580dd8e84
[dart2js] Remove hardcoded paths in dart2js unit tests.
...
Change-Id: Ic223c44d917ca55f07f9f62752a91ef4db325444
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145180
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-04-29 18:24:24 +00:00
cb77214f19
Revert 2 of the override_contributor.dart changes from last week.
...
This reverts commit f7d14e4945588642https://dart-review.googlesource.com/c/sdk/+/145481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-29 18:22:49 +00:00
53601ecc18
Implement available suggestions in completion_metrics.dart, a flag is added to enable the new feature.
...
Change-Id: Ib7477b1a517d4aa1dc09d85df3df553ca61baa2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145241
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-29 17:59:24 +00:00
82e4a4465b
Migrator: change sdk constraints to >=2.9.0 <2.10.0
...
Bug: #38347
Change-Id: Iedb9acfe313a14d4c35f3637f3ef0104e836dd4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145260
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-29 17:47:44 +00:00
2693b80dfd
[nnbd_migration] Do basic categorization of edit types to suppress noise.
...
We really should switch this, if possible, to use the edit kind APIs
that the preview tool uses, so that we can categorize this without
guesswork.
However this will keep it as a rough list, and I don't know if we need
anything fancier that currently -- and it will no longer produce noise
if new changes are added.
(currently produces "and 0 other changes" when running on flutter, so
it's probably mostly comprehensive currently).
Change-Id: I9cb2662995af340346a61d38eba3469927a0f4ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145160
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-04-29 17:22:44 +00:00
e20731c0c3
Exit sooner from VariableModel.write() when writeCaptured.
...
No semantic changes, I think.
Just a step closer to what the spec says.
R=paulberry@google.com
Change-Id: I3b27c3daa3b93d425ede56bc1b2b1056210135d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145243
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-04-29 16:32:54 +00:00
8241779d83
[vm, gc] Address data race when recycling TLABs.
...
Fixes TSAN failures in vm/cc/ExerciseTLABs.
Change-Id: I7b319d7dcff3fa7d77f08177efb08a9db7bc533d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145310
Reviewed-by: Alexander Aprelev <aam@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-04-29 16:26:04 +00:00
6c1f8a0fb6
Split migration_cli_test.dart into Windows and Posix tests.
...
Since the tests use a MemoryResourceProvider we can run both kinds of
tests on both platforms. That should make it easier to track down and
fix issues occurring under Windows (see
https://github.com/dart-lang/sdk/issues/40381 ).
Change-Id: Ie058f8c08923a3ef4ea12c5f28219e48aa17c28d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145026
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-29 16:20:44 +00:00
30fcb067e0
Rework how migration_cli_test tests the preview server.
...
This mechanism is simpler, and it has the advantage that if the
preview server fails to start for some reason, we get a useful failure
message rather than a timeout.
Change-Id: I6ead899b3af02431c2a022fa104c6596ff952917
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145142
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-29 16:20:44 +00:00
51a66bcfa2
Use SuggestionBuilder to build suggestions for field formal parameters
...
Change-Id: I157cc755f4bad5086c8e44d7e89504e31283e6bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145442
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-29 15:30:14 +00:00
2ccfc88f25
Change Feature.restrictToVersion() to keep features of the current language version.
...
See https://github.com/dart-lang/sdk/issues/41691
Change-Id: I3ee40592158d4054d187120048f1eb805108ee69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145220
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-29 15:24:54 +00:00
d131ea4e13
Add Variable type parameter to VariableModel.
...
So, we can use exact type for TypeOperations, and it will be convenient
for implementing promotion via initialization.
R=paulberry@google.com
Change-Id: I5b1243d5a4ac95f92ee1d08e6ed64be09e8c8f53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145306
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-29 15:08:23 +00:00
0b1451c5fd
[dart2js] Trivial nnbd fix for no_such_method_forwarders_test.
...
Change-Id: Ib55e3c632c99e0700d239fe0c62e35aeadb0bf0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145301
Reviewed-by: Mayank Patke <fishythefish@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2020-04-29 14:21:03 +00:00
64c9984ecf
[dart:io] Fix HTTP parser not decoding header values as Latin-1.
...
This change reverts an accidental breaking change in 6a5b87fhttps://github.com/dart-lang/sdk/issues/41688
Change-Id: I02bae07b5721eb4cbec789ad912c7fe6e2b2b015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145244
Reviewed-by: Jonas Termansen <sortie@google.com >
Commit-Queue: Jonas Termansen <sortie@google.com >
2020-04-29 12:58:53 +00:00
b67a1313ae
[cfe] Add an option to inspect internal state of text serialization
...
The option is added to the unit testing framework and is supposed to
be used locally.
Change-Id: Ia043ca35d27c15e597fe1b66429f923ccb24f3dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144825
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2020-04-29 10:36:40 +00:00
12a5c93d4a
Revert "Reland "[VM] Remove unnecessary Closure.clone() from sync*.""
...
This reverts commit 1bf25798fa430c75b5faca94ad7112https://github.com/dart-lang/sdk/issues/37753
> > > Change-Id: If099dbfe9e5d62979626b852386fd0173fc76de5
> > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136190
> > > Commit-Queue: Clement Skau <cskau@google.com >
> > > Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
> >
> > TBR=vegorov@google.com ,cskau@google.com
> >
> > Change-Id: I89e517196f03622337f909f0fcecbdc77c9dda93
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: https://github.com/dart-lang/sdk/issues/37753
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144920
> > Reviewed-by: Clement Skau <cskau@google.com >
> > Commit-Queue: Clement Skau <cskau@google.com >
>
> TBR=vegorov@google.com ,cskau@google.com
>
> Change-Id: I78589c83cbb17151ca4ab8f811b4f18f252fb9c1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: https://github.com/dart-lang/sdk/issues/37753
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144921
> Reviewed-by: Clement Skau <cskau@google.com >
> Commit-Queue: Clement Skau <cskau@google.com >
TBR=vegorov@google.com ,cskau@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/dart-lang/sdk/issues/37753
Change-Id: I879df17bd282d01468fa010b94a8c89afdb8cd0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145361
Reviewed-by: Clement Skau <cskau@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2020-04-29 09:52:30 +00:00
871983d8ae
Revert "[VM] Fixes missing bits for new sync* transform."
...
This reverts commit 05b7f49c72https://github.com/KhronosGroup/glTF-Validator
>
> TBR: To unblock roll blocked by crash.
>
> Bug: https://github.com/dart-lang/sdk/issues/37753
> Change-Id: Ie20f351b16f2f87e92f0731fc96b0a5ea29e0300
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144948
> Commit-Queue: Clement Skau <cskau@google.com >
> Reviewed-by: Clement Skau <cskau@google.com >
TBR=kustermann@google.com ,cskau@google.com
Change-Id: Ided526100e7393375445545d0fe16806333b0d20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/37753
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145360
Reviewed-by: Clement Skau <cskau@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2020-04-29 08:35:52 +00:00
05b7f49c72
[VM] Fixes missing bits for new sync* transform.
...
The missing part of the transform fixes an issue that manifested
as a crash when running tests for [0].
Which was caused by un-transformed yields in nested functions in sync*s.
The second half of this CL updates the type_checker tool for the new
transform of sync*s.
[0] https://github.com/KhronosGroup/glTF-Validator
TBR: To unblock roll blocked by crash.
Bug: https://github.com/dart-lang/sdk/issues/37753
Change-Id: Ie20f351b16f2f87e92f0731fc96b0a5ea29e0300
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144948
Commit-Queue: Clement Skau <cskau@google.com >
Reviewed-by: Clement Skau <cskau@google.com >
2020-04-29 06:56:14 +00:00
1eb7ed02eb
Fix leak of changed FileState(s).
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I8b68eee0b0a3cdf613912615198990edec7768dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145309
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-29 05:10:14 +00:00
Konstantin Shcheglov