Commit Graph

7 Commits

Author SHA1 Message Date
Sam Rawlins 638523c3e1 analyzer: Fix addtional language test
which was broken by https://dart-review.googlesource.com/c/sdk/+/143248

Change-Id: Id14c6583a2838f85d21da56575aa2ecaf538160a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2020-04-13 17:27:51 +00:00
Sam Rawlins c9710e5059 analyzer: Do not report on a bad type of return expression if function has illegal return type
Fixes #38188 and fixes #41439

Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-04-13 03:42:35 +00:00
Konstantin Shcheglov 2854d6f4c0 Add the analyzer error on return in language/async/or_generator_return_type_stacktrace_test
Change-Id: If3e6b9c62c53389c428149ef6ff267b4cf6cfaf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143010
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-04-10 15:54:24 +00:00
Johnni Winther 62f84880ef [cfe] Report error on missing return from non-nullable function
Closes #40520
Closes #40948
Closes #40425

Change-Id: I0aa3cfa51b410c90dd0bea963846eeb6b2e73efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140540
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2020-03-24 08:21:36 +00:00
Leaf Petersen 7aace6fa60 Make StackTrace generally not nullable in migrated NNBD library.
Bug: https://github.com/dart-lang/sdk/issues/40130
Change-Id: I13aba0c2a3fa5b1c3d3995f075ffd38f03aca897
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139880
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-03-19 23:31:30 +00:00
Robert Nystrom 434f7228bf Make parameter required to fix nullability error.
It is only used in one place and is always passed.

Change-Id: I8bdc46963ee9e10591edb951dc72e065ba5678cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137760
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2020-02-28 01:43:01 +00:00
Robert Nystrom 16f072c783 Migrate language_2/async to NNBD.
Change-Id: Id66e712eaf52fda2069ce5177aa091e373ad52c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134244
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
2020-02-27 23:04:03 +00:00