dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
72,374 Commits 2 Branches 0 Tags
cf3a0342102b8ec2094de629dfb891134df9de3c
Commit Graph

5143 Commits

Author SHA1 Message Date
Johnni Winther e046afac1f [cfe] Don't print nullability on Null in messages 
Change-Id: I530d3eef1a0af73d68aaccf33095ab2dcaf4747c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145461
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-30 08:16:24 +00:00
Robert Nystrom 62d5f57477 Migrate language_2/extension_methods to NNBD. 
Change-Id: Ic4426baeb9d02624af5f60106473a1eeced15310
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142780
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-29 21:36:28 +00:00
Paul Berry 885de405d2 Add test to validate resolution of #39641. 
This test validates my understanding of
https://github.com/dart-lang/sdk/issues/39641#issuecomment-573669413,
namely that when assigning to a promoted variable, the context used to
do inference of the RHS of the assignment should come from the
promoted type, but it should still be ok if the RHS doesn't evaluate
to a subtype of the context type (in which case the assignment
de-promotes).

Change-Id: Iafb2e741f8b9631a9b017804a5ad59972bfc638e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144883
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-28 23:28:13 +00:00
Nicholas Shahan 3da1591253 [ddc] Fix function type casts in weak mode 
Allow null to be cast as function types in weak mode.

Change-Id: I42084250c428b7e6a18ce343305d43603b4e1ec4
Fixes: https://github.com/dart-lang/sdk/issues/41680
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144995
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
 2020-04-28 21:19:54 +00:00
Robert Nystrom 5ed88471ec Migrate language_2/function to NNBD. 
Change-Id: I0726fa252736a83a2d80345d71c05aacf8ed0649
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142941
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-25 01:53:20 +00:00
Konstantin Shcheglov 46a2086e6c Issue 41479. When terminate null shorting at CascadeExpression, don't make it nullable. 
Bug: https://github.com/dart-lang/sdk/issues/41479
Change-Id: I2d843846ca2a0232dbea60ad2b71e745ac118588
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144672
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-24 18:45:13 +00:00
Leaf Petersen 6befc18cae Add tests for assignability around Never. 
Change-Id: I2d3548eb609743277c026155d70fc1cb4d976cc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143040
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-24 04:38:43 +00:00
Nicholas Shahan 1accf661e2 [tests] Break test into weak and strong versions 
In weak mode A<dynamic> is a subtype of A<Object>. Break out this
expectation into separate files for weak and strong modes.

Change-Id: I8d7b10d836eeb4a3221fe51ee7717aa544347b05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144682
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-04-24 01:03:52 +00:00
Nicholas Shahan ea03ea355c [tests] Loosen weak expectation to any throw 
The current behavior is inconsistent across the backends so locking this
down in weak mode feels like a subtle breaking change. The VM currently
tries calling .iterable and throws a NoSuchMethodError. DDC throws a
TypeError.

Change-Id: Ib121a91f045a4f190be77dc57b5c216d818e0301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144683
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-04-23 21:54:10 +00:00
Nicholas Shahan 23cbe39355 [ddc] Remove error handler from number parse helpers 
This copies the logic from dart2js and brings the two patches closer
together. There is no need to pass the error handler to the helper
function shared between `parse()` and `tryParse()`.

Update JS foreign function types in parseDouble to match the NNBD
version.

Fixes: https://github.com/dart-lang/sdk/issues/41613

Change-Id: I85d39f8ba6bd76459cf6263099983b8b96d3a669
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144304
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-04-22 16:07:29 +00:00
Liam Appelbe 87b829bacd [nnbd] Fix some more strong mode tests 
All these tests now pass in both weak and strong mode, except for
relation_subclass_test and typedef_reflected_type_test. For those 2
tests I fixed the compile time error and now they have the same runtime
errors in both weak and strong mode (they were already failing at
runtime in weak mode).

Change-Id: If0157f811fffcf72a12ce6690ac0568c8f4419a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144343
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-04-22 00:12:24 +00:00
Erik Ernst ad8ed8bd46 Add test: await voidExpression is an error iff null-safety is enabled. 
Change-Id: Ibdd201b595b8835015a1a17417ee1d6e76030676
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144140
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2020-04-21 15:30:03 +00:00
Konstantin Shcheglov 7e4673f497 Check overrides using only direct superinterfaces. 
Change-Id: Ib17c3fb18d6ec4ff4541835a78c645a7b13affd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-21 02:42:04 +00:00
Konstantin Shcheglov eae75026fa Update tests after rename to UNCHECKED_USE_OF_NULLABLE_VALUE. 
R=brianwilkerson@google.com

Change-Id: I51544b0955a906920aa80ae30aa9ecbf80294baf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-20 02:39:25 +00:00
Nate Bosch 0416cfd075 Add a static error test for default catch type 
Static error test for https://github.com/dart-lang/language/issues/922

If the type of the error argument was `dynamic` there would be no error
for calling a method that does not exist.

If the type of the error argument was `Object?` there would be an error
for the call to `_takesObject`.

Change-Id: I3cec1a8ae2903887e5da086cdeecd4008ef5d667
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143329
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-16 20:52:45 +00:00
Konstantin Shcheglov 21f42b4305 Fix covariant/return_type_test 
Change-Id: Ie71d0579ed52af187dacc8f642425866da6a2d2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143246
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 18:18:22 +00:00
Konstantin Shcheglov 7ed155ff49 Update analyzer expected error range for language/operator/invalid_operators_test. 
Change-Id: I1acbbfd8dd173f90a49231577c67678d94040c8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143247
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 18:00:37 +00:00
Konstantin Shcheglov ec3dd52462 The type 'dynamic' is defined in dart:core. 
This makes fixes to analyzer and update the test for updated spec.

Change-Id: Ie5222bcf9056d5cbb7f18437dec04d5af21ff314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:55:36 +00:00
Sam Rawlins 638523c3e1 analyzer: Fix addtional language test 
which was broken by https://dart-review.googlesource.com/c/sdk/+/143248

Change-Id: Id14c6583a2838f85d21da56575aa2ecaf538160a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-13 17:27:51 +00:00
Sam Rawlins c9710e5059 analyzer: Do not report on a bad type of return expression if function has illegal return type 
Fixes #38188 and fixes #41439

Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 03:42:35 +00:00
Konstantin Shcheglov 23a8788f6a Issue 41378. Update on-catch and throw for the spec changes. 
Now it is not an error to use a potentially nullable type in on-catch.

But it is an error for throw an expression of type that is not
assignable to Object.

Bug: https://github.com/dart-lang/sdk/issues/41378
Change-Id: If0a198ae618cd01d03f45a46aa1efa6179df76ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-11 20:08:03 +00:00
Leaf Petersen b135aab6d7 Fix bad test expectation, convert to static error test 
Change-Id: I821dd3af8c1be346d983bd41bb80efefba176cd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143102
Auto-Submit: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-04-10 18:07:44 +00:00
Konstantin Shcheglov 2854d6f4c0 Add the analyzer error on return in language/async/or_generator_return_type_stacktrace_test 
Change-Id: If3e6b9c62c53389c428149ef6ff267b4cf6cfaf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143010
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:54:24 +00:00
Leaf Petersen 9a51d7003d Fix top_merge tests. 
Fix several issues causing spurious errors in the top_merge tests and
remove one test file for which there is not a sensible resolution of
the issues.

Change-Id: Ia7fcdc02c0461980bae99cdbdc78bfac18d3efb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142887
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2020-04-10 01:05:41 +00:00
Leaf Petersen e8ff0c884e Add tests for null safety boolean conversion. 
Tests for the null safety spec clarification landed in
https://github.com/dart-lang/language/pull/917 .

Change-Id: Ieafe5315c31919c01ff816a26d29fa0d1cbc8c9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142782
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-10 00:46:06 +00:00
Robert Nystrom 07e606ec65 Migrate language_2/dynamic to NNBD. 
Change-Id: I51434a653b5b9ef65a185dc11cdff2aa9ab3e359
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142546
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-04-09 21:27:22 +00:00
Robert Nystrom bcf8a7fc51 Migrate language_2/enum to NNBD. 
Change-Id: I6d1045d95d0ea1c7e9a1f9fa8524687ed4dd8480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142562
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-09 14:47:19 +00:00
Robert Nystrom a7e3c5507f Migrate language_2/final to NNBD. 
Change-Id: I20328968f057658d4cb25e2a51a02745af3af211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142885
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2020-04-09 00:00:26 +00:00
Leaf Petersen 8e5e74e7c9 Test TOP_MERGE on super-interfaces. 
Test that TOP_MERGE correctly resolves multiple super-interfaces.

Change-Id: Iba7b4c63cb21ce8ffe1c82b235668c3c3f0f0e05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141847
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-08 20:21:08 +00:00
Leaf Petersen 5ba1b3f904 TOP_MERGE member override tests. 
Tests for member signature resolution as specified in this change:
https://github.com/dart-lang/language/pull/904

Change-Id: I7ee81dd1927b8f9419082f9bd2cbec14f0a5c0f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142802
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-08 20:19:52 +00:00
Robert Nystrom a1e2a2c76a Migrate language_2/factory to NNBD. 
Change-Id: Icc5193e503d8f7d9da240cb2ba4b22edc7290dbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142801
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-04-08 19:18:14 +00:00
Robert Nystrom 8e9d1445dd Migrate language_2/field to NNBD. 
Change-Id: Ic0c7e51d6be12dba4500f0fc41378466c6043245
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142803
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-08 19:16:25 +00:00
Robert Nystrom 22b8caff1f Migrate language_2/export to NNBD. 
Change-Id: Ib33ec31e1d200d602fd05439101847afbb629f47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142709
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2020-04-07 23:30:56 +00:00
Robert Nystrom 74ef393e6d Migrate language_2/exception to NNBD. 
Change-Id: I0f758fce0af79be77b2fc885afcc3bd17d9fb55e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142701
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-07 22:13:46 +00:00
Riley Porter ed086f0f95 [tests] Remove more deprecated List constructor usage in tests 
Change-Id: I9a6da832ee51f9362bb2ea4f17931a109b36456e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142721
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Riley Porter <rileyporter@google.com>
 2020-04-07 20:09:26 +00:00
Erik Ernst e2e722463c Adjust member signature expectations for mixed inheritance 
The rule NNBD_TOP_MERGE(S*,T) = NNBD_TOP_MERGE(S,T) and the converse
imply that when a legacy member signature and a null-safe member
signature are brought together by two different superinterfaces,
the null-safe signature prevails (so the legacy signature is ignored).

This CL makes adjustments to 'legacy_resolves_conflict_3_test.dart'
to match this. Note that this means that a class like DiB3 has a
member signature `int Function(int) get a` even though it inherits an
implementation with signature `int? Function(int?) get a`, so we may
have to make such classes an error. [Edit: Based on the notion of
a 'class implementation', which is consolidated in the same sense as
the class interface, but which records the concrete member
declarations available in superclasses, with the declaration in the
nearest superclass prevailing over declarations in more remote ones,
the conflict disappears in the usual way: The class implementation
of a legacy class is legacy-erased. So there are no errors for those
classes after all.]

Change-Id: Ie72e6b80064764fa722304f32bee5e9188710a2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142372
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-04-07 12:20:21 +00:00
Konstantin Shcheglov 8a8c2e74d2 Update constants_2018/constant_types_test to allow type parameters in 'as'. 
Change-Id: I37b0413914d6677e2be53fb0ce98c51f81694edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142568
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-07 06:50:28 +00:00
Leaf Petersen 6cb98c55d5 Add tests for extended GLB. 
This adds tests for the specification change from
 https://github.com/dart-lang/language/pull/903


Change-Id: I2344ea32ac1ca51360ed262f761d14e8db7045bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141841
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-07 02:57:18 +00:00
Robert Nystrom 5f655a8c27 Migrate language_2/covariant to NNBD. 
Change-Id: Icb4eae77fab5257ea00ff948d3f775725398e6ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142067
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-07 01:05:28 +00:00
Robert Nystrom 8f85a9efe4 Migrate language_2/constants_2018 to NNBD. 
Change-Id: I52dee4ed475611ce4ea5d0d45914717ff13f5b8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141768
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-06 23:32:25 +00:00
Konstantin Shcheglov 4558607b05 Update language/constructor/return_test 
Change-Id: I432bbe74a84ad7c0dfe7e974b1f0962dfeb9a312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142548
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-06 23:08:38 +00:00
Robert Nystrom 9be92b28f1 Migrate language_2/double to NNBD. 
Change-Id: I72b95b7d84847c1b7c4e89ba607dfca6d9069854
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142212
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-04 00:25:17 +00:00
Robert Nystrom 8cb5ba4adc Migrate language_2/double_literals to NNBD. 
Change-Id: I6c9041c80cec102c301e59b3bc30d8a86b9b98b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142300
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-04 00:20:37 +00:00
Robert Nystrom ed571882d2 Migrate language_2/constructor to NNBD. 
Change-Id: I2f638cbf6b0fc6e91b3666143a34eb12a66c6fea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141780
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-04-04 00:14:32 +00:00
Konstantin Shcheglov f91880f9e6 Update analyzer expectation for language/const/switch2_test 
Change-Id: I787c81947f0396243ac97cdd694ae300639d33f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142442
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-04 00:12:32 +00:00
Robert Nystrom a4b09ac192 Migrate language_2/control_flow_collections to NNBD. 
Change-Id: I8b9b7d70abc47d672c68db65bc67d08beb7d41a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142089
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-04 00:04:27 +00:00
Konstantin Shcheglov 90574ee9fd Add default values for optional parameters in const/constructor2_test 
Change-Id: Ibf8066d7c4eb5c047a6423efb4529ac9fa620459
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142403
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 21:44:06 +00:00
Robert Nystrom fd3882091c Migrate language_2/deferred to NNBD. 
Change-Id: I6c936a9ad34befccf1b6775d7c9bdc621995a96f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142280
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-04-03 20:04:47 +00:00
Aske Simon Christensen f41de20d46 [vm] Fix unsound code motion through checks. 
Fixes https://github.com/dart-lang/sdk/issues/40765

Change-Id: If3b239c832c5137ad6999ab6e6ff3196bf54a6af
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137970
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2020-04-03 15:55:15 +00:00
Erik Ernst 72e4d14983 Moved several classes with compile-time errors to 3_error_test 
Johnni Winther noted that several classes in
'legacy_resolves_conflict_3_lib2.dart' must be flagged as errors,
because they have incorrect override relationships between declarations
in the class and a the member signatures of a direct superinterface.

This CL moves those classes out of
'legacy_resolves_conflict_3_lib2.dart' and into
'logacy_resolves_conflict_3_error_test.dart',
such that they are only in scope in the library that expects compile-
time errors. Adjusted other libraries to stop referring to these
classes, and marked the classes with the expected errors.

Change-Id: Ia40f56efcb3dea17e60652dd8a2bbb892f89e5b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142142
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-04-03 07:02:46 +00:00