dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
72,374 Commits 2 Branches 0 Tags
cf3a0342102b8ec2094de629dfb891134df9de3c
Commit Graph

103 Commits

Author SHA1 Message Date
Joshua Litt 8495451a6b [dart2js] fix id testing labels. 
Change-Id: I4d40cf9f0b99fa8534d3c6b98deaa4a9a1616231
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144620
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-04-24 15:30:13 +00:00
Joshua Litt 6f5f7ad05c [dart2js] rebase deferred_loading_test for nnbd. 
Change-Id: Ia8cd18e19554afec57675bab64797984445556c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143820
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-04-23 01:17:58 +00:00
Joshua Litt b69e1fd96f [dart2js] Manually opt out tests/compilers/dart2js*. 
Change-Id: I6a8a20e9ae58a56bd7e99a714ab94e73cae2f315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140252
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2020-03-21 16:12:36 +00:00
Johnni Winther 5829fc7829 [analyzer,cfe,dart2js] Add marker.options files to automate running id tests on all configurations 
Change-Id: Ib5eb7f3967634721047f8dcc57b9e6c350b91a41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136226
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-02-21 08:34:26 +00:00
Sigmund Cherem d735f1f12d (dart2js): enable new-rti by default 
This change:
* adds the `--use-old-rti` flag to revert to the old behavior
* enables the new behavior by default
* changes the -rti- builders to run the old rti instead of the new rti
* documents the change in CHANGELOG.md

I've kept around the logic as `useNewRti` to avoid swapping all the conditions
in the compiler.

Change-Id: I773ac33b658cb60f72e0b6beef83375abec31bad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127492
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2020-01-04 00:44:25 +00:00
Johnni Winther e3a20bf361 [analyzer,cfe,dart2js] Support annotated code generation 
Add support for generating annotations from actual data using
option -g

Change-Id: I88d9cdb62a38d579234b15097c9e9bb3d81ebe8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129708
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-01-03 13:57:39 +00:00
Kallen Tu 53bbe6c88c [dart2js] Added variance support for static subtype checking. 
Change-Id: I0731884aad68e3dd7f84658d75e946ca5db62bbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127063
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-12-04 20:54:16 +00:00
Stephen Adams bd47ec2f37 [dart2js] new-rti: Simplification and branch-strengthening for 'is' 
Change-Id: I49d712b303400fe2f2109b6c9f8fb684917df0ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112701
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-08-12 20:40:06 +00:00
Johnni Winther 9adf3c119e [dart2js] Remove testing of no-constant-update-2018 state 
Change-Id: If445307c28d9989f3b3c56d905e5bbe0d5f25ac6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112388
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-12 07:20:23 +00:00
Stephen Adams 41263a4c1a [dart2js] Fix for 37502: double ~/ x returns int 
http://dartbug.com/37502 shows the type-propagation results of ~/ is double instead of int.

Bug: 37502
Change-Id: Iec7b8a876a20784c7d2858305eaa67e9d02a63dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109889
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2019-07-22 20:54:10 +00:00
Johnni Winther 7075ae7026 [cfe+dart2js] Move features to CFE 
To share support for annotated tests based on Features.

Change-Id: Ic319442e2e016bf4d1584825ea019d13a74acedb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109560
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther dfa12c7456 [cfe+dart2js] Support library and error ids in annotated tests 
Change-Id: Ife808a7d4aa1d4cf459ac3c04ee6ff02042442d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108810
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-16 14:32:37 +00:00
Johnni Winther fdd3822e3c [cfe+dart2js] Move annotation testing logic to front_end 
Change-Id: Ic53c3d34d5c56232ac011e99972ef8f145aac6da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108602
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-07-11 10:49:23 +00:00
Lasse R.H. Nielsen 25319ef7a6 Fix bug in codegen/string_escapes_test.dart. 
Both a bug in the framework and the test not mathcing the current specification
of multiline strings.

Fixes #33060

Bug: http://dartbug.com/33060
Change-Id: I8937c768f560d119cb16f3684d9407db2ab04c35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108408
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2019-07-09 13:56:32 +00:00
Johnni Winther 4ceefdbe4c Rename ElementId to MemberId and use member: prefix instead of element: 
Change-Id: I71c82318357881230edcaeefe1d86ceb50473c73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108261
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-04 12:53:55 +00:00
Johnni Winther f889bd7067 Delete JavaScriptBackend 
* move names to Identifiers
* move resolution parts to front end strategy
* move codegen parts to backend strategy
* remove now unneeded methods from FrontendStrategy and BackendStrategy

Change-Id: I0675d56045dd212ad195177ecd23b27b0d849a80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105742
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-06-13 10:09:46 +00:00
Johnni Winther 30d118d429 Handle deferred expressions and names in model_test 
Change-Id: I262532c2c0e58e5066376c18d7bd1478502fe539
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104301
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-05-31 17:06:44 +00:00
Johnni Winther 0db620a2a5 Decouple Namer from RuntimeTypesEncoder and Tracer 
Change-Id: I1c52b6740b590b1089201c3d0d8286d8e0912c48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101824
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-05-10 08:58:29 +00:00
Johnni Winther 1c1af2808f Introduce Codegen interface to decouple JavaScriptBackend from the codegen phase 
Change-Id: I7effc20d34fa5d5da799c690182eb6f09948c6ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101288
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-05-07 07:57:06 +00:00
Johnni Winther 28faf8c7ca Merge GraphBuilder into KernelSsaGraphBuilder 
+ avoid use of `compiler` and `backend`
+ make members of KernelSsaGraphBuilder private when possible

Change-Id: Ia069a8c3b4167c1ae55554baadb857975aeff67f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101287
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-05-06 08:53:24 +00:00
Johnni Winther 8053c43dde Compute static types for for-in loops 
Change-Id: I47e98eaf6df7d04286cb737bfdff135e6c0d34d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100843
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-05-01 14:06:39 +00:00
Johnni Winther a1dd732ec6 Extract WorldBuilder results into an immutable BuiltWorld object 
For resolution this is the KClosedWorld and for codegen this is the new
CodegenWorld object. This change removes the use of the world builders
after the world building has ended. It prepares for computing more of the
result data from the collected member usages.

Change-Id: I80032e3fc0e29179137b8c0380f09f68ab6fa03b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100540
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-04-26 07:52:58 +00:00
Johnni Winther 58ff41ad33 Add test for static tear-off 
- to document the change (for the better) with CFE constant

Change-Id: I9b6673497fe07ccd4f92fc4c22df0ae3205f72a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99152
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-04-16 07:06:12 +00:00
Johnni Winther 45a5349175 Track constant field initializers for field analysis. 
Change-Id: I536975d235cbf7722b03aa7b0e2c9edd7c206484
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98852
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-04-09 16:30:27 +00:00
Johnni Winther 7ef28f0b03 Handle constant field init registration correctly. 
+ avoid side-effects of checking enqueuer invariants

Change-Id: Id327371bc70e4b1b5fd4d326b8c8cf8caf50ea0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98142
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-29 16:44:15 +00:00
Johnni Winther eb6f1b6abd Handle effectively constant fields in class stub generator 
Closes #36222

Change-Id: Ic8b7a3963e1364903b4b2d7871ff0b12cb134572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97082
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-15 20:15:25 +00:00
Johnni Winther 204651f3ab Replace package:expect annotations with @pragma 
Change-Id: Ib43d0d71a3ee8b0f0e6d676e6a3e448a107b7ca5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95180
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 11:00:17 +00:00
Johnni Winther 013cf68624 Replace js_helper annotations with @pragma 
@ForceInline is still used by dart:html, will be removed in a later CL.

Change-Id: I480325fe91cc6baefb17ead49f839442e023d441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95160
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 08:56:18 +00:00
Johnni Winther 1720704594 Recognize effectively constant static fields 
Change-Id: Ic8f7a014a6af2f9d8854e0731fe0d2df11b554da
Reviewed-on: https://dart-review.googlesource.com/c/94281
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-28 09:12:26 +00:00
Sigmund Cherem 36c14db2d3 Only refine non-null in SSA 
Code-size difference on a large app is very small (0.007% worse), but
this cuts the time spent in type-propagation by more than half
(23s -> 10s on my machine).

I saw a 0.4% code-size regression in pop-pop-win, but that is
recovered once we are smarter about generating simple is-checks
when the "raw" type can be used because the type arguments
match the bounds (see separate CL).

Change-Id: I45c0fb1afabdca3d045aec576c131ed764dc31ce
Reviewed-on: https://dart-review.googlesource.com/c/94120
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-27 21:48:00 +00:00
Johnni Winther edcaa05375 Support @pragma('dart2js:noElision') on non-internal methods 
Change-Id: Ifae3f76107086f6ad47de2f9eda7b7aec589fc89
Reviewed-on: https://dart-review.googlesource.com/c/94284
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-02-27 09:46:52 +00:00
Mayank Patke 8fface97f0 Reland "Eliminate singleton/static access to the constant system and expose its functionality at the top level." 
This is a reland of 027b76ecbf

Original change's description:
> Eliminate singleton/static access to the constant system and expose its
> functionality at the top level.
>
> Use sites have been updated to import the library with a prefix.
>
> Change-Id: I0f5e4e47bec089d2d0dc2fcd50caccfd98947cf5
> Reviewed-on: https://dart-review.googlesource.com/c/93842
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: Ib04a9d48c8dca51020258313256e0fb0df330d9b
Reviewed-on: https://dart-review.googlesource.com/c/94107
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:06:31 +00:00
Mayank Patke e40b0e04c9 Reland "Merge the JavaScript constant system into the base constant system and flatten the inheritance hierarchy." 
This is a reland of cf51eb2fba

Original change's description:
> Merge the JavaScript constant system into the base constant system and
> flatten the inheritance hierarchy.
>
> dart2js only needs one constant system at most.
>
> Change-Id: I72e446652ea44298677e986b06e63152e381353b
> Reviewed-on: https://dart-review.googlesource.com/c/93880
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: I83960035a7b0989397f9646f2f834ec468aa4908
Reviewed-on: https://dart-review.googlesource.com/c/94106
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:06:31 +00:00
Mayank Patke 6bdd38ae84 Reland "Move the JavaScript constant system into constants/constant_system.dart in preparation to merge it with the base constant system and flatten the constant system hierarchy." 
This is a reland of 1702b986c8

Original change's description:
> Move the JavaScript constant system into constants/constant_system.dart
> in preparation to merge it with the base constant system and flatten the
> constant system hierarchy.
>
> Change-Id: I6ef27b210515140d4516336fea015f74c8a0cd6a
> Reviewed-on: https://dart-review.googlesource.com/c/93840
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: I20ef9755886a6b54135aa7169c9d7de08e8cbe93
Reviewed-on: https://dart-review.googlesource.com/c/94105
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:06:31 +00:00
Mayank Patke 05d9c60a22 Revert "Move the JavaScript constant system into constants/constant_system.dart" 
This reverts commit 1702b986c8.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Move the JavaScript constant system into constants/constant_system.dart
> in preparation to merge it with the base constant system and flatten the
> constant system hierarchy.
> 
> Change-Id: I6ef27b210515140d4516336fea015f74c8a0cd6a
> Reviewed-on: https://dart-review.googlesource.com/c/93840
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

TBR=johnniwinther@google.com,sigmund@google.com,fishythefish@google.com

Change-Id: If1b6291508c9792a6135a2ad5333b4bb3b800f69
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94103
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-02-22 21:50:57 +00:00
Mayank Patke 388f8e7731 Revert "Merge the JavaScript constant system into the base constant system and" 
This reverts commit cf51eb2fba.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Merge the JavaScript constant system into the base constant system and
> flatten the inheritance hierarchy.
> 
> dart2js only needs one constant system at most.
> 
> Change-Id: I72e446652ea44298677e986b06e63152e381353b
> Reviewed-on: https://dart-review.googlesource.com/c/93880
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

TBR=johnniwinther@google.com,sigmund@google.com,fishythefish@google.com

Change-Id: I2d403834ac3ac41371e041d21eec3d83d152343a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94102
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-02-22 21:46:52 +00:00
Mayank Patke 2c3dfa9e71 Revert "Eliminate singleton/static access to the constant system and expose its" 
This reverts commit 027b76ecbf.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Eliminate singleton/static access to the constant system and expose its
> functionality at the top level.
> 
> Use sites have been updated to import the library with a prefix.
> 
> Change-Id: I0f5e4e47bec089d2d0dc2fcd50caccfd98947cf5
> Reviewed-on: https://dart-review.googlesource.com/c/93842
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

TBR=johnniwinther@google.com,sigmund@google.com,fishythefish@google.com

Change-Id: I65310b2579c6746620ed6129e670206ed9bf5e91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94101
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-02-22 21:42:52 +00:00
Mayank Patke 027b76ecbf Eliminate singleton/static access to the constant system and expose its 
functionality at the top level.

Use sites have been updated to import the library with a prefix.

Change-Id: I0f5e4e47bec089d2d0dc2fcd50caccfd98947cf5
Reviewed-on: https://dart-review.googlesource.com/c/93842
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-22 21:34:47 +00:00
Mayank Patke cf51eb2fba Merge the JavaScript constant system into the base constant system and 
flatten the inheritance hierarchy.

dart2js only needs one constant system at most.

Change-Id: I72e446652ea44298677e986b06e63152e381353b
Reviewed-on: https://dart-review.googlesource.com/c/93880
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-22 21:34:47 +00:00
Mayank Patke 1702b986c8 Move the JavaScript constant system into constants/constant_system.dart 
in preparation to merge it with the base constant system and flatten the
constant system hierarchy.

Change-Id: I6ef27b210515140d4516336fea015f74c8a0cd6a
Reviewed-on: https://dart-review.googlesource.com/c/93840
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-22 21:34:47 +00:00
Johnni Winther 8e2fcf7782 Advanced tracking of field initialization 
Change-Id: I8c8edb517bc3a3805ac0d72388f4e5c7fc34247f
Reviewed-on: https://dart-review.googlesource.com/c/93680
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-22 16:08:16 +00:00
Johnni Winther 60e4f194b0 Recognize and inline effectively constant fields 
Change-Id: I243ee80ebc45d9cdab2f7c944cf5eceb26185b2c
Reviewed-on: https://dart-review.googlesource.com/c/93436
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-22 14:06:05 +00:00
Stephen Adams b60a55510b [dart2js] Disable assignment chaining optimization 
Disable while we look into variable allocator assertion.

Change-Id: Ib1e7c2eb869020ae8ecfa123801009adb6a742c7
Reviewed-on: https://dart-review.googlesource.com/c/93925
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-02-22 00:10:23 +00:00
Stephen Adams 0e453c637b [dart2js] Chain static assignments 
Extend the logic for chaining field assignments to static variables.

Change-Id: Ia87d8ff3400d6f04257a546c7a1bb74775a3019e
Reviewed-on: https://dart-review.googlesource.com/c/93620
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-20 20:07:55 +00:00
Stephen Adams 1ac61b0c35 [dart2js] Basic chaining of field assignments 
t4 = t3.tooltip;
      t2._tooltipText = t4;
      this.currenttooltip = t4;
--->
      this.currenttooltip = t2._tooltipText = t3.tooltip;


        future = new P._Future(0, $.Zone__current, [P.bool]);
        this._stateData = future;
        return future;
--->
        return this._stateData = new P._Future(0, $.Zone__current, [P.bool]);

Change-Id: I8a1c4dae85b8a10f8b2c099668033f0c1ea9b6c4
Reviewed-on: https://dart-review.googlesource.com/c/93342
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-15 22:45:46 +00:00
Johnni Winther 45f55183c5 Refactor processing of pragma annotations 
Change-Id: I3d4efdab560557d5d9bbab748d003cd360efbe3d
Reviewed-on: https://dart-review.googlesource.com/c/92264
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-08 09:55:28 +00:00
Johnni Winther 33bc628235 Treeshake unread fields 
Change-Id: I188df5fd18163e5b32213a364d0fc163300db7b9
Reviewed-on: https://dart-review.googlesource.com/c/92130
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-07 09:58:19 +00:00
Johnni Winther c591454dd3 Inline unprovided optional parameters 
Change-Id: I61c82216965062feee8e01ba2533d0ea7c0052ef
Reviewed-on: https://dart-review.googlesource.com/c/90700
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-07 08:44:49 +00:00
Johnni Winther 0fd1679620 Sort named parameters in native methods by declaration. 
Change-Id: Ic4a7f9ad6cf0d362b6582a59c783cc05cc404a31
Reviewed-on: https://dart-review.googlesource.com/c/91828
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-02-04 10:02:23 +00:00
Johnni Winther 68d110ac2a Add test for codegen of optional parameters on native functions. 
Change-Id: Ice329d52be74f98653e5434b148b2b2c8f46c7d6
Reviewed-on: https://dart-review.googlesource.com/c/91661
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-01 09:23:55 +00:00