525e02fa5e
[ddc] Use Null Safety flag in typeAcceptsNull
...
- Expose the internal runtime flag for the Null Safety mode.
- Add a guard to protect against accidental configurations
that set the mode multiple times.
Change-Id: I8d16a3c7bd8590ea6f2fee9b6f8c09009898a64b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144991
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-04-28 21:56:48 +00:00
2e438d1baf
[ddc] Add temporary fix for typeAcceptsNull()
...
The CFE is evaluating the constant as if strong mode is always
enabled.
This is a temporary work around and we should be able to access
the mode flag here in a future change.
Change-Id: I28842a692183c8da7aa42086a034f5388af83af5
Issue: https://github.com/dart-lang/sdk/issues/41657
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144815
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-04-25 01:53:27 +00:00
721f7b4b3b
Null safe dart:async optimizations.
...
Various optimizations to the null safe dart:async sdk to fix
performance regressions in dart2js.
Change-Id: I32c64b54be196ac18946ade45de6b352a20be832
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144302
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-04-23 18:56:00 +00:00
23cbe39355
[ddc] Remove error handler from number parse helpers
...
This copies the logic from dart2js and brings the two patches closer
together. There is no need to pass the error handler to the helper
function shared between `parse()` and `tryParse()`.
Update JS foreign function types in parseDouble to match the NNBD
version.
Fixes: https://github.com/dart-lang/sdk/issues/41613
Change-Id: I85d39f8ba6bd76459cf6263099983b8b96d3a669
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144304
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-04-22 16:07:29 +00:00
7004b5f88e
[CoreLib] Eliminate casts from splay tree implementations.
...
Add type parameters to track the Node type through the splay tree
implementations to eliminate the need for downcasts to concrete
Node types.
Closes https://github.com/dart-lang/sdk/issues/41445
Change-Id: I046ad7654356554cd556ea5a2cb19ba7003fa648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143200
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-04-17 00:05:25 +00:00
ed83a28d3e
[dart:io] support Unix domain communications
...
Support Unix domain sockets communication on Linux, MacOS and Android.
Changes:
1. Add a field for InternetAddressType named unix.
2. Constructor of InternetAddress gains one more optional field: type. InternetAddress(String address, {InternetAddressType type});
3. Add another constructor to InternetAddress which taks raw address/path for ip/unix addresses as an argument. InternetAddress.fromRawAddress(Uint8List rawAddress, {InternetAddressType type});
The operation for unix domain sockets communication is basically the same as normal sockets except an InternetAddress with type unix should be passed.
Change-Id: I6a1135bbdd7f4e4fc745ccf8f95dec5272b6839b
Bug: https://github.com/dart-lang/sdk/issues/21403
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125932
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2020-03-23 03:51:40 +00:00
7aace6fa60
Make StackTrace generally not nullable in migrated NNBD library.
...
Bug: https://github.com/dart-lang/sdk/issues/40130
Change-Id: I13aba0c2a3fa5b1c3d3995f075ffd38f03aca897
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139880
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-19 23:31:30 +00:00
a5704eaca3
[dartdevc] Throw TypeError instead of CastError
...
Remove all `_check()` calls as they are now identical to `as()`.
Fixes : #41008
Change-Id: I4e4dd1ff50840d3d1cbf0aae9b8cef0621016079
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139490
Reviewed-by: Mark Zhou <markzipan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-03-18 18:39:26 +00:00
a1f87c6962
Reland "Fail synchronously if null is passed as an error to async APIs."
...
This is a reland of bef363bfb7https://dart-review.googlesource.com/c/sdk/+/138605
> Reviewed-by: Leaf Petersen <leafp@google.com >
Change-Id: I142831dca5dc4ca266ded08d93cb427ad3fbde74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139683
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-03-17 00:39:31 +00:00
330ec173a9
Add bool.hasEnvironment constructor and tests
...
Change-Id: I65ebfcb48bf46292d5ae611ecb7431e0666f753c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139286
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-16 11:17:58 +00:00
a5bf30c401
Revert "Fail synchronously if null is passed as an error to async APIs."
...
This reverts commit bef363bfb7https://dart-review.googlesource.com/c/sdk/+/138605
> Reviewed-by: Leaf Petersen <leafp@google.com >
TBR=leafp@google.com ,rnystrom@google.com
Change-Id: Ie17c35e9d23c70a7aecd1ef292962154cf6f007d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138925
Reviewed-by: David Morgan <davidmorgan@google.com >
Commit-Queue: David Morgan <davidmorgan@google.com >
2020-03-11 10:07:49 +00:00
bef363bfb7
Fail synchronously if null is passed as an error to async APIs.
...
The first patchset is Lasse's original changes.
Change-Id: Ic5f24bcfc0ef4e82edee68d61e015b095cb5916e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138605
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-03-10 23:42:43 +00:00
1fcce005b1
[nnbd/corelib] Fix performance regression in List.generate
...
Fixes https://github.com/dart-lang/sdk/issues/40878
Change-Id: I58278280e49514aef07c0af28aa5235242664083
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138382
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-03-05 01:40:43 +00:00
16f072c783
Migrate language_2/async to NNBD.
...
Change-Id: Id66e712eaf52fda2069ce5177aa091e373ad52c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134244
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-02-27 23:04:03 +00:00
4017a5ca7c
[dartdevc] Fix analysis error in dart:collection patch file
...
If hashcode is null it gets set on line 128 to dart.hashcode which
is a top level method in the dart:_runtime library.
Change-Id: Ib26a70dc84305dfa11eb15206abd36f003adcd9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137401
Auto-Submit: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-02-27 01:19:14 +00:00
b5a08c916c
[dartdevc/nnbd] fix null checks in primitive casts
...
These should go through the `cast` operation to fail in strong and pass with warning in weak.
Change-Id: I1863b507835c0c9993357318b9e7038154e47151
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136902
Reviewed-by: Mark Zhou <markzipan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2020-02-24 21:42:58 +00:00
623b3fee52
[nnbd/dart:io] Fix nullability in _EventHandler._sendData
...
_EventHandler._sendData is assigned to VMLibraryHooks.eventHandlerSendData
and being called using VMLibraryHooks.eventHandlerSendData with null
sender (from timer_impl.dart).
Implementation of _EventHandler._sendData in the VM actually supports
null sender - it explicitly handles null sender at
https://github.com/dart-lang/sdk/blob/732cd81f058cf9baacb0b5a0d325b8c272738b81/runtime/bin/eventhandler.cc#L131-L132
Given the above, _EventHandler._sendData should take 'Object? sender'
instead of 'Object sender'.
Change-Id: I13a4b11a27e992ecbd27f68da27ea0d568dd0bdb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136782
Reviewed-by: Liam Appelbe <liama@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-02-24 16:49:05 +00:00
999eeea5a3
[dartdevc/nnbd] Type fixes uncovered by strong param checking
...
Change-Id: I86969c021ac2dea28455b40dfdbed8f5923b197e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135797
Commit-Queue: Vijay Menon <vsm@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-18 14:22:54 +00:00
272a03a71d
[ddc,dart2js] restore null check in dart:js
...
Change-Id: I275c202368eabc3d72fb49ff21d8635e0905ad69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135443
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2020-02-12 20:01:57 +00:00
855309a1dd
[dartdevc] Delete patch files for mirrors library
...
Cleanup special handling for annotations required by pageloader/mirrors
use case that is now fully unsupported.
Should not be submitted until the removal of the libraries has landed
in flutter web.
https://github.com/flutter/engine/compare/master...vsmenon:vsm-mirrors
Change-Id: I00dbdc8e185a9c3e0585d030f670c1d5a4c77395
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134889
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-11 17:02:11 +00:00
05b806ace7
[dartdevc,nnbd] analyze whole sdk, fix isolate errors
...
This should fix all ddc isolate errors. Remaining two io/_http errors are due to:
https://github.com/dart-lang/sdk/issues/40482
The rest are mirrors. Do we think we'll be able to remove it altogether? If not,
I can take a pass to fix.
Change-Id: I4cef9773b5fa36490bdfbc08a06fae6cd80c5eae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134860
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-07 20:50:16 +00:00
9781d3dc9f
Fix minor bug with NNBD and Math.exp
...
This cl simply adds a missing nullcheck to Math.exp
Change-Id: I5a5a145b1c60e31d956891c530cba2bb9a718b4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134761
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2020-02-06 20:41:07 +00:00
20745941ad
[ddc,dart2js] make dart:typed_data the same in dart2js and ddc and opt-in to null safety.
...
Change-Id: If325a2ea11afef1d784fd01830999d5a4c9d4daf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134049
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2020-02-05 19:29:10 +00:00
d798004ba3
[ddc,dart2js] remove web patches for dart:cli
...
Since dart:cli is not in the libraries.yaml/json for ddc and dart2js, imports to
it are not allowed on web code. The patch files were not needed and can be
removed.
Change-Id: I46acf8a540f4b2d0a2aa7dcc50b572adab564b68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134048
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2020-02-04 23:32:47 +00:00
f6e0200523
[nnbd] Migrate dart:io to NNBD.
...
The Process class will now throw a StateError if the process is detached
upon accessing the stdin, stdout, stderr, and exitCode getters.
The Socket class will now throw a SocketException if the socket has been
destroyed or upgraded to a secure socket upon setting or getting socket
options.
Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I68e22873932c68a3fac549c0f742dd49d0a60dfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133060
Commit-Queue: Jonas Termansen <sortie@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-01-30 15:46:08 +00:00
95511b314c
Stop using List() constructor in NNBD code.
...
The List constructor has been disallowed in NNBD code, so the NNBD SDK
should not be using it.
This changes all uses, not just in the already migrated libraries.
(Also found some bad typing in the `RegExpMatch` class along the way).
Change-Id: Ic61bd64427c0961c23aaf7ce59af5c2c271890ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132282
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-01-24 15:59:29 +00:00
b07b710b93
[lib] Be explicit about the type parameter for positional argument lists.
...
Widen `reflect` and `setField` to accept dynamic. `Object` will soon no longer be a top type, and dynamic is more consistent with other reflective inputs and `reflectee`.
Bug: https://github.com/dart-lang/sdk/issues/40045
Change-Id: Ic1e3a26aaea5de078cc616846cb52417c7975d11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132720
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2020-01-22 21:36:03 +00:00
8b4a4e470f
Make the NNBD List.empty default to non-growable.
...
Since a growable list can be created using `[]`, you never need to call
`List.empty` with anything but `growable: false` or `growable: dynamicValue`.
That means that the default should be non-growable (which also matches
`List.filled` and apparently user expectations - since there is already one bug where
I assumed it would be non-grwowble while migrating List.generate).
Ensure it's implemented by dart2js too and used where there were comments
saying to use it when available.
Change-Id: Ied20d69346ecfb93640ee2cec718e30e6f8980e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132600
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
2020-01-20 20:19:18 +00:00
3bd63c92ec
[nnbd] port web patch files for dart:isolate
...
Change-Id: Icf54d76d264c8e5754023c0cf51d5e28db22d52f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132201
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2020-01-17 23:21:26 +00:00
17f80f0d1f
[nnbd] port dart:js to nnbd
...
This tests static analysis on the ddc patch, but not the dart2js one yet.
It also fixes js/null_test.dart to ensure it passes. Note, that test was broken independent of NNBD.
Change-Id: I5a6bfdfaac845eaba6f154d30f2c1e30199574d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131300
Commit-Queue: Vijay Menon <vsm@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-01-16 19:26:18 +00:00
e0c366a3c8
[vm] Update dart:mirrors for Dart 3.
...
Also back-ports all non-type changes to the Dart 2 version for the sake of testing.
Bug: https://github.com/dart-lang/sdk/issues/40045
Change-Id: Idda6b6c5e8508efe4db79f27f41d0a2485b9f197
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131485
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-01-15 00:56:24 +00:00
5169a52b2a
Use @patch for List.of factory constructor
...
This will permit List.of to be specialize for the different platforms.
Change-Id: I63583566354625b683d0897da619fc8cd23d0b7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131281
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-01-14 00:17:33 +00:00
28c335d5a2
Move dart:js to patch format
...
This is prep for nnbd port to ensure APIs remain consistent across DDC and Dart2JS.
Change-Id: I8ec6c5b152eb87868038570f2275e82af3325fb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131000
Commit-Queue: Vijay Menon <vsm@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-01-12 01:13:53 +00:00
96cea64fa6
Cleaning up NNBD tests and migrations.
...
Change-Id: I0a63a6864c568491ad5e20b6eb490760e620a889
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130200
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-01-09 17:11:46 +00:00
99c5ec5c75
[dart:_internal] Update signature of extractTypeArguments()
...
Object -> Object? in the NNBD fork.
Change-Id: Id17827327f77d61266f1a478abb735348dbc7312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130564
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-01-08 16:23:59 +00:00
5804537b83
[vm, timeline] Following switch from Duration events to Begin-End event pairs, avoid separate native call transitions to query the monotonic and thread clocks.
...
Bug: https://github.com/dart-lang/sdk/issues/39727
Change-Id: Ie38947c63845f13d660cb4a367681fed31796473
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128564
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2020-01-02 23:13:06 +00:00
2f57602411
[dartdevc] Update is, as, and _check methods for null safety
...
Change-Id: I67e97c988a0c7a0e9d04e84e85c07152f8f35306
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129202
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-01-02 22:29:16 +00:00
4589145939
[dartdevc] Cleaning up analysis errors.
...
Change-Id: I5af7281af4500f939b335a1df97abefe9386f347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128080
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2019-12-13 17:40:49 +00:00
942c58f32d
[dartdevc] Fix build errors in runtime patch files
...
Change-Id: I98bb1435e9fe888158a4ccad7dc4a39ee73fb936
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127491
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
2019-12-07 01:17:14 +00:00
baf1afa902
[dartdevc] Opt in dart:collection patch file for NNBD support
...
Pairs best with https://dart-review.googlesource.com/c/sdk/+/127161
Change-Id: I7450128ddc7a59e05c518d22301b1a493a39e16a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127222
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-12-05 22:49:00 +00:00
461b80a0e4
[dartdevc] Fix analysis errors in NNBD dart:core patch file
...
Remove the language version comment from dart:_js_helper but it has not yet
been fully migrated. This only makes the necessary changes to fix errors in
dart:core.
Change-Id: Ib0dafd7838ad46e5e0284cefb751e12504c318b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126401
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2019-11-26 23:12:15 +00:00
965fb9942f
[dartdevc] Restore dart:core imports in dart:_internal patch file
...
The lack of these imports are breaking the `dartdevc_platform` build target when
using the `--nnbd` flag.
Change-Id: Ib8b8368286c24b5435ad4d141ad68aea8ba6be0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126220
Auto-Submit: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
2019-11-25 21:38:46 +00:00
488daa270c
[dartdevc] Fix analysis errors in patched dart:core library
...
Change-Id: Iab9efe67cee6f1c7ea9c42120bc08ddcf5ff2086
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125700
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-11-20 20:09:02 +00:00
5b72c1c669
[dartdevc] Migrating internal_patch to nnbd.
...
Change-Id: I1ec8cde975ca7ea60c2730ca5b3afa113d783e7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125581
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2019-11-19 01:03:53 +00:00
7c5f81eb0f
[dartdevc] Cleanup unused optional parameter from NoSuchMethodError
...
Some preparation for NNBD migration.
This was not part of the public API and only part of the DDC patch. I could not
find any use besides passing null which was the default anyway.
Change-Id: Icab2bb3f24e228afd4f0a57c9a2474121f27a67b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125466
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-11-19 00:55:43 +00:00
baa2d8125f
[dartdevc] Cleanup dynamic calls and downcasts in _BigIntImpl
...
This is some preparation for the NNBD migration where the existing downcasts and
possible nullable accesses will be errors.
- Downcasts have been replaced with covariant parameters.
- Local variables have either been declared with a specific type or given
initial values so that they can become non-nullable in the future.
- Remove a pointless `is! int` type check. The parameter is an int.
Change-Id: I3a0358d83a181eee5576c2062128d89d197ba3e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125303
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-11-19 00:16:43 +00:00
6f00b19174
Migrating dart:convert patch files to NNBD.
...
Change-Id: Ib1127853bc50682e674ccc783f958e7865118b6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125063
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2019-11-18 22:56:05 +00:00
c825038296
[dartdevc] Migrating dart:async patch files for DDC to be nnbd-compliant.
...
Change-Id: I822fc9db7ddfe95a6f561ef1acfc88f96f2635dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125060
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-11-18 22:16:55 +00:00
1d6584720b
Migrating DDC dart:developer patch files.
...
Change-Id: I99fb8004433ac0b518c6da23dfb7d73d2a30e769
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124421
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2019-11-11 17:43:23 +00:00
ed956daa3f
Update the DDC dart:async patch file version to match the migrated lib.
...
Change-Id: Ia15e68e2124fe0af5ebcb36529cef943b3406362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124642
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2019-11-09 00:57:18 +00:00
Nicholas Shahan