dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
72,374 Commits 2 Branches 0 Tags
cf3a0342102b8ec2094de629dfb891134df9de3c
Commit Graph

60 Commits

Author SHA1 Message Date
Johnni Winther 712efa2a49 [cfe] Handle problems and recovery in non-null check 
Closes #41597

Change-Id: I781d70d7cd720ab09d68a22ead1639bf37953955
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144941
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-28 08:06:48 +00:00
Jens Johansen 676c2df9a2 [CFE] Fix parser expect output when there's errorTokens all over the place 
Change-Id: I5509f866bb33e91f49d873678761e00ce8601654
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144284
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-04-21 13:03:43 +00:00
Jens Johansen 97e0983094 [parser] Fix NP in scanner caused by never setting eof 
This e.g. happends on input that's UTF-16 LE.

Also see https://github.com/flutter/flutter/issues/54840.

Note that this doesn't really fix much, because the scanner still
tries to read the input as utf8 (which it potentially isn't, and isn't
in the test cases added) and it thus basically outputs garbage.

Change-Id: I7198928dc6f0dd16728c1c04ccd4286faae8dd20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143586
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-04-20 13:21:46 +00:00
Johnni Winther 594f77715b [cfe] Handle potentially constant type expression in is expression 
Closes #41385

Change-Id: Ia2fa829621931d52c5e41ac0414d12b9caa1256d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142860
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-16 09:07:21 +00:00
Jens Johansen 9f06c32b45 [CFE] Fix crash when implementing or mixing in a functionType 
Bug: 41265
Change-Id: Idf4fbc44c210008c3c94639c138adbd3afec2cef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143522
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-04-16 06:35:50 +00:00
Johnni Winther fae35fca47 [cfe] Handle potentially constant type expressions in CFE 
Closes #41305

Change-Id: Ibb839c5b6619ae2f7e90cc956c7de20d8c76ae3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142120
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-02 13:23:04 +00:00
Jens Johansen 43079207d4 [parser] Parse a!?[0] 
Fixes #41177.

Change-Id: I135f0b7aedbcb320ab0d1a1806b2ad3bedcda307
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141886
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-04-01 07:33:01 +00:00
Jens Johansen 4ab3bda5db [parser] Change recovery for constructor; report errors in bad constructors 
Change-Id: I3d656afce4a3ec14c7c099893a434abba3945ebf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140862
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-27 11:57:56 +00:00
Jens Johansen 13dbe2a815 [parser] Correct precedence on ?[ when it's an index bracket operator 
Fixes #40267.

Change-Id: I1929da0500f85f70dc241d969d05590a1e0c277e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138927
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-12 11:25:02 +00:00
Jens Johansen 81768cbd7f [CFE] Update parser_test_parser and expect files 
Change-Id: I8620aa9b762d7f49262635e482d1e16d70d46e2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138926
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-12 11:25:02 +00:00
Konstantin Shcheglov 0649115b06 Rename VoidWithTypeParameters to VoidWithTypeArguments. 
Change-Id: I5df6a49f0b27b6edfe2ce0f677d5f898900d8384
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-05 17:31:34 +00:00
Jens Johansen f828f00b59 [parser] Error recovery of type parameters on void 
Fixes #39958.

Change-Id: I851bef762776f4b68f0fcb645d634019b8b32e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-04 14:02:35 +00:00
Sam Rawlins 19dc177a82 Missed one expectation change in parser recovery test 
Change-Id: I3592dfa6c2ed0f704a34975d35d02a4073830834
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-03 18:39:44 +00:00
Sam Rawlins e7e45599cb Improve error recovery of misplaced await or yield 
Bug: #32967
Change-Id: I9f8e2ae434ea79470949e7931bcb80c542c54f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138042
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-03 14:58:21 +00:00
Jens Johansen 47d462e8b1 [parser] Better handling of nullable types vs conditional expressions 
Fixes #40834

Change-Id: I2fdad5a383c1873b1dd782b70e2f1e3ab8664b40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137960
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-03-03 09:49:57 +00:00
Sam Rawlins e687b62ffe Improve recovery on yield not-in generator; Improves #32967 
Fix is inspired by very similar recover for `await` in synchronous
function, like `looksLikeAwaitExpression` and `endInvalidAwaitExpression`.

Change-Id: I50bf0c1e73c31551b94de29d78fd3d449c30fd20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136920
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-03-02 17:29:22 +00:00
Jens Johansen 3969356f1a [parser] Parse bangs before type parameters correctly 
Change-Id: Ie05e57d12cdbdeac037785ef6b94497c77d264ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137789
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-03-02 11:21:40 +00:00
Jens Johansen 399c68e884 [parser] Parse chained calls with type arguments correctly 
Change-Id: Ifaecd7f74c4e2d3d332fc759f5e2ae55de47b8a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137784
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-02 10:28:47 +00:00
Jens Johansen 1b7b0bcc95 [parser] Allow covariant late final variables when it doesn't have an initializer 
Bug: #40805
Change-Id: I94db171493ccb57f294928a3e2cec60740a09e91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137796
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-02 08:32:43 +00:00
Jens Johansen 1b534d04a8 [CFE] Change parser test output slightly 
Special handling of beginBinaryExpression/endBinaryExpression as they
don't always comes in pairs.

Change-Id: I74323dd45615fbb340acc1c5144b0ba94ea19f5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137783
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-02 08:22:03 +00:00
Jens Johansen 991b522353 [CFE] Remove space from test filename 
Change-Id: I0314708d14c24282c10b5ca545a30569f9a29025
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137540
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-02-27 10:15:33 +00:00
Jens Johansen 3660b9ecc7 [parser] New syntax for null aware index (2nd try) 
This reverts commit bc4893a3b3.

The previous attempt failed because when we check if something is a
conditional expression we used a rewriter that didn't actually rewrite.
This further down the line (still checking if we can parse the expression)
results in errors occurring (that wouldn't have occurred if the rewrite
had happened) and the conclusion was thus that it wasn't a conditional
expression and we parsed it as a null-aware index operator (which gave
errors because it wasn't).

This 2nd try solves it by having a rewriter that actually rewrites,
but then allows to undo the rewrites after we're done parsing.

Change-Id: Ide3c0d6a870d4dc18b6d9475b0227d93c733dc7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136624
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-26 13:31:52 +00:00
Jens Johansen bc4893a3b3 Revert "[parser] New syntax for null aware index" 
This reverts commit cf4e044e07.

Reason for revert: Breaks internal customer.

Original change's description:
> [parser] New syntax for null aware index
> 
> Change-Id: Iea6b29eb897eb01863a92b223e270d225c3ca1ba
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135903
> Commit-Queue: Jens Johansen <jensj@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=brianwilkerson@google.com,jensj@google.com,johnniwinther@google.com

Change-Id: Ic0ff607c944e489f29bda7da37afd63c62d368eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136600
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-02-20 14:11:08 +00:00
Jens Johansen cf4e044e07 [parser] New syntax for null aware index 
Change-Id: Iea6b29eb897eb01863a92b223e270d225c3ca1ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135903
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-20 12:33:28 +00:00
Jens Johansen f0d16c3c31 [CFE] Parser test for class called late and required 
Bug: #40288.
Change-Id: I5be3b949c954e071db4ad5418d23f56fdeb711ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134281
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-02-04 13:45:31 +00:00
Jens Johansen 201e6a86e1 [parser] Fix 'late' used as 'var' 
Fixes #39858.

Change-Id: Ic2721fc56d184b3d0ad3082a7fa9cc45d6bbf45d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129060
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-01-10 10:46:17 +00:00
Jens Johansen b4a83427fd [parser] bang before type arguments 
Fixes #39776.

Change-Id: If830e5d9d8fd68e98eb757f21e6c361fc496c931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-01-10 09:53:19 +00:00
Johnni Winther f521734ce7 [cfe] Handle setter import conflicts 
Fixes the underlying problem for the crash reported in
https://github.com/flutter/flutter/issues/46823

Change-Id: I392c7bae3679cae52b694f3bd08b0b700ee9c56f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128540
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-16 12:02:47 +00:00
Johnni Winther 77d066fd7d [cfe] Report errors on nnbd features used in opt-out libraries 
Change-Id: I8131464fff9f09a90083581f10933430133cfaed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128406
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-16 09:02:17 +00:00
Jens Johansen e2d5aa352c [parser] Allow ?? after Type? 
Fixes #39697.

Change-Id: I65c762304881038b205f1221d6cfdd1125ba71e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127890
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-12-12 06:59:53 +00:00
Jens Johansen 2a886d257f [parser] Allow '?.' and '?.[' after '!' 
Fixes #39723

Change-Id: Ic98b7ddefcbbfefe33e6306b8fb4215419355f6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127887
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-12-12 06:59:33 +00:00
Karl Klose bd06f1bf51 [cfe/infra] Unit test suites: print re-run command when a test fails 
Closes #39423

Change-Id: Ifa3fbe4d670f4f95beceb2aae8769a553a9fbe7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125604
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-11-22 10:45:54 +00:00
Johnni Winther acff31ed26 [cfe] Support null-aware index access 
Change-Id: I54b58624722845e4b008b90e675516ec274bc2da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125960
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-11-21 14:36:30 +00:00
Jens Johansen 12c92332f8 [CFE] Parser test can run scanner in non-nnbd-mode 
Tests in the folder "non-nnbd" are run in non-nnbd mode.

Change-Id: I27c2acec93f729b76f024f12dcfb84f31903e0b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124688
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-11-11 11:43:07 +00:00
Jens Johansen 48f0b83ff2 [CFE] Allow ! in cascade 
Fixes #39286.

Change-Id: I4e7270dacf7bc43accae4d45d26146cfb7d2b1ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124330
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-11-11 09:44:12 +00:00
Jens Johansen fe3afde2eb [CFE] Parser: Don't report (recovered) operator as endClassConstructor 
Before this CL any method with initializers would be ended with a call
to listener.endClassConstructor.
If we know it's an operator, though, we shouldn't: The listener has
most likely created a specific operator name and should't call it a
constructor.

Bug: 39230
Change-Id: I6ee79ba1907cb3932c461e0b00937af23b5b5edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124121
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-11-06 09:42:37 +00:00
Jens Johansen c75e5e4cf4 [CFE] Fix assert in parser 
Change-Id: Iee9059c1f7c87191f4d4551c8c9e50766d0a520f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123731
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-11-04 08:05:52 +00:00
Johnni Winther d76ffbc149 [cfe] Handle assigned variables in for and for-in 
Change-Id: I06deda7f017dcd40e5c6987c61261cf3be2be0ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123410
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-31 11:36:43 +00:00
Jens Johansen fa05fedd89 [CFE] Parser test suite prints messages prettily at top of expect file 
Change-Id: I9af28f57f8ab54b38e34b06019000b720e5fdecb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123524
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-30 14:25:54 +00:00
Jens Johansen c791aa880c [CFE] Fix parser crash when recovering from missing operator and having a return type 
Fixes #39026

Change-Id: I2eb5620017f6c52e8a06248a8c2ed9f2eb196f9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123520
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-30 11:14:44 +00:00
Jens Johansen 5e323ba031 [CFE] Allow eof in assert to avoid crash 
Fixes #39024.

Change-Id: I7c45d58133d54944f256f5c555b0f4f7332606ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123405
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-30 08:16:45 +00:00
Jens Johansen 63b9a155f7 [CFE] Fix potential parser crash when parsing typedef 
Fixes #39033.

Change-Id: I746e7b9c6bd531565721ad45954ee68e0ac392b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123403
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-30 08:16:37 +00:00
Jens Johansen cdb1ed7504 [CFE] Fix parser expect files after CQ commits that was too close 
c738b6bc8a and
c8ff1b0c21 was landed basically at the
same time. Both passed the CQ, but the latter one changed how expect files
added in the prior one should look.

TBR.

Change-Id: Ib4400d1c59bae69ecf7b13b8c98f1495d82d8016
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123401
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-29 10:22:04 +00:00
Johnni Winther c8ff1b0c21 [cfe] Add BlockKind to parse/begin/endBlock 
... and use this to computed AssignedVariables data for try statements

Change-Id: I235575b055cb89b553baf0ac728d9954d8d0aaa6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123251
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-29 09:17:06 +00:00
Johnni Winther 688454c4a7 [cfe] Compute AssignedVariables in body builder 
For-loops and try statements currently not supported.

Change-Id: I52a591b55149ddfd5d0c5792239555d72b8146fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123248
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-10-29 09:17:06 +00:00
Jens Johansen c738b6bc8a [CFE] Fix parser crash ("isSynthetic called on null" in list literal suffix) 
Fixes #39058.

Change-Id: I6fd6c6ba45f43e95cea12e0a7776ff10515d3d9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123243
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-29 07:10:16 +00:00
Jens Johansen 995fcfc1e9 [CFE] Rename parser test that used to cause an infinate loop 
For people with an installed analyzer, it causes it to go into an
infinate loop when it's called .dart --- calling it .crash_dart instead
should fix it.

Change-Id: Ib21b67bc7efdc87afa7893f7ec8d6e64bcff9c29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123246
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-28 14:15:32 +00:00
Jens Johansen 0f7343e1a9 [parser] Reproduce analyser crash _OperatorName in endClassConstructor 
This will crash the analyser:

class operator {
  operator^(int x) {}
}

The output from the parser looks reasonable to me though.

Change-Id: I956daf43670decca979d9dad6614e139007cda26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121321
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-28 14:00:37 +00:00
Jens Johansen d7c75edd57 [CFE] Use 'SyntheticBeginToken' for BeginToken that origins from a synthetic node 
This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/122863.

Change-Id: I17e79687fe9950ae8ff0f1f8a4a6270926106813
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123241
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-28 11:01:10 +00:00
Jens Johansen 5b7c981086 [CFE] Parser test framework also outputs token stream 
This makes it much easier to see what the parser is actually working
with in the face of token stream rewrites.

Change-Id: Ic336f18fab7c8fd7a42020b32af4a480bbde25bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122865
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-28 10:25:30 +00:00