cf3a034210
Implement promotion via initialization in flow analysis.
...
Change-Id: I10a5f6bfeb5a05dd144db5212c9f31796f5a2385
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145502
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-30 16:26:27 +00:00
a9b81e18d9
[cfe] Handle dynamic return in async
...
Closes #41437
Change-Id: I493b516f0b72fc1da097b92bd75150aea8e60ba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145042
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-30 12:39:04 +00:00
c08bcbb25e
[CFE] Enable textual outline sorting in test suite
...
Change-Id: Iccf35b9cb3dce96487ca9ba688394e3b05be2e75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145401
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-04-30 08:25:17 +00:00
b1435ec38a
[CFE] Textual outline can sort data
...
Change-Id: Iac337903aace923f2cff8797840aa5cdbfded03f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145400
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-04-30 08:25:17 +00:00
e046afac1f
[cfe] Don't print nullability on Null in messages
...
Change-Id: I530d3eef1a0af73d68aaccf33095ab2dcaf4747c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145461
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-30 08:16:24 +00:00
712efa2a49
[cfe] Handle problems and recovery in non-null check
...
Closes #41597
Change-Id: I781d70d7cd720ab09d68a22ead1639bf37953955
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144941
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-28 08:06:48 +00:00
3e26a5d0dd
Issue 40957. Report the language feature, and recommend to set SDK constraint.
...
...but don't recommend to enabled any experiment.
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/40957
Change-Id: I556ce9952b28d0b079521ac46558f8e3adf352c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144982
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-27 22:11:46 +00:00
eada4d8d65
Implement Factor in flow analysis.
...
Bug: https://github.com/dart-lang/sdk/issues/40014
Change-Id: I8d21d3c3368495d9d0dbb1cd52317b053657a176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144804
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-04-27 18:47:08 +00:00
3c0e9642d2
[cfe] Ensure default type on generic forwarding stubs/method signatures
...
Change-Id: Iad6246c55f45953bffe2c3de4a2e30a32db347d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144820
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-27 16:25:18 +00:00
b8343d071d
[cfe] Support Never and Never? in function literal parameter type inference
...
Closes #41415
Change-Id: Ia98c916da00e663ba909d6c38c6d9dc70d740bb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143812
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-27 15:11:08 +00:00
e9ca413263
[cfe] Handle nullable access to extension members
...
Closes #41349
Closes #41495
Change-Id: I1893502592af1615184b5dd294e1835b51959a07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144761
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-27 13:47:08 +00:00
6c21ed6314
[cfe] Support class hierarchy changes in ChangedStructureNotifier
...
Closes #40707
Change-Id: I0a9e0b11d0f597dfed7182dd869382057d04e5dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144821
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-26 19:51:29 +00:00
d59d0752e2
[cfe] Avoid hoisting in top-level inference
...
Change-Id: I1ae642c241557f0c5d00a56ab6af350408aef1bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144513
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-23 13:35:09 +00:00
4084c4cc24
[kernel/CFE] Use kernel 'Version' class for versions
...
Define a "Version" class in kernel that allows easy comparison between
versions (e.g. a < b, a >= b etc).
Use this Version class in CFE.
Change-Id: I2f382e7bb3c2083258743b9b66a909a88d575dbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144283
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-04-21 09:44:52 +00:00
a12c36dd97
Issue 41557. Support for breaks out of labeled blocks.
...
Bug: https://github.com/dart-lang/sdk/issues/41557
Change-Id: Ica1c6c04acf600cb20d11a195d6c6da73197733c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143889
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-20 16:30:56 +00:00
7425ef9470
[cfe] Support --link-dependencies on fasta compile
...
Change-Id: I8af2d127764e4ef60a1ea0a5ab0804a417ce42f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143808
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-20 08:34:36 +00:00
d690a0c7c4
[cfe] Handle nullability of typedefs
...
Closes #41496
Closes #41498
Closes #41499
Closes #41501
Closes #41505
Change-Id: I425b6137f9ea41d01c95332ef1f7d43ca7afb5a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143811
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-20 07:03:55 +00:00
a85a7fc254
[kernel/CFE] Better mixed compilation mode handling
...
* Throw a specific error on mixed compilation mode; let the incremental
compiler ignore that error when trying to initialize (i.e. it doesn't
initialize from it, but it doesn't show any warning either).
* Allow some mixed mode stuff: Eventually the SDK should be in agnostic
mode, so we should allow mixing agnostic with non-agnostic.
Fixes #41493 .
Change-Id: Idb33fb31afe6bbba6d74134cb722ca825751898b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143583
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-04-17 10:22:46 +00:00
594f77715b
[cfe] Handle potentially constant type expression in is expression
...
Closes #41385
Change-Id: Ia2fa829621931d52c5e41ac0414d12b9caa1256d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142860
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-16 09:07:21 +00:00
f48a3afbae
[cfe] Handle nullability difference in LUB computation
...
Closes #41114
Change-Id: Ifc7d3a35c4274bbb5651ced1c28c984e5c1a34ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142985
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-04-16 06:52:30 +00:00
9f06c32b45
[CFE] Fix crash when implementing or mixing in a functionType
...
Bug: 41265
Change-Id: Idf4fbc44c210008c3c94639c138adbd3afec2cef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143522
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-04-16 06:35:50 +00:00
3c85da7778
[release] Bump version to 2.9
...
Change-Id: I2fc393cbb7a9111f4c09db6a2a7a202eeb88992c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142996
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2020-04-15 18:36:42 +00:00
da95c79901
[cfe] Handle nnbd is-test in constant evaluation
...
+ detect ~/ evaluation errors
Change-Id: Ic3f979c7516ed9aa2da0eab8b8d902987107c189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142982
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-04-15 17:29:43 +00:00
eb18db2116
[cfe,kernel] Add Field.isInternalImplementation
...
This bit is required to support synthesized field used for the late
lowering. These fields should not be seen as part of the interface,
that is, classes that implement the class declaring the late field should
not be required to override these fields.
Closes #41436
Change-Id: I9a98322bdd1842b46bde34fff1176a7577672e0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142998
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-15 13:46:43 +00:00
208ab625c1
[cfe] Avoid reporting missing implementation on internal fields for late lowering
...
Closes #41436
Change-Id: Ib6227a34ca188a379f8910a2911082caef280d79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142984
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-14 12:21:19 +00:00
0d16ff6d86
[cfe] Handle static type of access on Never
...
Closes #41273
Change-Id: Ia236481ab47033198d7952086cdf5c9c8f5a34b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142366
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-04-08 08:46:02 +00:00
04b6c6a116
[cfe] Handle Null <: Never in mixed inheritance bounds check
...
Change-Id: I994f76b3b4f6d498a8e41f7e34849616960dca08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142368
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-06 15:18:31 +00:00
32f82b5852
[CFE] Add NNBD compilation mode into kernel component
...
Fixes https://github.com/dart-lang/sdk/issues/41311
Change-Id: I2f4345f8ca7a31da705fcae37a28a8b801feb5e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142149
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-04-06 14:00:01 +00:00
9f80082ce3
[cfe] Avoid unconsolidated override checks in mixed inheritance
...
Change-Id: I1cd8aa5bdf53010d8f394e5981239211921f2117
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142365
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-04-06 09:51:30 +00:00
0e5624a083
[cfe] Handle static typing of nullable access to Object members
...
Closes #41282
Change-Id: I39d0bf8a35e635e860f4bf810ee37e00950e3a8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142364
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-06 09:22:00 +00:00
feff4f48f4
[vm/nnbd] Fix expression evaluation in NNBD strong mode
...
When creating a library for expression evaluation we should copy
NNBD properties from the real library, otherwise VM may refuse
to load resulting kernel binary.
Change-Id: I594b718c74e516f998593cde55ea0cabaf3b4024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142443
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-04-06 00:55:30 +00:00
05103dfe5a
[cfe] Implement factor function
...
+ share test with analyzer
Change-Id: Ie19a8746e65986f46f75c1bdd6bac3e79aedb922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142369
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-05 18:16:00 +00:00
a7f1a5e677
[cfe] Handle A extends FutureOr<B> <: FutureOr<B>
...
Change-Id: Ib5580328f006b033b2c004083b575a2cf5aed551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141541
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-05 06:31:19 +00:00
04d002e3fe
[cfe] Add runtime/tests/vm/dart to the list of opt-out tests
...
Tests in runtime/tests/vm/dart are not migrated yet and fail to compile
in null-safety mode. We cannot migrate those tests without making a
copy because we still need to run them in legacy mode.
Issue: https://github.com/dart-lang/sdk/issues/41314
Change-Id: I219f552810d603c6a36547fb3faa23c720e2f278
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142265
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-04-03 16:11:16 +00:00
4039373d90
[cfe] Handle covariant operator == parameter
...
Closes #41283
Change-Id: Ibd452dd181ce8ff17a48ffb1e12f312fe64ec216
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142145
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-04-03 10:54:13 +00:00
c4a7c3488e
[vm/async] Make async transformer use typed variables, make async patch use function types
...
This gets rid of a slow AssertAssignable (function type test)
in _asyncThenWrapperHelper/_awaitHelper, which currently falls back to the slow table
search:
AssertAssignable
^--> TypeTestingStub
^--> SlowTypeTestStub
^--> Subtype6TestCacheStub
Issue https://github.com/dart-lang/sdk/issues/37668
Change-Id: I3b6517b7e348e39619e8096d6ac2a4b179bb3242
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142022
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Clement Skau <cskau@google.com >
2020-04-03 08:28:47 +00:00
ebdc894324
[CFE] Fix crash with constructor recovery; add error recovery tests
...
Change-Id: I67f7a4592e562e1b1411f424d96c1a7b1d49d26b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142160
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-04-03 06:24:46 +00:00
fae35fca47
[cfe] Handle potentially constant type expressions in CFE
...
Closes #41305
Change-Id: Ibb839c5b6619ae2f7e90cc956c7de20d8c76ae3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142120
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-02 13:23:04 +00:00
46bb15edf3
[cfe] Fix inheritance test data discrepancies.
...
Change-Id: I367aace60324a7755f795d2f24aaf0d138bc8d59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141602
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-04-02 13:14:39 +00:00
1a744e3341
[CFE] Synthesize enough of the sdk to be able to compile dart2js without an sdk without crashing
...
Change-Id: I0bf8fa796acebb0368669e38bf085bca55707034
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141892
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-04-02 11:18:04 +00:00
0579a9250a
[cfe] Pass typeArguments from parser
...
This is the "next step" mentioned in
https://dart-review.googlesource.com/c/sdk/+/141240 .
`List<UnresolvedType> typeArguments` were dropped (and null was passed)
in several cases in `handleSend`, but they are needed in
BodyBuilder.buildConstructorInvocation in the case where the receiver
of the constructor invocation is a type alias.
This CL ensures that the `typeArguments` are passed when needed, and a
named parameter `isTypeArgumentsInForest` is passed in order to preserve
the information about whether or not they have been to the `forest`.
The CL also adjusts tests '{generic_,}usage_type_variable_*' to fit the
decision made in language issue 848 that a type alias cannot be used
for constructor invocations when it (directly or indirectly) denotes
a type variable.
Change-Id: I8d831457e35a7455f8fcfe461a10872c61555748
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141543
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-04-01 16:57:15 +00:00
d68f552e70
[analyzer,cfe] Handle (un)assigned state in try-statement
...
This handles (un)assigned state in try-statement that do not
complete normally. In this case we could create a variable model
for an unreachable state that would be both assigned and unassigned
leading to an assertion failure.
Closes #41284
Change-Id: Id4c7689bc7c614338af3542eb342c964696fca1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141981
Auto-Submit: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-04-01 15:46:15 +00:00
47b57e8995
[CFE] Cache checkInheritanceConflict calculation
...
When compiling a big internal app with the NNBD SDK there's a big time
regression. This is a first "poor-mans fix" that "fixes" it via caching
which probably is not the best solution, but does the trick.
Without change
==============
Without NNBD platform:
$ out/ReleaseX64/dart pkg/front_end/tool/_fasta/compile.dart --target=dart2js --platform=out/ReleaseX64/dart2js_platform.dill -v bigapp.dart
[...]
0:00:14.238352: Built class hierarchy in 1663ms.
[...]
0:00:55.871356: Wrote component to bigapp.dart.dill in 5690ms.
With NNBD platform:
$ out/ReleaseX64/dart pkg/front_end/tool/_fasta/compile.dart --target=dart2js --platform=out/ReleaseX64NNBD/dart2js_platform.dill -v bigapp.dart
[...]
0:04:41.842548: Built class hierarchy in 268716ms.
[...]
0:05:22.120455: Wrote component to bigapp.dart.dill in 5407ms.
So: Big regression; it takes almost 4.5 minutes to built the class
hierarchy and almost as long extra to compile as a whole.
With change
===========
Without NNBD platform:
$ out/ReleaseX64/dart pkg/front_end/tool/_fasta/compile.dart --target=dart2js --platform=out/ReleaseX64/dart2js_platform.dill -v bigapp.dart
[...]
0:00:15.255893: Built class hierarchy in 2175ms.
[...]
0:00:55.203753: Wrote component to bigapp.dart.dill in 5306ms.
So: Without the NNBD platform there's basically no change.
With NNBD platform:
$ out/ReleaseX64/dart pkg/front_end/tool/_fasta/compile.dart --target=dart2js --platform=out/ReleaseX64NNBD/dart2js_platform.dill -v bigapp.dart
[...]
0:00:15.864901: Built class hierarchy in 2574ms.
[...]
0:00:55.640201: Wrote component to bigapp.dart.dill in 5363ms.
So: With the NNBD platform, the speedup is significant and there's basically no
change between using the NNBD platform or not.
Change-Id: I74993710a34f08f69421b03f2682ff8418af7599
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141982
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-04-01 12:28:34 +00:00
2e822ae91b
[cfe] Apply the special treatment of FutureOr in GLB for NNBD
...
For details see:
https://github.com/dart-lang/sdk/issues/37439#issuecomment-519654959
This CL implements the same special treatment of FutureOr to the
NNBD-aware algorithm for computing of GLB.
Change-Id: I6e95b9884738b426dce0152217d79fe0298404bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140658
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2020-03-31 09:16:49 +00:00
605f9eb030
[CFE] Perform transformPostInference when doing expression compilation
...
Previously, if using spread features, it would crash (if not before
when trying to serialize), and set literals wouldn't be transformed
away either (which the VM probably requires).
It should fix https://github.com/flutter/flutter/issues/41678
Change-Id: I40361d592e9e7a3fe820c4835aaac893c87d94fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141620
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-31 06:48:19 +00:00
82d4bd1c7e
[cfe] Handle member signatures from dill in class hierarchy builder
...
Closes #41210
Change-Id: I1e38e014c04f140dd37821375a6efbfe73f37562
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141545
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-30 14:09:31 +00:00
56748006a1
[cfe] Add missing .next in endImplicitCreationExpression
...
Said method seems to break the pattern of similar methods, and the
actual token seems to be wrong. This change seems to fix the issue.
Change-Id: I54fcaa0ce2a846cbe10dfe5edc4e30282c523731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141544
Auto-Submit: Erik Ernst <eernst@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-30 12:52:51 +00:00
7d4d26a013
[CFE] Add api to get language version for uri
...
Closes #41205
Change-Id: I9e55257341e7c53f4f68f9d636b04f8fd6bffb68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141250
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-30 09:14:25 +00:00
6540f603d8
[cfe] Don't include member signature in id testing by default.
...
This prepares id testing for the unforked sdk where all Object
members add a member signature in the immediate opt-out subclasses
of Object.
Change-Id: Ife443582c4f88b6c8673aa560a700dbb88475c3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141600
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-30 08:42:25 +00:00
0a9e57419b
[kernel] Make verbose qualified names conditional in toStringInternal
...
Including the library name/uri in types and member names makes these
unreadable in most cases. This changes that default toStringInternal
to omit the library name/uri but supports a verbose mode that includes
the library name/uri for debugging the rare occasions where they matter.
Change-Id: I783e8bd0ac5d2f19c3051e8e7f226b240c8d1bc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141546
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-30 08:41:15 +00:00
Konstantin Shcheglov