Commit Graph

8 Commits

Author SHA1 Message Date
Jaime Wren 5bf1223ea9 Set a longer default timeout for dartdev.dart tests so flakiness is removed from the bots. Reason in utils.dart:
/// A long [Timeout] is provided for tests that start a process on
/// `bin/dartdev.dart` as the command is not compiled ahead of time, and each
/// invocation requires the VM to compile the entire dependency graph.

Change-Id: Ieec2238b5fb7358af5e9924912eaf2580d5dbfb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143181
Commit-Queue: Siva Annamalai <asiva@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2020-04-14 04:19:29 +00:00
Devon Carew 0a95bacb4f [dartdev] test the dartdev analyze --fatal-warnings option
Change-Id: I4c2c370777deb7e47a446b6cf1e74b82bf8ee028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141472
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2020-03-30 04:22:14 +00:00
Janice Collins 34fee361b6 Add sanity checks for NNBD state in migration.
Also adds some ability for the migration tool to abort itself on
a few known-fatal errors and armor-plates dartdev tests against
CWD problems.

Bug: https://github.com/dart-lang/sdk/issues/40329
Change-Id: I1cfa2c9dcc7815eed075ecb38c63a74c75889002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139282
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2020-03-16 18:27:58 +00:00
Jaime Wren 4b8af9d734 Additional flags on the dartdev analyze command: --fatal-warnings and --fatal-infos
Change-Id: Id11ac9e924ef5fab61961cbf1c9d293b62e954e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137141
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2020-02-25 21:57:46 +00:00
Jaime Wren 754972096f Add a test to dartdev which asserts that all the command descriptions end with a period.
Change-Id: I3676e393b341afbdf78cde2af2133177de11b1a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136711
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2020-02-21 19:45:31 +00:00
Jaime Wren d986ab830e Initial implementation in dartdev for the 'analyze' verb. This 'dart analyze .' carries over functionality from 'flutter analyze .', but with minimal flags (as a starting point).
Change-Id: I4a9e2210b2b9923ffd7b33073a7b0ea7946f1438
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136520
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2020-02-21 07:44:46 +00:00
Jaime Wren e525e42267 Initial working 'dartdev format *' tool with the set of args and flags to match the 'flutter format *' tool
Change-Id: I292a85cf7b10a725f82a7a86d90aada4972b7c38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134566
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-02-06 00:09:19 +00:00
Jaime Wren e9bd2595f4 Add an initial tests for dartdev that can execute and pass on the Dart build bots, as well as locally.
Change-Id: I92b24b7b5252d2f2dab97fe552406b7e97fc927c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132703
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
2020-01-22 20:31:08 +00:00