dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
72,374 Commits 2 Branches 0 Tags
cf3a0342102b8ec2094de629dfb891134df9de3c
Commit Graph

6296 Commits

Author SHA1 Message Date
Konstantin Shcheglov 768fad820b Extract EnclosingExecutableContext. 
Change-Id: Ib4a8344db60c8c717dd6259ff550088d3b30d100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 16:18:22 +00:00
Konstantin Shcheglov 39c503970b Reset the library context in FileResolver by timeout. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4dafff7229ad8a6f6713d6929121222ad818eccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144996
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-04-28 19:38:02 +00:00
Konstantin Shcheglov eada4d8d65 Implement Factor in flow analysis. 
Bug: https://github.com/dart-lang/sdk/issues/40014
Change-Id: I8d21d3c3368495d9d0dbb1cd52317b053657a176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144804
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-27 18:47:08 +00:00
Konstantin Shcheglov a18e3f6fb4 Issue 41645. Report assigning to Never type variables. 
Bug: https://github.com/dart-lang/sdk/issues/41645
Change-Id: I877ef09a4650b40577d2f0af63427432a8396dec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144811
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-25 00:25:59 +00:00
Konstantin Shcheglov 46a2086e6c Issue 41479. When terminate null shorting at CascadeExpression, don't make it nullable. 
Bug: https://github.com/dart-lang/sdk/issues/41479
Change-Id: I2d843846ca2a0232dbea60ad2b71e745ac118588
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144672
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-24 18:45:13 +00:00
Konstantin Shcheglov 8bce5840a5 Incrementally invalidate file state and library context for Cider. 
Change-Id: I278b990d27a380bded958681e07a47ffcedc8e56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144690
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-24 17:10:53 +00:00
Konstantin Shcheglov 8990c063b7 Issue 41603. await voidExpression is an error. 
Bug: https://github.com/dart-lang/sdk/issues/41603
Change-Id: I6cbd8938c62e7f5f60e48e0ee65b80f4924a3a65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-24 03:42:52 +00:00
Konstantin Shcheglov 4490e2f541 Deprecate VariableElement.constantValue, use computeConstantValue(). 
Bug: https://github.com/dart-lang/linter/issues/2073
Change-Id: I68d9c8eaf632c72c4634bb56f13af7ab603e3c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144666
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-24 00:37:52 +00:00
Konstantin Shcheglov 9b2663939a Issue 41632. Support Never in NNBD_TOP_MERGE. 
Bug: https://github.com/dart-lang/sdk/issues/41632
Change-Id: Ic3d91c8d155068056e2177b2658b99913c95dc05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-23 18:53:10 +00:00
Konstantin Shcheglov ea58996b27 Issue 41593. End dead code flow at TryStatement body. 
Bug: https://github.com/dart-lang/sdk/issues/41593
Change-Id: I7d8bc076143a253ea40d0ed04bbceab507c33bc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144348
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 03:15:28 +00:00
Konstantin Shcheglov 6f97affca2 Don't apply substitution for top-level function members. 
Bug: https://buganizer.corp.google.com/issues/154516150
Change-Id: I353701ec0e6d2384644685a4d950be7751a6c6b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-21 20:10:55 +00:00
Konstantin Shcheglov 704642a9b0 Report DEAD_CODE using flow analysis when NNBD. 
Bug: https://github.com/dart-lang/sdk/issues/35716
Change-Id: I066d744e30ec582f0c79a238dc5bf8194eaef578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143900
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-21 03:47:54 +00:00
Konstantin Shcheglov 7e4673f497 Check overrides using only direct superinterfaces. 
Change-Id: Ib17c3fb18d6ec4ff4541835a78c645a7b13affd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-21 02:42:04 +00:00
Konstantin Shcheglov b779c938eb Convert element type in for-each to legacy if opt-out library. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://buganizer.corp.google.com/issues/154515220
Change-Id: Ic62feab5fa090a9994b25769729d56fdfed97335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-20 22:12:54 +00:00
Brian Wilkerson 88876d5642 Add documentation for most of the Null Safety diagnostics 
This also updates the testing framework to allow experiments to be
specified with code snippets so that the examples can be tested.

Change-Id: Ifd15c321fef60c736124d368f4d6bfa947460fe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-19 15:24:59 +00:00
Konstantin Shcheglov cf70a46f8e Change the default type of the exception to 'Object' instead of 'dynamic'. 
Bug: https://github.com/dart-lang/sdk/issues/41521
Change-Id: I4410bb5b968899b6368eed304e1dfb84f4451554
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143980
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-18 01:33:17 +00:00
Konstantin Shcheglov b691657a10 Store isLegacy flag for elements into summary. 
Bug: https://buganizer.corp.google.com/issues/153397493
Change-Id: I10c325bc63a8c057475b75240a4a641370016f61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-16 23:30:21 +00:00
Jens Johansen c670ae42b0 [analyzer] Add test for parser fix of bang question index 
This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/141886 adding the
requested test to analyzer.

Change-Id: Ibb34886943b6a80c218212acad17b93b83faadb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142999
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-04-16 06:36:10 +00:00
Konstantin Shcheglov 69526e6512 Depecate many AnalysisOptions fields. 
Change-Id: Ibe219527d9abdad38bb99390d3023e7ee6bb8420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143251
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-15 18:36:52 +00:00
Alexander Thomas 3c85da7778 [release] Bump version to 2.9 
Change-Id: I2fc393cbb7a9111f4c09db6a2a7a202eeb88992c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142996
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-04-15 18:36:42 +00:00
Konstantin Shcheglov d16eacd5e9 Add FileResolver.getErrors() to use instead of resolve() for diagnostics in Cider. 
Change-Id: I4eeab48a15d2ada7df16859d61a7fc013f2f8cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143480
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-15 17:50:03 +00:00
Konstantin Shcheglov aa636281a9 Don't do TOP_MERGE when computing inheritedMap. 
Bug: https://github.com/dart-lang/sdk/issues/41470
Change-Id: I9a97ab0b505e4614a338ae20c011ccef7f9026c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-14 20:33:05 +00:00
Johnni Winther dc97454b63 [analyzer,cfe,dart2js] Add pretty printing to id testing 
Adds support for pretty printing verbose annotations.
Adds support for force updating annotation texts useful for applying
the pretty printing to valid annotations.

Change-Id: I8fe9b6d2f8198bd5e160854053c8d964ef832a8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129710
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-14 13:24:09 +00:00
Konstantin Shcheglov dd033a6ab7 Report HintCode.NULLABLE_TYPE_IN_CATCH_CLAUSE. 
Change-Id: I747fa9992243f811b4a98320a4ebd169f35daec0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143326
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 20:21:42 +00:00
Konstantin Shcheglov f5b3a0abb0 Save state in FileResolver 
Change-Id: I926346c66a5438b3dc97e638ccc34869457f7968
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143014
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-04-13 19:03:32 +00:00
Konstantin Shcheglov ec3dd52462 The type 'dynamic' is defined in dart:core. 
This makes fixes to analyzer and update the test for updated spec.

Change-Id: Ie5222bcf9056d5cbb7f18437dec04d5af21ff314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:55:36 +00:00
Konstantin Shcheglov 3d19be30b5 Report errors for enum constants conflics. 
This should fix:
language/enum/syntax_test/05
language/enum/syntax_test/06

Change-Id: Id9cfc9ebd3a39d7234ed7e898196b8d30f417877
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143244
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-13 17:52:32 +00:00
Konstantin Shcheglov c57fe977f0 Make exception and stack trace variables final. 
This should fix:
language/exception/try_catch_on_syntax_test/10

Bug: https://github.com/dart-lang/sdk/issues/41460
Change-Id: Id300deeeab5d25c5ab8062c8b8f5a887dc8c318b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:30:52 +00:00
Konstantin Shcheglov 5d703a5c9c Fix computing annotation values when referencing opt-in from opt-out. 
Bug: https://buganizer.corp.google.com/issues/153801444
Change-Id: If3297aebd9f72b5d774af5b4570ac9f76638da8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143250
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 16:42:31 +00:00
Konstantin Shcheglov f290ae0696 Issue 40554. Apply NORM and TOP_MERGE only when one of the interfaces is not syntactically equal. 
Bug: https://github.com/dart-lang/sdk/issues/40554
Change-Id: Ib96873a825a5a33142655231881562e278b586d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143249
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 16:42:13 +00:00
Sam Rawlins c9710e5059 analyzer: Do not report on a bad type of return expression if function has illegal return type 
Fixes #38188 and fixes #41439

Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 03:42:35 +00:00
Konstantin Shcheglov 23a8788f6a Issue 41378. Update on-catch and throw for the spec changes. 
Now it is not an error to use a potentially nullable type in on-catch.

But it is an error for throw an expression of type that is not
assignable to Object.

Bug: https://github.com/dart-lang/sdk/issues/41378
Change-Id: If0a198ae618cd01d03f45a46aa1efa6179df76ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-11 20:08:03 +00:00
Konstantin Shcheglov 89b0f67261 Implement InterfaceType.asInstanceOf() using allSupertypes. 
Change-Id: I2e67f68dd924d1abc9718f5e822980692ce47408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-11 18:39:53 +00:00
Sam Rawlins 5ddea4b8f6 analyzer: Fix analyzer crash when spreading a mixin 
Fixes #41424

Change-Id: I2093b02d325f1593f36c4752dd665601d6d0422c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-10 23:50:12 +00:00
Mike Fairhurst 353ebdc251 [analyzer] Fix windows test path in micro file resolution 
Change-Id: I67b63187894bb59450a50bf5243a60ce85ccf73f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143120
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 19:41:54 +00:00
Sam Rawlins 2c420267b7 analyzer: Do not allow errors to be ignored inline. Fixes #27218 
Change-Id: If37dabba3ec18a9f79f44c4ea38d6920a4013019
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-04-10 17:16:24 +00:00
Konstantin Shcheglov 830bfd8886 Rename several FunctionExpressionTest, use shared method. 
Change-Id: Id73036441bf1ec165ee84f3b6580eedec87bba28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143012
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 16:02:29 +00:00
Konstantin Shcheglov 450ae848f6 Applying a mixin replaces corresponding names in the interface. 
Change-Id: I5e2ada71af50aa580f5d236773ccb122fca5591c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:57:44 +00:00
Konstantin Shcheglov 516f297d87 Generator function bodies don't need a return. 
This should fix:
language/async_star/yield_expressions_test

Change-Id: Ifa1dc86f442ca36b292a587d67a208fc15d370dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143011
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:07:34 +00:00
Konstantin Shcheglov fa3a4eb956 Update TOP_MERGE according to the spec change. 
Bug: https://github.com/dart-lang/sdk/issues/41412
Change-Id: If61638188e594cb1b4272e0011ff0ebd5dbb2772
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-09 16:28:09 +00:00
Sam Rawlins 38be00f971 analyzer: Do not mark any enum values as unused if the values accessor is accessed 
Fixes #41377

Change-Id: I8c3c03c033a18c6770ab7fbe00435eccb747fb49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-09 15:51:49 +00:00
Konstantin Shcheglov f72378eb1b Test that hints are reported. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: Ief4be0bf88e22c7a1462495d4319a9c0ba3cbb08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142888
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-09 01:24:56 +00:00
Konstantin Shcheglov f557fbd943 Support for TypedLiteral in LinterContext.canBeConst(). 
Bug: https://github.com/dart-lang/linter/issues/2058
Change-Id: I8a037cec8d0b3488733f8cb34eddb3ff2cce5600
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142907
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 22:04:15 +00:00
Konstantin Shcheglov bcdfdeb280 Issue 41399. Check for 'dynamic' and 'Never' when verifying EXPORT_LEGACY_SYMBOL. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/41399
Change-Id: I7d36c16085bed80460269f477dcb13fdddfd8603
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 17:18:53 +00:00
Konstantin Shcheglov d43eb2b368 Support for analysis options in FileResolver. 
Change-Id: Ifaebeaf87abdac0260c0084090c39d64c699585e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142821
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-04-08 16:19:15 +00:00
Konstantin Shcheglov ed38c78397 Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETE for external factory constructors. 
See https://dart-review.googlesource.com/c/sdk/+/142555 for the context.

Change-Id: I0d20c7ef40f6e59e184a2891b061d82492329545
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 15:53:24 +00:00
Konstantin Shcheglov 2d47db7424 Improve DOWN for FutureOr vs. FutureOr or Future. 
https://github.com/dart-lang/language/pull/903
https://github.com/dart-lang/sdk/issues/41363

Change-Id: Ieedd4468bbf44b2fec9abba22955eac9b8905a24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 18:35:21 +00:00
Konstantin Shcheglov fa66c73fea Implement hasTypeParameterReference using RecursiveTypeVisitor. 
Change-Id: I351f2b03e1866a15528ed781689e2c894a20d466
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 18:27:36 +00:00
Konstantin Shcheglov 91b581fb2c Fix LinterContext().canBeConst() - compute dependencies. 
Change-Id: Ibcf08f79a9990ca714dd69a0dd0cc856e99335c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142581
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 16:38:34 +00:00
Konstantin Shcheglov dcdc71d763 Report CONFLICTING_GENERIC_INTERFACES using ClassHierarchy. 
Change-Id: Ib5d79403358efffd5365ac4931c3163d746d933a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142567
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 15:50:28 +00:00