dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
72,374 Commits 2 Branches 0 Tags
cf3a0342102b8ec2094de629dfb891134df9de3c
Commit Graph

7390 Commits

Author SHA1 Message Date
Konstantin Shcheglov cf3a034210 Implement promotion via initialization in flow analysis. 
Change-Id: I10a5f6bfeb5a05dd144db5212c9f31796f5a2385
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145502
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 16:26:27 +00:00
Konstantin Shcheglov 768fad820b Extract EnclosingExecutableContext. 
Change-Id: Ib4a8344db60c8c717dd6259ff550088d3b30d100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 16:18:22 +00:00
Sam Rawlins 5506769402 Count variables checked with ArgumentError.checkNotNull as not null 
Fixes https://github.com/dart-lang/sdk/issues/39644

Change-Id: I552e87e7c57dd2c5a012b76d9c73c24fefb19785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145025
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-29 22:35:18 +00:00
Konstantin Shcheglov 7deb5a3874 Fix documentation for EXPORT_LEGACY_SYMBOL. 
With https://dart-review.googlesource.com/c/sdk/+/145220 specifying
the current language version using `// @dart=` does not opt-out from
experiments.

Change-Id: Ibee76c35af8e829bef7d14347fe155ba876c1033
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-29 20:36:39 +00:00
Konstantin Shcheglov 2ccfc88f25 Change Feature.restrictToVersion() to keep features of the current language version. 
See https://github.com/dart-lang/sdk/issues/41691

Change-Id: I3ee40592158d4054d187120048f1eb805108ee69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145220
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-29 15:24:54 +00:00
Konstantin Shcheglov 1eb7ed02eb Fix leak of changed FileState(s). 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I8b68eee0b0a3cdf613912615198990edec7768dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145309
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-29 05:10:14 +00:00
Konstantin Shcheglov 39c503970b Reset the library context in FileResolver by timeout. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4dafff7229ad8a6f6713d6929121222ad818eccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144996
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-04-28 19:38:02 +00:00
Sam Rawlins af1ba835da Analyzer: unnamed ExtensionElement should have a null name 
Fixes #41614

Change-Id: I5221f0e7dcff26c4115eaa673cd4cab65af6fdbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-28 16:17:51 +00:00
Konstantin Shcheglov 14f41846ab Add CiderFixesComputer. 
Change-Id: Ie0a69ccbba5a6b9afec322caeb3d8edfe8293abd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-28 15:34:31 +00:00
Sam Rawlins 2032460323 analyzer: Fix message of REDIRECT_TO_INVALID_TYPE 
Fixes #37048

Change-Id: I15ada167d2665b017b078710d5798a4deedf2248
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-28 03:59:37 +00:00
Konstantin Shcheglov 3e26a5d0dd Issue 40957. Report the language feature, and recommend to set SDK constraint. 
...but don't recommend to enabled any experiment.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/40957
Change-Id: I556ce9952b28d0b079521ac46558f8e3adf352c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144982
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-27 22:11:46 +00:00
Konstantin Shcheglov eada4d8d65 Implement Factor in flow analysis. 
Bug: https://github.com/dart-lang/sdk/issues/40014
Change-Id: I8d21d3c3368495d9d0dbb1cd52317b053657a176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144804
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-27 18:47:08 +00:00
Konstantin Shcheglov a18e3f6fb4 Issue 41645. Report assigning to Never type variables. 
Bug: https://github.com/dart-lang/sdk/issues/41645
Change-Id: I877ef09a4650b40577d2f0af63427432a8396dec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144811
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-25 00:25:59 +00:00
Konstantin Shcheglov 46a2086e6c Issue 41479. When terminate null shorting at CascadeExpression, don't make it nullable. 
Bug: https://github.com/dart-lang/sdk/issues/41479
Change-Id: I2d843846ca2a0232dbea60ad2b71e745ac118588
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144672
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-24 18:45:13 +00:00
Konstantin Shcheglov 8bce5840a5 Incrementally invalidate file state and library context for Cider. 
Change-Id: I278b990d27a380bded958681e07a47ffcedc8e56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144690
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-24 17:10:53 +00:00
Konstantin Shcheglov 8990c063b7 Issue 41603. await voidExpression is an error. 
Bug: https://github.com/dart-lang/sdk/issues/41603
Change-Id: I6cbd8938c62e7f5f60e48e0ee65b80f4924a3a65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-24 03:42:52 +00:00
Konstantin Shcheglov 4490e2f541 Deprecate VariableElement.constantValue, use computeConstantValue(). 
Bug: https://github.com/dart-lang/linter/issues/2073
Change-Id: I68d9c8eaf632c72c4634bb56f13af7ab603e3c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144666
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-24 00:37:52 +00:00
Konstantin Shcheglov a36ec667e6 Issue 41630. Catch exceptions from Directory.listSync() in EvictingFileByteStore. 
Bug: https://github.com/dart-lang/sdk/issues/41630
Change-Id: I02d581c984d69876432b6e17616cab6f84725b38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144663
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-23 19:01:14 +00:00
Konstantin Shcheglov 9b2663939a Issue 41632. Support Never in NNBD_TOP_MERGE. 
Bug: https://github.com/dart-lang/sdk/issues/41632
Change-Id: Ic3d91c8d155068056e2177b2658b99913c95dc05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-23 18:53:10 +00:00
Keerti Parthasarathy 2c5969d0f2 Add workspace root to ContextRoot.included 
Change-Id: Id73d78e904e7548aad3365c5fa3f3bb27cefd89d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144496
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-04-23 03:46:18 +00:00
Konstantin Shcheglov 7f57c06e84 Log cumulative statistics for getFileContext(). 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I9135651a277d04d0891d968b9e46cd031490b089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144491
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 23:33:54 +00:00
Konstantin Shcheglov 838b2eca6a Clean up ClassHierarchy after linking. 
So that we don't keep references to ClassElement(s) being linked.
We will reload libraries from bytes, and rebuild necessary hierarchies.

Change-Id: Ibef128779e5422bdcdb8b5cc92d4676d76a8ed77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144485
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 21:04:29 +00:00
Konstantin Shcheglov a934ec2961 If possible, reuse the last completion result. 
Also rename "character" to "column".

R=brianwilkerson@google.com, keertip@google.com

Change-Id: I6167de6e1fd5aede2a619603635e96f16bfbcc8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144352
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 14:50:38 +00:00
Konstantin Shcheglov ea58996b27 Issue 41593. End dead code flow at TryStatement body. 
Bug: https://github.com/dart-lang/sdk/issues/41593
Change-Id: I7d8bc076143a253ea40d0ed04bbceab507c33bc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144348
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 03:15:28 +00:00
Konstantin Shcheglov 6f97affca2 Don't apply substitution for top-level function members. 
Bug: https://buganizer.corp.google.com/issues/154516150
Change-Id: I353701ec0e6d2384644685a4d950be7751a6c6b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-21 20:10:55 +00:00
Konstantin Shcheglov 704642a9b0 Report DEAD_CODE using flow analysis when NNBD. 
Bug: https://github.com/dart-lang/sdk/issues/35716
Change-Id: I066d744e30ec582f0c79a238dc5bf8194eaef578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143900
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-21 03:47:54 +00:00
Konstantin Shcheglov 7e4673f497 Check overrides using only direct superinterfaces. 
Change-Id: Ib17c3fb18d6ec4ff4541835a78c645a7b13affd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-21 02:42:04 +00:00
Konstantin Shcheglov 85336d761f Fail building SDK summary if diagnostics during parsing. 
Change-Id: I1ec1d45b362177ae883f7c0d3a78c081ffaa27bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-21 00:40:04 +00:00
Konstantin Shcheglov b779c938eb Convert element type in for-each to legacy if opt-out library. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://buganizer.corp.google.com/issues/154515220
Change-Id: Ic62feab5fa090a9994b25769729d56fdfed97335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-20 22:12:54 +00:00
Paul Berry 925e3fe782 Migration: detect weak-only code in conditional expressions. 
This change adds the ability to detect when one branch of a
conditional expression is weak-only due to nullability.  For example,
in the following code:

  int f(int/*!*/ i) => i == null ? g(null) : i;
  int g(int j) => ...;

the call to `g` can only happen in weak checking mode.  The migrator
also now understands that j only needs to be nullable if i is
nullable.

Fixes #41555.
Partially addresses #41551.

Bug: https://github.com/dart-lang/sdk/issues/41555
Change-Id: I02c9c3072f0104db0f1a5b432fb1f2f8f06d5282
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144120
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-04-20 19:09:32 +00:00
Paul Berry aebd854015 Make StaticTypeAnalizer.recordStaticType public. 
This will be needed in a future CL to allow
ResolverVisitorForMigration to set the static type of conditional
expressions when the migration tool is eliminating dead code.

Change-Id: I1361a78d42dd96718edfac99710270046016bff1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144002
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-04-20 17:26:26 +00:00
Konstantin Shcheglov a12c36dd97 Issue 41557. Support for breaks out of labeled blocks. 
Bug: https://github.com/dart-lang/sdk/issues/41557
Change-Id: Ica1c6c04acf600cb20d11a195d6c6da73197733c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143889
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-20 16:30:56 +00:00
Konstantin Shcheglov bf363c5b32 Update types in Future in MockSdk. 
Change-Id: I71e8c5f8345ffb2ce5beb780a5a6399f51ee9628
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-19 19:58:13 +00:00
Brian Wilkerson 88876d5642 Add documentation for most of the Null Safety diagnostics 
This also updates the testing framework to allow experiments to be
specified with code snippets so that the examples can be tested.

Change-Id: Ifd15c321fef60c736124d368f4d6bfa947460fe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-19 15:24:59 +00:00
Konstantin Shcheglov cf70a46f8e Change the default type of the exception to 'Object' instead of 'dynamic'. 
Bug: https://github.com/dart-lang/sdk/issues/41521
Change-Id: I4410bb5b968899b6368eed304e1dfb84f4451554
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143980
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-18 01:33:17 +00:00
Konstantin Shcheglov 780bea595e Add CiderCompletionComputer. 
It encapsulates resolution logic, creating completion request and
manager, caching and reusing suggestions from imported libraries.

In the spirit of keeping the Cider part thin.

R=brianwilkerson@google.com, keertip@google.com

Change-Id: I95f13a98d776eb418b40ea2fae421654eef7602d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-17 18:47:36 +00:00
Konstantin Shcheglov b691657a10 Store isLegacy flag for elements into summary. 
Bug: https://buganizer.corp.google.com/issues/153397493
Change-Id: I10c325bc63a8c057475b75240a4a641370016f61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-16 23:30:21 +00:00
Johnni Winther 594f77715b [cfe] Handle potentially constant type expression in is expression 
Closes #41385

Change-Id: Ia2fa829621931d52c5e41ac0414d12b9caa1256d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142860
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-16 09:07:21 +00:00
Konstantin Shcheglov 69526e6512 Depecate many AnalysisOptions fields. 
Change-Id: Ibe219527d9abdad38bb99390d3023e7ee6bb8420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143251
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-15 18:36:52 +00:00
Alexander Thomas 3c85da7778 [release] Bump version to 2.9 
Change-Id: I2fc393cbb7a9111f4c09db6a2a7a202eeb88992c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142996
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-04-15 18:36:42 +00:00
Sam Rawlins bac18c3efd analyzer: Add Element.createFragment and .setInnerHtml to mock SDK 
This will allow improved testing of the unsafe_html rule in the linter:
https://github.com/dart-lang/linter/pull/2057

Change-Id: Ia98f07fd1c5fb27e6250c2c5281e3c49001fc55a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143482
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-15 18:04:05 +00:00
Konstantin Shcheglov d16eacd5e9 Add FileResolver.getErrors() to use instead of resolve() for diagnostics in Cider. 
Change-Id: I4eeab48a15d2ada7df16859d61a7fc013f2f8cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143480
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-15 17:50:03 +00:00
Sam Rawlins 2feaa2ad81 analyzer: Add SecurityLintCode and a new getter on ErrorCode, isIgnorable 
`isIgnorable` is the new way to determine whether a report from the
analyzer can be ignored. Codes with an ERROR severity are not ignorable,
and the new SecurityLintCode is not ignorable.

Change-Id: Ied72f1b61808eda088b947b8836e0cf1dfdd9850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143331
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-15 01:51:59 +00:00
Konstantin Shcheglov aa636281a9 Don't do TOP_MERGE when computing inheritedMap. 
Bug: https://github.com/dart-lang/sdk/issues/41470
Change-Id: I9a97ab0b505e4614a338ae20c011ccef7f9026c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-14 20:33:05 +00:00
Konstantin Shcheglov dd033a6ab7 Report HintCode.NULLABLE_TYPE_IN_CATCH_CLAUSE. 
Change-Id: I747fa9992243f811b4a98320a4ebd169f35daec0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143326
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 20:21:42 +00:00
Konstantin Shcheglov f5b3a0abb0 Save state in FileResolver 
Change-Id: I926346c66a5438b3dc97e638ccc34869457f7968
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143014
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-04-13 19:03:32 +00:00
Konstantin Shcheglov ec3dd52462 The type 'dynamic' is defined in dart:core. 
This makes fixes to analyzer and update the test for updated spec.

Change-Id: Ie5222bcf9056d5cbb7f18437dec04d5af21ff314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:55:36 +00:00
Konstantin Shcheglov 3d19be30b5 Report errors for enum constants conflics. 
This should fix:
language/enum/syntax_test/05
language/enum/syntax_test/06

Change-Id: Id9cfc9ebd3a39d7234ed7e898196b8d30f417877
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143244
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-13 17:52:32 +00:00
Konstantin Shcheglov c57fe977f0 Make exception and stack trace variables final. 
This should fix:
language/exception/try_catch_on_syntax_test/10

Bug: https://github.com/dart-lang/sdk/issues/41460
Change-Id: Id300deeeab5d25c5ab8062c8b8f5a887dc8c318b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:30:52 +00:00
Konstantin Shcheglov 5d703a5c9c Fix computing annotation values when referencing opt-in from opt-out. 
Bug: https://buganizer.corp.google.com/issues/153801444
Change-Id: If3297aebd9f72b5d774af5b4570ac9f76638da8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143250
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 16:42:31 +00:00