4aec1e76e2
Record and report the completion suggestions that take the longest to compute in completion_metrics.dart.
...
Change-Id: I5a4043a9754439c38be6b86c094a895366c2afc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145562
Commit-Queue: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-29 22:38:58 +00:00
3dc7664a8a
Additional tests in override_contributor_test.dart
...
Change-Id: I04311b5685bb853926ebef4c20aef5ac58b5881d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-29 20:54:04 +00:00
1784caa31d
Completion metrics bug fix, pass in DartdocDirectiveInfo() when creating a DartCompletionManager()
...
Change-Id: Ib9a1c15016d3ed2427510e58dd63458655a50b5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145504
Commit-Queue: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-29 20:05:44 +00:00
c6f94c3224
Migrtaion: add a hook to allow the preview server to be shut down in unit tests.
...
Without this, it's possible for a unit test failure to result in a
preview server remaining open, which can prevent test execution from
terminating.
Change-Id: I8a11056da5bea003dfa46e3871a241e8f5ce8cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145440
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-29 19:11:54 +00:00
cb77214f19
Revert 2 of the override_contributor.dart changes from last week.
...
This reverts commit f7d14e4945588642https://dart-review.googlesource.com/c/sdk/+/145481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-29 18:22:49 +00:00
53601ecc18
Implement available suggestions in completion_metrics.dart, a flag is added to enable the new feature.
...
Change-Id: Ib7477b1a517d4aa1dc09d85df3df553ca61baa2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145241
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-29 17:59:24 +00:00
82e4a4465b
Migrator: change sdk constraints to >=2.9.0 <2.10.0
...
Bug: #38347
Change-Id: Iedb9acfe313a14d4c35f3637f3ef0104e836dd4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145260
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-29 17:47:44 +00:00
51a66bcfa2
Use SuggestionBuilder to build suggestions for field formal parameters
...
Change-Id: I157cc755f4bad5086c8e44d7e89504e31283e6bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145442
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-29 15:30:14 +00:00
2270add4ae
Use the element kind feature for instance members
...
Change-Id: I8fb449e485c77f7c13b9dd8b01f056d970ba551b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-28 23:40:43 +00:00
5528d8daac
Add a fix to add the required keyword
...
Change-Id: I2602ab5b4d3b47d3d8e302aa60847b791768481a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-28 20:04:22 +00:00
39c503970b
Reset the library context in FileResolver by timeout.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I4dafff7229ad8a6f6713d6929121222ad818eccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144996
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2020-04-28 19:38:02 +00:00
1c7a69e015
Support suggesting an accessor in SuggestionBuilder
...
This also introduces a first step toward de-duplicating suggestions as
part of the responsibilities of the SuggestionBuilder.
Change-Id: I1bcda241b0caee528c5740deae5662c6d43102aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145143
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-28 18:38:52 +00:00
d57c35f2ac
Fix CiderFixesComputerTest on Windows bot.
...
TBR
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I1b4d6fcc8a87edd2b0dc4c9996698257aed48f7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-04-28 17:12:10 +00:00
14f41846ab
Add CiderFixesComputer.
...
Change-Id: Ie0a69ccbba5a6b9afec322caeb3d8edfe8293abd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-28 15:34:31 +00:00
20ac7e08ee
Remove _coverageMarker and uses
...
Change-Id: I52158e1bfc75773136dbbdc3191cb31d2813a3f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144989
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-28 04:32:17 +00:00
7598d4b3d5
Support suggesting methods in SuggestionBuilder
...
Change-Id: I2d6845690513eaa408b69d7028b7bc25376cbda3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144987
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-27 22:41:46 +00:00
38c0fb78b6
Completion bug fix - extended types will now be completable in extension declarations
...
Bug: https://github.com/dart-lang/sdk/issues/41665
Change-Id: I5e89babc7a52fa833ebd55398fca50b292c710da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-27 19:20:08 +00:00
123222090f
Migration: add the ability for the preview server to be turned off.
...
This is necessary for unit testing, and probably good practice for
normal usage; we don't want to fire up a server even briefly if the
user specifies `--no-web-preview` when running the migration tool.
Not yet wired up to dartfix--probably I won't bother to do this since
migration is being decoupled from dartfix and a new CLI is being
implemented for it.
Change-Id: I79862d9baf328d0f428f63955fb5918c94186ccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144860
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-27 16:33:23 +00:00
7dd9945622
Bug fix in combinator_contributor.dart, don't suggest names already shown or hidden by the existing combinators (in the same directive).
...
Change-Id: I8de3670d4026ed2b6eda4c24223580e22015864b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144806
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-27 16:18:09 +00:00
03429b20cd
Use FuzzyMatcher for Cider completion filtering and sorting.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I1b8360e95327dfd4eaefaa8990105bd4750c2acc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144864
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-27 04:10:09 +00:00
c1edd26d97
Remove the remaining unnecessary awaits from analysis_server
...
Change-Id: I3d10c244ca711a0978cb2d4a99dbe1f3bedc159c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144863
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-27 04:05:59 +00:00
f43437cf80
Fix for avoid_types_as_parameter_names in try/catch.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I5d7e89567ac947274de073b166840753a79814bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144786
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-04-27 03:29:09 +00:00
12dcfe63bb
Start removing extraneous awaits from server
...
Change-Id: I484227773e98d87c915f6dfe6e320dda1a7b8eaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144862
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-26 23:45:29 +00:00
a53d336b9f
Convert the remaining methods in BaseProcessor to use subclasses of CorrectionProducer
...
Change-Id: Ide2c426939f6a0965caaa37a87ebe825b74d9d17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144787
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-26 20:12:49 +00:00
78907e46db
Another round of cleaning up the code in BaseProcessor
...
Change-Id: I347d585050023bf26d50913658d8413490e37155
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144812
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-25 00:26:07 +00:00
299c852b60
Migration: make an API for shutting down the preview server.
...
This will make it easier to write automated tests of the preview
server.
Change-Id: I4605beaa9ce3a8f43ec358568a53f24b4f05dece
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144801
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-24 22:53:17 +00:00
aa529bc684
Support plugin notifications in LSP server
...
This adds support for analysis domains that plugins contribute to by
sending notifications. I've only implemented folding so far, but most
of this CL is to cache results from plugins and to adapt sending server
capabilities.
Instead of using a NullNotificationManager, the LSP server now uses a
regular NotificationManager, except that results won't be forwarded to
clients. LSP handlers will fetch partial results from plugins and merge
them with data from the server that will be computed when needed.
I've extracted the server capabilities calculation from the init
handlers into ServerCapabilityComputer. It will also contain the
interestingFiles glob from active plugins and re-register capabilities
whenever plugins change.
Change-Id: I9869240cbfa284592e952498933e638b89a2a763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142981
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-24 20:36:07 +00:00
455886420c
Bug fix in the override_contributor.dart, don't generate the override completions if the target is in a comment text.
...
Change-Id: Ifbde00721858c9ad58b9d50cadf7775e37cf235b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144802
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-24 20:34:47 +00:00
403cfe3b12
Start converting uses of MemberSuggestionBuilder
...
Change-Id: Ia29834ac6670acde7e8ad0e36d5e0425e65e1951
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144782
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-24 19:59:37 +00:00
bade55aa20
Use the context type feature in SuggestionBuilder
...
Change-Id: I79f9f3f3e46bf240a75eba0d9a5d43d2478fb440
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-04-24 18:38:08 +00:00
a6b0e4fa13
Fix an analysis_server lint (prefer single-quoted strings)
...
Change-Id: If154127c6625194a856c23729f5b4a26b8b7fe8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144472
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-24 10:55:34 +00:00
319843b6ff
Migration: Further decouple NonNullableFix from DartFixListener.
...
NonNullableFix now communicates with DartFixListener through the
abstract interface DartFixListenerInterface; this will allow us to
build a version of DartFixListenerInterface that doesn't require the
analysis server.
Change-Id: I106d769b0e6ed49a916e2f1665a7e31a9a63be86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144471
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-24 10:06:53 +00:00
4787fc190b
Decouple migration logic from AnalysisDriver.
...
The migration logic doesn't need to access the AnalysisDriver object;
it just needs access to the AnalysisSession (which the driver holds).
By changing the interface so that it requests the session directly, we
pave the way for making a version of the migration tool that doesn't
require the analysis server.
Change-Id: Ib99725bbb2c1728a4c57b46659e9d94cbfe65ee0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144470
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-24 10:06:53 +00:00
b0173c1d3e
Begin to decouple nnbd_migration tool from analysis_server.
...
This removes most of the imports from nnbd_migration to
analysis_server by replacing them with abstract interfaces that are in
turn implemented by classes in analysis_server.
Change-Id: I9be9a5bd69b1664f0fea9ff3b6ba4678f134f0e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144468
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-24 10:06:53 +00:00
4490e2f541
Deprecate VariableElement.constantValue, use computeConstantValue().
...
Bug: https://github.com/dart-lang/linter/issues/2073
Change-Id: I68d9c8eaf632c72c4634bb56f13af7ab603e3c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144666
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-24 00:37:52 +00:00
94178e920e
[nnbd_migration] Fix regression: respondOk not returning JSON.
...
This causes the current state to fail to parse the (empty) success
result and falsely thinks things like rerunning the migration/applying
the migration result in an error.
Change-Id: Id68e089000e0be65278f687cd06112756ccb2a3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144668
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-04-23 23:55:12 +00:00
eab774c255
Move much of migration tool UI code into pkg/nnbd_migration
...
Change-Id: Ia3b388b274c908dcc6f9cb9ee4bf004b82681c43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144320
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-23 23:43:42 +00:00
c9c4aa5b25
Remove LibraryElementSuggestionBuilder
...
Change-Id: Idcc99641e3ffc43fea021b5acd0c14a515a4eee5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144670
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-23 22:32:52 +00:00
11c9dd3cd8
[nnbd_migration] Present errors to user in new popup dialog
...
Includes link to file an issue on github.
Change-Id: Ie0003651d3b3955766c6af016565418fd6ec86a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144523
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-23 21:10:49 +00:00
005af39cbc
Add some extensions for ASTNodes to start to cleanup some common utils.
...
Brian- I didn't know if we wanted this in analyzer or analysis server, I am happy to move it if we want it in analyzer.
Change-Id: I7cf909da6d31009ca9be726829cee4342aa2f7a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144665
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-23 19:32:59 +00:00
c980e5d876
Produce a completion location for the argument list in an extension override
...
Change-Id: I694d77dbba171fb0d4806933ce766c9d411dba21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144664
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-04-23 19:30:19 +00:00
747d363720
Move more suggestion building to happen in the SuggestionBuilder
...
Change-Id: I7ced2ecdf2fd126cab24400cd7d5688c204670d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-23 18:39:19 +00:00
f7d14e49c2
Modify the override_contributor.dart to provide the completions even when no class member characters have been typed.
...
Change-Id: I03164bcb0761faf7634ec219a1b1cc87dc568fa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144493
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-23 16:19:49 +00:00
4d4353ded9
Move navigation_dart.dart from analysis_server to analyzer_plugin.
...
This will allow it to be used by the nnbd_migration package.
Change-Id: Ia628630cf156af7bbfdbe2e104254cf5a609ae91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144467
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-23 12:35:39 +00:00
d2331fd8fc
Migration: Remove MigrationState.adapter and InfoBuilder.adapter.
...
These fields were not being used. Removing them will make it easier
to move these classes into pkg/nnbd_migration.
Change-Id: I7528bc07e5efd3936a9c6fd1635415e139d5df43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144466
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-23 12:35:39 +00:00
a5add116bf
Migrator: Add a 'Report a problem' button
...
Fixes #41485
Change-Id: If5c4347ad177b7050a90a4549a880f49577ada8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144522
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-04-23 09:07:38 +00:00
09dabd510e
[nnbd_migration] Handle json response on client
...
Change-Id: Ibd06a3529d85903576cb906f5dedb59c5392982f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144484
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-04-23 05:47:18 +00:00
3a6c863e23
[nnbd_migration] Respond in json for errors, simple successes.
...
Change-Id: I69015f21463b3060dd168654627f8e753ede52ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144340
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-23 05:47:18 +00:00
87e8a701db
Remove a field by moving the logic it controlled to the only place it was used
...
Change-Id: I07fc506a3a43de74b7425f1ed2d88a04e5d767c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144492
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-22 23:34:34 +00:00
fa75e17298
Use element kind for relevance of constructors
...
Change-Id: Ia63f70bbcd8a4a40da4a203889bfdd34ab08a873
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144489
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-04-22 21:56:09 +00:00
Jaime Wren